From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Huang Ying <ying.huang@intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [RFC 2/3] PCI/PM: Make PCI devices notified when its power resource turned on
Date: Thu, 20 Sep 2012 21:33:44 +0200 [thread overview]
Message-ID: <201209202133.44738.rjw@sisk.pl> (raw)
In-Reply-To: <1347872076-5260-3-git-send-email-ying.huang@intel.com>
On Monday, September 17, 2012, Huang Ying wrote:
> A set of power resources may be shared by multiple devices. When all
> devices share one set of power resources is put into D3_COLD state,
> the power resources will be turned off. When one of the device is
> waked, the power resource will be turned on and all devices share it
> will be powered on to D0uninitialized state. These devices should be
> resumed, so that they can get opportunity to go to low power state
> later.
>
> Signed-off-by: Huang Ying <ying.huang@intel.com>
Makes sense.
Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
> drivers/acpi/pci_bind.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- a/drivers/acpi/pci_bind.c
> +++ b/drivers/acpi/pci_bind.c
> @@ -45,6 +45,7 @@ static int acpi_pci_unbind(struct acpi_d
>
> device_set_run_wake(&dev->dev, false);
> pci_acpi_remove_pm_notifier(device);
> + acpi_power_resource_unregister_device(dev, device->handle);
>
> if (!dev->subordinate)
> goto out;
> @@ -71,6 +72,7 @@ static int acpi_pci_bind(struct acpi_dev
> return 0;
>
> pci_acpi_add_pm_notifier(device, dev);
> + acpi_power_resource_register_device(dev, device->handle);
> if (device->wakeup.flags.run_wake)
> device_set_run_wake(&dev->dev, true);
>
>
>
next prev parent reply other threads:[~2012-09-20 19:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 8:54 [RFC 0/3] PCI/PM: RTD3 fixes/changes for 3.7 Huang Ying
2012-09-17 8:54 ` [RFC 1/3] PCI/PM: Fix kexec for D3cold and bridge suspending Huang Ying
2012-09-17 20:54 ` Bjorn Helgaas
2012-09-20 7:38 ` Eric W. Biederman
2012-09-20 8:19 ` Huang Ying
2012-09-20 8:27 ` Eric W. Biederman
2012-09-20 19:20 ` Rafael J. Wysocki
2012-09-21 0:28 ` Huang Ying
2012-09-21 19:30 ` Rafael J. Wysocki
2012-09-17 8:54 ` [RFC 2/3] PCI/PM: Make PCI devices notified when its power resource turned on Huang Ying
2012-09-20 19:33 ` Rafael J. Wysocki [this message]
2012-09-17 8:54 ` [RFC 3/3] PCI/PM: Disable PME poll for PCIe devices Huang Ying
2012-09-20 19:31 ` Rafael J. Wysocki
2012-09-20 19:39 ` Matthew Garrett
2012-09-21 1:50 ` Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209202133.44738.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).