linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Henrik Rydberg" <rydberg@euromail.se>
To: Peter Stuge <peter@stuge.se>
Cc: Hans de Goede <hdegoede@redhat.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: REGRESSION: usbdevfs: Use-scatter-gather-lists-for-large-bulk-transfers
Date: Thu, 11 Oct 2012 07:44:03 +0200	[thread overview]
Message-ID: <20121011054403.GA1680@polaris.bitmath.org> (raw)
In-Reply-To: <20121010203459.20663.qmail@stuge.se>

On Wed, Oct 10, 2012 at 10:34:59PM +0200, Peter Stuge wrote:
> Hej Henrik,
> 
> Henrik Rydberg wrote:
> > commit 3d97ff63f8997761f12c8fbe8082996c6eeaba1a
> > Author: Hans de Goede <hdegoede@redhat.com>
> > Date:   Wed Jul 4 09:18:03 2012 +0200
> > 
> >     usbdevfs: Use scatter-gather lists for large bulk transfers
> >     
> > breaks an usb programming cable over here. The problem is reported as
> > "bulk tranfer failed" [sic] by the tool, and bisection leads to this
> > commit. Reverting on top of 3.6 solves it for me.
> > 
> > I am happy to test alternatives.
> 
> In order to make full use of the new kernel commit you also need
> changes in libusb, if the tool uses libusb, but I agree that the
> kernel change must under no circumstance cause existing userland
> software to regress.

Indeed.

> What is the programming cable and software that uses it?

The programmer is impact, using libusbx-1.0.14-1. The device runs the
xusbdfwu firmware. The (usb 2.0) bulk endpoint says wMaxPacketSize
1x512 bytes, and bInterval 0.

The patch is pretty generic, so I am suprised the problem has not
shown up earlier.

Henrik

  reply	other threads:[~2012-10-11  5:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-10 20:31 REGRESSION: usbdevfs: Use-scatter-gather-lists-for-large-bulk-transfers Henrik Rydberg
2012-10-10 20:34 ` Peter Stuge
2012-10-11  5:44   ` Henrik Rydberg [this message]
2012-10-11  6:50     ` Peter Stuge
2012-10-11  6:57       ` Xiaofan Chen
2012-10-11  7:12         ` Peter Stuge
2012-10-11 21:54       ` Henrik Rydberg
2012-10-11  8:21 ` Hans de Goede
2012-10-11 21:37   ` Henrik Rydberg
2012-10-11 21:40     ` Peter Stuge
2012-10-11 21:53     ` Greg Kroah-Hartman
2012-10-12 14:11       ` Hans de Goede
2012-10-12 15:10         ` Henrik Rydberg
2012-10-12 14:25     ` Alan Stern
2012-10-12 15:08       ` Henrik Rydberg
2012-10-12 15:10         ` Alan Stern
2012-10-14 15:40         ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121011054403.GA1680@polaris.bitmath.org \
    --to=rydberg@euromail.se \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter@stuge.se \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).