From: Peter Stuge <peter@stuge.se>
To: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: REGRESSION: usbdevfs: Use-scatter-gather-lists-for-large-bulk-transfers
Date: Thu, 11 Oct 2012 23:40:59 +0200 [thread overview]
Message-ID: <20121011214059.2038.qmail@stuge.se> (raw)
In-Reply-To: <20121011213707.GA2187@polaris.bitmath.org>
Henrik Rydberg wrote:
> Hi Hans,
>
> > Oh what fun (not). The best way to figure out what really is going
> > on is to get some usb level traces. Note my first hunch is that what
> > you're seeing is a device firmware bug, as this patch together with
> > a new libusb (which you seem to also have) will make bulk transfers
> > run slightly faster, which might be just enough to overwhelm your
> > device ...
>
> Or, the large bulk transfer actually never worked in the first place.
> The list you gave me seemed boringly long, so I read the patch more
> closely instead. The fix below is the result. Greg, will you please
> take it through your tree?
>
> Thanks,
> Henrik
>
> From 40b70394747eea51fdd07cc8213dd6afd24b1b30 Mon Sep 17 00:00:00 2001
> From: Henrik Rydberg <rydberg@euromail.se>
> Date: Thu, 11 Oct 2012 23:27:04 +0200
> Subject: [PATCH] usbdevfs: Fix broken scatter-gather transfer
>
> The recently introduced handling of large bulk transfers is completely
> broken; the same user page is read over and over again. Fixed with
> this patch.
>
> Cc: stable@kernel.org
> Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
Acked-by: Peter Stuge <peter@stuge.se>
next prev parent reply other threads:[~2012-10-11 21:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 20:31 REGRESSION: usbdevfs: Use-scatter-gather-lists-for-large-bulk-transfers Henrik Rydberg
2012-10-10 20:34 ` Peter Stuge
2012-10-11 5:44 ` Henrik Rydberg
2012-10-11 6:50 ` Peter Stuge
2012-10-11 6:57 ` Xiaofan Chen
2012-10-11 7:12 ` Peter Stuge
2012-10-11 21:54 ` Henrik Rydberg
2012-10-11 8:21 ` Hans de Goede
2012-10-11 21:37 ` Henrik Rydberg
2012-10-11 21:40 ` Peter Stuge [this message]
2012-10-11 21:53 ` Greg Kroah-Hartman
2012-10-12 14:11 ` Hans de Goede
2012-10-12 15:10 ` Henrik Rydberg
2012-10-12 14:25 ` Alan Stern
2012-10-12 15:08 ` Henrik Rydberg
2012-10-12 15:10 ` Alan Stern
2012-10-14 15:40 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121011214059.2038.qmail@stuge.se \
--to=peter@stuge.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).