From: Hans de Goede <hdegoede@redhat.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Henrik Rydberg <rydberg@euromail.se>,
Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Peter Stuge <peter@stuge.se>
Subject: Re: REGRESSION: usbdevfs: Use-scatter-gather-lists-for-large-bulk-transfers
Date: Fri, 12 Oct 2012 16:11:35 +0200 [thread overview]
Message-ID: <50782517.1020408@redhat.com> (raw)
In-Reply-To: <20121011215310.GA24651@kroah.com>
Hi,
On 10/11/2012 11:53 PM, Greg Kroah-Hartman wrote:
> On Thu, Oct 11, 2012 at 11:37:07PM +0200, Henrik Rydberg wrote:
>> Hi Hans,
>>
>>> Oh what fun (not). The best way to figure out what really is going
>>> on is to get some usb level traces. Note my first hunch is that whath
>>> you're seeing is a device firmware bug, as this patch together with
>>> a new libusb (which you seem to also have) will make bulk transfers
>>> run slightly faster, which might be just enough to overwhelm your
>>> device ...
>>
>> Or, the large bulk transfer actually never worked in the first place.
Large input transfers certainly do, as they were part of my tests, but
I must admit my test cases seem to not include large output transfers
(my bad).
Thanks for fixing this!
>> The list you gave me seemed boringly long, so I read the patch more
>> closely instead. The fix below is the result. Greg, will you please
>> take it through your tree?
>
> Henrik, Very nice fix, thanks for debugging this.
>
> Hans, any objection to me taking this?
No objections please take it, this patch is:
Acked-by: Hans de Goede <hdegoede@redhat.com>
And stating the obvious:
CC: stable@vger.kernel.org
To be backported to 3.6 only
Thanks & Regards,
Hans
next prev parent reply other threads:[~2012-10-12 14:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 20:31 REGRESSION: usbdevfs: Use-scatter-gather-lists-for-large-bulk-transfers Henrik Rydberg
2012-10-10 20:34 ` Peter Stuge
2012-10-11 5:44 ` Henrik Rydberg
2012-10-11 6:50 ` Peter Stuge
2012-10-11 6:57 ` Xiaofan Chen
2012-10-11 7:12 ` Peter Stuge
2012-10-11 21:54 ` Henrik Rydberg
2012-10-11 8:21 ` Hans de Goede
2012-10-11 21:37 ` Henrik Rydberg
2012-10-11 21:40 ` Peter Stuge
2012-10-11 21:53 ` Greg Kroah-Hartman
2012-10-12 14:11 ` Hans de Goede [this message]
2012-10-12 15:10 ` Henrik Rydberg
2012-10-12 14:25 ` Alan Stern
2012-10-12 15:08 ` Henrik Rydberg
2012-10-12 15:10 ` Alan Stern
2012-10-14 15:40 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50782517.1020408@redhat.com \
--to=hdegoede@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter@stuge.se \
--cc=rydberg@euromail.se \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).