From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-kernel@vger.kernel.org, lenb@kernel.org,
rafael.j.wysocki@intel.com, broonie@opensource.wolfsonmicro.com,
grant.likely@secretlab.ca, linus.walleij@linaro.org,
khali@linux-fr.org, ben-linux@fluff.org, w.sang@pengutronix.de,
bhelgaas@google.com, mathias.nyman@linux.intel.com,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v2 1/3] gpio / ACPI: add ACPI support
Date: Fri, 16 Nov 2012 10:05:49 +0200 [thread overview]
Message-ID: <20121116080549.GO17774@intel.com> (raw)
In-Reply-To: <20121116065448.GN17774@intel.com>
On Fri, Nov 16, 2012 at 08:54:48AM +0200, Mika Westerberg wrote:
> On Fri, Nov 16, 2012 at 02:34:22AM +0100, Rafael J. Wysocki wrote:
> > On Thursday, November 15, 2012 01:03:15 PM Mika Westerberg wrote:
> > > From: Mathias Nyman <mathias.nyman@linux.intel.com>
> > >
> > > Add support for translating ACPI GPIO pin numbers to Linux GPIO API pins.
> > > Needs a gpio controller driver with the acpi handler hook set.
> > >
> > > Drivers can use acpi_get_gpio() to translate ACPI5 GpioIO and GpioInt
> > > resources to Linux GPIO's.
> > >
> > > Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > > ---
> > > drivers/gpio/Kconfig | 4 ++++
> > > drivers/gpio/Makefile | 1 +
> > > drivers/gpio/gpiolib-acpi.c | 56 +++++++++++++++++++++++++++++++++++++++++++
> > > include/linux/acpi_gpio.h | 19 +++++++++++++++
> > > 4 files changed, 80 insertions(+)
> > > create mode 100644 drivers/gpio/gpiolib-acpi.c
> > > create mode 100644 include/linux/acpi_gpio.h
> > >
> > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> > > index f11d8e3..5c9b384 100644
> > > --- a/drivers/gpio/Kconfig
> > > +++ b/drivers/gpio/Kconfig
> > > @@ -49,6 +49,10 @@ config OF_GPIO
> > > def_bool y
> > > depends on OF
> > >
> > > +config GPIO_ACPI
> > > + def_bool y
> > > + depends on ACPI
> > > +
> > > config DEBUG_GPIO
> > > bool "Debug GPIO calls"
> > > depends on DEBUG_KERNEL
> > > diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
> > > index 9aeed67..420dbac 100644
> > > --- a/drivers/gpio/Makefile
> > > +++ b/drivers/gpio/Makefile
> > > @@ -4,6 +4,7 @@ ccflags-$(CONFIG_DEBUG_GPIO) += -DDEBUG
> > >
> > > obj-$(CONFIG_GPIOLIB) += gpiolib.o devres.o
> > > obj-$(CONFIG_OF_GPIO) += gpiolib-of.o
> > > +obj-$(CONFIG_GPIO_ACPI) += gpiolib-acpi.o
> > >
> > > # Device drivers. Generally keep list sorted alphabetically
> > > obj-$(CONFIG_GPIO_GENERIC) += gpio-generic.o
> > > diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
> > > new file mode 100644
> > > index 0000000..8ef9831
> > > --- /dev/null
> > > +++ b/drivers/gpio/gpiolib-acpi.c
> > > @@ -0,0 +1,56 @@
> > > +/*
> > > + * ACPI helpers for GPIO API
> > > + *
> > > + * Copyright (C) 2012, Intel Corporation
> > > + * Authors: Mathias Nyman <mathias.nyman@linux.intel.com>
> > > + * Mika Westerberg <mika.westerberg@linux.intel.com>
> > > + *
> > > + * This program is free software; you can redistribute it and/or modify
> > > + * it under the terms of the GNU General Public License version 2 as
> > > + * published by the Free Software Foundation.
> > > + */
> > > +
> > > +#include <linux/errno.h>
> > > +#include <linux/gpio.h>
> > > +#include <linux/export.h>
> > > +#include <linux/acpi_gpio.h>
> > > +#include <linux/acpi.h>
> > > +
> > > +static int acpi_gpiochip_find(struct gpio_chip *gc, void *data)
> > > +{
> > > + acpi_handle handle = data;
> > > +
> > > + if (!gc->dev)
> > > + return false;
> > > +
> > > + return gc->dev->acpi_handle == handle;
> >
> > I'd prefer DEVICE_ACPI_HANDLE() to be used in such places, we may want to
> > replace it with something else in the future or make it work differently.
>
> Sure but then we need to make it available for drivers as well when
> !CONFIG_ACPI. Something like below is needed.
One more thing, sometimes we want to assign the handle like in the case of
SPI controller driver we set the master->dev.acpi_handle. In that case we
can't use DEVICE_ACPI_HANDLE() as is. Should we just do something like:
master->dev.acpi_handle = pdev->dev.acpi_handle;
or should we introduce some new macro that supports this?
next prev parent reply other threads:[~2012-11-16 8:02 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 11:03 [PATCH v2 0/3] ACPI 5 support for GPIO, SPI and I2C Mika Westerberg
2012-11-15 11:03 ` [PATCH v2 1/3] gpio / ACPI: add ACPI support Mika Westerberg
2012-11-16 1:34 ` Rafael J. Wysocki
2012-11-16 6:54 ` Mika Westerberg
2012-11-16 8:05 ` Mika Westerberg [this message]
2012-11-16 8:12 ` Mika Westerberg
2012-11-16 10:02 ` Rafael J. Wysocki
2012-11-16 12:49 ` Mika Westerberg
2012-11-16 10:03 ` Rafael J. Wysocki
2012-11-15 11:03 ` [PATCH v2 2/3] spi / ACPI: add ACPI enumeration support Mika Westerberg
2012-11-16 10:06 ` Rafael J. Wysocki
2012-11-17 10:11 ` Rafael J. Wysocki
2012-11-17 10:18 ` Mika Westerberg
2012-11-15 11:03 ` [PATCH v2 3/3] i2c " Mika Westerberg
2012-11-16 10:09 ` Rafael J. Wysocki
2012-11-16 13:03 ` Jean Delvare
2012-11-16 13:21 ` Rafael J. Wysocki
2012-11-16 13:42 ` Jean Delvare
2012-11-16 14:17 ` Mika Westerberg
2012-11-16 15:23 ` Mika Westerberg
2012-11-16 16:47 ` Jean Delvare
2012-11-16 17:28 ` [PATCH v2 3/3 UPDATED] " Mika Westerberg
2012-11-16 18:12 ` Jean Delvare
2012-11-17 6:46 ` Bjorn Helgaas
2012-11-17 8:03 ` Mika Westerberg
2012-11-17 9:55 ` Mika Westerberg
2012-11-19 22:49 ` Bjorn Helgaas
2012-11-19 23:15 ` Rafael J. Wysocki
2012-11-19 23:28 ` Rafael J. Wysocki
2012-11-20 7:07 ` Mika Westerberg
2012-11-17 11:24 ` Rafael J. Wysocki
2012-11-18 15:55 ` Mika Westerberg
2012-11-18 21:10 ` [PATCH 0/2] ACPI: Simplify "glueing" to physical nodes (was: Re: [PATCH v2 3/3 UPDATED] i2c / ACPI: add ACPI enumeration support) Rafael J. Wysocki
2012-11-18 21:12 ` [PATCH 1/2] ACPI: Allow ACPI handles of devices to be initialized in advance Rafael J. Wysocki
2012-11-19 9:42 ` Mika Westerberg
2012-11-19 12:33 ` [Update][PATCH " Rafael J. Wysocki
2012-11-18 21:13 ` [PATCH 2/2] ACPI / platform: Initialize ACPI handles of platform devices " Rafael J. Wysocki
2012-11-19 16:23 ` Greg Kroah-Hartman
2012-11-19 17:32 ` Rafael J. Wysocki
2012-11-19 17:45 ` Rafael J. Wysocki
2012-11-19 20:44 ` Rafael J. Wysocki
2012-11-19 21:05 ` Mika Westerberg
2012-11-19 21:56 ` Rafael J. Wysocki
2012-11-19 22:32 ` Greg Kroah-Hartman
2012-11-19 22:44 ` Rafael J. Wysocki
2012-11-19 18:25 ` Rafael J. Wysocki
2012-11-19 22:31 ` Greg Kroah-Hartman
2012-11-19 22:45 ` Rafael J. Wysocki
2012-11-20 0:55 ` [Update][PATCH 0/3] ACPI: Simplify "glueing" to physical nodes Rafael J. Wysocki
2012-11-20 0:57 ` [Update][PATCH 1/3] ACPI: Allow ACPI handles of devices to be initialized in advance Rafael J. Wysocki
2012-11-20 0:59 ` [Update][PATCH 2/3] ACPI / driver core: Introduce struct acpi_dev_node and related macros Rafael J. Wysocki
2012-11-20 9:10 ` Mika Westerberg
2012-11-20 9:34 ` [Update 2][PATCH " Rafael J. Wysocki
2012-11-20 12:57 ` Mika Westerberg
2012-11-20 18:08 ` Greg Kroah-Hartman
2012-11-20 1:01 ` [Update][PATCH 3/3] ACPI / platform: Initialize ACPI handles of platform devices in advance Rafael J. Wysocki
2012-11-20 18:08 ` Greg Kroah-Hartman
2012-11-20 9:11 ` [Update][PATCH 0/3] ACPI: Simplify "glueing" to physical nodes Mika Westerberg
2012-11-20 9:31 ` Rafael J. Wysocki
2012-11-20 18:09 ` Greg Kroah-Hartman
2012-11-20 21:40 ` Rafael J. Wysocki
2012-11-16 20:02 ` [PATCH v2 3/3] i2c / ACPI: add ACPI enumeration support Rafael J. Wysocki
2012-11-16 20:09 ` Mika Westerberg
2012-11-16 20:18 ` Rafael J. Wysocki
2012-11-20 10:29 ` [PATCH v3 0/3] ACPI 5 support for GPIO, SPI and I2C Mika Westerberg
2012-11-20 10:29 ` [PATCH v3 1/3] gpio / ACPI: add ACPI support Mika Westerberg
2012-11-20 12:46 ` Rafael J. Wysocki
2012-11-20 10:29 ` [PATCH v3 2/3] spi / ACPI: add ACPI enumeration support Mika Westerberg
2012-11-20 13:05 ` Rafael J. Wysocki
2012-11-20 13:15 ` Mika Westerberg
2012-11-20 13:24 ` Rafael J. Wysocki
2012-11-20 10:29 ` [PATCH v3 3/3] i2c " Mika Westerberg
2012-11-20 13:06 ` Rafael J. Wysocki
2012-11-20 13:57 ` Mika Westerberg
2012-11-20 18:13 ` [PATCH v4 0/3] ACPI 5 support for GPIO, SPI and I2C Mika Westerberg
2012-11-20 18:13 ` [PATCH v4 1/3] gpio / ACPI: add ACPI support Mika Westerberg
2012-11-30 11:20 ` Grant Likely
2012-11-30 11:27 ` Rafael J. Wysocki
2012-11-20 18:13 ` [PATCH v4 2/3] spi / ACPI: add ACPI enumeration support Mika Westerberg
2012-11-30 11:24 ` Grant Likely
2012-11-30 11:36 ` Rafael J. Wysocki
2012-11-20 18:13 ` [PATCH v4 3/3] i2c " Mika Westerberg
2012-11-21 21:31 ` [PATCH v4 0/3] ACPI 5 support for GPIO, SPI and I2C Rafael J. Wysocki
2012-11-21 21:54 ` Jean Delvare
2012-11-23 11:39 ` Rafael J. Wysocki
2012-11-22 1:36 ` Mark Brown
2012-11-22 9:43 ` Linus Walleij
2012-11-22 10:03 ` Rafael J. Wysocki
2012-11-28 12:36 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121116080549.GO17774@intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=ben-linux@fluff.org \
--cc=bhelgaas@google.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=grant.likely@secretlab.ca \
--cc=khali@linux-fr.org \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@sisk.pl \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).