From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Mike Turquette <mturquette@ti.com>,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [PATCH 1/3] CLK: uninline clk_prepare() and clk_unprepare()
Date: Tue, 20 Nov 2012 01:57:57 -0800 [thread overview]
Message-ID: <20121120095757.GB11732@core.coreip.homeip.net> (raw)
In-Reply-To: <20121120093242.GK3290@n2100.arm.linux.org.uk>
On Tue, Nov 20, 2012 at 09:32:42AM +0000, Russell King - ARM Linux wrote:
> On Tue, Nov 20, 2012 at 01:22:17AM -0800, Dmitry Torokhov wrote:
> > We'll need to invoke clk_unprepare() via a pointer in our devm_*
> > conversion so let's uninline the pair.
>
> NAK. This breaks non-common clock using implementations.
As Viresh mentioned I provided stubs for case when we do not have
CONFIG_HAVE_CLK, so I am not sure how I'll break these platforms, but I
am certainly open for suggestions.
>
> Why do you need to call this function via a pointer? That sounds absurd.
devres framework takes and stores a pointer to a "destructor" which will
be used later.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2012-11-20 9:58 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 9:22 [RFC/PATCH 0/3] CLK: add more devm_* APIs Dmitry Torokhov
2012-11-20 9:22 ` [PATCH 1/3] CLK: uninline clk_prepare() and clk_unprepare() Dmitry Torokhov
2012-11-20 9:32 ` Russell King - ARM Linux
2012-11-20 9:40 ` Viresh Kumar
2012-11-20 9:57 ` Dmitry Torokhov [this message]
2012-11-20 10:13 ` Viresh Kumar
2012-11-21 20:43 ` Mike Turquette
2012-11-21 20:54 ` Dmitry Torokhov
2012-11-21 22:38 ` Russell King - ARM Linux
2012-11-22 2:17 ` Dmitry Torokhov
2012-11-22 3:11 ` Dmitry Torokhov
2012-11-22 3:24 ` Mike Turquette
2012-11-22 9:31 ` Russell King - ARM Linux
2012-11-22 3:26 ` Viresh Kumar
2012-11-22 9:30 ` Russell King - ARM Linux
2012-11-22 10:03 ` Russell King - ARM Linux
2012-11-22 10:08 ` Viresh Kumar
2012-11-23 7:19 ` Dmitry Torokhov
2012-11-23 7:27 ` Viresh Kumar
2012-11-23 8:08 ` Dmitry Torokhov
2012-11-23 8:43 ` Shawn Guo
2012-11-22 3:34 ` Viresh Kumar
2012-11-22 4:05 ` Mike Turquette
2012-11-20 9:22 ` [PATCH 2/3] CLK: uninline clk_prepare_enable() and clk_disable_unprepare() Dmitry Torokhov
2012-11-20 9:35 ` Russell King - ARM Linux
2012-11-20 10:18 ` Viresh Kumar
2012-12-16 11:40 ` Viresh Kumar
2012-12-16 11:41 ` Viresh Kumar
2012-12-16 11:57 ` Russell King - ARM Linux
2012-12-16 12:20 ` Viresh Kumar
2012-12-16 12:40 ` Russell King - ARM Linux
2012-12-16 13:05 ` Viresh Kumar
2012-12-16 13:09 ` Russell King - ARM Linux
2012-12-17 5:42 ` Dmitry Torokhov
2013-04-08 10:19 ` Viresh Kumar
2014-01-13 14:06 ` Andy Shevchenko
2012-11-20 9:22 ` [PATCH 3/3] CLK: add more managed APIs Dmitry Torokhov
2012-11-20 10:05 ` Viresh Kumar
2012-11-20 9:34 ` [RFC/PATCH 0/3] CLK: add more devm_* APIs Russell King - ARM Linux
2012-11-20 9:53 ` Dmitry Torokhov
2012-11-22 5:34 ` [PATCH v2 " Dmitry Torokhov
2012-11-22 5:34 ` [PATCH v2 1/3] CLK: get rid of HAVE_CLK_PREPARE Dmitry Torokhov
2012-11-22 6:12 ` Shawn Guo
2012-11-22 9:54 ` Russell King - ARM Linux
2012-11-22 5:34 ` [PATCH v2 2/3] CLK: uninline clk_prepare_enable() and clk_disable_unprepare() Dmitry Torokhov
2012-11-22 5:34 ` [PATCH v2 3/3] CLK: add more managed APIs Dmitry Torokhov
2017-01-02 18:09 ` [v2,3/3] " Guenter Roeck
2012-11-22 5:47 ` [PATCH v2 0/3] CLK: add more devm_* APIs Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121120095757.GB11732@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mturquette@ti.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).