linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Mike Turquette <mturquette@ti.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] CLK: uninline clk_prepare() and clk_unprepare()
Date: Thu, 22 Nov 2012 09:30:33 +0000	[thread overview]
Message-ID: <20121122093033.GA5764@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20121122021750.GD25470@core.coreip.homeip.net>

On Wed, Nov 21, 2012 at 06:17:50PM -0800, Dmitry Torokhov wrote:
> > You've checked non-ARM architectures too?
> 
> Yes:
> 
> [dtor@dtor-d630 linux-next]$ grep -r HAVE_CLK_PREPARE .
> ./arch/arm/Kconfig:     select HAVE_CLK_PREPARE
> Binary file ./.git/objects/pack/pack-7dad5ee164f601f1327dc78648fa317772c2d872.pack matches
> ./include/linux/clk.h:#ifdef CONFIG_HAVE_CLK_PREPARE
> ./include/linux/clk.h:#ifdef CONFIG_HAVE_CLK_PREPARE
> ./drivers/clk/Kconfig:config HAVE_CLK_PREPARE
> ./drivers/clk/Kconfig:  select HAVE_CLK_PREPARE

Err, no you haven't, not with that grep.  What you've found are the places
which enable this, and say "yes, I have clk_prepare".

What HAVE_CLK_PREPARE is about though is providing a transition path between
drivers using clk_prepare() to platforms which _don't_ have a clk_prepare()
implementation - and when it's unset, it provides a default implementation.

So, finding all those places where the symbol exists is the exact opposite
of what you need to be doing.  You need to find those platforms which have
CLK support, but which don't have HAVE_CLK_PREPARE selected.

  parent reply	other threads:[~2012-11-22 22:32 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-20  9:22 [RFC/PATCH 0/3] CLK: add more devm_* APIs Dmitry Torokhov
2012-11-20  9:22 ` [PATCH 1/3] CLK: uninline clk_prepare() and clk_unprepare() Dmitry Torokhov
2012-11-20  9:32   ` Russell King - ARM Linux
2012-11-20  9:40     ` Viresh Kumar
2012-11-20  9:57     ` Dmitry Torokhov
2012-11-20 10:13   ` Viresh Kumar
2012-11-21 20:43     ` Mike Turquette
2012-11-21 20:54       ` Dmitry Torokhov
2012-11-21 22:38         ` Russell King - ARM Linux
2012-11-22  2:17           ` Dmitry Torokhov
2012-11-22  3:11             ` Dmitry Torokhov
2012-11-22  3:24               ` Mike Turquette
2012-11-22  9:31                 ` Russell King - ARM Linux
2012-11-22  3:26               ` Viresh Kumar
2012-11-22  9:30             ` Russell King - ARM Linux [this message]
2012-11-22 10:03               ` Russell King - ARM Linux
2012-11-22 10:08               ` Viresh Kumar
2012-11-23  7:19               ` Dmitry Torokhov
2012-11-23  7:27                 ` Viresh Kumar
2012-11-23  8:08                   ` Dmitry Torokhov
2012-11-23  8:43                     ` Shawn Guo
2012-11-22  3:34       ` Viresh Kumar
2012-11-22  4:05         ` Mike Turquette
2012-11-20  9:22 ` [PATCH 2/3] CLK: uninline clk_prepare_enable() and clk_disable_unprepare() Dmitry Torokhov
2012-11-20  9:35   ` Russell King - ARM Linux
2012-11-20 10:18   ` Viresh Kumar
2012-12-16 11:40   ` Viresh Kumar
2012-12-16 11:41     ` Viresh Kumar
2012-12-16 11:57     ` Russell King - ARM Linux
2012-12-16 12:20       ` Viresh Kumar
2012-12-16 12:40         ` Russell King - ARM Linux
2012-12-16 13:05           ` Viresh Kumar
2012-12-16 13:09             ` Russell King - ARM Linux
2012-12-17  5:42             ` Dmitry Torokhov
2013-04-08 10:19               ` Viresh Kumar
2014-01-13 14:06                 ` Andy Shevchenko
2012-11-20  9:22 ` [PATCH 3/3] CLK: add more managed APIs Dmitry Torokhov
2012-11-20 10:05   ` Viresh Kumar
2012-11-20  9:34 ` [RFC/PATCH 0/3] CLK: add more devm_* APIs Russell King - ARM Linux
2012-11-20  9:53   ` Dmitry Torokhov
2012-11-22  5:34 ` [PATCH v2 " Dmitry Torokhov
2012-11-22  5:34   ` [PATCH v2 1/3] CLK: get rid of HAVE_CLK_PREPARE Dmitry Torokhov
2012-11-22  6:12     ` Shawn Guo
2012-11-22  9:54     ` Russell King - ARM Linux
2012-11-22  5:34   ` [PATCH v2 2/3] CLK: uninline clk_prepare_enable() and clk_disable_unprepare() Dmitry Torokhov
2012-11-22  5:34   ` [PATCH v2 3/3] CLK: add more managed APIs Dmitry Torokhov
2017-01-02 18:09     ` [v2,3/3] " Guenter Roeck
2012-11-22  5:47   ` [PATCH v2 0/3] CLK: add more devm_* APIs Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121122093033.GA5764@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@ti.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).