From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Mike Turquette <mturquette@ti.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] CLK: uninline clk_prepare_enable() and clk_disable_unprepare()
Date: Sun, 16 Dec 2012 13:09:47 +0000 [thread overview]
Message-ID: <20121216130947.GQ14363@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAKohpom37Liqhz38YthaL9q+iFh4=iYHoUmrTOMq2=Ut-D0Dhg@mail.gmail.com>
On Sun, Dec 16, 2012 at 06:35:24PM +0530, Viresh Kumar wrote:
> On 16 December 2012 18:10, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > Well, there's my comment against patch 2 which never got a reply:
> >
> > "Again, what about stuff not using drivers/clk/clk.c ?"
> >
> > Has this been addressed?
>
> Hmm.. I misread it and thought it is same as breaking other platforms
> because there are
> no dummy routines. But i was wrong :(
>
> So, the problem is, platform not using common-clock framework uses
> this routine, and they
> don't want it to be dummy but call prepare & enable..
>
> Because Dmirty requires this one to be non-inline, either he can move
> these routines to
> drivers/clk/clk-devres.c (which would be wrong) or can add wrappers
> over them in clk-devres
> file.
The point of the inlines in linux/clk.h is so that people using the clk
API have a way to transition to the new prepare+enable solution without
having their drivers break. This patch series totally wrecks that by
making clk_prepare() private to the common clock framework. All the
time that it does that, it's totally and utterly unsuitable for going
into mainline.
Is that strong enough language that my point is properly heard?
next prev parent reply other threads:[~2012-12-16 13:10 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 9:22 [RFC/PATCH 0/3] CLK: add more devm_* APIs Dmitry Torokhov
2012-11-20 9:22 ` [PATCH 1/3] CLK: uninline clk_prepare() and clk_unprepare() Dmitry Torokhov
2012-11-20 9:32 ` Russell King - ARM Linux
2012-11-20 9:40 ` Viresh Kumar
2012-11-20 9:57 ` Dmitry Torokhov
2012-11-20 10:13 ` Viresh Kumar
2012-11-21 20:43 ` Mike Turquette
2012-11-21 20:54 ` Dmitry Torokhov
2012-11-21 22:38 ` Russell King - ARM Linux
2012-11-22 2:17 ` Dmitry Torokhov
2012-11-22 3:11 ` Dmitry Torokhov
2012-11-22 3:24 ` Mike Turquette
2012-11-22 9:31 ` Russell King - ARM Linux
2012-11-22 3:26 ` Viresh Kumar
2012-11-22 9:30 ` Russell King - ARM Linux
2012-11-22 10:03 ` Russell King - ARM Linux
2012-11-22 10:08 ` Viresh Kumar
2012-11-23 7:19 ` Dmitry Torokhov
2012-11-23 7:27 ` Viresh Kumar
2012-11-23 8:08 ` Dmitry Torokhov
2012-11-23 8:43 ` Shawn Guo
2012-11-22 3:34 ` Viresh Kumar
2012-11-22 4:05 ` Mike Turquette
2012-11-20 9:22 ` [PATCH 2/3] CLK: uninline clk_prepare_enable() and clk_disable_unprepare() Dmitry Torokhov
2012-11-20 9:35 ` Russell King - ARM Linux
2012-11-20 10:18 ` Viresh Kumar
2012-12-16 11:40 ` Viresh Kumar
2012-12-16 11:41 ` Viresh Kumar
2012-12-16 11:57 ` Russell King - ARM Linux
2012-12-16 12:20 ` Viresh Kumar
2012-12-16 12:40 ` Russell King - ARM Linux
2012-12-16 13:05 ` Viresh Kumar
2012-12-16 13:09 ` Russell King - ARM Linux [this message]
2012-12-17 5:42 ` Dmitry Torokhov
2013-04-08 10:19 ` Viresh Kumar
2014-01-13 14:06 ` Andy Shevchenko
2012-11-20 9:22 ` [PATCH 3/3] CLK: add more managed APIs Dmitry Torokhov
2012-11-20 10:05 ` Viresh Kumar
2012-11-20 9:34 ` [RFC/PATCH 0/3] CLK: add more devm_* APIs Russell King - ARM Linux
2012-11-20 9:53 ` Dmitry Torokhov
2012-11-22 5:34 ` [PATCH v2 " Dmitry Torokhov
2012-11-22 5:34 ` [PATCH v2 1/3] CLK: get rid of HAVE_CLK_PREPARE Dmitry Torokhov
2012-11-22 6:12 ` Shawn Guo
2012-11-22 9:54 ` Russell King - ARM Linux
2012-11-22 5:34 ` [PATCH v2 2/3] CLK: uninline clk_prepare_enable() and clk_disable_unprepare() Dmitry Torokhov
2012-11-22 5:34 ` [PATCH v2 3/3] CLK: add more managed APIs Dmitry Torokhov
2017-01-02 18:09 ` [v2,3/3] " Guenter Roeck
2012-11-22 5:47 ` [PATCH v2 0/3] CLK: add more devm_* APIs Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121216130947.GQ14363@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@ti.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).