From: Lee Jones <lee.jones@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rabin Vincent <rabin@rab.in>,
Linus Walleij <linus.walleij@linaro.org>,
Grant Likely <grant.likely@secretlab.ca>,
sameo@linux.intel.com, devicetree-discuss@lists.ozlabs.org,
spear-devel@list.st.com, linux-kernel@vger.kernel.org,
l.fu@pengutronix.de
Subject: Re: [PATCH V3 3/3] mfd: stmpe: Update DT support in stmpe driver
Date: Wed, 28 Nov 2012 09:00:28 +0000 [thread overview]
Message-ID: <20121128090028.GJ2013@gmail.com> (raw)
In-Reply-To: <CAKohpok6=O_TMaApYQGKbzHmJ8tkST5VAHDnLYgHb0g3gSPwbQ@mail.gmail.com>
On Wed, 28 Nov 2012, Viresh Kumar wrote:
> On 28 November 2012 01:25, Rabin Vincent <rabin@rab.in> wrote:
> > 2012/11/27 Viresh Kumar <viresh.kumar@linaro.org>:
> >> On 27 November 2012 14:10, Lee Jones <lee.jones@linaro.org> wrote:
> >> I haven't seen this in any of SPEAr boards i have worked on. Maybe Rabin
> >> would have, that's why he added that part of code :)
> >>
> >> @Rabin/Linus: Do you remember why have you added this in stmpe driver:
> >>
> >> + if (stmpe->pdata->irq_invert_polarity)
> >> + icr ^= STMPE_ICR_LSB_HIGH;
> >> +
> >>
> >> Does somebody actually need it?
> >
> > It was (as irq_rev_pol) part of Luotao Fu's proposed STMPE811 patchset
> > (https://patchwork.kernel.org/patch/106173/) which I integrated into my
> > version of the STMPE driver, which didn't have it in its initial version
> > (https://patchwork.kernel.org/patch/103273/).
> >
> > It's not something _I_ ever used.
>
> I grep'd kernel and nobody is using it there, so lets get rid of it
> completely :)
> I will patch it.
Great. :)
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2012-11-28 9:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 18:56 [PATCH V1 1/3] mfd: stmpe: Arrange #include <header files> in alphabetical order Viresh Kumar
2012-11-22 18:56 ` [PATCH V1 2/3] mfd: stmpe-i2c: Move .driver structure fields inside {} in stmpe_i2c_driver Viresh Kumar
2012-11-26 11:15 ` Samuel Ortiz
2012-11-22 18:56 ` [PATCH V3 3/3] mfd: stmpe: Update DT support in stmpe driver Viresh Kumar
2012-11-23 9:41 ` Grant Likely
2012-11-23 17:33 ` Viresh Kumar
2012-11-26 11:18 ` Lee Jones
2012-11-26 18:40 ` Grant Likely
2012-11-27 2:40 ` Viresh Kumar
2012-11-27 3:28 ` Viresh Kumar
2012-11-27 8:40 ` Lee Jones
2012-11-27 8:46 ` Viresh Kumar
2012-11-27 19:55 ` Rabin Vincent
2012-11-28 2:13 ` Viresh Kumar
2012-11-28 9:00 ` Lee Jones [this message]
2012-11-23 10:03 ` Lee Jones
2012-11-26 11:16 ` [PATCH V1 1/3] mfd: stmpe: Arrange #include <header files> in alphabetical order Samuel Ortiz
2012-11-26 11:22 ` Viresh Kumar
2012-11-26 13:25 ` Lee Jones
2012-11-26 14:55 ` Viresh Kumar
2012-11-26 15:31 ` Lee Jones
2012-11-26 16:05 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121128090028.GJ2013@gmail.com \
--to=lee.jones@linaro.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=l.fu@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rabin@rab.in \
--cc=sameo@linux.intel.com \
--cc=spear-devel@list.st.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).