From: Viresh Kumar <viresh.kumar@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, spear-devel@list.st.com
Subject: Re: [PATCH V1 1/3] mfd: stmpe: Arrange #include <header files> in alphabetical order
Date: Mon, 26 Nov 2012 20:25:19 +0530 [thread overview]
Message-ID: <CAKohpo=7CEbKgEQ8KbnVpS0Opxn9xjDP26atZBefgHcxXVbMkA@mail.gmail.com> (raw)
In-Reply-To: <20121126132557.GA6824@gmail.com>
On 26 November 2012 18:55, Lee Jones <lee.jones@linaro.org> wrote:
> Why do you need to sort them? Is there _really_ a need?
Many people & maintainers like to have their header files ordered. The
reason for that is:
If they are not ordered, there is a possibility of adding an header file
multiple times in a file. This might not do something serious
when thinking about compilation time or Image size, but adding an header
file multiple times is simply wrong.
This can't be caught in patch reviews most of the time, as diff may not show
the earlier inclusion.
That's why i ordered them. And i don't see any harm in doing so.
--
viresh
next prev parent reply other threads:[~2012-11-26 14:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 18:56 [PATCH V1 1/3] mfd: stmpe: Arrange #include <header files> in alphabetical order Viresh Kumar
2012-11-22 18:56 ` [PATCH V1 2/3] mfd: stmpe-i2c: Move .driver structure fields inside {} in stmpe_i2c_driver Viresh Kumar
2012-11-26 11:15 ` Samuel Ortiz
2012-11-22 18:56 ` [PATCH V3 3/3] mfd: stmpe: Update DT support in stmpe driver Viresh Kumar
2012-11-23 9:41 ` Grant Likely
2012-11-23 17:33 ` Viresh Kumar
2012-11-26 11:18 ` Lee Jones
2012-11-26 18:40 ` Grant Likely
2012-11-27 2:40 ` Viresh Kumar
2012-11-27 3:28 ` Viresh Kumar
2012-11-27 8:40 ` Lee Jones
2012-11-27 8:46 ` Viresh Kumar
2012-11-27 19:55 ` Rabin Vincent
2012-11-28 2:13 ` Viresh Kumar
2012-11-28 9:00 ` Lee Jones
2012-11-23 10:03 ` Lee Jones
2012-11-26 11:16 ` [PATCH V1 1/3] mfd: stmpe: Arrange #include <header files> in alphabetical order Samuel Ortiz
2012-11-26 11:22 ` Viresh Kumar
2012-11-26 13:25 ` Lee Jones
2012-11-26 14:55 ` Viresh Kumar [this message]
2012-11-26 15:31 ` Lee Jones
2012-11-26 16:05 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKohpo=7CEbKgEQ8KbnVpS0Opxn9xjDP26atZBefgHcxXVbMkA@mail.gmail.com' \
--to=viresh.kumar@linaro.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=spear-devel@list.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).