From: Martin Steigerwald <Martin@lichtvoll.de>
To: linux-kernel@vger.kernel.org
Cc: Dave Chinner <david@fromorbit.com>,
"Theodore Ts'o" <tytso@mit.edu>,
torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH, 3.7-rc7, RESEND] fs: revert commit bbdd6808 to fallocate UAPI
Date: Wed, 5 Dec 2012 11:48:27 +0100 [thread overview]
Message-ID: <201212051148.28039.Martin@lichtvoll.de> (raw)
In-Reply-To: <20121126091202.GO32450@dastard>
Am Montag, 26. November 2012 schrieb Dave Chinner:
> On Sun, Nov 25, 2012 at 09:55:20PM -0500, Theodore Ts'o wrote:
> > On Mon, Nov 26, 2012 at 11:28:14AM +1100, Dave Chinner wrote:
> > > fs: revert commit bbdd6808 to fallocate UAPI
> > >
> > > From: Dave Chinner <dchinner@redhat.com>
> > >
> > > Commit bbdd6808 ("fs: reserve fallocate flag codepoint") changes
> > > the fallocate(2) syscall interface. The flag that is reserved by
> > > this commit is for functionality that has previously been NAKed on
> > > the -fsdevel mailing list, and so exists out-of-tree.
> >
> > Hi Linus,
> >
> > It doesn't change the interface or break anything; it just reserves a
> > bit so that out-of-tree patches don't collide with future
> > allocations. There are significant usages of this bit within Google
> > and Tao Bao. It is true that there has been significant pushback
> > about adding this functionality on linux-fsdevel;
>
> It's not the fact that you want to reserve a bit that is at issue
> here - it's the way it's been pushed into the tree that is the
> front-and-center issue.
>
> > I find it personally frustrating that
> > in effect, if enough people scream, they can veto an optional feature
> > that might only be implemented by a single file system.
>
> Having a significant portion of the wider fs development community
> disagree with your patches is no reason for subverting the review
> process. Besides, that's irrelevant to the issue being discussed,
> unless you are describing your motives in an effort to justify your
> actions.
>
> In fact, it's even more disturbing if this was your real motive.
> That is, is sounds somewhat like you've just admitted that you
> pushed this change silently through the ext4 tree to avoid review
> and discussion and that you are blaming the rest of the FS community
> for forcing you to take such actions.
>
> > It's not like there is any shortage of flag bits, so what's the harm
> > of reserving the bit?
>
> The harm has already been done - to the trust we've placed in you as
> a maintainer. To argue that the code does no harm is to completely
> miss the crux of the issue at hand: principles, process and trust
> are far more important in our community than a single line of
> code.
>
> Ted, it comes down to trust. If we can't trust you not to push your
> own changes to syscall APIs into the mainline tree via backdoor
> channels, then how can we trust you not to push the entire
> out-of-tree patch into the kernel the same way?
Ping.
Linus, while I am interested in an answer I think that Dave and Christoph
as Linux filesystem developers actually deserve one (instead of silently
being ignored which is also a decision in this matter).
I did not see an answer in linux-2.6 commit log as of today so far.
Thanks,
--
Martin 'Helios' Steigerwald - http://www.Lichtvoll.de
GPG: 03B0 0D6C 0040 0710 4AFA B82F 991B EAAC A599 84C7
next prev parent reply other threads:[~2012-12-05 10:48 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 23:04 [PATCH] fs: revert commit bbdd6808 to fallocate UAPI Dave Chinner
2012-11-20 16:36 ` Christoph Hellwig
2012-11-26 0:28 ` [PATCH, 3.7-rc7, RESEND] " Dave Chinner
2012-11-26 2:55 ` Theodore Ts'o
2012-11-26 6:14 ` Tao Ma
2012-11-26 9:12 ` Dave Chinner
2012-12-05 10:48 ` Martin Steigerwald [this message]
2012-12-05 15:45 ` Linus Torvalds
2012-12-05 16:18 ` Martin Steigerwald
2012-12-05 16:33 ` Theodore Ts'o
2012-12-05 17:24 ` Martin Steigerwald
2012-12-05 17:34 ` Theodore Ts'o
2012-12-05 17:55 ` Martin Steigerwald
2012-12-06 0:42 ` Dave Chinner
2012-12-06 9:24 ` Martin Steigerwald
2012-12-05 18:25 ` Linus Torvalds
2012-12-06 1:14 ` Dave Chinner
2012-12-06 3:03 ` Linus Torvalds
2012-12-06 9:37 ` Martin Steigerwald
2012-12-07 1:08 ` Ingo Molnar
2012-12-07 2:40 ` Dave Chinner
2012-12-07 10:24 ` Martin Steigerwald
2012-12-06 12:06 ` Christoph Hellwig
2012-12-06 16:50 ` Theodore Ts'o
2012-12-07 1:57 ` Dave Chinner
2012-12-06 12:05 ` Christoph Hellwig
2012-12-07 1:16 ` Ingo Molnar
2012-12-07 3:19 ` Dave Chinner
2012-12-07 17:36 ` Ric Wheeler
2012-12-07 18:18 ` Linus Torvalds
2012-12-07 19:03 ` Chris Mason
2012-12-07 20:43 ` Theodore Ts'o
2012-12-07 21:09 ` Chris Mason
2012-12-07 21:27 ` Theodore Ts'o
2012-12-07 21:43 ` Chris Mason
2012-12-07 21:49 ` Ric Wheeler
2012-12-07 21:57 ` Chris Mason
2012-12-07 22:51 ` Eric Sandeen
2012-12-07 22:52 ` Eric Sandeen
2012-12-07 21:42 ` Ric Wheeler
2012-12-07 21:57 ` Theodore Ts'o
2012-12-07 22:02 ` Ric Wheeler
2012-12-08 0:39 ` Dave Chinner
2012-12-08 2:52 ` Joel Becker
2012-12-08 4:04 ` Dave Chinner
2012-12-08 0:17 ` Dave Chinner
2012-12-08 1:39 ` Chris Mason
2012-12-10 16:02 ` Chris Mason
2012-12-10 17:37 ` Theodore Ts'o
2012-12-10 18:05 ` Steven Whitehouse
2012-12-10 18:13 ` Theodore Ts'o
2012-12-10 18:20 ` Theodore Ts'o
2012-12-11 12:16 ` Steven Whitehouse
2012-12-11 22:09 ` Dave Chinner
2012-12-10 18:52 ` Ric Wheeler
2012-12-11 0:52 ` Dave Chinner
2012-12-07 19:30 ` Steven Rostedt
2012-12-07 21:14 ` Theodore Ts'o
2012-12-07 21:47 ` Ric Wheeler
2012-12-07 23:25 ` Howard Chu
2012-12-08 0:50 ` Dave Chinner
2012-12-08 13:52 ` Howard Chu
2012-12-08 14:02 ` Ric Wheeler
2012-12-07 22:01 ` Eric Sandeen
2012-12-09 21:37 ` Ric Wheeler
2012-11-26 11:53 ` Alan Cox
2012-11-26 14:43 ` Theodore Ts'o
2012-11-26 21:12 ` Dave Chinner
2012-11-27 13:44 ` Martin Steigerwald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201212051148.28039.Martin@lichtvoll.de \
--to=martin@lichtvoll.de \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).