From: Martin Steigerwald <Martin@lichtvoll.de>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dave Chinner <david@fromorbit.com>,
"linux-fsdevel" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH, 3.7-rc7, RESEND] fs: revert commit bbdd6808 to fallocate UAPI
Date: Wed, 5 Dec 2012 18:24:05 +0100 [thread overview]
Message-ID: <201212051824.05621.Martin@lichtvoll.de> (raw)
In-Reply-To: <20121205163303.GG18885@thunk.org>
Am Mittwoch, 5. Dezember 2012 schrieb Theodore Ts'o:
> On Wed, Dec 05, 2012 at 05:18:43PM +0100, Martin Steigerwald wrote:
> > Dave provided technical reasons.
> >
> > First in the patch description and then in:
> >
> > https://lkml.org/lkml/2012/11/26/700
>
> There were no technical reasons. We are only reserving a bit. And
> different file systems don't support all of the various different
> fallocate flags already --- for example, not all file systems support
> the punch system call.
>
> Yes, I could create an entrely new ioctl() that looks just like
> fallocate, but supports the extra bit, just so that Dave and others
> don't have to be offended about the existence of that extra bit ---
> but Linus (and others) have considered ioctl()'s evil, since there is
> no type checking, and it's just silly to create a separate interface
> just because somebody doesn't think some other file system shouldn't
> implement a particular feature --- especially since it's not like
> we're have any kind of shortage of bits in the fallocate field.
Thanks for explaining your technical view about this. I appreciate it.
> Heck, I probably have more to complain about with the inode flags
> field, which were originally created specifically for ext2/3/4, and
> which has since been grabbed for use by other file systems, including
> btrfs. You haven't heard me kvetching because btrfs has grabbed
> btrfs-specific inode flags for nocow and notail... no one even bother
> to try to get it past the fs-devel shed painting crew before *those*
> bits were allocated --- and I am absolutely fine with that.
Thats no technical reason – thats exactly the process / patch review stuff
Linus does not seem to give a shit about at least with this topic.
That aside I wondered about that inode flags in earlier days already. At
some time chattr +i worked with XFS and then it only worked in Ext3.
Before that I thought that chattr stuff would work with all filesystems.
--
Martin 'Helios' Steigerwald - http://www.Lichtvoll.de
GPG: 03B0 0D6C 0040 0710 4AFA B82F 991B EAAC A599 84C7
next prev parent reply other threads:[~2012-12-05 17:24 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 23:04 [PATCH] fs: revert commit bbdd6808 to fallocate UAPI Dave Chinner
2012-11-20 16:36 ` Christoph Hellwig
2012-11-26 0:28 ` [PATCH, 3.7-rc7, RESEND] " Dave Chinner
2012-11-26 2:55 ` Theodore Ts'o
2012-11-26 6:14 ` Tao Ma
2012-11-26 9:12 ` Dave Chinner
2012-12-05 10:48 ` Martin Steigerwald
2012-12-05 15:45 ` Linus Torvalds
2012-12-05 16:18 ` Martin Steigerwald
2012-12-05 16:33 ` Theodore Ts'o
2012-12-05 17:24 ` Martin Steigerwald [this message]
2012-12-05 17:34 ` Theodore Ts'o
2012-12-05 17:55 ` Martin Steigerwald
2012-12-06 0:42 ` Dave Chinner
2012-12-06 9:24 ` Martin Steigerwald
2012-12-05 18:25 ` Linus Torvalds
2012-12-06 1:14 ` Dave Chinner
2012-12-06 3:03 ` Linus Torvalds
2012-12-06 9:37 ` Martin Steigerwald
2012-12-07 1:08 ` Ingo Molnar
2012-12-07 2:40 ` Dave Chinner
2012-12-07 10:24 ` Martin Steigerwald
2012-12-06 12:06 ` Christoph Hellwig
2012-12-06 16:50 ` Theodore Ts'o
2012-12-07 1:57 ` Dave Chinner
2012-12-06 12:05 ` Christoph Hellwig
2012-12-07 1:16 ` Ingo Molnar
2012-12-07 3:19 ` Dave Chinner
2012-12-07 17:36 ` Ric Wheeler
2012-12-07 18:18 ` Linus Torvalds
2012-12-07 19:03 ` Chris Mason
2012-12-07 20:43 ` Theodore Ts'o
2012-12-07 21:09 ` Chris Mason
2012-12-07 21:27 ` Theodore Ts'o
2012-12-07 21:43 ` Chris Mason
2012-12-07 21:49 ` Ric Wheeler
2012-12-07 21:57 ` Chris Mason
2012-12-07 22:51 ` Eric Sandeen
2012-12-07 22:52 ` Eric Sandeen
2012-12-07 21:42 ` Ric Wheeler
2012-12-07 21:57 ` Theodore Ts'o
2012-12-07 22:02 ` Ric Wheeler
2012-12-08 0:39 ` Dave Chinner
2012-12-08 2:52 ` Joel Becker
2012-12-08 4:04 ` Dave Chinner
2012-12-08 0:17 ` Dave Chinner
2012-12-08 1:39 ` Chris Mason
2012-12-10 16:02 ` Chris Mason
2012-12-10 17:37 ` Theodore Ts'o
2012-12-10 18:05 ` Steven Whitehouse
2012-12-10 18:13 ` Theodore Ts'o
2012-12-10 18:20 ` Theodore Ts'o
2012-12-11 12:16 ` Steven Whitehouse
2012-12-11 22:09 ` Dave Chinner
2012-12-10 18:52 ` Ric Wheeler
2012-12-11 0:52 ` Dave Chinner
2012-12-07 19:30 ` Steven Rostedt
2012-12-07 21:14 ` Theodore Ts'o
2012-12-07 21:47 ` Ric Wheeler
2012-12-07 23:25 ` Howard Chu
2012-12-08 0:50 ` Dave Chinner
2012-12-08 13:52 ` Howard Chu
2012-12-08 14:02 ` Ric Wheeler
2012-12-07 22:01 ` Eric Sandeen
2012-12-09 21:37 ` Ric Wheeler
2012-11-26 11:53 ` Alan Cox
2012-11-26 14:43 ` Theodore Ts'o
2012-11-26 21:12 ` Dave Chinner
2012-11-27 13:44 ` Martin Steigerwald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201212051824.05621.Martin@lichtvoll.de \
--to=martin@lichtvoll.de \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).