linux-next: build failure after merge of the leds tree

linux-next: build failure after merge of the leds tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]

Hi Bryan,

After merging the leds tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/built-in.o: In function `lp55xx_unregister_leds':
(.text+0x161dab): undefined reference to `led_classdev_unregister'

Caused by commit 14732b162d34 ("leds-lp55xx: use lp55xx_unregister_leds()").

drivers/built-in.o: In function `lp55xx_init_led':
leds-lp55xx-common.c:(.text+0x161f23): undefined reference to `led_classdev_register'
leds-lp55xx-common.c:(.text+0x161f9f): undefined reference to `led_classdev_unregister'

Caused by commit b5370ff365fa ("eds-lp55xx: use lp55xx_init_led() common function").

drivers/built-in.o: In function `lp55xx_read':
(.text+0x1621b3): undefined reference to `i2c_smbus_read_byte_data'
drivers/built-in.o: In function `lp55xx_init_device':
(.text+0x1622f0): undefined reference to `i2c_smbus_write_byte_data'
drivers/built-in.o: In function `lp55xx_init_device':
(.text+0x162331): undefined reference to `i2c_smbus_write_byte_data'
drivers/built-in.o: In function `lp55xx_update_bits':
(.text+0x162492): undefined reference to `i2c_smbus_write_byte_data'
drivers/built-in.o: In function `lp55xx_write':
(.text+0x1624c5): undefined reference to `i2c_smbus_write_byte_data'

Caused by commit 597eb710be87 ("leds-lp55xx: add new common driver for
lp5521/5523").

I have used the leds tree from next-20130122 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

RE: linux-next: build failure after merge of the leds tree

[Kim, Milo]

> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> Sent: Wednesday, January 23, 2013 1:12 PM
> To: Bryan Wu
> Cc: linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Kim, Milo
> Subject: linux-next: build failure after merge of the leds tree
> 
> Hi Bryan,
> 
> After merging the leds tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/built-in.o: In function `lp55xx_unregister_leds':
> (.text+0x161dab): undefined reference to `led_classdev_unregister'
> 
> Caused by commit 14732b162d34 ("leds-lp55xx: use
> lp55xx_unregister_leds()").
> 
> drivers/built-in.o: In function `lp55xx_init_led':
> leds-lp55xx-common.c:(.text+0x161f23): undefined reference to
> `led_classdev_register'
> leds-lp55xx-common.c:(.text+0x161f9f): undefined reference to
> `led_classdev_unregister'
> 
> Caused by commit b5370ff365fa ("eds-lp55xx: use lp55xx_init_led()
> common function").
> 
> drivers/built-in.o: In function `lp55xx_read':
> (.text+0x1621b3): undefined reference to `i2c_smbus_read_byte_data'
> drivers/built-in.o: In function `lp55xx_init_device':
> (.text+0x1622f0): undefined reference to `i2c_smbus_write_byte_data'
> drivers/built-in.o: In function `lp55xx_init_device':
> (.text+0x162331): undefined reference to `i2c_smbus_write_byte_data'
> drivers/built-in.o: In function `lp55xx_update_bits':
> (.text+0x162492): undefined reference to `i2c_smbus_write_byte_data'
> drivers/built-in.o: In function `lp55xx_write':
> (.text+0x1624c5): undefined reference to `i2c_smbus_write_byte_data'
> 
> Caused by commit 597eb710be87 ("leds-lp55xx: add new common driver for
> lp5521/5523").
> 
> I have used the leds tree from next-20130122 for today.

Bryan and Stephen,

Sorry for this errors. A patch has been sent.
https://lkml.org/lkml/2013/1/23/14

And I've got few warnings about leds-lp5521/5523 drivers, separate patchset will
be submitted soon.

Best Regards,
Milo

linux-next: build failure after merge of the leds tree

[broonie]

Hi all,

After merging the leds tree, today's linux-next build (x86 allmodconfig)
failed like this:

/tmp/next/build/drivers/leds/leds-pca963x.c: In function 'pca963x_register_leds':
/tmp/next/build/drivers/leds/leds-pca963x.c:355:3: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
  355 |   if (hw_blink)
      |   ^~
/tmp/next/build/drivers/leds/leds-pca963x.c:357:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
  357 |    led->blinking = false;
      |    ^~~
cc1: all warnings being treated as errors

Caused by commit

   fd6dd9584ed3ee6deb ("leds: pca963x: fix blink with hw acceleration")

I am continuing to use the version from 20220921.

Re: linux-next: build failure after merge of the leds tree

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 896 bytes --]

Hi!

> After merging the leds tree, today's linux-next build (x86 allmodconfig)
> failed like this:
> 
> /tmp/next/build/drivers/leds/leds-pca963x.c: In function 'pca963x_register_leds':
> /tmp/next/build/drivers/leds/leds-pca963x.c:355:3: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
>   355 |   if (hw_blink)
>       |   ^~
> /tmp/next/build/drivers/leds/leds-pca963x.c:357:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
>   357 |    led->blinking = false;
>       |    ^~~
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>    fd6dd9584ed3ee6deb ("leds: pca963x: fix blink with hw acceleration")

Thanks, fixed and pushed out. Someone please check my fix is right.

Best regards,
								Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

linux-next: build failure after merge of the leds tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 780 bytes --]

Hi all,

After merging the leds tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/leds/leds-pca963x.c: In function 'pca963x_register_leds':
drivers/leds/leds-pca963x.c:355:17: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
  355 |                 if (hw_blink)
      |                 ^~
drivers/leds/leds-pca963x.c:357:25: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
  357 |                         led->blinking = false;
      |                         ^~~

Caused by commit

  fd6dd9584ed3 ("leds: pca963x: fix blink with hw acceleration")

I have used the version of the leds tree from next-20220921 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the leds tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 872 bytes --]

Hi all,

After merging the leds tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/leds/leds-lm3692x.c: In function 'lm3692x_max_brightness':
drivers/leds/leds-lm3692x.c:355:9: error: 'struct lm3692x_led' has no member named 'brightness_ctrl'
  355 |  if (led->brightness_ctrl & LM3692X_MAP_MODE_EXP) {
      |         ^~
drivers/leds/leds-lm3692x.c: In function 'lm3692x_probe_dt':
drivers/leds/leds-lm3692x.c:437:61: error: 'max_cur' undeclared (first use in this function)
  437 |  ret = fwnode_property_read_u32(child, "led-max-microamp", &max_cur);
      |                                                             ^~~~~~~

Caused by commit

  ef791c4d0ce8 ("leds: lm3692x: Make sure we don't exceed the maximum LED current")

I have used the leds tree from next-20191220 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the leds tree

[Guido Günther]

Hi,
On Mon, Jan 06, 2020 at 02:21:16PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the leds tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/leds/leds-lm3692x.c: In function 'lm3692x_max_brightness':
> drivers/leds/leds-lm3692x.c:355:9: error: 'struct lm3692x_led' has no member named 'brightness_ctrl'
>   355 |  if (led->brightness_ctrl & LM3692X_MAP_MODE_EXP) {
>       |         ^~

That's a result of a patch from the mid of the series not being applied.
'leds: lm3692x: Allow to configure brigthness mode' introduces that
struct member.

> drivers/leds/leds-lm3692x.c: In function 'lm3692x_probe_dt':
> drivers/leds/leds-lm3692x.c:437:61: error: 'max_cur' undeclared (first use in this function)
>   437 |  ret = fwnode_property_read_u32(child, "led-max-microamp", &max_cur);
>       |                                                             ^~~~~~~

That somehow got lost during merge of this commit:

    https://lore.kernel.org/linux-leds/5826b77d42521595e93d01d53475a8881cad1875.1578134779.git.agx@sigxcpu.org/T/#u

Pavel, shall i send a patch to fix that up or should we rather try to
get the rest of the series in in the right order? Resetting linux-next
back to cffd61a5c7755546154539dcd7f36590e91e002f for the moment?

Cheers,
 -- Guido

> Caused by commit
> 
>   ef791c4d0ce8 ("leds: lm3692x: Make sure we don't exceed the maximum LED current")
> 
> I have used the leds tree from next-20191220 for today.


> 
> -- 
> Cheers,
> Stephen Rothwell

Re: linux-next: build failure after merge of the leds tree

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1626 bytes --]

Hi!

> > After merging the leds tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > drivers/leds/leds-lm3692x.c: In function 'lm3692x_max_brightness':
> > drivers/leds/leds-lm3692x.c:355:9: error: 'struct lm3692x_led' has no member named 'brightness_ctrl'
> >   355 |  if (led->brightness_ctrl & LM3692X_MAP_MODE_EXP) {
> >       |         ^~
> 
> That's a result of a patch from the mid of the series not being applied.
> 'leds: lm3692x: Allow to configure brigthness mode' introduces that
> struct member.
> 
> > drivers/leds/leds-lm3692x.c: In function 'lm3692x_probe_dt':
> > drivers/leds/leds-lm3692x.c:437:61: error: 'max_cur' undeclared (first use in this function)
> >   437 |  ret = fwnode_property_read_u32(child, "led-max-microamp", &max_cur);
> >       |                                                             ^~~~~~~
> 
> That somehow got lost during merge of this commit:
> 
>     https://lore.kernel.org/linux-leds/5826b77d42521595e93d01d53475a8881cad1875.1578134779.git.agx@sigxcpu.org/T/#u
> 
> Pavel, shall i send a patch to fix that up or should we rather try to
> get the rest of the series in in the right order? Resetting linux-next
> back to cffd61a5c7755546154539dcd7f36590e91e002f for the moment?

I kept just three patches from the series, and pushed the result.

Could I get the rest of the series, minus the "exponential" stuff, on
top of that?

Sorry for the confusion,

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: linux-next: build failure after merge of the leds tree

[Guido Günther]

Hi,
On Mon, Jan 06, 2020 at 11:32:33AM +0100, Pavel Machek wrote:
> Hi!
> 
> > > After merging the leds tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > > 
> > > drivers/leds/leds-lm3692x.c: In function 'lm3692x_max_brightness':
> > > drivers/leds/leds-lm3692x.c:355:9: error: 'struct lm3692x_led' has no member named 'brightness_ctrl'
> > >   355 |  if (led->brightness_ctrl & LM3692X_MAP_MODE_EXP) {
> > >       |         ^~
> > 
> > That's a result of a patch from the mid of the series not being applied.
> > 'leds: lm3692x: Allow to configure brigthness mode' introduces that
> > struct member.
> > 
> > > drivers/leds/leds-lm3692x.c: In function 'lm3692x_probe_dt':
> > > drivers/leds/leds-lm3692x.c:437:61: error: 'max_cur' undeclared (first use in this function)
> > >   437 |  ret = fwnode_property_read_u32(child, "led-max-microamp", &max_cur);
> > >       |                                                             ^~~~~~~
> > 
> > That somehow got lost during merge of this commit:
> > 
> >     https://lore.kernel.org/linux-leds/5826b77d42521595e93d01d53475a8881cad1875.1578134779.git.agx@sigxcpu.org/T/#u
> > 
> > Pavel, shall i send a patch to fix that up or should we rather try to
> > get the rest of the series in in the right order? Resetting linux-next
> > back to cffd61a5c7755546154539dcd7f36590e91e002f for the moment?
> 
> I kept just three patches from the series, and pushed the result.
> 
> Could I get the rest of the series, minus the "exponential" stuff, on
> top of that?
> 
> Sorry for the confusion,

No problem, reshuffling stuff turned out to be simpler than expected:

     https://lore.kernel.org/linux-leds/cover.1578324703.git.agx@sigxcpu.org/T/#mbbbaabea8ebaba1f864d8a4211d9bcac780261aa

If you don't want the exponential mode setting just omit 5/6 and
6/6.

Cheers,
 -- Guido

> 
> 									Pavel
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

linux-next: build failure after merge of the leds tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 785 bytes --]

Hi all,

After merging the leds tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/leds/leds-max77650.c: In function 'max77650_led_probe':
drivers/leds/leds-max77650.c:121:8: error: implicit declaration of function 'devm_of_led_classdev_register'; did you mean 'devm_led_classdev_register'? [-Werror=implicit-function-declaration]
   rv = devm_of_led_classdev_register(dev, child, &led->cdev);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        devm_led_classdev_register

Caused by commit

  4eba5b82096e ("leds: class: Improve LED and LED flash class registration API")

interacting with commit

  5be102eb161a ("leds: max77650: Add LEDs support")

I have used the leds tree from next-20190724 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the leds tree

[Jacek Anaszewski]

On 7/25/19 4:31 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the leds tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/leds/leds-max77650.c: In function 'max77650_led_probe':
> drivers/leds/leds-max77650.c:121:8: error: implicit declaration of function 'devm_of_led_classdev_register'; did you mean 'devm_led_classdev_register'? [-Werror=implicit-function-declaration]
>    rv = devm_of_led_classdev_register(dev, child, &led->cdev);
>         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>         devm_led_classdev_register
> 
> Caused by commit
> 
>   4eba5b82096e ("leds: class: Improve LED and LED flash class registration API")
> 
> interacting with commit
> 
>   5be102eb161a ("leds: max77650: Add LEDs support")
> 
> I have used the leds tree from next-20190724 for today.
> 

I forgot about this driver jumping in lately.

But here is the fixup and the rationale:

devm_of_led_classdev_register() API has been useless from the beginning,
since it was just an initial portion of work aiming at adding some
generic DT parser. The actual parser had not been added up to this
commit which also switches the API:

devm_of_led_classdev_register(struct device *parent,
                              struct device_node *np,
                              struct led_classdev *led_cdev);

to:

devm_led_classdev_register_ext(struct device *parent,
                               struct led_classdev *led_cdev,
                               struct led_init_data *init_data)

To not break the bisectibility The remaining users of
devm_of_led_classdev_register are being fixed by this commit to use the
wrapper:

+#define devm_led_classdev_register(parent, led_cdev)           \
+       devm_led_classdev_register_ext(parent, led_cdev, NULL)


leds-max77650.c is the one that was omitted, so I've just applied
the following fix to this commit:

diff --git a/drivers/leds/leds-max77650.c b/drivers/leds/leds-max77650.c
index 04738324b3e6..5a14f9775b0e 100644
--- a/drivers/leds/leds-max77650.c
+++ b/drivers/leds/leds-max77650.c
@@ -118,7 +118,7 @@ static int max77650_led_probe(struct platform_device
*pdev)
                of_property_read_string(child, "linux,default-trigger",
                                        &led->cdev.default_trigger);

-               rv = devm_of_led_classdev_register(dev, child, &led->cdev);
+               rv = devm_led_classdev_register(dev, &led->cdev);
                if (rv)
                        goto err_node_put;

and melded it with the original one to not break the bisect.

If you have any doubts please let me know.


Best regards,
Jacek Anaszewski

linux-next: build failure after merge of the leds tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

Hi Bryan,

After merging the leds tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/leds/leds-mc13783.c: In function 'mc13xxx_led_probe':
drivers/leds/leds-mc13783.c:280:4: error: implicit declaration of function 'of_get_next_child' [-Werror=implicit-function-declaration]
    child = of_get_next_child(parent, child);
    ^

Caused by commit 2ca3a455432f ("leds: leds-mc13783: Add devicetree support").  of_get_next_child() is only defined if CONFIG_OF is set.

I have used the version of the leds tree from next-20130607 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the leds tree

[Alexander Shiyan]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 849 bytes --]

> Hi Bryan,
> 
> After merging the leds tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/leds/leds-mc13783.c: In function 'mc13xxx_led_probe':
> drivers/leds/leds-mc13783.c:280:4: error: implicit declaration of function 'of_get_next_child' [-Werror=implicit-function-declaration]
>     child = of_get_next_child(parent, child);
>     ^
> 
> Caused by commit 2ca3a455432f ("leds: leds-mc13783: Add devicetree support").  of_get_next_child() is only defined if CONFIG_OF is set.
> 
> I have used the version of the leds tree from next-20130607 for today.

The patch has already been sent by me.
http://www.spinics.net/lists/linux-leds/msg00994.html

---
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: linux-next: build failure after merge of the leds tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]

Hi Guys,

On Mon, 17 Jun 2013 10:26:31 +0400 Alexander Shiyan <shc_work@mail.ru> wrote:
>
> > After merging the leds tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > drivers/leds/leds-mc13783.c: In function 'mc13xxx_led_probe':
> > drivers/leds/leds-mc13783.c:280:4: error: implicit declaration of function 'of_get_next_child' [-Werror=implicit-function-declaration]
> >     child = of_get_next_child(parent, child);
> >     ^
> > 
> > Caused by commit 2ca3a455432f ("leds: leds-mc13783: Add devicetree support").  of_get_next_child() is only defined if CONFIG_OF is set.
> > 
> > I have used the version of the leds tree from next-20130607 for today.
> 
> The patch has already been sent by me.
> http://www.spinics.net/lists/linux-leds/msg00994.html

I anything happening about this?  That patch would need to go into the
leds tree (with acks from devicetree people - Grant cc'd).
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the leds tree

[Grant Likely]

On Fri, Jun 21, 2013 at 1:16 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Guys,
>
> On Mon, 17 Jun 2013 10:26:31 +0400 Alexander Shiyan <shc_work@mail.ru> wrote:
>>
>> > After merging the leds tree, today's linux-next build (x86_64
>> > allmodconfig) failed like this:
>> >
>> > drivers/leds/leds-mc13783.c: In function 'mc13xxx_led_probe':
>> > drivers/leds/leds-mc13783.c:280:4: error: implicit declaration of function 'of_get_next_child' [-Werror=implicit-function-declaration]
>> >     child = of_get_next_child(parent, child);
>> >     ^
>> >
>> > Caused by commit 2ca3a455432f ("leds: leds-mc13783: Add devicetree support").  of_get_next_child() is only defined if CONFIG_OF is set.
>> >
>> > I have used the version of the leds tree from next-20130607 for today.
>>
>> The patch has already been sent by me.
>> http://www.spinics.net/lists/linux-leds/msg00994.html
>
> I anything happening about this?  That patch would need to go into the
> leds tree (with acks from devicetree people - Grant cc'd).

I've gone and looked at the patch. It should be reverted and
revisited. It interleaves a bunch of DT calls with non-DT calls which
the absence of empty stubs when !CONFIG_OF is intended to catch.

g.

linux-next: build failure after merge of the leds tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

Hi Bryan,

After merging the leds tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/leds/led-core.c: In function 'led_set_software_blink':
drivers/leds/led-core.c:44:2: error: implicit declaration of function 'led_stop_software_blink' [-Werror=implicit-function-declaration]

Caused by commit eb91300a9786 ("leds: fix led_brightness_set when
soft-blinking").

This is exactly the problem I reported on June 8 and was fixed in
next-20120612 ...

I have used the leds tree from next-20120612 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the leds tree

[Bryan Wu]

On Wed, Jun 13, 2012 at 12:10 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Bryan,
>
> After merging the leds tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/leds/led-core.c: In function 'led_set_software_blink':
> drivers/leds/led-core.c:44:2: error: implicit declaration of function 'led_stop_software_blink' [-Werror=implicit-function-declaration]
>
> Caused by commit eb91300a9786 ("leds: fix led_brightness_set when
> soft-blinking").
>
> This is exactly the problem I reported on June 8 and was fixed in
> next-20120612 ...
>
> I have used the leds tree from next-20120612 for today.

Thanks for raising this. I rebuilt the for-next branch.

-Bryan

linux-next: build failure after merge of the leds tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

Hi Bryan,

After merging the leds tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/leds/led-core.c: In function 'led_set_software_blink':
drivers/leds/led-core.c:44:2: error: implicit declaration of function 'led_stop_software_blink' [-Werror=implicit-function-declaration]

Caused by commit 12b204f41034 ("leds: fix led_brightness_set when
soft-blinking").  Please build test this stuff.

I have used the leds tree from next-20120607 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the leds tree

[Bryan Wu]

Hi Stephen,

I fixed this, since I put 2 bug fixing patches in my fixes-for-3.5
branch, which were missing in for-next.

-Bryan

On Fri, Jun 8, 2012 at 10:44 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Bryan,
>
> After merging the leds tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/leds/led-core.c: In function 'led_set_software_blink':
> drivers/leds/led-core.c:44:2: error: implicit declaration of function 'led_stop_software_blink' [-Werror=implicit-function-declaration]
>
> Caused by commit 12b204f41034 ("leds: fix led_brightness_set when
> soft-blinking").  Please build test this stuff.
>
> I have used the leds tree from next-20120607 for today.
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/



-- 
Bryan Wu <bryan.wu@canonical.com>
Kernel Developer    +86.186-168-78255 Mobile
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com