From: aris@redhat.com
To: linux-kernel@vger.kernel.org
Cc: cgroups@vger.kernel.org, Tejun Heo <tj@kernel.org>,
Serge Hallyn <serge.hallyn@canonical.com>
Subject: [PATCH v3 4/9] devcg: expand may_access() logic
Date: Tue, 29 Jan 2013 14:08:03 -0500 [thread overview]
Message-ID: <20130129190759.857103871@napanee.usersys.redhat.com> (raw)
In-Reply-To: 20130129190759.117458287@napanee.usersys.redhat.com
[-- Attachment #1: split_may_access_logic.patch --]
[-- Type: text/plain, Size: 1300 bytes --]
In order to make the next patch more clear, expand may_access() logic.
Cc: Tejun Heo <tj@kernel.org>
Cc: Serge Hallyn <serge.hallyn@canonical.com>
Signed-off-by: Aristeu Rozanski <aris@redhat.com>
---
security/device_cgroup.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
--- github.orig/security/device_cgroup.c 2013-01-29 11:49:15.244665037 -0500
+++ github/security/device_cgroup.c 2013-01-29 11:49:15.514669057 -0500
@@ -382,15 +382,18 @@ if (ex->minor != ~0 && ex->minor != re
/*
* In two cases we'll consider this new exception valid:
- * - the dev cgroup has its default policy to allow + exception list:
- * the new exception should *not* match any of the exceptions
- * (behavior == DEVCG_DEFAULT_ALLOW, !match)
* - the dev cgroup has its default policy to deny + exception list:
* the new exception *should* match the exceptions
- * (behavior == DEVCG_DEFAULT_DENY, match)
+ * - the dev cgroup has its default policy to allow + exception list:
+ * the new exception should *not* match any of the exceptions
*/
- if ((dev_cgroup->behavior == DEVCG_DEFAULT_DENY) == match)
- return 1;
+ if (dev_cgroup->behavior == DEVCG_DEFAULT_DENY) {
+ if (match)
+ return 1;
+ } else {
+ if (!match)
+ return 1;
+ }
return 0;
}
next prev parent reply other threads:[~2013-01-29 19:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 19:07 [PATCH v3 0/9] devcg: introduce proper hierarchy support aris
2013-01-29 19:08 ` [PATCH v3 1/9] device_cgroup: prepare exception list handling functions for two lists aris
2013-01-29 19:41 ` Tejun Heo
2013-01-29 19:45 ` Aristeu Rozanski
2013-01-30 17:41 ` Serge E. Hallyn
2013-01-30 18:45 ` Aristeu Rozanski
2013-01-29 19:08 ` [PATCH v3 2/9] devcg: reorder device exception functions aris
2013-01-29 19:44 ` Tejun Heo
2013-01-29 19:08 ` [PATCH v3 3/9] device_cgroup: keep track of local group settings aris
2013-01-29 19:46 ` Tejun Heo
2013-01-29 19:08 ` aris [this message]
2013-01-29 19:47 ` [PATCH v3 4/9] devcg: expand may_access() logic Tejun Heo
2013-01-29 19:08 ` [PATCH v3 5/9] devcg: prepare may_access() for hierarchy support aris
2013-01-29 19:49 ` Tejun Heo
2013-01-29 19:08 ` [PATCH v3 6/9] devcg: use css_online and css_offline aris
2013-01-29 19:52 ` Tejun Heo
2013-01-29 19:08 ` [PATCH v3 7/9] devcg: split single exception copy from dev_exceptions_copy() aris
2013-01-29 19:54 ` Tejun Heo
2013-01-29 19:08 ` [PATCH v3 8/9] devcg: refactor dev_exception_clean() aris
2013-01-29 19:55 ` Tejun Heo
2013-01-29 19:08 ` [PATCH v3 9/9] devcg: propagate local changes down the hierarchy aris
2013-01-29 20:35 ` Tejun Heo
2013-01-29 20:50 ` Aristeu Rozanski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130129190759.857103871@napanee.usersys.redhat.com \
--to=aris@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=serge.hallyn@canonical.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).