From: Tejun Heo <tj@kernel.org>
To: aris@redhat.com
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
Serge Hallyn <serge.hallyn@canonical.com>
Subject: Re: [PATCH v3 5/9] devcg: prepare may_access() for hierarchy support
Date: Tue, 29 Jan 2013 11:49:01 -0800 [thread overview]
Message-ID: <20130129194901.GF6824@mtj.dyndns.org> (raw)
In-Reply-To: <20130129190759.993951510@napanee.usersys.redhat.com>
On Tue, Jan 29, 2013 at 02:08:04PM -0500, aris@redhat.com wrote:
> Currently may_access() is only able to verify if an exception is valid for the
> current cgroup, which has the same behavior. With hierarchy, it'll be also used
> to verify if a cgroup local exception is valid towards its cgroup parent, which
> might have different behavior.
>
> v2:
> - updated patch description
> - rebased on top of a new patch to expand the may_access() logic to make it
> more clear
> - fixed argument description order in may_access()
>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Serge Hallyn <serge.hallyn@canonical.com>
> Signed-off-by: Aristeu Rozanski <aris@redhat.com>
>
> ---
> security/device_cgroup.c | 44 +++++++++++++++++++++++++++-----------------
> 1 file changed, 27 insertions(+), 17 deletions(-)
>
> --- github.orig/security/device_cgroup.c 2013-01-29 11:49:15.514669057 -0500
> +++ github/security/device_cgroup.c 2013-01-29 11:49:15.795673240 -0500
> @@ -354,9 +354,11 @@ return 0;
> * verify if a certain access is allowed.
> * @dev_cgroup: dev cgroup to be tested against
> * @refex: new exception
> + * @behavior: behavior of the exception
> */
> -static int may_access(struct dev_cgroup *dev_cgroup,
> - struct dev_exception_item *refex)
> +static bool may_access(struct dev_cgroup *dev_cgroup,
> + struct dev_exception_item *refex,
> + enum devcg_behavior behavior)
Probably belongs to the previous patch. Other than that,
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2013-01-29 19:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 19:07 [PATCH v3 0/9] devcg: introduce proper hierarchy support aris
2013-01-29 19:08 ` [PATCH v3 1/9] device_cgroup: prepare exception list handling functions for two lists aris
2013-01-29 19:41 ` Tejun Heo
2013-01-29 19:45 ` Aristeu Rozanski
2013-01-30 17:41 ` Serge E. Hallyn
2013-01-30 18:45 ` Aristeu Rozanski
2013-01-29 19:08 ` [PATCH v3 2/9] devcg: reorder device exception functions aris
2013-01-29 19:44 ` Tejun Heo
2013-01-29 19:08 ` [PATCH v3 3/9] device_cgroup: keep track of local group settings aris
2013-01-29 19:46 ` Tejun Heo
2013-01-29 19:08 ` [PATCH v3 4/9] devcg: expand may_access() logic aris
2013-01-29 19:47 ` Tejun Heo
2013-01-29 19:08 ` [PATCH v3 5/9] devcg: prepare may_access() for hierarchy support aris
2013-01-29 19:49 ` Tejun Heo [this message]
2013-01-29 19:08 ` [PATCH v3 6/9] devcg: use css_online and css_offline aris
2013-01-29 19:52 ` Tejun Heo
2013-01-29 19:08 ` [PATCH v3 7/9] devcg: split single exception copy from dev_exceptions_copy() aris
2013-01-29 19:54 ` Tejun Heo
2013-01-29 19:08 ` [PATCH v3 8/9] devcg: refactor dev_exception_clean() aris
2013-01-29 19:55 ` Tejun Heo
2013-01-29 19:08 ` [PATCH v3 9/9] devcg: propagate local changes down the hierarchy aris
2013-01-29 20:35 ` Tejun Heo
2013-01-29 20:50 ` Aristeu Rozanski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130129194901.GF6824@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=aris@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=serge.hallyn@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).