From: "Serge E. Hallyn" <serge@hallyn.com>
To: aris@redhat.com
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
Tejun Heo <tj@kernel.org>,
Serge Hallyn <serge.hallyn@canonical.com>
Subject: Re: [PATCH v3 1/9] device_cgroup: prepare exception list handling functions for two lists
Date: Wed, 30 Jan 2013 17:41:40 +0000 [thread overview]
Message-ID: <20130130174140.GA6411@mail.hallyn.com> (raw)
In-Reply-To: <20130129190759.321644928@napanee.usersys.redhat.com>
Quoting aris@redhat.com (aris@redhat.com):
> In the following patches, device_cgroup structure will have two sets of
> behavior and exceptions list (actual one, another with the local settings)
> so rework the functions to use exception list, not a device_cgroup.
>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Serge Hallyn <serge.hallyn@canonical.com>
Hi,
near as I can tell this is identical to the one I acked on Nov 20?
Acked-by: Serge Hallyn <serge.hallyn@canonical.com>
> Signed-off-by: Aristeu Rozanski <aris@redhat.com>
>
> ---
> security/device_cgroup.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> --- github.orig/security/device_cgroup.c 2013-01-29 11:48:50.603298122 -0500
> +++ github/security/device_cgroup.c 2013-01-29 11:49:14.739657516 -0500
> @@ -104,7 +104,7 @@ free_and_exit:
> /*
> * called under devcgroup_mutex
> */
> -static int dev_exception_add(struct dev_cgroup *dev_cgroup,
> +static int dev_exception_add(struct list_head *exceptions,
> struct dev_exception_item *ex)
> {
> struct dev_exception_item *excopy, *walk;
> @@ -115,7 +115,7 @@ static int dev_exception_add(struct dev_
> if (!excopy)
> return -ENOMEM;
>
> - list_for_each_entry(walk, &dev_cgroup->exceptions, list) {
> + list_for_each_entry(walk, exceptions, list) {
> if (walk->type != ex->type)
> continue;
> if (walk->major != ex->major)
> @@ -129,21 +129,21 @@ static int dev_exception_add(struct dev_
> }
>
> if (excopy != NULL)
> - list_add_tail_rcu(&excopy->list, &dev_cgroup->exceptions);
> + list_add_tail_rcu(&excopy->list, exceptions);
> return 0;
> }
>
> /*
> * called under devcgroup_mutex
> */
> -static void dev_exception_rm(struct dev_cgroup *dev_cgroup,
> +static void dev_exception_rm(struct list_head *exceptions,
> struct dev_exception_item *ex)
> {
> struct dev_exception_item *walk, *tmp;
>
> lockdep_assert_held(&devcgroup_mutex);
>
> - list_for_each_entry_safe(walk, tmp, &dev_cgroup->exceptions, list) {
> + list_for_each_entry_safe(walk, tmp, exceptions, list) {
> if (walk->type != ex->type)
> continue;
> if (walk->major != ex->major)
> @@ -514,10 +514,10 @@ case '\0':
> * don't want to break compatibility
> */
> if (devcgroup->behavior == DEVCG_DEFAULT_ALLOW) {
> - dev_exception_rm(devcgroup, &ex);
> + dev_exception_rm(&devcgroup->exceptions, &ex);
> return 0;
> }
> - return dev_exception_add(devcgroup, &ex);
> + return dev_exception_add(&devcgroup->exceptions, &ex);
> case DEVCG_DENY:
> /*
> * If the default policy is to deny by default, try to remove
> @@ -525,10 +525,10 @@ return 0;
> * don't want to break compatibility
> */
> if (devcgroup->behavior == DEVCG_DEFAULT_DENY) {
> - dev_exception_rm(devcgroup, &ex);
> + dev_exception_rm(&devcgroup->exceptions, &ex);
> return 0;
> }
> - return dev_exception_add(devcgroup, &ex);
> + return dev_exception_add(&devcgroup->exceptions, &ex);
> default:
> return -EINVAL;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2013-01-30 17:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 19:07 [PATCH v3 0/9] devcg: introduce proper hierarchy support aris
2013-01-29 19:08 ` [PATCH v3 1/9] device_cgroup: prepare exception list handling functions for two lists aris
2013-01-29 19:41 ` Tejun Heo
2013-01-29 19:45 ` Aristeu Rozanski
2013-01-30 17:41 ` Serge E. Hallyn [this message]
2013-01-30 18:45 ` Aristeu Rozanski
2013-01-29 19:08 ` [PATCH v3 2/9] devcg: reorder device exception functions aris
2013-01-29 19:44 ` Tejun Heo
2013-01-29 19:08 ` [PATCH v3 3/9] device_cgroup: keep track of local group settings aris
2013-01-29 19:46 ` Tejun Heo
2013-01-29 19:08 ` [PATCH v3 4/9] devcg: expand may_access() logic aris
2013-01-29 19:47 ` Tejun Heo
2013-01-29 19:08 ` [PATCH v3 5/9] devcg: prepare may_access() for hierarchy support aris
2013-01-29 19:49 ` Tejun Heo
2013-01-29 19:08 ` [PATCH v3 6/9] devcg: use css_online and css_offline aris
2013-01-29 19:52 ` Tejun Heo
2013-01-29 19:08 ` [PATCH v3 7/9] devcg: split single exception copy from dev_exceptions_copy() aris
2013-01-29 19:54 ` Tejun Heo
2013-01-29 19:08 ` [PATCH v3 8/9] devcg: refactor dev_exception_clean() aris
2013-01-29 19:55 ` Tejun Heo
2013-01-29 19:08 ` [PATCH v3 9/9] devcg: propagate local changes down the hierarchy aris
2013-01-29 20:35 ` Tejun Heo
2013-01-29 20:50 ` Aristeu Rozanski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130130174140.GA6411@mail.hallyn.com \
--to=serge@hallyn.com \
--cc=aris@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=serge.hallyn@canonical.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).