From: Andrew Vagin <avagin@parallels.com>
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc: Oleg Nesterov <oleg@redhat.com>,
David Howells <dhowells@redhat.com>,
Pavel Emelyanov <xemul@parallels.com>,
<linux-api@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<criu@openvz.org>, Cyrill Gorcunov <gorcunov@openvz.org>,
Andrey Wagin <avagin@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
<linux-fsdevel@vger.kernel.org>, Dave Jones <davej@redhat.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [CRIU] [PATCH 3/3] signalfd: add ability to read siginfo-s without dequeuing signals (v2)
Date: Sun, 10 Feb 2013 14:04:24 +0400 [thread overview]
Message-ID: <20130210100424.GA15978@paralelels.com> (raw)
In-Reply-To: <CAKgNAkiYrP046mEv1_GJED5DckJrZSHvwu2u=P_BRxx-NuKALQ@mail.gmail.com>
On Sat, Feb 09, 2013 at 11:53:04PM +0100, Michael Kerrisk (man-pages) wrote:
> On Sat, Feb 9, 2013 at 7:22 PM, Oleg Nesterov <oleg@redhat.com> wrote:
> > On 02/08, Michael Kerrisk (man-pages) wrote:
> >>
> >> On Fri, Feb 8, 2013 at 8:10 PM, Oleg Nesterov <oleg@redhat.com> wrote:
> >> >
> >> > Well. I do not know. Up to you and Michael.
> >> >
> >> > But honestly, I can't say this all looks really nice. And why do we
> >> > need SIGNALFD_PEEK then?
> >>
> >> It surely is no beauty. The hope is at least to make it less ugly than it was.
> >
> > This is subjective, but I am not sure about "less" ;) Yes, we avoid the
> > magic offsets, but we add SFD_SHARED/PER_THREAD which need to change
> > dequeue_signal plus other complications. And for what?
> >
> >> > Seriously, perhaps we should simply add signalfd_fops->ioctl() for PEEK.
> >> > Or add PTRACE_{PEEK,POKE}_SIGNAL which looks even logical and useful...
> >> > And much simpler/straightforward.
> >> >
> >> > But I am not going to argue.
> >>
> >> I suppose I had wondered along similar lines, but in a slightly
> >> different direction: would the use of a /proc interface to get the
> >> queued signals make some sense?
> >
> > (Can't resist sorry... yes we need /proc/pid/cr or /dev/cr or whatever
> > which dumps almost everything c/r needs without need to add a lot of
> > cr code everywhere).
> >
> > Perhaps, but I am not sure about the textual representation.
> >
> > And to me, the best solution is the simplest solution. Please look
> > at the patch below. It is trivial. And we can also drop the SFD_RAW
> > patch in -mm.
>
> Oleg,
>
> This looks promising, but I am not sure I understand the user-space
> API. Could you explain how it would look to (say) pull all per-thread
> signals from user space?
>
siginfo_t *signals = malloc(...);
...
ret = ptrace(PTRACE_ATTACH, pid, NULL, NULL);
if (ret == -1)
goto err;
for (i = 0; ; i++) {
ret = ptrace(PTRACE_PEEKSIGNAL, pid, i, signals + i);
if (ret == -1) {
if (errno == ESOMETHING)
break;
else
goto err_detach;
}
}
...
err_detach:
ret = ptrace(PTRACE_DETACH, pid, NULL, NULL);
err:
...
For shared (per-process) signals one line should be changed:
ret = ptrace(PTRACE_PEEKSIGNAL, pid, PTRACE_PEEK_SHARED + i, signals + i);
> Thanks,
>
> Michael
>
>
> > --- x/kernel/ptrace.c
> > +++ x/kernel/ptrace.c
> > @@ -618,6 +618,35 @@ static int ptrace_setsiginfo(struct task
> > return error;
> > }
> >
> > +static int ptrace_peek_signal(struct task_struct *child,
> > + unsigned long addr, siginfo_t __user *uinfo)
> > +{
> > + siginfo_t info;
> > + struct sigpending *pending;
> > + int ret = -ESOMETHING;
> > +
> > + pending = &child->pending;
> > + if (addr & PTRACE_PEEK_SHARED) {
> > + addr &= ~PTRACE_PEEK_SHARED;
> > + pending = &child->signal->shared_pending;
> > + }
> > +
> > + spin_lock_irq(&child->sighand->siglock);
> > + list_for_each_entry(q, &pending->list, list) {
> > + if (!addr--) {
> > + copy_siginfo(info, &q->info);
> > + ret = 0;
> > + break;
> > + }
> > + }
> > + spin_lock_irq(&child->sighand->siglock);
> > +
> > + if (!ret)
> > + ret = copy_siginfo_to_user(uinfo, info);
> > + if (!ret)
> > + ret = __put_user(info, si_code);
> > + return ret;
> > +}
> >
> > #ifdef PTRACE_SINGLESTEP
> > #define is_singlestep(request) ((request) == PTRACE_SINGLESTEP)
> > @@ -742,6 +771,10 @@ int ptrace_request(struct task_struct *c
> > ret = put_user(child->ptrace_message, datalp);
> > break;
> >
> > + case PTRACE_PEEKSIGNAL:
> > + ret = ptrace_peek_signal(child, addr, datavp);
> > + break;
> > +
> > case PTRACE_GETSIGINFO:
> > ret = ptrace_getsiginfo(child, &siginfo);
> > if (!ret)
> >
>
>
>
> --
> Michael Kerrisk
> Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
> Author of "The Linux Programming Interface"; http://man7.org/tlpi/
> _______________________________________________
> CRIU mailing list
> CRIU@openvz.org
> https://lists.openvz.org/mailman/listinfo/criu
next prev parent reply other threads:[~2013-02-10 10:05 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 10:15 [PATCH 0/3] signalfd: a kernel interface for dumping pending signals Andrey Vagin
2013-01-22 10:15 ` [PATCH 1/3] signal: add a helper for dequeuing signals from a specified queue Andrey Vagin
2013-02-05 12:00 ` [PATCH 1/3] signal: add a helper for dequeuing signals from a specified queue (v2) Andrey Vagin
2013-01-22 10:15 ` [PATCH 2/3] signalfd: add ability to choose a private or shared queue Andrey Vagin
2013-02-07 18:17 ` Oleg Nesterov
2013-02-08 0:35 ` Michael Kerrisk (man-pages)
2013-02-08 19:12 ` Oleg Nesterov
2013-01-22 10:15 ` [PATCH 3/3] signalfd: add ability to read siginfo-s without dequeuing signals Andrey Vagin
2013-01-29 19:03 ` [PATCH 3/3] signalfd: add ability to read siginfo-s without dequeuing signals (v2) Andrey Vagin
[not found] ` <CAKgNAkgQA=zK=2ZnytPFU=DH6jr0sja0iy6K+j6c7unheLFniQ@mail.gmail.com>
2013-02-02 7:15 ` Andrey Wagin
2013-02-07 17:34 ` Oleg Nesterov
2013-02-07 21:13 ` Andrey Wagin
2013-02-08 0:51 ` Michael Kerrisk (man-pages)
2013-02-08 19:10 ` Oleg Nesterov
2013-02-08 20:15 ` Michael Kerrisk (man-pages)
2013-02-09 18:22 ` Oleg Nesterov
2013-02-09 22:53 ` Michael Kerrisk (man-pages)
2013-02-10 10:04 ` Andrew Vagin [this message]
2013-02-11 16:47 ` [CRIU] " Oleg Nesterov
2013-02-10 10:07 ` Andrew Vagin
2013-02-11 9:29 ` Denys Vlasenko
2013-02-11 10:59 ` [CRIU] " Andrew Vagin
2013-02-11 14:46 ` Denys Vlasenko
2013-02-11 14:53 ` Pavel Emelyanov
2013-02-11 17:25 ` Denys Vlasenko
2013-02-12 14:50 ` Pavel Emelyanov
2013-01-23 4:19 ` [PATCH 0/3] signalfd: a kernel interface for dumping pending signals Michael Kerrisk (man-pages)
2013-01-23 11:03 ` Andrew Vagin
2013-01-23 12:11 ` Michael Kerrisk (man-pages)
2013-01-23 13:03 ` Andrew Vagin
2013-02-07 18:20 ` Oleg Nesterov
2013-02-08 0:36 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130210100424.GA15978@paralelels.com \
--to=avagin@parallels.com \
--cc=avagin@gmail.com \
--cc=criu@openvz.org \
--cc=davej@redhat.com \
--cc=dhowells@redhat.com \
--cc=gorcunov@openvz.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).