* drivers/gpu/drm/nouveau/nouveau_acpi.c:420: undefined reference to `acpi_video_get_edid'
@ 2013-02-04 15:23 Borislav Petkov
2013-02-04 15:41 ` [PATCH] drm/nouveau: always select ACPI_VIDEO if ACPI is enabled Maarten Lankhorst
0 siblings, 1 reply; 7+ messages in thread
From: Borislav Petkov @ 2013-02-04 15:23 UTC (permalink / raw)
To: dri-devel; +Cc: lkml
Hi,
I'm guessing someone has already triggered this on latest Linus' tree
and has a fix?
drivers/built-in.o: In function `nouveau_acpi_edid':
/w/kernel/linux/drivers/gpu/drm/nouveau/nouveau_acpi.c:420: undefined reference to `acpi_video_get_edid'
make: *** [vmlinux] Error 1
Btw, I got CONFIG_ACPI_VIDEO=m while CONFIG_DRM_NOUVEAU=y and this is
probably the reason for the vmlinux link error.
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] drm/nouveau: always select ACPI_VIDEO if ACPI is enabled. 2013-02-04 15:23 drivers/gpu/drm/nouveau/nouveau_acpi.c:420: undefined reference to `acpi_video_get_edid' Borislav Petkov @ 2013-02-04 15:41 ` Maarten Lankhorst 2013-02-05 14:52 ` Borislav Petkov 0 siblings, 1 reply; 7+ messages in thread From: Maarten Lankhorst @ 2013-02-04 15:41 UTC (permalink / raw) To: Borislav Petkov, dri-devel, lkml Hey, Op 04-02-13 16:23, Borislav Petkov schreef: > Hi, > > I'm guessing someone has already triggered this on latest Linus' tree > and has a fix? > > drivers/built-in.o: In function `nouveau_acpi_edid': > /w/kernel/linux/drivers/gpu/drm/nouveau/nouveau_acpi.c:420: undefined reference to `acpi_video_get_edid' > make: *** [vmlinux] Error 1 > > Btw, I got CONFIG_ACPI_VIDEO=m while CONFIG_DRM_NOUVEAU=y and this is > probably the reason for the vmlinux link error. > > Thanks. > Does this fix things? -->8 Having nouveau builtin would still allow ACPI_VIDEO to be used as external module if some of the deps for acpi_video have not been met, which would result in a linking failure. Solve this by only requiring ACPI && X86 to select ACPI_VIDEO. Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com> --- diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig index 8a55bee..f08b9b6 100644 --- a/drivers/gpu/drm/nouveau/Kconfig +++ b/drivers/gpu/drm/nouveau/Kconfig @@ -10,7 +10,7 @@ config DRM_NOUVEAU select FB select FRAMEBUFFER_CONSOLE if !EXPERT select FB_BACKLIGHT if DRM_NOUVEAU_BACKLIGHT - select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT + select ACPI_VIDEO if ACPI && X86 select ACPI_WMI if ACPI select MXM_WMI if ACPI select POWER_SUPPLY ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/nouveau: always select ACPI_VIDEO if ACPI is enabled. 2013-02-04 15:41 ` [PATCH] drm/nouveau: always select ACPI_VIDEO if ACPI is enabled Maarten Lankhorst @ 2013-02-05 14:52 ` Borislav Petkov 2013-02-05 15:38 ` [PATCH v2] " Maarten Lankhorst 0 siblings, 1 reply; 7+ messages in thread From: Borislav Petkov @ 2013-02-05 14:52 UTC (permalink / raw) To: Maarten Lankhorst; +Cc: dri-devel, lkml On Mon, Feb 04, 2013 at 04:41:22PM +0100, Maarten Lankhorst wrote: > Hey, > > Op 04-02-13 16:23, Borislav Petkov schreef: > > Hi, > > > > I'm guessing someone has already triggered this on latest Linus' tree > > and has a fix? > > > > drivers/built-in.o: In function `nouveau_acpi_edid': > > /w/kernel/linux/drivers/gpu/drm/nouveau/nouveau_acpi.c:420: undefined reference to `acpi_video_get_edid' > > make: *** [vmlinux] Error 1 > > > > Btw, I got CONFIG_ACPI_VIDEO=m while CONFIG_DRM_NOUVEAU=y and this is > > probably the reason for the vmlinux link error. > > > > Thanks. > > > Does this fix things? > > -->8 > Having nouveau builtin would still allow ACPI_VIDEO to be used as external module if some of the deps for acpi_video > have not been met, which would result in a linking failure. Solve this by only requiring ACPI && X86 to select ACPI_VIDEO. > > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com> > > --- > diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig > index 8a55bee..f08b9b6 100644 > --- a/drivers/gpu/drm/nouveau/Kconfig > +++ b/drivers/gpu/drm/nouveau/Kconfig > @@ -10,7 +10,7 @@ config DRM_NOUVEAU > select FB > select FRAMEBUFFER_CONSOLE if !EXPERT > select FB_BACKLIGHT if DRM_NOUVEAU_BACKLIGHT > - select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT > + select ACPI_VIDEO if ACPI && X86 > select ACPI_WMI if ACPI > select MXM_WMI if ACPI > select POWER_SUPPLY Not really. drivers/built-in.o: In function `acpi_video_bus_put_one_device': /root/kernel/linux/drivers/acpi/video.c:1407: undefined reference to `thermal_cooling_device_unregister' drivers/built-in.o: In function `acpi_video_device_find_cap': /root/kernel/linux/drivers/acpi/video.c:842: undefined reference to `thermal_cooling_device_register' make: *** [vmlinux] Error 1 It is CONFIG_THERMAL=m this time. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] drm/nouveau: always select ACPI_VIDEO if ACPI is enabled. 2013-02-05 14:52 ` Borislav Petkov @ 2013-02-05 15:38 ` Maarten Lankhorst 2013-02-05 16:22 ` Borislav Petkov 0 siblings, 1 reply; 7+ messages in thread From: Maarten Lankhorst @ 2013-02-05 15:38 UTC (permalink / raw) To: Borislav Petkov, dri-devel, lkml; +Cc: Michal Marek Op 05-02-13 15:52, Borislav Petkov schreef: > On Mon, Feb 04, 2013 at 04:41:22PM +0100, Maarten Lankhorst wrote: >> Hey, >> >> Op 04-02-13 16:23, Borislav Petkov schreef: >>> Hi, >>> >>> I'm guessing someone has already triggered this on latest Linus' tree >>> and has a fix? >>> >>> drivers/built-in.o: In function `nouveau_acpi_edid': >>> /w/kernel/linux/drivers/gpu/drm/nouveau/nouveau_acpi.c:420: undefined reference to `acpi_video_get_edid' >>> make: *** [vmlinux] Error 1 >>> >>> Btw, I got CONFIG_ACPI_VIDEO=m while CONFIG_DRM_NOUVEAU=y and this is >>> probably the reason for the vmlinux link error. >>> >>> Thanks. >>> >> Does this fix things? >> >> -->8 >> Having nouveau builtin would still allow ACPI_VIDEO to be used as external module if some of the deps for acpi_video >> have not been met, which would result in a linking failure. Solve this by only requiring ACPI && X86 to select ACPI_VIDEO. >> >> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com> >> >> --- >> diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig >> index 8a55bee..f08b9b6 100644 >> --- a/drivers/gpu/drm/nouveau/Kconfig >> +++ b/drivers/gpu/drm/nouveau/Kconfig >> @@ -10,7 +10,7 @@ config DRM_NOUVEAU >> select FB >> select FRAMEBUFFER_CONSOLE if !EXPERT >> select FB_BACKLIGHT if DRM_NOUVEAU_BACKLIGHT >> - select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT >> + select ACPI_VIDEO if ACPI && X86 >> select ACPI_WMI if ACPI >> select MXM_WMI if ACPI >> select POWER_SUPPLY > Not really. > > drivers/built-in.o: In function `acpi_video_bus_put_one_device': > /root/kernel/linux/drivers/acpi/video.c:1407: undefined reference to `thermal_cooling_device_unregister' > drivers/built-in.o: In function `acpi_video_device_find_cap': > /root/kernel/linux/drivers/acpi/video.c:842: undefined reference to `thermal_cooling_device_register' > make: *** [vmlinux] Error 1 > > It is CONFIG_THERMAL=m this time. > > Thanks. > Argh, next attempt, based on i915's Kconfig. It seems that not only I have to select ACPI_VIDEO, I also have to select all the dependencies. Is this a Kconfig bug or working as intended? i915 seems to have a workaround, so I copied it from there. Except it's currently missing select THERMAL, so I guess it didn't get updated when that got added. ---->8 Having nouveau builtin would still allow ACPI_VIDEO to be used as external module if some of the deps for acpi_video have not been met, which would result in a linking failure. Solve this by selecting all dependencies as well. Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com> --- diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig index 8a55bee..e84763a 100644 --- a/drivers/gpu/drm/nouveau/Kconfig +++ b/drivers/gpu/drm/nouveau/Kconfig @@ -10,10 +10,16 @@ config DRM_NOUVEAU select FB select FRAMEBUFFER_CONSOLE if !EXPERT select FB_BACKLIGHT if DRM_NOUVEAU_BACKLIGHT - select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT select ACPI_WMI if ACPI select MXM_WMI if ACPI select POWER_SUPPLY + # Similar to i915, we need to select ACPI_VIDEO and it's dependencies + select BACKLIGHT_LCD_SUPPORT if ACPI && X86 + select BACKLIGHT_CLASS_DEVICE if ACPI && X86 + select VIDEO_OUTPUT_CONTROL if ACPI && X86 + select INPUT if ACPI && X86 + select THERMAL if ACPI && X86 + select ACPI_VIDEO if ACPI && X86 help Choose this option for open-source nVidia support. ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drm/nouveau: always select ACPI_VIDEO if ACPI is enabled. 2013-02-05 15:38 ` [PATCH v2] " Maarten Lankhorst @ 2013-02-05 16:22 ` Borislav Petkov 2013-02-20 18:56 ` Borislav Petkov 0 siblings, 1 reply; 7+ messages in thread From: Borislav Petkov @ 2013-02-05 16:22 UTC (permalink / raw) To: Maarten Lankhorst; +Cc: dri-devel, lkml, Michal Marek On Tue, Feb 05, 2013 at 04:38:35PM +0100, Maarten Lankhorst wrote: > Argh, next attempt, based on i915's Kconfig. > > It seems that not only I have to select ACPI_VIDEO, I also have to select all the dependencies. > Is this a Kconfig bug or working as intended? i915 seems to have a workaround, so I copied it from > there. Except it's currently missing select THERMAL, so I guess it didn't get updated when that got > added. > > ---->8 > Having nouveau builtin would still allow ACPI_VIDEO to be used as external module > if some of the deps for acpi_video have not been met, which would result in a linking > failure. Solve this by selecting all dependencies as well. > > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com> Yep, this takes care of all deps, Tested-by: Borislav Petkov <bp@suse.de> Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drm/nouveau: always select ACPI_VIDEO if ACPI is enabled. 2013-02-05 16:22 ` Borislav Petkov @ 2013-02-20 18:56 ` Borislav Petkov 2013-04-17 10:10 ` Borislav Petkov 0 siblings, 1 reply; 7+ messages in thread From: Borislav Petkov @ 2013-02-20 18:56 UTC (permalink / raw) To: Maarten Lankhorst, dri-devel, lkml, Michal Marek On Tue, Feb 05, 2013 at 05:22:06PM +0100, Borislav Petkov wrote: > On Tue, Feb 05, 2013 at 04:38:35PM +0100, Maarten Lankhorst wrote: > > Argh, next attempt, based on i915's Kconfig. > > > > It seems that not only I have to select ACPI_VIDEO, I also have to select all the dependencies. > > Is this a Kconfig bug or working as intended? i915 seems to have a workaround, so I copied it from > > there. Except it's currently missing select THERMAL, so I guess it didn't get updated when that got > > added. > > > > ---->8 > > Having nouveau builtin would still allow ACPI_VIDEO to be used as external module > > if some of the deps for acpi_video have not been met, which would result in a linking > > failure. Solve this by selecting all dependencies as well. > > > > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com> > > Yep, this takes care of all deps, > > Tested-by: Borislav Petkov <bp@suse.de> Just to check whether anyone has picked this already - it is triggering on 3.8 too so it most probably needs a stable tag too. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drm/nouveau: always select ACPI_VIDEO if ACPI is enabled. 2013-02-20 18:56 ` Borislav Petkov @ 2013-04-17 10:10 ` Borislav Petkov 0 siblings, 0 replies; 7+ messages in thread From: Borislav Petkov @ 2013-04-17 10:10 UTC (permalink / raw) To: Linus Torvalds; +Cc: Maarten Lankhorst, dri-devel, lkml, Michal Marek On Wed, Feb 20, 2013 at 07:56:33PM +0100, Borislav Petkov wrote: > On Tue, Feb 05, 2013 at 05:22:06PM +0100, Borislav Petkov wrote: > > On Tue, Feb 05, 2013 at 04:38:35PM +0100, Maarten Lankhorst wrote: > > > Argh, next attempt, based on i915's Kconfig. > > > > > > It seems that not only I have to select ACPI_VIDEO, I also have to select all the dependencies. > > > Is this a Kconfig bug or working as intended? i915 seems to have a workaround, so I copied it from > > > there. Except it's currently missing select THERMAL, so I guess it didn't get updated when that got > > > added. > > > > > > ---->8 > > > Having nouveau builtin would still allow ACPI_VIDEO to be used as external module > > > if some of the deps for acpi_video have not been met, which would result in a linking > > > failure. Solve this by selecting all dependencies as well. > > > > > > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com> > > > > Yep, this takes care of all deps, > > > > Tested-by: Borislav Petkov <bp@suse.de> > > Just to check whether anyone has picked this already - it is triggering > on 3.8 too so it most probably needs a stable tag too. Ok, this is not good. So we have -rc7+, this patch has been out there for 2 months and still not in Linus' tree. Linus, the patch below fixes a build failure here with my custom config. I think this late in the game, we need some kind of a fix before 3.9 is released. I'm adding the patch here in case you want to pick it up yourself. Thanks. -- From: Maarten Lankhorst <maarten.lankhorst@canonical.com> Date: Wed, 17 Apr 2013 12:04:09 +0200 Subject: [PATCH] drm/nouveau: always select ACPI_VIDEO if ACPI is enabled. Having nouveau builtin would still allow ACPI_VIDEO to be used as external module if some of the deps for acpi_video have not been met, which would result in a linking failure. Solve this by selecting all dependencies as well. Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com> Tested-by: Borislav Petkov <bp@suse.de> --- drivers/gpu/drm/nouveau/Kconfig | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig index a7ff6d5a34b9..845b7caa9ee1 100644 --- a/drivers/gpu/drm/nouveau/Kconfig +++ b/drivers/gpu/drm/nouveau/Kconfig @@ -10,11 +10,17 @@ config DRM_NOUVEAU select FB select FRAMEBUFFER_CONSOLE if !EXPERT select FB_BACKLIGHT if DRM_NOUVEAU_BACKLIGHT - select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT select X86_PLATFORM_DEVICES if ACPI && X86 select ACPI_WMI if ACPI && X86 select MXM_WMI if ACPI && X86 select POWER_SUPPLY + # Similar to i915, we need to select ACPI_VIDEO and it's dependencies + select BACKLIGHT_LCD_SUPPORT if ACPI && X86 + select BACKLIGHT_CLASS_DEVICE if ACPI && X86 + select VIDEO_OUTPUT_CONTROL if ACPI && X86 + select INPUT if ACPI && X86 + select THERMAL if ACPI && X86 + select ACPI_VIDEO if ACPI && X86 help Choose this option for open-source nVidia support. -- 1.8.2.135.g7b592fa -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. - - ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-04-17 10:10 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2013-02-04 15:23 drivers/gpu/drm/nouveau/nouveau_acpi.c:420: undefined reference to `acpi_video_get_edid' Borislav Petkov 2013-02-04 15:41 ` [PATCH] drm/nouveau: always select ACPI_VIDEO if ACPI is enabled Maarten Lankhorst 2013-02-05 14:52 ` Borislav Petkov 2013-02-05 15:38 ` [PATCH v2] " Maarten Lankhorst 2013-02-05 16:22 ` Borislav Petkov 2013-02-20 18:56 ` Borislav Petkov 2013-04-17 10:10 ` Borislav Petkov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).