linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Kent Overstreet <kmo@daterainc.com>,
	linux-kernel@vger.kernel.org, dm-devel@redhat.com,
	"Alasdair G. Kergon" <agk@redhat.com>
Subject: Re: block: flush queued bios when the process blocks
Date: Tue, 27 May 2014 13:33:06 -0400	[thread overview]
Message-ID: <20140527173306.GA12201@redhat.com> (raw)
In-Reply-To: <alpine.LRH.2.02.1405271222150.8745@file01.intranet.prod.int.rdu2.redhat.com>

On Tue, May 27 2014 at 12:26pm -0400,
Mikulas Patocka <mpatocka@redhat.com> wrote:

> On Tue, 27 May 2014, Jens Axboe wrote:
> 
> > On 2014-05-27 09:23, Mikulas Patocka wrote:
> > 
> > > The patch adds bio list flushing to the scheduler just besides plug
> > > flushsing.
> > 
> > ... which is exactly why I'm commenting. It'd be great to avoid yet one more
> > scheduler hook for this sort of thing.
> > 
> > -- 
> > Jens Axboe
> 
> One could create something like schedule notifier chain, but I'm not sure 
> if it is worth the complexity because of just two users. If more users 
> come in the future, it could be generalized.

It could be that Jens is suggesting updating blk_needs_flush_plug() and
blk_schedule_flush_plug() to be bio_list aware too (rather than train
sched_submit_work() from this new bio_list)?

Somewhat awkward, but _could_ be made to work.

  reply	other threads:[~2014-05-27 17:33 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-27 15:03 [PATCH] block: flush queued bios when the process blocks Mikulas Patocka
2014-05-27 15:08 ` Jens Axboe
2014-05-27 15:23   ` Mikulas Patocka
2014-05-27 15:42     ` Jens Axboe
2014-05-27 16:26       ` Mikulas Patocka
2014-05-27 17:33         ` Mike Snitzer [this message]
2014-05-27 19:56           ` Kent Overstreet
2015-10-05 19:50             ` Mike Snitzer
2014-05-27 17:42         ` [PATCH] " Jens Axboe
2014-05-27 18:14           ` [dm-devel] " Christoph Hellwig
2014-05-27 19:59             ` Kent Overstreet
2014-05-27 19:56           ` Mikulas Patocka
2014-05-27 20:06             ` Kent Overstreet
2014-05-29 23:52           ` Mikulas Patocka
2015-10-05 20:59             ` Mike Snitzer
2015-10-06 13:28               ` Mikulas Patocka
2015-10-06 13:47                 ` Mike Snitzer
2015-10-06 14:10                   ` Mikulas Patocka
2015-10-06 14:26                   ` Mikulas Patocka
2015-10-06 18:17               ` [dm-devel] " Mikulas Patocka
2015-10-06 18:50                 ` Mike Snitzer
2015-10-06 20:16                   ` [PATCH v2] " Mike Snitzer
2015-10-06 20:26                     ` Mike Snitzer
2015-10-08 15:04                     ` Mikulas Patocka
2015-10-08 15:08                       ` Mike Snitzer
2015-10-09 19:52                         ` Mike Snitzer
2015-10-09 19:59                           ` Mike Snitzer
2015-10-14 20:47                             ` [PATCH v3 for-4.4] block: flush queued bios when process blocks to avoid deadlock Mike Snitzer
2015-10-14 21:44                               ` Jeff Moyer
2015-10-17 16:04                               ` Ming Lei
2015-10-20 19:57                                 ` Mike Snitzer
2015-10-20 20:03                                 ` Mikulas Patocka
2015-10-21 16:38                                   ` Ming Lei
2015-10-21 21:49                                     ` Mikulas Patocka
2015-10-22  1:53                                       ` Ming Lei
2015-10-15  3:27                           ` [PATCH v2] block: flush queued bios when the process blocks Ming Lei
2015-10-15  8:06                             ` Mike Snitzer
2015-10-16  3:08                               ` Ming Lei
2015-10-16 15:29                                 ` Mike Snitzer
2015-10-17 15:54                                   ` Ming Lei
2015-10-09 11:58                     ` kbuild test robot
2014-05-27 17:59   ` [PATCH] " Kent Overstreet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140527173306.GA12201@redhat.com \
    --to=snitzer@redhat.com \
    --cc=agk@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=kmo@daterainc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).