[RFC 1/1] fs/configfs/dir.c: remove unused debugging functions

[RFC 1/1] fs/configfs/dir.c: remove unused debugging functions

[Fabian Frederick]

Joe Perches noticed it was not used anywhere.
If there's no plan to use it in the future,
we could simply remove both functions ...

Cc: Joe Perches <joe@perches.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 fs/configfs/dir.c | 37 -------------------------------------
 1 file changed, 37 deletions(-)

diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c
index e081acb..1b12d0a 100644
--- a/fs/configfs/dir.c
+++ b/fs/configfs/dir.c
@@ -937,43 +937,6 @@ static void client_drop_item(struct config_item *parent_item,
 		config_item_put(item);
 }
 
-#ifdef DEBUG
-static void configfs_dump_one(struct configfs_dirent *sd, int level)
-{
-	printk(KERN_INFO "%*s\"%s\":\n", level, " ", configfs_get_name(sd));
-
-#define type_print(_type) if (sd->s_type & _type) printk(KERN_INFO "%*s %s\n", level, " ", #_type);
-	type_print(CONFIGFS_ROOT);
-	type_print(CONFIGFS_DIR);
-	type_print(CONFIGFS_ITEM_ATTR);
-	type_print(CONFIGFS_ITEM_LINK);
-	type_print(CONFIGFS_USET_DIR);
-	type_print(CONFIGFS_USET_DEFAULT);
-	type_print(CONFIGFS_USET_DROPPING);
-#undef type_print
-}
-
-static int configfs_dump(struct configfs_dirent *sd, int level)
-{
-	struct configfs_dirent *child_sd;
-	int ret = 0;
-
-	configfs_dump_one(sd, level);
-
-	if (!(sd->s_type & (CONFIGFS_DIR|CONFIGFS_ROOT)))
-		return 0;
-
-	list_for_each_entry(child_sd, &sd->s_children, s_sibling) {
-		ret = configfs_dump(child_sd, level + 2);
-		if (ret)
-			break;
-	}
-
-	return ret;
-}
-#endif
-
-
 /*
  * configfs_depend_item() and configfs_undepend_item()
  *
-- 
1.8.4.5

Re: [RFC 1/1] fs/configfs/dir.c: remove unused debugging functions

[Joel Becker]

On Tue, May 13, 2014 at 08:38:32PM +0200, Fabian Frederick wrote:
> Joe Perches noticed it was not used anywhere.
> If there's no plan to use it in the future,
> we could simply remove both functions ...
> 
> Cc: Joe Perches <joe@perches.com>
> Cc: Joel Becker <jlbec@evilplan.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>

We used to flip DEBUG and insert them as needed.  It's been a while.

Acked-by: Joel Becker <jlbec@evilplan.org>


> ---
>  fs/configfs/dir.c | 37 -------------------------------------
>  1 file changed, 37 deletions(-)
> 
> diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c
> index e081acb..1b12d0a 100644
> --- a/fs/configfs/dir.c
> +++ b/fs/configfs/dir.c
> @@ -937,43 +937,6 @@ static void client_drop_item(struct config_item *parent_item,
>  		config_item_put(item);
>  }
>  
> -#ifdef DEBUG
> -static void configfs_dump_one(struct configfs_dirent *sd, int level)
> -{
> -	printk(KERN_INFO "%*s\"%s\":\n", level, " ", configfs_get_name(sd));
> -
> -#define type_print(_type) if (sd->s_type & _type) printk(KERN_INFO "%*s %s\n", level, " ", #_type);
> -	type_print(CONFIGFS_ROOT);
> -	type_print(CONFIGFS_DIR);
> -	type_print(CONFIGFS_ITEM_ATTR);
> -	type_print(CONFIGFS_ITEM_LINK);
> -	type_print(CONFIGFS_USET_DIR);
> -	type_print(CONFIGFS_USET_DEFAULT);
> -	type_print(CONFIGFS_USET_DROPPING);
> -#undef type_print
> -}
> -
> -static int configfs_dump(struct configfs_dirent *sd, int level)
> -{
> -	struct configfs_dirent *child_sd;
> -	int ret = 0;
> -
> -	configfs_dump_one(sd, level);
> -
> -	if (!(sd->s_type & (CONFIGFS_DIR|CONFIGFS_ROOT)))
> -		return 0;
> -
> -	list_for_each_entry(child_sd, &sd->s_children, s_sibling) {
> -		ret = configfs_dump(child_sd, level + 2);
> -		if (ret)
> -			break;
> -	}
> -
> -	return ret;
> -}
> -#endif
> -
> -
>  /*
>   * configfs_depend_item() and configfs_undepend_item()
>   *
> -- 
> 1.8.4.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--