* [GIT PULL 0/5] perf/core improvements and fixes
@ 2014-06-27 12:20 Jiri Olsa
2014-06-27 12:20 ` [PATCH 1/5] tools lib traceevent: Fix a risk for doing free on uninitialized pointer Jiri Olsa
` (5 more replies)
0 siblings, 6 replies; 36+ messages in thread
From: Jiri Olsa @ 2014-06-27 12:20 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Corey Ashford,
David Ahern, Frederic Weisbecker, Jiri Olsa, Maynard Johnson,
Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Rickard Strandqvist, Sebastian Andrzej Siewior, Steven Rostedt,
Sukadev Bhattiprolu
hi Ingo,
please consider pulling
thanks,
jirka
The following changes since commit 1c92f88542faa3ae4f970c548b4fe8275a45201b:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf into perf/core (2014-06-25 07:44:19 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-core-for-mingo
for you to fetch changes up to 8ac631cd502d6b31fd29f6d019305305b479fa3e:
perf script: Handle the num array type in python properly (2014-06-27 11:15:02 +0200)
----------------------------------------------------------------
perf/core improvements and fixes:
. Handle the num array type in python properly (Sebastian Andrzej Siewior)
. Fix wrong condition for allocation failure (Jiri Olsa)
. Adjust callchain based on DWARF debug info on powerpc (Sukadev Bhattiprolu)
. Fix a risk for doing free on uninitialized pointer in traceevent lib (Rickard Strandqvist)
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
----------------------------------------------------------------
Jiri Olsa (1):
perf tools: Fix wrong condition for allocation failure
Rickard Strandqvist (1):
tools lib traceevent: Fix a risk for doing free on uninitialized pointer
Sebastian Andrzej Siewior (2):
perf script: Move the number processing into its own function
perf script: Handle the num array type in python properly
Sukadev Bhattiprolu (1):
perf tools powerpc: Adjust callchain based on DWARF debug info
tools/lib/traceevent/event-parse.c | 6 +-
tools/perf/arch/powerpc/Makefile | 1 +
tools/perf/arch/powerpc/util/skip-callchain-idx.c | 266 +++++++++++++++++++++
tools/perf/builtin-stat.c | 2 +-
tools/perf/config/Makefile | 4 +
tools/perf/util/callchain.h | 13 +
tools/perf/util/machine.c | 18 +-
.../util/scripting-engines/trace-event-python.c | 57 +++--
8 files changed, 346 insertions(+), 21 deletions(-)
create mode 100644 tools/perf/arch/powerpc/util/skip-callchain-idx.c
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 1/5] tools lib traceevent: Fix a risk for doing free on uninitialized pointer
2014-06-27 12:20 [GIT PULL 0/5] perf/core improvements and fixes Jiri Olsa
@ 2014-06-27 12:20 ` Jiri Olsa
2014-06-27 12:20 ` [PATCH 2/5] perf tools powerpc: Adjust callchain based on DWARF debug info Jiri Olsa
` (4 subsequent siblings)
5 siblings, 0 replies; 36+ messages in thread
From: Jiri Olsa @ 2014-06-27 12:20 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel, Rickard Strandqvist, Jiri Olsa
From: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Fix a risk of doing free on an uninitialized pointer.
This was found using a static code analysis program called cppcheck.
Acked-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Link: http://lkml.kernel.org/r/1403608150-13037-1-git-send-email-rickard_strandqvist@spectrumdigital.se
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/lib/traceevent/event-parse.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index 93825a1..cf3a44b 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -2395,7 +2395,7 @@ process_flags(struct event_format *event, struct print_arg *arg, char **tok)
{
struct print_arg *field;
enum event_type type;
- char *token;
+ char *token = NULL;
memset(arg, 0, sizeof(*arg));
arg->type = PRINT_FLAGS;
@@ -2448,7 +2448,7 @@ process_symbols(struct event_format *event, struct print_arg *arg, char **tok)
{
struct print_arg *field;
enum event_type type;
- char *token;
+ char *token = NULL;
memset(arg, 0, sizeof(*arg));
arg->type = PRINT_SYMBOL;
@@ -2487,7 +2487,7 @@ process_hex(struct event_format *event, struct print_arg *arg, char **tok)
{
struct print_arg *field;
enum event_type type;
- char *token;
+ char *token = NULL;
memset(arg, 0, sizeof(*arg));
arg->type = PRINT_HEX;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 2/5] perf tools powerpc: Adjust callchain based on DWARF debug info
2014-06-27 12:20 [GIT PULL 0/5] perf/core improvements and fixes Jiri Olsa
2014-06-27 12:20 ` [PATCH 1/5] tools lib traceevent: Fix a risk for doing free on uninitialized pointer Jiri Olsa
@ 2014-06-27 12:20 ` Jiri Olsa
2014-06-27 12:20 ` [PATCH 3/5] perf tools: Fix wrong condition for allocation failure Jiri Olsa
` (3 subsequent siblings)
5 siblings, 0 replies; 36+ messages in thread
From: Jiri Olsa @ 2014-06-27 12:20 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel, Sukadev Bhattiprolu, Jiri Olsa
From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
When saving the callchain on Power, the kernel conservatively saves excess
entries in the callchain. A few of these entries are needed in some cases
but not others. We should use the DWARF debug information to determine
when the entries are needed.
Eg: the value in the link register (LR) is needed only when it holds the
return address of a function. At other times it must be ignored.
If the unnecessary entries are not ignored, we end up with duplicate arcs
in the call-graphs.
Use the DWARF debug information to determine if any callchain entries
should be ignored when building call-graphs.
Callgraph before the patch:
14.67% 2234 sprintft libc-2.18.so [.] __random
|
--- __random
|
|--61.12%-- __random
| |
| |--97.15%-- rand
| | do_my_sprintf
| | main
| | generic_start_main.isra.0
| | __libc_start_main
| | 0x0
| |
| --2.85%-- do_my_sprintf
| main
| generic_start_main.isra.0
| __libc_start_main
| 0x0
|
--38.88%-- rand
|
|--94.01%-- rand
| do_my_sprintf
| main
| generic_start_main.isra.0
| __libc_start_main
| 0x0
|
--5.99%-- do_my_sprintf
main
generic_start_main.isra.0
__libc_start_main
0x0
Callgraph after the patch:
14.67% 2234 sprintft libc-2.18.so [.] __random
|
--- __random
|
|--95.93%-- rand
| do_my_sprintf
| main
| generic_start_main.isra.0
| __libc_start_main
| 0x0
|
--4.07%-- do_my_sprintf
main
generic_start_main.isra.0
__libc_start_main
0x0
TODO: For split-debug info objects like glibc, we can only determine
the call-frame-address only when both .eh_frame and .debug_info
sections are available. We should be able to determin the CFA
even without the .eh_frame section.
Fix suggested by Anton Blanchard.
Thanks to valuable input on DWARF debug information from Ulrich Weigand.
Reported-by: Maynard Johnson <maynard@us.ibm.com>
Tested-by: Maynard Johnson <maynard@us.ibm.com>
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/20140625154903.GA29607@us.ibm.com
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/perf/arch/powerpc/Makefile | 1 +
tools/perf/arch/powerpc/util/skip-callchain-idx.c | 266 ++++++++++++++++++++++
tools/perf/config/Makefile | 4 +
tools/perf/util/callchain.h | 13 ++
tools/perf/util/machine.c | 18 +-
5 files changed, 300 insertions(+), 2 deletions(-)
create mode 100644 tools/perf/arch/powerpc/util/skip-callchain-idx.c
diff --git a/tools/perf/arch/powerpc/Makefile b/tools/perf/arch/powerpc/Makefile
index 744e629..b92219b 100644
--- a/tools/perf/arch/powerpc/Makefile
+++ b/tools/perf/arch/powerpc/Makefile
@@ -3,3 +3,4 @@ PERF_HAVE_DWARF_REGS := 1
LIB_OBJS += $(OUTPUT)arch/$(ARCH)/util/dwarf-regs.o
endif
LIB_OBJS += $(OUTPUT)arch/$(ARCH)/util/header.o
+LIB_OBJS += $(OUTPUT)arch/$(ARCH)/util/skip-callchain-idx.o
diff --git a/tools/perf/arch/powerpc/util/skip-callchain-idx.c b/tools/perf/arch/powerpc/util/skip-callchain-idx.c
new file mode 100644
index 0000000..a7c23a4
--- /dev/null
+++ b/tools/perf/arch/powerpc/util/skip-callchain-idx.c
@@ -0,0 +1,266 @@
+/*
+ * Use DWARF Debug information to skip unnecessary callchain entries.
+ *
+ * Copyright (C) 2014 Sukadev Bhattiprolu, IBM Corporation.
+ * Copyright (C) 2014 Ulrich Weigand, IBM Corporation.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version
+ * 2 of the License, or (at your option) any later version.
+ */
+#include <inttypes.h>
+#include <dwarf.h>
+#include <elfutils/libdwfl.h>
+
+#include "util/thread.h"
+#include "util/callchain.h"
+
+/*
+ * When saving the callchain on Power, the kernel conservatively saves
+ * excess entries in the callchain. A few of these entries are needed
+ * in some cases but not others. If the unnecessary entries are not
+ * ignored, we end up with duplicate arcs in the call-graphs. Use
+ * DWARF debug information to skip over any unnecessary callchain
+ * entries.
+ *
+ * See function header for arch_adjust_callchain() below for more details.
+ *
+ * The libdwfl code in this file is based on code from elfutils
+ * (libdwfl/argp-std.c, libdwfl/tests/addrcfi.c, etc).
+ */
+static char *debuginfo_path;
+
+static const Dwfl_Callbacks offline_callbacks = {
+ .debuginfo_path = &debuginfo_path,
+ .find_debuginfo = dwfl_standard_find_debuginfo,
+ .section_address = dwfl_offline_section_address,
+};
+
+
+/*
+ * Use the DWARF expression for the Call-frame-address and determine
+ * if return address is in LR and if a new frame was allocated.
+ */
+static int check_return_reg(int ra_regno, Dwarf_Frame *frame)
+{
+ Dwarf_Op ops_mem[2];
+ Dwarf_Op dummy;
+ Dwarf_Op *ops = &dummy;
+ size_t nops;
+ int result;
+
+ result = dwarf_frame_register(frame, ra_regno, ops_mem, &ops, &nops);
+ if (result < 0) {
+ pr_debug("dwarf_frame_register() %s\n", dwarf_errmsg(-1));
+ return -1;
+ }
+
+ /*
+ * Check if return address is on the stack.
+ */
+ if (nops != 0 || ops != NULL)
+ return 0;
+
+ /*
+ * Return address is in LR. Check if a frame was allocated
+ * but not-yet used.
+ */
+ result = dwarf_frame_cfa(frame, &ops, &nops);
+ if (result < 0) {
+ pr_debug("dwarf_frame_cfa() returns %d, %s\n", result,
+ dwarf_errmsg(-1));
+ return -1;
+ }
+
+ /*
+ * If call frame address is in r1, no new frame was allocated.
+ */
+ if (nops == 1 && ops[0].atom == DW_OP_bregx && ops[0].number == 1 &&
+ ops[0].number2 == 0)
+ return 1;
+
+ /*
+ * A new frame was allocated but has not yet been used.
+ */
+ return 2;
+}
+
+/*
+ * Get the DWARF frame from the .eh_frame section.
+ */
+static Dwarf_Frame *get_eh_frame(Dwfl_Module *mod, Dwarf_Addr pc)
+{
+ int result;
+ Dwarf_Addr bias;
+ Dwarf_CFI *cfi;
+ Dwarf_Frame *frame;
+
+ cfi = dwfl_module_eh_cfi(mod, &bias);
+ if (!cfi) {
+ pr_debug("%s(): no CFI - %s\n", __func__, dwfl_errmsg(-1));
+ return NULL;
+ }
+
+ result = dwarf_cfi_addrframe(cfi, pc, &frame);
+ if (result) {
+ pr_debug("%s(): %s\n", __func__, dwfl_errmsg(-1));
+ return NULL;
+ }
+
+ return frame;
+}
+
+/*
+ * Get the DWARF frame from the .debug_frame section.
+ */
+static Dwarf_Frame *get_dwarf_frame(Dwfl_Module *mod, Dwarf_Addr pc)
+{
+ Dwarf_CFI *cfi;
+ Dwarf_Addr bias;
+ Dwarf_Frame *frame;
+ int result;
+
+ cfi = dwfl_module_dwarf_cfi(mod, &bias);
+ if (!cfi) {
+ pr_debug("%s(): no CFI - %s\n", __func__, dwfl_errmsg(-1));
+ return NULL;
+ }
+
+ result = dwarf_cfi_addrframe(cfi, pc, &frame);
+ if (result) {
+ pr_debug("%s(): %s\n", __func__, dwfl_errmsg(-1));
+ return NULL;
+ }
+
+ return frame;
+}
+
+/*
+ * Return:
+ * 0 if return address for the program counter @pc is on stack
+ * 1 if return address is in LR and no new stack frame was allocated
+ * 2 if return address is in LR and a new frame was allocated (but not
+ * yet used)
+ * -1 in case of errors
+ */
+static int check_return_addr(const char *exec_file, Dwarf_Addr pc)
+{
+ int rc = -1;
+ Dwfl *dwfl;
+ Dwfl_Module *mod;
+ Dwarf_Frame *frame;
+ int ra_regno;
+ Dwarf_Addr start = pc;
+ Dwarf_Addr end = pc;
+ bool signalp;
+
+ dwfl = dwfl_begin(&offline_callbacks);
+ if (!dwfl) {
+ pr_debug("dwfl_begin() failed: %s\n", dwarf_errmsg(-1));
+ return -1;
+ }
+
+ if (dwfl_report_offline(dwfl, "", exec_file, -1) == NULL) {
+ pr_debug("dwfl_report_offline() failed %s\n", dwarf_errmsg(-1));
+ goto out;
+ }
+
+ mod = dwfl_addrmodule(dwfl, pc);
+ if (!mod) {
+ pr_debug("dwfl_addrmodule() failed, %s\n", dwarf_errmsg(-1));
+ goto out;
+ }
+
+ /*
+ * To work with split debug info files (eg: glibc), check both
+ * .eh_frame and .debug_frame sections of the ELF header.
+ */
+ frame = get_eh_frame(mod, pc);
+ if (!frame) {
+ frame = get_dwarf_frame(mod, pc);
+ if (!frame)
+ goto out;
+ }
+
+ ra_regno = dwarf_frame_info(frame, &start, &end, &signalp);
+ if (ra_regno < 0) {
+ pr_debug("Return address register unavailable: %s\n",
+ dwarf_errmsg(-1));
+ goto out;
+ }
+
+ rc = check_return_reg(ra_regno, frame);
+
+out:
+ dwfl_end(dwfl);
+ return rc;
+}
+
+/*
+ * The callchain saved by the kernel always includes the link register (LR).
+ *
+ * 0: PERF_CONTEXT_USER
+ * 1: Program counter (Next instruction pointer)
+ * 2: LR value
+ * 3: Caller's caller
+ * 4: ...
+ *
+ * The value in LR is only needed when it holds a return address. If the
+ * return address is on the stack, we should ignore the LR value.
+ *
+ * Further, when the return address is in the LR, if a new frame was just
+ * allocated but the LR was not saved into it, then the LR contains the
+ * caller, slot 4: contains the caller's caller and the contents of slot 3:
+ * (chain->ips[3]) is undefined and must be ignored.
+ *
+ * Use DWARF debug information to determine if any entries need to be skipped.
+ *
+ * Return:
+ * index: of callchain entry that needs to be ignored (if any)
+ * -1 if no entry needs to be ignored or in case of errors
+ */
+int arch_skip_callchain_idx(struct machine *machine, struct thread *thread,
+ struct ip_callchain *chain)
+{
+ struct addr_location al;
+ struct dso *dso = NULL;
+ int rc;
+ u64 ip;
+ u64 skip_slot = -1;
+
+ if (chain->nr < 3)
+ return skip_slot;
+
+ ip = chain->ips[2];
+
+ thread__find_addr_location(thread, machine, PERF_RECORD_MISC_USER,
+ MAP__FUNCTION, ip, &al);
+
+ if (al.map)
+ dso = al.map->dso;
+
+ if (!dso) {
+ pr_debug("%" PRIx64 " dso is NULL\n", ip);
+ return skip_slot;
+ }
+
+ rc = check_return_addr(dso->long_name, ip);
+
+ pr_debug("DSO %s, nr %" PRIx64 ", ip 0x%" PRIx64 "rc %d\n",
+ dso->long_name, chain->nr, ip, rc);
+
+ if (rc == 0) {
+ /*
+ * Return address on stack. Ignore LR value in callchain
+ */
+ skip_slot = 2;
+ } else if (rc == 2) {
+ /*
+ * New frame allocated but return address still in LR.
+ * Ignore the caller's caller entry in callchain.
+ */
+ skip_slot = 3;
+ }
+ return skip_slot;
+}
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index f30ac5e..346bdb6 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -48,6 +48,10 @@ ifneq ($(ARCH),$(filter $(ARCH),x86 arm))
NO_LIBDW_DWARF_UNWIND := 1
endif
+ifeq ($(ARCH),powerpc)
+ CFLAGS += -DHAVE_SKIP_CALLCHAIN_IDX
+endif
+
ifeq ($(LIBUNWIND_LIBS),)
NO_LIBUNWIND := 1
else
diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h
index 8f84423..da43619 100644
--- a/tools/perf/util/callchain.h
+++ b/tools/perf/util/callchain.h
@@ -176,4 +176,17 @@ static inline void callchain_cursor_snapshot(struct callchain_cursor *dest,
dest->first = src->curr;
dest->nr -= src->pos;
}
+
+#ifdef HAVE_SKIP_CALLCHAIN_IDX
+extern int arch_skip_callchain_idx(struct machine *machine,
+ struct thread *thread, struct ip_callchain *chain);
+#else
+static inline int arch_skip_callchain_idx(struct machine *machine __maybe_unused,
+ struct thread *thread __maybe_unused,
+ struct ip_callchain *chain __maybe_unused)
+{
+ return -1;
+}
+#endif
+
#endif /* __PERF_CALLCHAIN_H */
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index c73e1fc..e9b943a 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c
@@ -1281,7 +1281,9 @@ static int machine__resolve_callchain_sample(struct machine *machine,
u8 cpumode = PERF_RECORD_MISC_USER;
int chain_nr = min(max_stack, (int)chain->nr);
int i;
+ int j;
int err;
+ int skip_idx __maybe_unused;
callchain_cursor_reset(&callchain_cursor);
@@ -1290,14 +1292,26 @@ static int machine__resolve_callchain_sample(struct machine *machine,
return 0;
}
+ /*
+ * Based on DWARF debug information, some architectures skip
+ * a callchain entry saved by the kernel.
+ */
+ skip_idx = arch_skip_callchain_idx(machine, thread, chain);
+
for (i = 0; i < chain_nr; i++) {
u64 ip;
struct addr_location al;
if (callchain_param.order == ORDER_CALLEE)
- ip = chain->ips[i];
+ j = i;
else
- ip = chain->ips[chain->nr - i - 1];
+ j = chain->nr - i - 1;
+
+#ifdef HAVE_SKIP_CALLCHAIN_IDX
+ if (j == skip_idx)
+ continue;
+#endif
+ ip = chain->ips[j];
if (ip >= PERF_CONTEXT_MAX) {
switch (ip) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 3/5] perf tools: Fix wrong condition for allocation failure
2014-06-27 12:20 [GIT PULL 0/5] perf/core improvements and fixes Jiri Olsa
2014-06-27 12:20 ` [PATCH 1/5] tools lib traceevent: Fix a risk for doing free on uninitialized pointer Jiri Olsa
2014-06-27 12:20 ` [PATCH 2/5] perf tools powerpc: Adjust callchain based on DWARF debug info Jiri Olsa
@ 2014-06-27 12:20 ` Jiri Olsa
2014-06-27 14:12 ` Arnaldo Carvalho de Melo
2014-06-27 12:21 ` [PATCH 4/5] perf script: Move the number processing into its own function Jiri Olsa
` (2 subsequent siblings)
5 siblings, 1 reply; 36+ messages in thread
From: Jiri Olsa @ 2014-06-27 12:20 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Jiri Olsa, Arnaldo Carvalho de Melo, Corey Ashford,
David Ahern, Frederic Weisbecker, Namhyung Kim, Paul Mackerras,
Peter Zijlstra
Check real allocated pointer for NULL.
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/n/tip-5rfzbalwjphmdzzil74eazyl@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/perf/builtin-stat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 65a151e..3e80aa1 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -184,7 +184,7 @@ static void perf_evsel__reset_stat_priv(struct perf_evsel *evsel)
static int perf_evsel__alloc_stat_priv(struct perf_evsel *evsel)
{
evsel->priv = zalloc(sizeof(struct perf_stat));
- if (evsel == NULL)
+ if (evsel->priv == NULL)
return -ENOMEM;
perf_evsel__reset_stat_priv(evsel);
return 0;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* Re: [PATCH 3/5] perf tools: Fix wrong condition for allocation failure
2014-06-27 12:20 ` [PATCH 3/5] perf tools: Fix wrong condition for allocation failure Jiri Olsa
@ 2014-06-27 14:12 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 36+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-06-27 14:12 UTC (permalink / raw)
To: Jiri Olsa
Cc: Ingo Molnar, linux-kernel, Corey Ashford, David Ahern,
Frederic Weisbecker, Namhyung Kim, Paul Mackerras,
Peter Zijlstra
Em Fri, Jun 27, 2014 at 02:20:59PM +0200, Jiri Olsa escreveu:
> Check real allocated pointer for NULL.
Thanks, applied.
- Arnaldo
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Link: http://lkml.kernel.org/n/tip-5rfzbalwjphmdzzil74eazyl@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
> tools/perf/builtin-stat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index 65a151e..3e80aa1 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -184,7 +184,7 @@ static void perf_evsel__reset_stat_priv(struct perf_evsel *evsel)
> static int perf_evsel__alloc_stat_priv(struct perf_evsel *evsel)
> {
> evsel->priv = zalloc(sizeof(struct perf_stat));
> - if (evsel == NULL)
> + if (evsel->priv == NULL)
> return -ENOMEM;
> perf_evsel__reset_stat_priv(evsel);
> return 0;
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 4/5] perf script: Move the number processing into its own function
2014-06-27 12:20 [GIT PULL 0/5] perf/core improvements and fixes Jiri Olsa
` (2 preceding siblings ...)
2014-06-27 12:20 ` [PATCH 3/5] perf tools: Fix wrong condition for allocation failure Jiri Olsa
@ 2014-06-27 12:21 ` Jiri Olsa
2014-06-27 12:21 ` [PATCH 5/5] perf script: Handle the num array type in python properly Jiri Olsa
2014-07-05 9:30 ` [GIT PULL 0/5] perf/core improvements and fixes Ingo Molnar
5 siblings, 0 replies; 36+ messages in thread
From: Jiri Olsa @ 2014-06-27 12:21 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel, Sebastian Andrzej Siewior, Jiri Olsa
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
I was going to change something here and the result was so much on the
right side of the screen that I decided to move that piece into its own
function.
This patch should make no function change except the moving the code
into its own function.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/n/1401207274-8170-1-git-send-email-bigeasy@linutronix.de
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
.../util/scripting-engines/trace-event-python.c | 38 +++++++++++++---------
1 file changed, 23 insertions(+), 15 deletions(-)
diff --git a/tools/perf/util/scripting-engines/trace-event-python.c b/tools/perf/util/scripting-engines/trace-event-python.c
index 1c41932..99c2536 100644
--- a/tools/perf/util/scripting-engines/trace-event-python.c
+++ b/tools/perf/util/scripting-engines/trace-event-python.c
@@ -231,6 +231,28 @@ static inline struct event_format *find_cache_event(struct perf_evsel *evsel)
return event;
}
+static PyObject *get_field_numeric_entry(struct event_format *event,
+ struct format_field *field, void *data)
+{
+ PyObject *obj;
+ unsigned long long val;
+
+ val = read_size(event, data + field->offset, field->size);
+ if (field->flags & FIELD_IS_SIGNED) {
+ if ((long long)val >= LONG_MIN &&
+ (long long)val <= LONG_MAX)
+ obj = PyInt_FromLong(val);
+ else
+ obj = PyLong_FromLongLong(val);
+ } else {
+ if (val <= LONG_MAX)
+ obj = PyInt_FromLong(val);
+ else
+ obj = PyLong_FromUnsignedLongLong(val);
+ }
+ return obj;
+}
+
static void python_process_tracepoint(struct perf_sample *sample,
struct perf_evsel *evsel,
struct thread *thread,
@@ -239,7 +261,6 @@ static void python_process_tracepoint(struct perf_sample *sample,
PyObject *handler, *retval, *context, *t, *obj, *dict = NULL;
static char handler_name[256];
struct format_field *field;
- unsigned long long val;
unsigned long s, ns;
struct event_format *event;
unsigned n = 0;
@@ -303,20 +324,7 @@ static void python_process_tracepoint(struct perf_sample *sample,
offset = field->offset;
obj = PyString_FromString((char *)data + offset);
} else { /* FIELD_IS_NUMERIC */
- val = read_size(event, data + field->offset,
- field->size);
- if (field->flags & FIELD_IS_SIGNED) {
- if ((long long)val >= LONG_MIN &&
- (long long)val <= LONG_MAX)
- obj = PyInt_FromLong(val);
- else
- obj = PyLong_FromLongLong(val);
- } else {
- if (val <= LONG_MAX)
- obj = PyInt_FromLong(val);
- else
- obj = PyLong_FromUnsignedLongLong(val);
- }
+ obj = get_field_numeric_entry(event, field, data);
}
if (handler)
PyTuple_SetItem(t, n++, obj);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH 5/5] perf script: Handle the num array type in python properly
2014-06-27 12:20 [GIT PULL 0/5] perf/core improvements and fixes Jiri Olsa
` (3 preceding siblings ...)
2014-06-27 12:21 ` [PATCH 4/5] perf script: Move the number processing into its own function Jiri Olsa
@ 2014-06-27 12:21 ` Jiri Olsa
2014-07-05 9:30 ` [GIT PULL 0/5] perf/core improvements and fixes Ingo Molnar
5 siblings, 0 replies; 36+ messages in thread
From: Jiri Olsa @ 2014-06-27 12:21 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel, Sebastian Andrzej Siewior, Jiri Olsa
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
The raw_syscalls:sys_enter tracer for instance passes has one argument
named 'arg' which is an array of 6 integers. Right the python scripts
gets only 0 passed as an argument. The reason is that
pevent_read_number() can not handle data types of 48 and returns always
0.
This patch changes this by passing num array as list of nums which fit
the description. As a result python will now see a list named arg which
contains 6 (integer) items.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/n/1401207274-8170-2-git-send-email-bigeasy@linutronix.de
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
.../util/scripting-engines/trace-event-python.c | 43 ++++++++++++++++------
1 file changed, 31 insertions(+), 12 deletions(-)
diff --git a/tools/perf/util/scripting-engines/trace-event-python.c b/tools/perf/util/scripting-engines/trace-event-python.c
index 99c2536..e55b65a 100644
--- a/tools/perf/util/scripting-engines/trace-event-python.c
+++ b/tools/perf/util/scripting-engines/trace-event-python.c
@@ -234,22 +234,41 @@ static inline struct event_format *find_cache_event(struct perf_evsel *evsel)
static PyObject *get_field_numeric_entry(struct event_format *event,
struct format_field *field, void *data)
{
- PyObject *obj;
+ bool is_array = field->flags & FIELD_IS_ARRAY;
+ PyObject *obj, *list = NULL;
unsigned long long val;
+ unsigned int item_size, n_items, i;
- val = read_size(event, data + field->offset, field->size);
- if (field->flags & FIELD_IS_SIGNED) {
- if ((long long)val >= LONG_MIN &&
- (long long)val <= LONG_MAX)
- obj = PyInt_FromLong(val);
- else
- obj = PyLong_FromLongLong(val);
+ if (is_array) {
+ list = PyList_New(field->arraylen);
+ item_size = field->size / field->arraylen;
+ n_items = field->arraylen;
} else {
- if (val <= LONG_MAX)
- obj = PyInt_FromLong(val);
- else
- obj = PyLong_FromUnsignedLongLong(val);
+ item_size = field->size;
+ n_items = 1;
+ }
+
+ for (i = 0; i < n_items; i++) {
+
+ val = read_size(event, data + field->offset + i * item_size,
+ item_size);
+ if (field->flags & FIELD_IS_SIGNED) {
+ if ((long long)val >= LONG_MIN &&
+ (long long)val <= LONG_MAX)
+ obj = PyInt_FromLong(val);
+ else
+ obj = PyLong_FromLongLong(val);
+ } else {
+ if (val <= LONG_MAX)
+ obj = PyInt_FromLong(val);
+ else
+ obj = PyLong_FromUnsignedLongLong(val);
+ }
+ if (is_array)
+ PyList_SET_ITEM(list, i, obj);
}
+ if (is_array)
+ obj = list;
return obj;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* Re: [GIT PULL 0/5] perf/core improvements and fixes
2014-06-27 12:20 [GIT PULL 0/5] perf/core improvements and fixes Jiri Olsa
` (4 preceding siblings ...)
2014-06-27 12:21 ` [PATCH 5/5] perf script: Handle the num array type in python properly Jiri Olsa
@ 2014-07-05 9:30 ` Ingo Molnar
5 siblings, 0 replies; 36+ messages in thread
From: Ingo Molnar @ 2014-07-05 9:30 UTC (permalink / raw)
To: Jiri Olsa
Cc: linux-kernel, Arnaldo Carvalho de Melo, Corey Ashford,
David Ahern, Frederic Weisbecker, Maynard Johnson, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Rickard Strandqvist,
Sebastian Andrzej Siewior, Steven Rostedt, Sukadev Bhattiprolu
* Jiri Olsa <jolsa@kernel.org> wrote:
> hi Ingo,
> please consider pulling
>
> thanks,
> jirka
>
> The following changes since commit 1c92f88542faa3ae4f970c548b4fe8275a45201b:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf into perf/core (2014-06-25 07:44:19 +0200)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-core-for-mingo
>
> for you to fetch changes up to 8ac631cd502d6b31fd29f6d019305305b479fa3e:
>
> perf script: Handle the num array type in python properly (2014-06-27 11:15:02 +0200)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> . Handle the num array type in python properly (Sebastian Andrzej Siewior)
>
> . Fix wrong condition for allocation failure (Jiri Olsa)
>
> . Adjust callchain based on DWARF debug info on powerpc (Sukadev Bhattiprolu)
>
> . Fix a risk for doing free on uninitialized pointer in traceevent lib (Rickard Strandqvist)
>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
>
> ----------------------------------------------------------------
> Jiri Olsa (1):
> perf tools: Fix wrong condition for allocation failure
>
> Rickard Strandqvist (1):
> tools lib traceevent: Fix a risk for doing free on uninitialized pointer
>
> Sebastian Andrzej Siewior (2):
> perf script: Move the number processing into its own function
> perf script: Handle the num array type in python properly
>
> Sukadev Bhattiprolu (1):
> perf tools powerpc: Adjust callchain based on DWARF debug info
>
> tools/lib/traceevent/event-parse.c | 6 +-
> tools/perf/arch/powerpc/Makefile | 1 +
> tools/perf/arch/powerpc/util/skip-callchain-idx.c | 266 +++++++++++++++++++++
> tools/perf/builtin-stat.c | 2 +-
> tools/perf/config/Makefile | 4 +
> tools/perf/util/callchain.h | 13 +
> tools/perf/util/machine.c | 18 +-
> .../util/scripting-engines/trace-event-python.c | 57 +++--
> 8 files changed, 346 insertions(+), 21 deletions(-)
> create mode 100644 tools/perf/arch/powerpc/util/skip-callchain-idx.c
Pulled, thanks a lot Jiri!
Ingo
^ permalink raw reply [flat|nested] 36+ messages in thread
* [GIT PULL 0/5] perf/core improvements and fixes
@ 2018-02-21 1:34 Arnaldo Carvalho de Melo
2018-02-21 7:52 ` Ingo Molnar
0 siblings, 1 reply; 36+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-02-21 1:34 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, linux-perf-users, Arnaldo Carvalho de Melo,
Adrian Hunter, Alexander Shishkin, Changbin Du, David Ahern,
Heiko Carstens, Hendrik Brueckner, Jaroslav Škarvada,
Jiri Olsa, kernel-team, Martin Schwidefsky, Namhyung Kim,
Peter Zijlstra, Thomas Richter, Wang Nan,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit 11737ca9e3b9d84448fa405a80980aa9957bcee8:
Merge tag 'perf-core-for-mingo-4.17-20180216' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2018-02-17 11:39:47 +0100)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.17-20180220
for you to fetch changes up to 66dfdff03d196e51322c6a85c0d8db8bb2bdd655:
perf tools: Add Python 3 support (2018-02-19 12:28:23 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
- Initial support for linking with python3, by explicitely setting
the PYTHON Makefile variable, python2 remains supported, more work
needed to test the shipped python scripts used with 'perf script'
(Jaroslav Škarvada)
- Make twatch.py, an example python script that sets up evlists and
evsels to then parse events from mmap, to work with both python2 and
python3 (Arnaldo Carvalho de Melo)
- Fix setting 'perf ftrace' function filter when using a non-existent
function, which should result in an error instead of simply not setting
the filter and showing all functions (Changbin Du)
- Fix paranoid check in machine__set_kernel_mmap(), problem introduced
in previous perf/core batch (Namhyung Kim)
- Fix reading cpuid model information in s/390, ditto, also introduced
in the previous perf/core batch (Thomas Richter)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
perf python: Make twatch.py work with both python2 and python3
Changbin Du (1):
perf ftrace: Append an EOL when write tracing files
Jaroslav Škarvada (1):
perf tools: Add Python 3 support
Namhyung Kim (1):
perf machine: Fix paranoid check in machine__set_kernel_mmap()
Thomas Richter (1):
perf s390: Fix reading cpuid model information
tools/perf/Makefile.config | 23 +---
tools/perf/Makefile.perf | 4 +-
tools/perf/arch/s390/util/header.c | 2 +-
tools/perf/builtin-ftrace.c | 18 ++-
tools/perf/python/twatch.py | 8 +-
.../perf/scripts/python/Perf-Trace-Util/Context.c | 34 ++++-
tools/perf/util/machine.c | 2 +-
tools/perf/util/python.c | 95 ++++++++++---
.../util/scripting-engines/trace-event-python.c | 147 +++++++++++++++------
tools/perf/util/setup.py | 6 +-
10 files changed, 243 insertions(+), 96 deletions(-)
Test results:
The first ones are container (docker) based builds of tools/perf with and
without libelf support. Where clang is available, it is also used to build
perf with/without libelf.
The objtool and samples/bpf/ builds are disabled now that I'm switching from
using the sources in a local volume to fetching them from a http server to
build it inside the container, to make it easier to build in a container cluster.
Those will come back later.
Several are cross builds, the ones with -x-ARCH and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
Intel(R) Core(TM) i5-7500 CPU @ 3.40GHz
# dm
1 49.10 alpine:3.4 : Ok gcc (Alpine 5.3.0) 5.3.0
2 51.30 alpine:3.5 : Ok gcc (Alpine 6.2.1) 6.2.1 20160822
3 53.53 alpine:3.6 : Ok gcc (Alpine 6.3.0) 6.3.0
4 54.74 alpine:edge : Ok gcc (Alpine 6.4.0) 6.4.0
5 41.38 amazonlinux:1 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-11)
6 58.50 amazonlinux:2 : Ok gcc (GCC) 7.2.1 20170915 (Red Hat 7.2.1-2)
7 35.52 android-ndk:r12b-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
8 34.34 android-ndk:r15c-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
9 31.16 centos:5 : Ok gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55)
10 40.51 centos:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-18)
11 50.00 centos:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16)
12 40.12 debian:7 : Ok gcc (Debian 4.7.2-5) 4.7.2
13 41.64 debian:8 : Ok gcc (Debian 4.9.2-10+deb8u1) 4.9.2
14 69.65 debian:9 : Ok gcc (Debian 6.3.0-18) 6.3.0 20170516
15 91.07 debian:experimental : Ok gcc (Debian 7.2.0-18) 7.2.0
16 48.13 debian:experimental-x-arm64 : Ok aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
17 41.69 debian:experimental-x-mips : Ok mips-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
18 36.72 debian:experimental-x-mips64 : Ok mips64-linux-gnuabi64-gcc (Debian 7.2.0-11) 7.2.0
19 52.76 debian:experimental-x-mipsel : Ok mipsel-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
20 49.01 fedora:20 : Ok gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7)
21 54.99 fedora:21 : Ok gcc (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6)
22 39.61 fedora:22 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
23 42.29 fedora:23 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
24 41.84 fedora:24 : Ok gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1)
25 36.88 fedora:24-x-ARC-uClibc : Ok arc-linux-gcc (ARCompact ISA Linux uClibc toolchain 2017.09-rc2) 7.1.1 20170710
26 78.12 fedora:25 : Ok gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1)
27 80.48 fedora:26 : Ok gcc (GCC) 7.2.1 20170915 (Red Hat 7.2.1-2)
28 81.00 fedora:27 : Ok gcc (GCC) 7.2.1 20170915 (Red Hat 7.2.1-2)
29 115.57 fedora:rawhide : Ok gcc (GCC) 7.2.1 20170915 (Red Hat 7.2.1-4)
30 42.70 gentoo-stage3-amd64:latest : Ok gcc (Gentoo 6.4.0-r1 p1.3) 6.4.0
31 45.48 mageia:5 : Ok gcc (GCC) 4.9.2
32 42.61 mageia:6 : Ok gcc (Mageia 5.4.0-5.mga6) 5.4.0
33 42.05 opensuse:42.1 : Ok gcc (SUSE Linux) 4.8.5
34 43.63 opensuse:42.2 : Ok gcc (SUSE Linux) 4.8.5
35 47.48 opensuse:42.3 : Ok gcc (SUSE Linux) 4.8.5
36 90.12 opensuse:tumbleweed : Ok gcc (SUSE Linux) 7.3.0
37 35.32 oraclelinux:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-18)
38 41.55 oraclelinux:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16)
39 33.95 ubuntu:12.04.5 : Ok gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
40 39.13 ubuntu:14.04.4 : Ok gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
41 33.62 ubuntu:14.04.4-x-linaro-arm64 : Ok aarch64-linux-gnu-gcc (Linaro GCC 5.5-2017.10) 5.5.0
42 62.84 ubuntu:16.04 : Ok gcc (Ubuntu 5.4.0-6ubuntu1~16.04.6) 5.4.0 20160609
43 38.41 ubuntu:16.04-x-arm : Ok arm-linux-gnueabihf-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
44 41.31 ubuntu:16.04-x-arm64 : Ok aarch64-linux-gnu-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
45 40.18 ubuntu:16.04-x-powerpc : Ok powerpc-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
46 35.83 ubuntu:16.04-x-powerpc64 : Ok powerpc64-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.1) 5.4.0 20160609
47 35.91 ubuntu:16.04-x-powerpc64el : Ok powerpc64le-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
48 32.80 ubuntu:16.04-x-s390 : Ok s390x-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
49 65.42 ubuntu:16.10 : Ok gcc (Ubuntu 6.2.0-5ubuntu12) 6.2.0 20161005
50 67.55 ubuntu:17.04 : Ok gcc (Ubuntu 6.3.0-12ubuntu2) 6.3.0 20170406
51 68.25 ubuntu:17.10 : Ok gcc (Ubuntu 7.2.0-8ubuntu3) 7.2.0
52 72.18 ubuntu:18.04 : Ok gcc (Ubuntu 7.3.0-3ubuntu1) 7.3.0
#
# uname -a
Linux jouet 4.16.0-rc2 #2 SMP Mon Feb 19 14:41:03 -03 2018 x86_64 x86_64 x86_64 GNU/Linux
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Test data source output : Ok
6: Parse event definition strings : Ok
7: Simple expression parser : Ok
8: PERF_RECORD_* events & perf_sample fields : Ok
9: Parse perf pmu format : Ok
10: DSO data read : Ok
11: DSO data cache : Ok
12: DSO data reopen : Ok
13: Roundtrip evsel->name : Ok
14: Parse sched tracepoints fields : Ok
15: syscalls:sys_enter_openat event fields : Ok
16: Setup struct perf_event_attr : Ok
17: Match and link multiple hists : Ok
18: 'import perf' in python : Ok
19: Breakpoint overflow signal handler : Ok
20: Breakpoint overflow sampling : Ok
21: Number of exit events of a simple workload : Ok
22: Software clock events period values : Ok
23: Object code reading : Ok
24: Sample parsing : Ok
25: Use a dummy software event to keep tracking : Ok
26: Parse with no sample_id_all bit set : Ok
27: Filter hist entries : Ok
28: Lookup mmap thread : Ok
29: Share thread mg : Ok
30: Sort output of hist entries : Ok
31: Cumulate child hist entries : Ok
32: Track with sched_switch : Ok
33: Filter fds with revents mask in a fdarray : Ok
34: Add fd to a fdarray, making it autogrow : Ok
35: kmod_path__parse : Ok
36: Thread map : Ok
37: LLVM search and compile :
37.1: Basic BPF llvm compile : Ok
37.2: kbuild searching : Ok
37.3: Compile source for BPF prologue generation : Ok
37.4: Compile source for BPF relocation : Ok
38: Session topology : Ok
39: BPF filter :
39.1: Basic BPF filtering : Ok
39.2: BPF pinning : Ok
39.3: BPF prologue generation : Ok
39.4: BPF relocation checker : Ok
40: Synthesize thread map : Ok
41: Remove thread map : Ok
42: Synthesize cpu map : Ok
43: Synthesize stat config : Ok
44: Synthesize stat : Ok
45: Synthesize stat round : Ok
46: Synthesize attr update : Ok
47: Event times : Ok
48: Read backward ring buffer : Ok
49: Print cpu map : Ok
50: Probe SDT events : Ok
51: is_printable_array : Ok
52: Print bitmap : Ok
53: perf hooks : Ok
54: builtin clang support : Skip (not compiled in)
55: unit_number__scnprintf : Ok
56: x86 rdpmc : Ok
57: Convert perf time to TSC : Ok
58: DWARF unwind : Ok
59: x86 instruction decoder - new instructions : Ok
60: Use vfs_getname probe to get syscall args filenames : Ok
61: probe libc's inet_pton & backtrace it with ping : Ok
62: Check open filename arg using perf trace + vfs_getname: Ok
63: Add vfs_getname probe to get syscall args filenames : Ok
#
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/perf/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_no_libelf_O: make NO_LIBELF=1
make_no_slang_O: make NO_SLANG=1
make_with_babeltrace_O: make LIBBABELTRACE=1
make_install_O: make install
make_no_libbpf_O: make NO_LIBBPF=1
make_pure_O: make
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_no_backtrace_O: make NO_BACKTRACE=1
make_no_demangle_O: make NO_DEMANGLE=1
make_tags_O: make tags
make_no_libperl_O: make NO_LIBPERL=1
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_no_libunwind_O: make NO_LIBUNWIND=1
make_no_libbionic_O: make NO_LIBBIONIC=1
make_no_newt_O: make NO_NEWT=1
make_no_libpython_O: make NO_LIBPYTHON=1
make_clean_all_O: make clean all
make_no_libaudit_O: make NO_LIBAUDIT=1
make_static_O: make LDFLAGS=-static
make_doc_O: make doc
make_no_gtk2_O: make NO_GTK2=1
make_install_prefix_O: make install prefix=/tmp/krava
make_no_auxtrace_O: make NO_AUXTRACE=1
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_help_O: make help
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_install_bin_O: make install-bin
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_util_map_o_O: make util/map.o
make_debug_O: make DEBUG=1
make_no_libnuma_O: make NO_LIBNUMA=1
make_perf_o_O: make perf.o
OK
make: Leaving directory '/home/acme/git/perf/tools/perf'
$
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [GIT PULL 0/5] perf/core improvements and fixes
2018-02-21 1:34 Arnaldo Carvalho de Melo
@ 2018-02-21 7:52 ` Ingo Molnar
0 siblings, 0 replies; 36+ messages in thread
From: Ingo Molnar @ 2018-02-21 7:52 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, linux-perf-users, Adrian Hunter,
Alexander Shishkin, Changbin Du, David Ahern, Heiko Carstens,
Hendrik Brueckner, Jaroslav Škarvada, Jiri Olsa,
kernel-team, Martin Schwidefsky, Namhyung Kim, Peter Zijlstra,
Thomas Richter, Wang Nan, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit 11737ca9e3b9d84448fa405a80980aa9957bcee8:
>
> Merge tag 'perf-core-for-mingo-4.17-20180216' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2018-02-17 11:39:47 +0100)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.17-20180220
>
> for you to fetch changes up to 66dfdff03d196e51322c6a85c0d8db8bb2bdd655:
>
> perf tools: Add Python 3 support (2018-02-19 12:28:23 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> - Initial support for linking with python3, by explicitely setting
> the PYTHON Makefile variable, python2 remains supported, more work
> needed to test the shipped python scripts used with 'perf script'
> (Jaroslav Škarvada)
>
> - Make twatch.py, an example python script that sets up evlists and
> evsels to then parse events from mmap, to work with both python2 and
> python3 (Arnaldo Carvalho de Melo)
>
> - Fix setting 'perf ftrace' function filter when using a non-existent
> function, which should result in an error instead of simply not setting
> the filter and showing all functions (Changbin Du)
>
> - Fix paranoid check in machine__set_kernel_mmap(), problem introduced
> in previous perf/core batch (Namhyung Kim)
>
> - Fix reading cpuid model information in s/390, ditto, also introduced
> in the previous perf/core batch (Thomas Richter)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
> perf python: Make twatch.py work with both python2 and python3
>
> Changbin Du (1):
> perf ftrace: Append an EOL when write tracing files
>
> Jaroslav Škarvada (1):
> perf tools: Add Python 3 support
>
> Namhyung Kim (1):
> perf machine: Fix paranoid check in machine__set_kernel_mmap()
>
> Thomas Richter (1):
> perf s390: Fix reading cpuid model information
>
> tools/perf/Makefile.config | 23 +---
> tools/perf/Makefile.perf | 4 +-
> tools/perf/arch/s390/util/header.c | 2 +-
> tools/perf/builtin-ftrace.c | 18 ++-
> tools/perf/python/twatch.py | 8 +-
> .../perf/scripts/python/Perf-Trace-Util/Context.c | 34 ++++-
> tools/perf/util/machine.c | 2 +-
> tools/perf/util/python.c | 95 ++++++++++---
> .../util/scripting-engines/trace-event-python.c | 147 +++++++++++++++------
> tools/perf/util/setup.py | 6 +-
> 10 files changed, 243 insertions(+), 96 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 36+ messages in thread
* [GIT PULL 0/5] perf/core improvements and fixes
@ 2015-10-21 21:31 Arnaldo Carvalho de Melo
2015-10-22 7:34 ` Ingo Molnar
0 siblings, 1 reply; 36+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-10-21 21:31 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexei Starovoitov, Andi Kleen, Borislav Petkov, David Ahern,
Frederic Weisbecker, Jiri Olsa, Kan Liang, kvm, Masami Hiramatsu,
Namhyung Kim, Paolo Bonzini, Paul Mackerras, Peter Zijlstra,
Stephane Eranian, Steven Rostedt, Wang Nan, Yunlong Song,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 43e41adc9e8c36545888d78fed2ef8d102a938dc:
perf record: Add ability to sample call branches (2015-10-20 10:30:55 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to e3d006ce8180a0c025ce66bdc89bbc125f85be57:
perf annotate: Add debug message for out of bounds sample (2015-10-21 18:12:37 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Print branch filter state with verbose mode (Andi Kleen)
- Fix core dump caused by per-socket/core system-wide stat (Kan Liang)
- Update libtraceevent KVM plugin (Paolo Bonzini)
Developer stuff:
- Add fixdep to 'tools/build' .gitignore (Yunlong Song)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Andi Kleen (1):
perf evsel: Print branch filter state with -vv
Arnaldo Carvalho de Melo (1):
perf annotate: Add debug message for out of bounds sample
Kan Liang (1):
perf cpu_map: Fix core dump caused by per-socket/core system-wide stat
Paolo Bonzini (1):
tools lib traceevent: update KVM plugin
Yunlong Song (1):
perf build: Add fixdep to .gitignore
tools/build/.gitignore | 1 +
tools/lib/traceevent/plugin_kvm.c | 25 +++++++++++++++++--------
tools/perf/util/annotate.c | 5 ++++-
tools/perf/util/cpumap.c | 2 +-
tools/perf/util/evsel.c | 1 +
5 files changed, 24 insertions(+), 10 deletions(-)
create mode 100644 tools/build/.gitignore
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [GIT PULL 0/5] perf/core improvements and fixes
2015-10-21 21:31 Arnaldo Carvalho de Melo
@ 2015-10-22 7:34 ` Ingo Molnar
0 siblings, 0 replies; 36+ messages in thread
From: Ingo Molnar @ 2015-10-22 7:34 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexei Starovoitov, Andi Kleen,
Borislav Petkov, David Ahern, Frederic Weisbecker, Jiri Olsa,
Kan Liang, kvm, Masami Hiramatsu, Namhyung Kim, Paolo Bonzini,
Paul Mackerras, Peter Zijlstra, Stephane Eranian, Steven Rostedt,
Wang Nan, Yunlong Song, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 43e41adc9e8c36545888d78fed2ef8d102a938dc:
>
> perf record: Add ability to sample call branches (2015-10-20 10:30:55 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to e3d006ce8180a0c025ce66bdc89bbc125f85be57:
>
> perf annotate: Add debug message for out of bounds sample (2015-10-21 18:12:37 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Print branch filter state with verbose mode (Andi Kleen)
>
> - Fix core dump caused by per-socket/core system-wide stat (Kan Liang)
>
> - Update libtraceevent KVM plugin (Paolo Bonzini)
>
> Developer stuff:
>
> - Add fixdep to 'tools/build' .gitignore (Yunlong Song)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Andi Kleen (1):
> perf evsel: Print branch filter state with -vv
>
> Arnaldo Carvalho de Melo (1):
> perf annotate: Add debug message for out of bounds sample
>
> Kan Liang (1):
> perf cpu_map: Fix core dump caused by per-socket/core system-wide stat
>
> Paolo Bonzini (1):
> tools lib traceevent: update KVM plugin
>
> Yunlong Song (1):
> perf build: Add fixdep to .gitignore
>
> tools/build/.gitignore | 1 +
> tools/lib/traceevent/plugin_kvm.c | 25 +++++++++++++++++--------
> tools/perf/util/annotate.c | 5 ++++-
> tools/perf/util/cpumap.c | 2 +-
> tools/perf/util/evsel.c | 1 +
> 5 files changed, 24 insertions(+), 10 deletions(-)
> create mode 100644 tools/build/.gitignore
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 36+ messages in thread
* [GIT PULL 0/5] perf/core improvements and fixes
@ 2015-10-07 22:45 Arnaldo Carvalho de Melo
0 siblings, 0 replies; 36+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-10-07 22:45 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andrzej Hajda, Bartlomiej Zolnierkiewicz, Borislav Petkov,
David Ahern, Frederic Weisbecker, Guy Streeter, Jiri Olsa,
kernel-janitors, Marek Szyprowski, Namhyung Kim, Peter Zijlstra,
Stephane Eranian, Wang Nan, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 712df65ccb63da08a484bf57c40b250dfd4103a7:
perf/x86/intel/uncore: Fix multi-segment problem of perf_event_intel_uncore (2015-10-06 17:31:51 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to ae938802443732e77d01f8d5b52b900b9327ff30:
perf python: Support the PERF_RECORD_SWITCH event (2015-10-07 19:41:50 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Adding a field via 'perf report -F' that already is enabled makes
the tool get stuck in a loop, fix it (Jiri Olsa)
Infrastructure:
- Support PERF_RECORD_SWITCH in the python binding (Arnaldo Carvalho de Melo)
- Fix handling read() result using a signed variable, found with Coccinelle
(Andrzej Hajda)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Andrzej Hajda (1):
perf tools: Fix handling read result using a signed variable
Arnaldo Carvalho de Melo (1):
perf python: Support the PERF_RECORD_SWITCH event
Jiri Olsa (3):
perf tools: Get rid of superfluos call to reset_dimensions
perf tools: Introduce hpp_dimension__add_output function
perf tools: Use hpp_dimension__add_output to register hpp columns
tools/perf/python/twatch.py | 23 +++++++++++++++---
tools/perf/ui/hist.c | 16 ++++++------
tools/perf/util/event.c | 3 ++-
tools/perf/util/python.c | 59 ++++++++++++++++++++++++++++++++++++++++++---
tools/perf/util/sort.c | 8 ++++--
tools/perf/util/sort.h | 2 ++
6 files changed, 93 insertions(+), 18 deletions(-)
^ permalink raw reply [flat|nested] 36+ messages in thread
* [GIT PULL 0/5] perf/core improvements and fixes
@ 2015-04-13 22:14 Arnaldo Carvalho de Melo
2015-04-13 22:33 ` Masami Hiramatsu
0 siblings, 1 reply; 36+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-04-13 22:14 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, David Ahern, He Kuang,
Jiri Olsa, Joonsoo Kim, linux-mm, Masami Hiramatsu, Minchan Kim,
Namhyung Kim, Peter Zijlstra, Steven Rostedt, Wang Nan,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
Best regards,
- Arnaldo
The following changes since commit 066450be419fa48007a9f29e19828f2a86198754:
perf/x86/intel/pt: Clean up the control flow in pt_pmu_hw_init() (2015-04-12 11:21:15 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to be8d5b1c6b468d10bd2928bbd1a5ca3fd2980402:
perf probe: Fix segfault when probe with lazy_line to file (2015-04-13 17:59:41 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
New features:
- Analyze page allocator events also in 'perf kmem' (Namhyung Kim)
User visible fixes:
- Fix retprobe 'perf probe' handling when failing to find needed debuginfo (He Kuang)
- lazy_line probe fixes in 'perf probe' (He Kuang)
Infrastructure:
- Record pfn instead of pointer to struct page in tracepoints (Namhyung Kim)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
He Kuang (3):
perf probe: Set retprobe flag when probe in address-based alternative mode
perf probe: Make --source avaiable when probe with lazy_line
perf probe: Fix segfault when probe with lazy_line to file
Namhyung Kim (2):
tracing, mm: Record pfn instead of pointer to struct page
perf kmem: Analyze page allocator events also
include/trace/events/filemap.h | 8 +-
include/trace/events/kmem.h | 42 +--
include/trace/events/vmscan.h | 8 +-
tools/perf/Documentation/perf-kmem.txt | 8 +-
tools/perf/builtin-kmem.c | 500 +++++++++++++++++++++++++++++++--
tools/perf/util/probe-event.c | 3 +-
tools/perf/util/probe-event.h | 2 +
tools/perf/util/probe-finder.c | 20 +-
8 files changed, 540 insertions(+), 51 deletions(-)
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [GIT PULL 0/5] perf/core improvements and fixes
2015-04-13 22:14 Arnaldo Carvalho de Melo
@ 2015-04-13 22:33 ` Masami Hiramatsu
2015-04-13 23:09 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 36+ messages in thread
From: Masami Hiramatsu @ 2015-04-13 22:33 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Ingo Molnar, linux-kernel, David Ahern, He Kuang, Jiri Olsa,
Joonsoo Kim, linux-mm, Minchan Kim, Namhyung Kim, Peter Zijlstra,
Steven Rostedt, Wang Nan, Arnaldo Carvalho de Melo
Hi, Arnaldo,
> perf probe: Make --source avaiable when probe with lazy_line
No, could you pull Naohiro's patch?
I'd like to move get_real_path to probe_finder.c
Thank you,
(2015/04/14 7:14), Arnaldo Carvalho de Melo wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> Best regards,
>
> - Arnaldo
>
> The following changes since commit 066450be419fa48007a9f29e19828f2a86198754:
>
> perf/x86/intel/pt: Clean up the control flow in pt_pmu_hw_init() (2015-04-12 11:21:15 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to be8d5b1c6b468d10bd2928bbd1a5ca3fd2980402:
>
> perf probe: Fix segfault when probe with lazy_line to file (2015-04-13 17:59:41 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> New features:
>
> - Analyze page allocator events also in 'perf kmem' (Namhyung Kim)
>
> User visible fixes:
>
> - Fix retprobe 'perf probe' handling when failing to find needed debuginfo (He Kuang)
>
> - lazy_line probe fixes in 'perf probe' (He Kuang)
>
> Infrastructure:
>
> - Record pfn instead of pointer to struct page in tracepoints (Namhyung Kim)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> He Kuang (3):
> perf probe: Set retprobe flag when probe in address-based alternative mode
> perf probe: Make --source avaiable when probe with lazy_line
> perf probe: Fix segfault when probe with lazy_line to file
>
> Namhyung Kim (2):
> tracing, mm: Record pfn instead of pointer to struct page
> perf kmem: Analyze page allocator events also
>
> include/trace/events/filemap.h | 8 +-
> include/trace/events/kmem.h | 42 +--
> include/trace/events/vmscan.h | 8 +-
> tools/perf/Documentation/perf-kmem.txt | 8 +-
> tools/perf/builtin-kmem.c | 500 +++++++++++++++++++++++++++++++--
> tools/perf/util/probe-event.c | 3 +-
> tools/perf/util/probe-event.h | 2 +
> tools/perf/util/probe-finder.c | 20 +-
> 8 files changed, 540 insertions(+), 51 deletions(-)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>
--
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: masami.hiramatsu.pt@hitachi.com
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [GIT PULL 0/5] perf/core improvements and fixes
2015-04-13 22:33 ` Masami Hiramatsu
@ 2015-04-13 23:09 ` Arnaldo Carvalho de Melo
2015-04-13 23:19 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 36+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-04-13 23:09 UTC (permalink / raw)
To: Masami Hiramatsu
Cc: Ingo Molnar, linux-kernel, David Ahern, He Kuang, Jiri Olsa,
Joonsoo Kim, linux-mm, Minchan Kim, Namhyung Kim, Peter Zijlstra,
Steven Rostedt, Wang Nan
Em Tue, Apr 14, 2015 at 07:33:07AM +0900, Masami Hiramatsu escreveu:
> Hi, Arnaldo,
>
> > perf probe: Make --source avaiable when probe with lazy_line
>
> No, could you pull Naohiro's patch?
> I'd like to move get_real_path to probe_finder.c
OOps, yeah, you asked for that... Ingo, please ignore this pull request
for now, thanks,
- Arnaldo
> Thank you,
>
> (2015/04/14 7:14), Arnaldo Carvalho de Melo wrote:
> > Hi Ingo,
> >
> > Please consider pulling,
> >
> > Best regards,
> >
> > - Arnaldo
> >
> > The following changes since commit 066450be419fa48007a9f29e19828f2a86198754:
> >
> > perf/x86/intel/pt: Clean up the control flow in pt_pmu_hw_init() (2015-04-12 11:21:15 +0200)
> >
> > are available in the git repository at:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
> >
> > for you to fetch changes up to be8d5b1c6b468d10bd2928bbd1a5ca3fd2980402:
> >
> > perf probe: Fix segfault when probe with lazy_line to file (2015-04-13 17:59:41 -0300)
> >
> > ----------------------------------------------------------------
> > perf/core improvements and fixes:
> >
> > New features:
> >
> > - Analyze page allocator events also in 'perf kmem' (Namhyung Kim)
> >
> > User visible fixes:
> >
> > - Fix retprobe 'perf probe' handling when failing to find needed debuginfo (He Kuang)
> >
> > - lazy_line probe fixes in 'perf probe' (He Kuang)
> >
> > Infrastructure:
> >
> > - Record pfn instead of pointer to struct page in tracepoints (Namhyung Kim)
> >
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> >
> > ----------------------------------------------------------------
> > He Kuang (3):
> > perf probe: Set retprobe flag when probe in address-based alternative mode
> > perf probe: Make --source avaiable when probe with lazy_line
> > perf probe: Fix segfault when probe with lazy_line to file
> >
> > Namhyung Kim (2):
> > tracing, mm: Record pfn instead of pointer to struct page
> > perf kmem: Analyze page allocator events also
> >
> > include/trace/events/filemap.h | 8 +-
> > include/trace/events/kmem.h | 42 +--
> > include/trace/events/vmscan.h | 8 +-
> > tools/perf/Documentation/perf-kmem.txt | 8 +-
> > tools/perf/builtin-kmem.c | 500 +++++++++++++++++++++++++++++++--
> > tools/perf/util/probe-event.c | 3 +-
> > tools/perf/util/probe-event.h | 2 +
> > tools/perf/util/probe-finder.c | 20 +-
> > 8 files changed, 540 insertions(+), 51 deletions(-)
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
> >
> >
>
>
> --
> Masami HIRAMATSU
> Linux Technology Research Center, System Productivity Research Dept.
> Center for Technology Innovation - Systems Engineering
> Hitachi, Ltd., Research & Development Group
> E-mail: masami.hiramatsu.pt@hitachi.com
>
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [GIT PULL 0/5] perf/core improvements and fixes
2015-04-13 23:09 ` Arnaldo Carvalho de Melo
@ 2015-04-13 23:19 ` Arnaldo Carvalho de Melo
2015-04-14 12:12 ` Ingo Molnar
0 siblings, 1 reply; 36+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-04-13 23:19 UTC (permalink / raw)
To: Masami Hiramatsu, Ingo Molnar
Cc: linux-kernel, David Ahern, He Kuang, Jiri Olsa, Joonsoo Kim,
linux-mm, Minchan Kim, Namhyung Kim, Peter Zijlstra,
Steven Rostedt, Wang Nan
Em Mon, Apr 13, 2015 at 08:09:23PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Apr 14, 2015 at 07:33:07AM +0900, Masami Hiramatsu escreveu:
> > Hi, Arnaldo,
> >
> > > perf probe: Make --source avaiable when probe with lazy_line
> >
> > No, could you pull Naohiro's patch?
> > I'd like to move get_real_path to probe_finder.c
>
> OOps, yeah, you asked for that... Ingo, please ignore this pull request
> for now, thanks,
Ok, I did that and created a perf-core-for-mingo-2, Masami, please check
that all is right, ok?
- Arnaldo
The following changes since commit 066450be419fa48007a9f29e19828f2a86198754:
perf/x86/intel/pt: Clean up the control flow in pt_pmu_hw_init() (2015-04-12 11:21:15 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-2
for you to fetch changes up to f19e80c640d58ddfd70f2454ee597f81ba966690:
perf probe: Fix segfault when probe with lazy_line to file (2015-04-13 20:12:21 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
New features:
- Analyze page allocator events also in 'perf kmem' (Namhyung Kim)
User visible fixes:
- Fix retprobe 'perf probe' handling when failing to find needed debuginfo (He Kuang)
- lazy_line probe fixes in 'perf probe' (Naohiro Aota, He Kuang)
Infrastructure:
- Record pfn instead of pointer to struct page in tracepoints (Namhyung Kim)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
He Kuang (2):
perf probe: Set retprobe flag when probe in address-based alternative mode
perf probe: Fix segfault when probe with lazy_line to file
Namhyung Kim (2):
tracing, mm: Record pfn instead of pointer to struct page
perf kmem: Analyze page allocator events also
Naohiro Aota (1):
perf probe: Find compilation directory path for lazy matching
include/trace/events/filemap.h | 8 +-
include/trace/events/kmem.h | 42 +--
include/trace/events/vmscan.h | 8 +-
tools/perf/Documentation/perf-kmem.txt | 8 +-
tools/perf/builtin-kmem.c | 500 +++++++++++++++++++++++++++++++--
tools/perf/util/probe-event.c | 60 +---
tools/perf/util/probe-finder.c | 73 ++++-
tools/perf/util/probe-finder.h | 4 +
8 files changed, 596 insertions(+), 107 deletions(-)
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [GIT PULL 0/5] perf/core improvements and fixes
2015-04-13 23:19 ` Arnaldo Carvalho de Melo
@ 2015-04-14 12:12 ` Ingo Molnar
0 siblings, 0 replies; 36+ messages in thread
From: Ingo Molnar @ 2015-04-14 12:12 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Masami Hiramatsu, linux-kernel, David Ahern, He Kuang, Jiri Olsa,
Joonsoo Kim, linux-mm, Minchan Kim, Namhyung Kim, Peter Zijlstra,
Steven Rostedt, Wang Nan
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Em Mon, Apr 13, 2015 at 08:09:23PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Tue, Apr 14, 2015 at 07:33:07AM +0900, Masami Hiramatsu escreveu:
> > > Hi, Arnaldo,
> > >
> > > > perf probe: Make --source avaiable when probe with lazy_line
> > >
> > > No, could you pull Naohiro's patch?
> > > I'd like to move get_real_path to probe_finder.c
> >
> > OOps, yeah, you asked for that... Ingo, please ignore this pull request
> > for now, thanks,
>
> Ok, I did that and created a perf-core-for-mingo-2, Masami, please check
> that all is right, ok?
>
> - Arnaldo
>
> The following changes since commit 066450be419fa48007a9f29e19828f2a86198754:
>
> perf/x86/intel/pt: Clean up the control flow in pt_pmu_hw_init() (2015-04-12 11:21:15 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-2
>
> for you to fetch changes up to f19e80c640d58ddfd70f2454ee597f81ba966690:
>
> perf probe: Fix segfault when probe with lazy_line to file (2015-04-13 20:12:21 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> New features:
>
> - Analyze page allocator events also in 'perf kmem' (Namhyung Kim)
>
> User visible fixes:
>
> - Fix retprobe 'perf probe' handling when failing to find needed debuginfo (He Kuang)
>
> - lazy_line probe fixes in 'perf probe' (Naohiro Aota, He Kuang)
>
> Infrastructure:
>
> - Record pfn instead of pointer to struct page in tracepoints (Namhyung Kim)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> He Kuang (2):
> perf probe: Set retprobe flag when probe in address-based alternative mode
> perf probe: Fix segfault when probe with lazy_line to file
>
> Namhyung Kim (2):
> tracing, mm: Record pfn instead of pointer to struct page
> perf kmem: Analyze page allocator events also
>
> Naohiro Aota (1):
> perf probe: Find compilation directory path for lazy matching
>
> include/trace/events/filemap.h | 8 +-
> include/trace/events/kmem.h | 42 +--
> include/trace/events/vmscan.h | 8 +-
> tools/perf/Documentation/perf-kmem.txt | 8 +-
> tools/perf/builtin-kmem.c | 500 +++++++++++++++++++++++++++++++--
> tools/perf/util/probe-event.c | 60 +---
> tools/perf/util/probe-finder.c | 73 ++++-
> tools/perf/util/probe-finder.h | 4 +
> 8 files changed, 596 insertions(+), 107 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 36+ messages in thread
* [GIT PULL 0/5] perf/core improvements and fixes
@ 2014-10-17 19:49 Arnaldo Carvalho de Melo
2014-10-18 7:04 ` Ingo Molnar
0 siblings, 1 reply; 36+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-10-17 19:49 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, Borislav Petkov, Corey Ashford, David Ahern,
Don Zickus, Frederic Weisbecker, Jean Pihet, Jen-Cheng Huang,
Jiri Olsa, Mike Galbraith, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Stephane Eranian, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 691286b5561aab2e1b00119bc328598c01250548:
kprobes/x86: Remove stale ARCH_SUPPORTS_KPROBES_ON_FTRACE define (2014-10-17 07:18:34 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to e8564b710c6df2c3aeb56c507c22f4bcfa4c0b2d:
perf script: Add period as a default output column (2014-10-17 15:22:19 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
o Add period data column and make it default in 'perf script' (Jiri Olsa)
Infrastructure:
* Move exit stuff from perf_evsel__delete to perf_evsel__exit, delete
should be just a front end for exit + free (Arnaldo Carvalho de Melo)
* Add missing 'struct option' forward declaration (Arnaldo Carvalho de Melo)
* No need to drag util/cgroup.h into evsel.h (Arnaldo Carvalho de Melo)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (3):
perf evsel: Move exit stuff from __delete to __exit
perf evlist: Add missing 'struct option' forward declaration
perf evsel: No need to drag util/cgroup.h
Jiri Olsa (2):
perf script: Add period data column
perf script: Add period as a default output column
tools/perf/Documentation/perf-script.txt | 2 +-
tools/perf/builtin-record.c | 1 +
tools/perf/builtin-script.c | 21 +++++++++++++++++----
tools/perf/builtin-stat.c | 1 +
tools/perf/util/evlist.h | 2 ++
tools/perf/util/evsel.c | 11 ++++++-----
tools/perf/util/evsel.h | 3 ++-
7 files changed, 30 insertions(+), 11 deletions(-)
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [GIT PULL 0/5] perf/core improvements and fixes
2014-10-17 19:49 Arnaldo Carvalho de Melo
@ 2014-10-18 7:04 ` Ingo Molnar
0 siblings, 0 replies; 36+ messages in thread
From: Ingo Molnar @ 2014-10-18 7:04 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Andi Kleen, Borislav Petkov,
Corey Ashford, David Ahern, Don Zickus, Frederic Weisbecker,
Jean Pihet, Jen-Cheng Huang, Jiri Olsa, Mike Galbraith,
Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 691286b5561aab2e1b00119bc328598c01250548:
>
> kprobes/x86: Remove stale ARCH_SUPPORTS_KPROBES_ON_FTRACE define (2014-10-17 07:18:34 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to e8564b710c6df2c3aeb56c507c22f4bcfa4c0b2d:
>
> perf script: Add period as a default output column (2014-10-17 15:22:19 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> o Add period data column and make it default in 'perf script' (Jiri Olsa)
>
> Infrastructure:
>
> * Move exit stuff from perf_evsel__delete to perf_evsel__exit, delete
> should be just a front end for exit + free (Arnaldo Carvalho de Melo)
>
> * Add missing 'struct option' forward declaration (Arnaldo Carvalho de Melo)
>
> * No need to drag util/cgroup.h into evsel.h (Arnaldo Carvalho de Melo)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (3):
> perf evsel: Move exit stuff from __delete to __exit
> perf evlist: Add missing 'struct option' forward declaration
> perf evsel: No need to drag util/cgroup.h
>
> Jiri Olsa (2):
> perf script: Add period data column
> perf script: Add period as a default output column
>
> tools/perf/Documentation/perf-script.txt | 2 +-
> tools/perf/builtin-record.c | 1 +
> tools/perf/builtin-script.c | 21 +++++++++++++++++----
> tools/perf/builtin-stat.c | 1 +
> tools/perf/util/evlist.h | 2 ++
> tools/perf/util/evsel.c | 11 ++++++-----
> tools/perf/util/evsel.h | 3 ++-
> 7 files changed, 30 insertions(+), 11 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 36+ messages in thread
* [GIT PULL 0/5] perf/core improvements and fixes
@ 2014-04-18 10:31 Jiri Olsa
0 siblings, 0 replies; 36+ messages in thread
From: Jiri Olsa @ 2014-04-18 10:31 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Corey Ashford,
David Ahern, Don Zickus, Frederic Weisbecker, Jiri Olsa,
Li Zefan, Namhyung Kim, Paul Mackerras, Peter Zijlstra
hi Ingo,
please consider pulling
thanks,
jirka
The following changes since commit 37b6cb475a6d74bc047c53bc323d6eb3113e27a4:
Merge branch 'uprobes/core' of git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc into perf/core (2014-04-18 09:49:14 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-core-for-mingo
for you to fetch changes up to a651d9357f936a19ae811a29d031224cdb8c2f1f:
perf callchain: Add generic report parse callchain callback function (2014-04-18 11:56:59 +0200)
----------------------------------------------------------------
perf/core improvements and fixes:
Developer stuff:
. Making some code (cpu node map and report parse callchain callback) global
to be usable by upcomming changes (Don Zickus)
. Fix pmu object compilation error (Jiri Olsa)
----------------------------------------------------------------
Don Zickus (4):
perf tools: Allow ability to map cpus to nodes easily
perf tools: Use cpu/possible instead of cpu/kernel_max
perf kmem: Utilize the new generic cpunode_map
perf callchain: Add generic report parse callchain callback function
Jiri Olsa (1):
perf tools: Fix pmu object compilation error
tools/perf/builtin-kmem.c | 78 +----------------------
tools/perf/builtin-report.c | 81 +-----------------------
tools/perf/util/callchain.c | 82 ++++++++++++++++++++++++
tools/perf/util/callchain.h | 1 +
tools/perf/util/cpumap.c | 147 ++++++++++++++++++++++++++++++++++++++++++++
tools/perf/util/cpumap.h | 35 +++++++++++
tools/perf/util/pmu.c | 6 +-
7 files changed, 274 insertions(+), 156 deletions(-)
^ permalink raw reply [flat|nested] 36+ messages in thread
* [GIT PULL 0/5] perf/core improvements and fixes
@ 2011-10-14 18:27 Arnaldo Carvalho de Melo
2011-10-15 14:59 ` Ingo Molnar
0 siblings, 1 reply; 36+ messages in thread
From: Arnaldo Carvalho de Melo @ 2011-10-14 18:27 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, David Ahern,
Frederic Weisbecker, Mike Galbraith, Paul Mackerras,
Peter Zijlstra, Stephane Eranian, Thomas Jarosch, arnaldo.melo
Hi Ingo,
Please consider pulling from:
git://github.com/acmel/linux.git perf/core
These are in addition to the ones you reported being problematic
with perf top segfaulting sometimes, that problem should be fixed by the
first patch below.
Regards,
- Arnaldo
Arnaldo Carvalho de Melo (4):
perf hists browser: Invalidate ui_browser->top after timer calls
perf annotate browser: Exit when pressing ESC or the left arrow
perf ui browser: Add filter method
perf annotate browser: Allow toggling the visualization of source code lines
Thomas Jarosch (1):
perf buildid: Fix possible unterminated readlink() result buffer
tools/perf/util/header.c | 2 +-
tools/perf/util/ui/browser.c | 52 +++++++++++++++++----
tools/perf/util/ui/browser.h | 1 +
tools/perf/util/ui/browsers/annotate.c | 78 +++++++++++++++++++++++++++++--
tools/perf/util/ui/browsers/hists.c | 15 +++++-
5 files changed, 131 insertions(+), 17 deletions(-)
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [GIT PULL 0/5] perf/core improvements and fixes
2011-10-14 18:27 Arnaldo Carvalho de Melo
@ 2011-10-15 14:59 ` Ingo Molnar
2011-10-15 17:00 ` David Ahern
0 siblings, 1 reply; 36+ messages in thread
From: Ingo Molnar @ 2011-10-15 14:59 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, David Ahern, Frederic Weisbecker, Mike Galbraith,
Paul Mackerras, Peter Zijlstra, Stephane Eranian, Thomas Jarosch,
arnaldo.melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> Hi Ingo,
>
> Please consider pulling from:
>
> git://github.com/acmel/linux.git perf/core
>
> These are in addition to the ones you reported being problematic
> with perf top segfaulting sometimes, that problem should be fixed by the
> first patch below.
>
> Regards,
>
> - Arnaldo
>
> Arnaldo Carvalho de Melo (4):
> perf hists browser: Invalidate ui_browser->top after timer calls
> perf annotate browser: Exit when pressing ESC or the left arrow
> perf ui browser: Add filter method
> perf annotate browser: Allow toggling the visualization of source code lines
>
> Thomas Jarosch (1):
> perf buildid: Fix possible unterminated readlink() result buffer
>
> tools/perf/util/header.c | 2 +-
> tools/perf/util/ui/browser.c | 52 +++++++++++++++++----
> tools/perf/util/ui/browser.h | 1 +
> tools/perf/util/ui/browsers/annotate.c | 78 +++++++++++++++++++++++++++++--
> tools/perf/util/ui/browsers/hists.c | 15 +++++-
> 5 files changed, 131 insertions(+), 17 deletions(-)
Pulled, thanks a lot Arnaldo!
The 'perf top' segfault is indeed fixed for me too.
Btw., i noticed another weirdness - sometimes after startup i get
this message:
/lib64/libc-2.14.90.so was updated, restart the long running apps that use it!
but it was not updated recently:
earth5:~/tip/tools/perf> ll /lib64/libc-2.14.90.so
-rwxr-xr-x 1 root root 2062920 Sep 28 15:11 /lib64/libc-2.14.90.so
earth5:~/tip/tools/perf> date
Sat Oct 15 16:59:04 CEST 2011
earth5:~/tip/tools/perf> uptime
16:59:08 up 19 days, 21:35, 11 users, load average: 7.77, 7.48, 3.81
Thanks,
Ingo
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [GIT PULL 0/5] perf/core improvements and fixes
2011-10-15 14:59 ` Ingo Molnar
@ 2011-10-15 17:00 ` David Ahern
2011-10-15 17:04 ` Ingo Molnar
0 siblings, 1 reply; 36+ messages in thread
From: David Ahern @ 2011-10-15 17:00 UTC (permalink / raw)
To: Ingo Molnar
Cc: Arnaldo Carvalho de Melo, linux-kernel, Frederic Weisbecker,
Mike Galbraith, Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Thomas Jarosch, arnaldo.melo
On 10/15/2011 08:59 AM, Ingo Molnar wrote:
> Btw., i noticed another weirdness - sometimes after startup i get
> this message:
>
> /lib64/libc-2.14.90.so was updated, restart the long running apps that use it!
>
> but it was not updated recently:
>
> earth5:~/tip/tools/perf> ll /lib64/libc-2.14.90.so
> -rwxr-xr-x 1 root root 2062920 Sep 28 15:11 /lib64/libc-2.14.90.so
> earth5:~/tip/tools/perf> date
> Sat Oct 15 16:59:04 CEST 2011
> earth5:~/tip/tools/perf> uptime
> 16:59:08 up 19 days, 21:35, 11 users, load average: 7.77, 7.48, 3.81
I got the impression that comment was relative to when the processes
were started versus prelink touching it. In your case the mod time of
libc is after the uptime of the box.
David
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [GIT PULL 0/5] perf/core improvements and fixes
2011-10-15 17:00 ` David Ahern
@ 2011-10-15 17:04 ` Ingo Molnar
2011-10-15 17:46 ` David Ahern
0 siblings, 1 reply; 36+ messages in thread
From: Ingo Molnar @ 2011-10-15 17:04 UTC (permalink / raw)
To: David Ahern
Cc: Arnaldo Carvalho de Melo, linux-kernel, Frederic Weisbecker,
Mike Galbraith, Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Thomas Jarosch, arnaldo.melo
* David Ahern <dsahern@gmail.com> wrote:
> On 10/15/2011 08:59 AM, Ingo Molnar wrote:
> > Btw., i noticed another weirdness - sometimes after startup i get
> > this message:
> >
> > /lib64/libc-2.14.90.so was updated, restart the long running apps that use it!
> >
> > but it was not updated recently:
> >
> > earth5:~/tip/tools/perf> ll /lib64/libc-2.14.90.so
> > -rwxr-xr-x 1 root root 2062920 Sep 28 15:11 /lib64/libc-2.14.90.so
> > earth5:~/tip/tools/perf> date
> > Sat Oct 15 16:59:04 CEST 2011
> > earth5:~/tip/tools/perf> uptime
> > 16:59:08 up 19 days, 21:35, 11 users, load average: 7.77, 7.48, 3.81
>
> I got the impression that comment was relative to when the
> processes were started versus prelink touching it. In your case the
> mod time of libc is after the uptime of the box.
Ok, that makes sense. Do we report this in perf report output as
well?
Thanks,
Ingo
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [GIT PULL 0/5] perf/core improvements and fixes
2011-10-15 17:04 ` Ingo Molnar
@ 2011-10-15 17:46 ` David Ahern
2011-10-15 19:06 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 36+ messages in thread
From: David Ahern @ 2011-10-15 17:46 UTC (permalink / raw)
To: Ingo Molnar
Cc: Arnaldo Carvalho de Melo, linux-kernel, Frederic Weisbecker,
Mike Galbraith, Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Thomas Jarosch, arnaldo.melo
On 10/15/2011 11:04 AM, Ingo Molnar wrote:
>
> * David Ahern <dsahern@gmail.com> wrote:
>
>> On 10/15/2011 08:59 AM, Ingo Molnar wrote:
>>> Btw., i noticed another weirdness - sometimes after startup i get
>>> this message:
>>>
>>> /lib64/libc-2.14.90.so was updated, restart the long running apps that use it!
>>>
>>> but it was not updated recently:
>>>
>>> earth5:~/tip/tools/perf> ll /lib64/libc-2.14.90.so
>>> -rwxr-xr-x 1 root root 2062920 Sep 28 15:11 /lib64/libc-2.14.90.so
>>> earth5:~/tip/tools/perf> date
>>> Sat Oct 15 16:59:04 CEST 2011
>>> earth5:~/tip/tools/perf> uptime
>>> 16:59:08 up 19 days, 21:35, 11 users, load average: 7.77, 7.48, 3.81
>>
>> I got the impression that comment was relative to when the
>> processes were started versus prelink touching it. In your case the
>> mod time of libc is after the uptime of the box.
>
> Ok, that makes sense. Do we report this in perf report output as
> well?
It should. The message comes from map__load() when it detects a deleted
mapping such as:
7f9e8d5c7000-7f9e8d5c8000 rw-p 0000c000 fd:02 1046947
/lib64/libpam.so.0.82.2.#prelink#.cM3f72 (deleted)
I have removed prelink from most of my systems (managed to find one lone
server with the above).
David
>
> Thanks,
>
> Ingo
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [GIT PULL 0/5] perf/core improvements and fixes
2011-10-15 17:46 ` David Ahern
@ 2011-10-15 19:06 ` Arnaldo Carvalho de Melo
2011-10-15 19:09 ` David Ahern
0 siblings, 1 reply; 36+ messages in thread
From: Arnaldo Carvalho de Melo @ 2011-10-15 19:06 UTC (permalink / raw)
To: David Ahern
Cc: Ingo Molnar, linux-kernel, Frederic Weisbecker, Mike Galbraith,
Paul Mackerras, Peter Zijlstra, Stephane Eranian, Thomas Jarosch
Em Sat, Oct 15, 2011 at 11:46:14AM -0600, David Ahern escreveu:
>
>
> On 10/15/2011 11:04 AM, Ingo Molnar wrote:
> >
> > * David Ahern <dsahern@gmail.com> wrote:
> >
> >> On 10/15/2011 08:59 AM, Ingo Molnar wrote:
> >>> Btw., i noticed another weirdness - sometimes after startup i get
> >>> this message:
> >>>
> >>> /lib64/libc-2.14.90.so was updated, restart the long running apps that use it!
> >>>
> >>> but it was not updated recently:
> >>>
> >>> earth5:~/tip/tools/perf> ll /lib64/libc-2.14.90.so
> >>> -rwxr-xr-x 1 root root 2062920 Sep 28 15:11 /lib64/libc-2.14.90.so
> >>> earth5:~/tip/tools/perf> date
> >>> Sat Oct 15 16:59:04 CEST 2011
> >>> earth5:~/tip/tools/perf> uptime
> >>> 16:59:08 up 19 days, 21:35, 11 users, load average: 7.77, 7.48, 3.81
> >>
> >> I got the impression that comment was relative to when the
> >> processes were started versus prelink touching it. In your case the
> >> mod time of libc is after the uptime of the box.
> >
> > Ok, that makes sense. Do we report this in perf report output as
> > well?
>
> It should. The message comes from map__load() when it detects a deleted
> mapping such as:
>
> 7f9e8d5c7000-7f9e8d5c8000 rw-p 0000c000 fd:02 1046947
> /lib64/libpam.so.0.82.2.#prelink#.cM3f72 (deleted)
>
> I have removed prelink from most of my systems (managed to find one lone
> server with the above).
David,
Can you send me a patch that clarifies this situation?
- Arnaldo
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [GIT PULL 0/5] perf/core improvements and fixes
2011-10-15 19:06 ` Arnaldo Carvalho de Melo
@ 2011-10-15 19:09 ` David Ahern
2011-10-17 1:15 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 36+ messages in thread
From: David Ahern @ 2011-10-15 19:09 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Ingo Molnar, linux-kernel, Frederic Weisbecker, Mike Galbraith,
Paul Mackerras, Peter Zijlstra, Stephane Eranian, Thomas Jarosch
On 10/15/2011 01:06 PM, Arnaldo Carvalho de Melo wrote:
>>
>> It should. The message comes from map__load() when it detects a deleted
>> mapping such as:
>>
>> 7f9e8d5c7000-7f9e8d5c8000 rw-p 0000c000 fd:02 1046947
>> /lib64/libpam.so.0.82.2.#prelink#.cM3f72 (deleted)
>>
>> I have removed prelink from most of my systems (managed to find one lone
>> server with the above).
>
> David,
>
> Can you send me a patch that clarifies this situation?
>
> - Arnaldo
Clarifies in what way? The code checks for "(deleted)" on the dso and
suggests a restart of the process.
David
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [GIT PULL 0/5] perf/core improvements and fixes
2011-10-15 19:09 ` David Ahern
@ 2011-10-17 1:15 ` Arnaldo Carvalho de Melo
2011-10-17 6:48 ` Ingo Molnar
0 siblings, 1 reply; 36+ messages in thread
From: Arnaldo Carvalho de Melo @ 2011-10-17 1:15 UTC (permalink / raw)
To: David Ahern
Cc: Ingo Molnar, linux-kernel, Frederic Weisbecker, Mike Galbraith,
Paul Mackerras, Peter Zijlstra, Stephane Eranian, Thomas Jarosch
Em Sat, Oct 15, 2011 at 01:09:32PM -0600, David Ahern escreveu:
> On 10/15/2011 01:06 PM, Arnaldo Carvalho de Melo wrote:
> >>
> >> It should. The message comes from map__load() when it detects a deleted
> >> mapping such as:
> >>
> >> 7f9e8d5c7000-7f9e8d5c8000 rw-p 0000c000 fd:02 1046947
> >> /lib64/libpam.so.0.82.2.#prelink#.cM3f72 (deleted)
> >>
> >> I have removed prelink from most of my systems (managed to find one lone
> >> server with the above).
> >
> > Can you send me a patch that clarifies this situation?
>
> Clarifies in what way? The code checks for "(deleted)" on the dso and
> suggests a restart of the process.
Perhaps telling that prelinking is the reason, so that users that don't
recall updating anything understands the situation.
- Arnaldo
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [GIT PULL 0/5] perf/core improvements and fixes
2011-10-17 1:15 ` Arnaldo Carvalho de Melo
@ 2011-10-17 6:48 ` Ingo Molnar
0 siblings, 0 replies; 36+ messages in thread
From: Ingo Molnar @ 2011-10-17 6:48 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: David Ahern, linux-kernel, Frederic Weisbecker, Mike Galbraith,
Paul Mackerras, Peter Zijlstra, Stephane Eranian, Thomas Jarosch
* Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote:
> Em Sat, Oct 15, 2011 at 01:09:32PM -0600, David Ahern escreveu:
> > On 10/15/2011 01:06 PM, Arnaldo Carvalho de Melo wrote:
> > >>
> > >> It should. The message comes from map__load() when it detects a deleted
> > >> mapping such as:
> > >>
> > >> 7f9e8d5c7000-7f9e8d5c8000 rw-p 0000c000 fd:02 1046947
> > >> /lib64/libpam.so.0.82.2.#prelink#.cM3f72 (deleted)
> > >>
> > >> I have removed prelink from most of my systems (managed to find one lone
> > >> server with the above).
> > >
> > > Can you send me a patch that clarifies this situation?
> >
> > Clarifies in what way? The code checks for "(deleted)" on the dso and
> > suggests a restart of the process.
>
> Perhaps telling that prelinking is the reason, so that users that
> don't recall updating anything understands the situation.
Yeah. I am certainly aware of prelinking yet it did not occur to me
when i saw the message.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 36+ messages in thread
* [GIT PULL 0/5] perf/core improvements and fixes
@ 2011-02-17 20:41 Arnaldo Carvalho de Melo
2011-02-18 7:26 ` Ingo Molnar
0 siblings, 1 reply; 36+ messages in thread
From: Arnaldo Carvalho de Melo @ 2011-02-17 20:41 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Arun Sharma,
David S . Miller, Frederic Weisbecker, Ingo Molnar,
Mike Galbraith, Paul Mackerras, Peter Zijlstra, Robert Richter,
Stephane Eranian, Steven Rostedt, Tom Zanussi,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling from:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core
Regards,
- Arnaldo
Arnaldo Carvalho de Melo (4):
perf python: Add cgroup.c to setup.py to get it building again
perf hists: Print number of samples, not the period sum
perf record: Delay setting the header writing atexit call
perf report: Tell the user when a perf.data file has no samples
Stephane Eranian (1):
perf: make perf stat print user provided full event names
tools/perf/builtin-record.c | 10 +++++-----
tools/perf/builtin-report.c | 6 ++++++
tools/perf/util/evsel.c | 1 +
tools/perf/util/evsel.h | 7 +++++++
tools/perf/util/hist.c | 7 +++++--
tools/perf/util/parse-events.c | 10 ++++++++++
tools/perf/util/setup.py | 2 +-
7 files changed, 35 insertions(+), 8 deletions(-)
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [GIT PULL 0/5] perf/core improvements and fixes
2011-02-17 20:41 Arnaldo Carvalho de Melo
@ 2011-02-18 7:26 ` Ingo Molnar
0 siblings, 0 replies; 36+ messages in thread
From: Ingo Molnar @ 2011-02-18 7:26 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arun Sharma, David S . Miller, Frederic Weisbecker,
Mike Galbraith, Paul Mackerras, Peter Zijlstra, Robert Richter,
Stephane Eranian, Steven Rostedt, Tom Zanussi,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> Hi Ingo,
>
> Please consider pulling from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core
>
> Regards,
>
> - Arnaldo
>
> Arnaldo Carvalho de Melo (4):
> perf python: Add cgroup.c to setup.py to get it building again
> perf hists: Print number of samples, not the period sum
> perf record: Delay setting the header writing atexit call
> perf report: Tell the user when a perf.data file has no samples
>
> Stephane Eranian (1):
> perf: make perf stat print user provided full event names
>
> tools/perf/builtin-record.c | 10 +++++-----
> tools/perf/builtin-report.c | 6 ++++++
> tools/perf/util/evsel.c | 1 +
> tools/perf/util/evsel.h | 7 +++++++
> tools/perf/util/hist.c | 7 +++++--
> tools/perf/util/parse-events.c | 10 ++++++++++
> tools/perf/util/setup.py | 2 +-
> 7 files changed, 35 insertions(+), 8 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 36+ messages in thread
* [GIT PULL 0/5] perf/core improvements and fixes
@ 2010-12-06 20:28 Arnaldo Carvalho de Melo
0 siblings, 0 replies; 36+ messages in thread
From: Arnaldo Carvalho de Melo @ 2010-12-06 20:28 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Akihiro Nagai,
Chris Samuel, David S . Miller, Frederic Weisbecker, Ian Munsie,
Ingo Molnar, Masami Hiramatsu, Mike Galbraith, Paul Mackerras,
Peter Zijlstra, Robert Richter, Stephane Eranian,
Stephane Eranian, Thomas Gleixner, Arnaldo Carvalho de Melo
Hi Ingo,
Please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core
This is in addition to the previous pull request.
Regards,
- Arnaldo
Akihiro Nagai (1):
perf options: add OPT_CALLBACK_DEFAULT_NOOPT
Chris Samuel (1):
perf tools: Catch a few uncheck calloc/malloc's
Ian Munsie (1):
perf hist: Better displaying of unresolved DSOs and symbols
Stephane Eranian (1):
perf script: Fix compiler warning in builtin_script.c:is_top_script()
Thomas Gleixner (1):
perf session: Sort all events if ordered_samples=true
tools/perf/builtin-kmem.c | 3 +
tools/perf/builtin-lock.c | 3 +
tools/perf/builtin-sched.c | 3 +
tools/perf/builtin-script.c | 10 ++--
tools/perf/builtin-timechart.c | 3 +
tools/perf/util/header.c | 3 +
tools/perf/util/parse-options.h | 4 +
tools/perf/util/session.c | 125 ++++++++++++++++++++++----------------
tools/perf/util/sort.c | 6 +-
9 files changed, 99 insertions(+), 61 deletions(-)
^ permalink raw reply [flat|nested] 36+ messages in thread
* [GIT PULL 0/5] perf/core improvements and fixes
@ 2010-11-26 21:47 Arnaldo Carvalho de Melo
0 siblings, 0 replies; 36+ messages in thread
From: Arnaldo Carvalho de Melo @ 2010-11-26 21:47 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Andreas Schwab,
Arnaldo Carvalho de Melo, Davidlohr Bueso, Frederic Weisbecker,
Ian Munsie, Ingo Molnar, Mike Galbraith, Paul Mackerras,
Peter Zijlstra, Shawn Bohrer, Stephane Eranian, Thomas Gleixner,
Tom Zanussi
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Hi Ingo,
Please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core
Regards,
- Arnaldo
Arnaldo Carvalho de Melo (2):
perf record: Add option to disable collecting build-ids
perf events: Default to using event__process_lost
Davidlohr Bueso (1):
perf tools: Add GCC optimization to memory allocating functions
Ian Munsie (1):
perf symbols: Correct final kernel map guesses
Shawn Bohrer (1):
perf trace: Handle DT_UNKNOWN on filesystems that don't support
d_type
tools/perf/builtin-record.c | 14 ++++++++++--
tools/perf/builtin-trace.c | 33 ++++++++++++++++++++++++-------
tools/perf/util/event.c | 2 +-
tools/perf/util/header.c | 11 ++++++++-
tools/perf/util/header.h | 1 +
tools/perf/util/include/linux/bitops.h | 5 ++++
tools/perf/util/session.c | 2 +-
tools/perf/util/symbol.c | 2 +-
tools/perf/util/util.h | 5 ++-
9 files changed, 57 insertions(+), 18 deletions(-)
^ permalink raw reply [flat|nested] 36+ messages in thread
* [GIT PULL 0/5] perf/core improvements and fixes
@ 2010-10-23 20:28 Arnaldo Carvalho de Melo
2010-10-24 9:39 ` Ingo Molnar
0 siblings, 1 reply; 36+ messages in thread
From: Arnaldo Carvalho de Melo @ 2010-10-23 20:28 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Ben Hutchings,
Frederic Weisbecker, Ingo Molnar, Masami Hiramatsu,
Mike Galbraith, Paul Mackerras, Peter Zijlstra, Robert Richter,
Sonny Rao, Stephane Eranian
Hi Ingo,
Please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core
Regards,
- Arnaldo
Arnaldo Carvalho de Melo (2):
perf tools: Remove direct slang.h include
perf probe: Fix format specified for Dwarf_Off parameter
Ben Hutchings (2):
perf trace: Use $PERF_EXEC_PATH in canned report scripts
perf trace: Fix detection of script extension
Sonny Rao (1):
perf tools: Document event modifiers
tools/perf/Documentation/perf-list.txt | 17 +++++++++++++++++
tools/perf/builtin-trace.c | 8 ++++----
tools/perf/scripts/perl/bin/failed-syscalls-report | 2 +-
tools/perf/scripts/perl/bin/rw-by-file-report | 2 +-
tools/perf/scripts/perl/bin/rw-by-pid-report | 2 +-
tools/perf/scripts/perl/bin/rwtop-report | 2 +-
tools/perf/scripts/perl/bin/wakeup-latency-report | 2 +-
tools/perf/scripts/perl/bin/workqueue-stats-report | 2 +-
.../python/bin/failed-syscalls-by-pid-report | 2 +-
tools/perf/scripts/python/bin/netdev-times-report | 2 +-
.../perf/scripts/python/bin/sched-migration-report | 2 +-
tools/perf/scripts/python/bin/sctop-report | 2 +-
.../python/bin/syscall-counts-by-pid-report | 2 +-
.../perf/scripts/python/bin/syscall-counts-report | 2 +-
tools/perf/util/probe-finder.c | 3 ++-
tools/perf/util/ui/browser.c | 1 -
16 files changed, 35 insertions(+), 18 deletions(-)
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [GIT PULL 0/5] perf/core improvements and fixes
2010-10-23 20:28 Arnaldo Carvalho de Melo
@ 2010-10-24 9:39 ` Ingo Molnar
0 siblings, 0 replies; 36+ messages in thread
From: Ingo Molnar @ 2010-10-24 9:39 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Ben Hutchings, Frederic Weisbecker,
Masami Hiramatsu, Mike Galbraith, Paul Mackerras, Peter Zijlstra,
Robert Richter, Sonny Rao, Stephane Eranian
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> Hi Ingo,
>
> Please pull from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core
>
> Regards,
>
> - Arnaldo
>
> Arnaldo Carvalho de Melo (2):
> perf tools: Remove direct slang.h include
> perf probe: Fix format specified for Dwarf_Off parameter
>
> Ben Hutchings (2):
> perf trace: Use $PERF_EXEC_PATH in canned report scripts
> perf trace: Fix detection of script extension
>
> Sonny Rao (1):
> perf tools: Document event modifiers
>
> tools/perf/Documentation/perf-list.txt | 17 +++++++++++++++++
> tools/perf/builtin-trace.c | 8 ++++----
> tools/perf/scripts/perl/bin/failed-syscalls-report | 2 +-
> tools/perf/scripts/perl/bin/rw-by-file-report | 2 +-
> tools/perf/scripts/perl/bin/rw-by-pid-report | 2 +-
> tools/perf/scripts/perl/bin/rwtop-report | 2 +-
> tools/perf/scripts/perl/bin/wakeup-latency-report | 2 +-
> tools/perf/scripts/perl/bin/workqueue-stats-report | 2 +-
> .../python/bin/failed-syscalls-by-pid-report | 2 +-
> tools/perf/scripts/python/bin/netdev-times-report | 2 +-
> .../perf/scripts/python/bin/sched-migration-report | 2 +-
> tools/perf/scripts/python/bin/sctop-report | 2 +-
> .../python/bin/syscall-counts-by-pid-report | 2 +-
> .../perf/scripts/python/bin/syscall-counts-report | 2 +-
> tools/perf/util/probe-finder.c | 3 ++-
> tools/perf/util/ui/browser.c | 1 -
> 16 files changed, 35 insertions(+), 18 deletions(-)
Pulled, thanks Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 36+ messages in thread
end of thread, other threads:[~2018-02-21 7:52 UTC | newest]
Thread overview: 36+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-27 12:20 [GIT PULL 0/5] perf/core improvements and fixes Jiri Olsa
2014-06-27 12:20 ` [PATCH 1/5] tools lib traceevent: Fix a risk for doing free on uninitialized pointer Jiri Olsa
2014-06-27 12:20 ` [PATCH 2/5] perf tools powerpc: Adjust callchain based on DWARF debug info Jiri Olsa
2014-06-27 12:20 ` [PATCH 3/5] perf tools: Fix wrong condition for allocation failure Jiri Olsa
2014-06-27 14:12 ` Arnaldo Carvalho de Melo
2014-06-27 12:21 ` [PATCH 4/5] perf script: Move the number processing into its own function Jiri Olsa
2014-06-27 12:21 ` [PATCH 5/5] perf script: Handle the num array type in python properly Jiri Olsa
2014-07-05 9:30 ` [GIT PULL 0/5] perf/core improvements and fixes Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2018-02-21 1:34 Arnaldo Carvalho de Melo
2018-02-21 7:52 ` Ingo Molnar
2015-10-21 21:31 Arnaldo Carvalho de Melo
2015-10-22 7:34 ` Ingo Molnar
2015-10-07 22:45 Arnaldo Carvalho de Melo
2015-04-13 22:14 Arnaldo Carvalho de Melo
2015-04-13 22:33 ` Masami Hiramatsu
2015-04-13 23:09 ` Arnaldo Carvalho de Melo
2015-04-13 23:19 ` Arnaldo Carvalho de Melo
2015-04-14 12:12 ` Ingo Molnar
2014-10-17 19:49 Arnaldo Carvalho de Melo
2014-10-18 7:04 ` Ingo Molnar
2014-04-18 10:31 Jiri Olsa
2011-10-14 18:27 Arnaldo Carvalho de Melo
2011-10-15 14:59 ` Ingo Molnar
2011-10-15 17:00 ` David Ahern
2011-10-15 17:04 ` Ingo Molnar
2011-10-15 17:46 ` David Ahern
2011-10-15 19:06 ` Arnaldo Carvalho de Melo
2011-10-15 19:09 ` David Ahern
2011-10-17 1:15 ` Arnaldo Carvalho de Melo
2011-10-17 6:48 ` Ingo Molnar
2011-02-17 20:41 Arnaldo Carvalho de Melo
2011-02-18 7:26 ` Ingo Molnar
2010-12-06 20:28 Arnaldo Carvalho de Melo
2010-11-26 21:47 Arnaldo Carvalho de Melo
2010-10-23 20:28 Arnaldo Carvalho de Melo
2010-10-24 9:39 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).