[GIT PULL 0/5] perf/core improvements and fixes

[GIT PULL 0/5] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

        Please consider pulling from:

git://github.com/acmel/linux.git perf/core

	These are in addition to the ones you reported being problematic
with perf top segfaulting sometimes, that problem should be fixed by the
first patch below.

Regards,

- Arnaldo

Arnaldo Carvalho de Melo (4):
  perf hists browser: Invalidate ui_browser->top after timer calls
  perf annotate browser: Exit when pressing ESC or the left arrow
  perf ui browser: Add filter method
  perf annotate browser: Allow toggling the visualization of source code lines

Thomas Jarosch (1):
  perf buildid: Fix possible unterminated readlink() result buffer

 tools/perf/util/header.c               |    2 +-
 tools/perf/util/ui/browser.c           |   52 +++++++++++++++++----
 tools/perf/util/ui/browser.h           |    1 +
 tools/perf/util/ui/browsers/annotate.c |   78 +++++++++++++++++++++++++++++--
 tools/perf/util/ui/browsers/hists.c    |   15 +++++-
 5 files changed, 131 insertions(+), 17 deletions(-)

[PATCH 1/5] perf hists browser: Invalidate ui_browser->top after timer calls

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@redhat.com>

With underlying dynamic data structures we need to invalidate pointers
to them after a timer, as that entry may have vanished (decayed in top,
for instance).

I forgot about browser_ui->top. Fix it by resetting it to null after a
timer. The seek operation from SEEK_SET will then set it to a valid
entry because it starts from rb_first(&hists->entries).

Reported-by: Ingo Molnar <mingo@elte.hu>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-2ssjm0ouh9tsz4dwkcu7c40n@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/ui/browser.c        |    1 +
 tools/perf/util/ui/browsers/hists.c |   15 +++++++++++++--
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/ui/browser.c b/tools/perf/util/ui/browser.c
index 2923c49..078ceaf 100644
--- a/tools/perf/util/ui/browser.c
+++ b/tools/perf/util/ui/browser.c
@@ -249,6 +249,7 @@ void ui_browser__update_nr_entries(struct ui_browser *browser, u32 nr_entries)
 		browser->top_idx += offset;
 	}
 
+	browser->top = NULL;
 	browser->seek(browser, browser->top_idx, SEEK_SET);
 }
 
diff --git a/tools/perf/util/ui/browsers/hists.c b/tools/perf/util/ui/browsers/hists.c
index 4a3a7c9..b144b10 100644
--- a/tools/perf/util/ui/browsers/hists.c
+++ b/tools/perf/util/ui/browsers/hists.c
@@ -600,14 +600,23 @@ static int hist_browser__show_entry(struct hist_browser *self,
 	return printed;
 }
 
+static void ui_browser__hists_init_top(struct ui_browser *browser)
+{
+	if (browser->top == NULL) {
+		struct hist_browser *hb;
+
+		hb = container_of(browser, struct hist_browser, b);
+		browser->top = rb_first(&hb->hists->entries);
+	}
+}
+
 static unsigned int hist_browser__refresh(struct ui_browser *self)
 {
 	unsigned row = 0;
 	struct rb_node *nd;
 	struct hist_browser *hb = container_of(self, struct hist_browser, b);
 
-	if (self->top == NULL)
-		self->top = rb_first(&hb->hists->entries);
+	ui_browser__hists_init_top(self);
 
 	for (nd = self->top; nd; nd = rb_next(nd)) {
 		struct hist_entry *h = rb_entry(nd, struct hist_entry, rb_node);
@@ -659,6 +668,8 @@ static void ui_browser__hists_seek(struct ui_browser *self,
 	if (self->nr_entries == 0)
 		return;
 
+	ui_browser__hists_init_top(self);
+
 	switch (whence) {
 	case SEEK_SET:
 		nd = hists__filter_entries(rb_first(self->entries));
-- 
1.6.2.5

[PATCH 2/5] perf annotate browser: Exit when pressing ESC or the left arrow

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@redhat.com>

We lost that functionality on ed7e566, restore it.

Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-z8eb8af2x46x42lgpn1ustid@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/ui/browsers/annotate.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/tools/perf/util/ui/browsers/annotate.c b/tools/perf/util/ui/browsers/annotate.c
index cbefb4f..84315c9 100644
--- a/tools/perf/util/ui/browsers/annotate.c
+++ b/tools/perf/util/ui/browsers/annotate.c
@@ -285,6 +285,8 @@ static int annotate_browser__run(struct annotate_browser *self, int evidx,
 						     timer, arg, delay_secs);
 			}
 			break;
+		case NEWT_KEY_LEFT:
+		case NEWT_KEY_ESCAPE:
 		case 'q':
 		case CTRL('c'):
 			goto out;
-- 
1.6.2.5

[PATCH 3/5] perf ui browser: Add filter method

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@redhat.com>

Its becoming common to allow the user to filter out parts of the data
structure being browsed, like already done in the hists browser and in
the annotate browser in the next commit, so provide it directly in the
ui_browser class list_head helpers.

More work required to move the equivalent routines found now in the
hists browser to the rb_tree helpers.

Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-jk7danyt1d9ji4e3o2xuthpn@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/ui/browser.c |   51 ++++++++++++++++++++++++++++++++++-------
 tools/perf/util/ui/browser.h |    1 +
 2 files changed, 43 insertions(+), 9 deletions(-)

diff --git a/tools/perf/util/ui/browser.c b/tools/perf/util/ui/browser.c
index 078ceaf..a54b926 100644
--- a/tools/perf/util/ui/browser.c
+++ b/tools/perf/util/ui/browser.c
@@ -42,31 +42,62 @@ void ui_browser__gotorc(struct ui_browser *self, int y, int x)
 	SLsmg_gotorc(self->y + y, self->x + x);
 }
 
+static struct list_head *
+ui_browser__list_head_filter_entries(struct ui_browser *browser,
+				     struct list_head *pos)
+{
+	do {
+		if (!browser->filter || !browser->filter(browser, pos))
+			return pos;
+		pos = pos->next;
+	} while (pos != browser->entries);
+
+	return NULL;
+}
+
+static struct list_head *
+ui_browser__list_head_filter_prev_entries(struct ui_browser *browser,
+					  struct list_head *pos)
+{
+	do {
+		if (!browser->filter || !browser->filter(browser, pos))
+			return pos;
+		pos = pos->prev;
+	} while (pos != browser->entries);
+
+	return NULL;
+}
+
 void ui_browser__list_head_seek(struct ui_browser *self, off_t offset, int whence)
 {
 	struct list_head *head = self->entries;
 	struct list_head *pos;
 
+	if (self->nr_entries == 0)
+		return;
+
 	switch (whence) {
 	case SEEK_SET:
-		pos = head->next;
+		pos = ui_browser__list_head_filter_entries(self, head->next);
 		break;
 	case SEEK_CUR:
 		pos = self->top;
 		break;
 	case SEEK_END:
-		pos = head->prev;
+		pos = ui_browser__list_head_filter_prev_entries(self, head->prev);
 		break;
 	default:
 		return;
 	}
 
+	assert(pos != NULL);
+
 	if (offset > 0) {
 		while (offset-- != 0)
-			pos = pos->next;
+			pos = ui_browser__list_head_filter_entries(self, pos->next);
 	} else {
 		while (offset++ != 0)
-			pos = pos->prev;
+			pos = ui_browser__list_head_filter_prev_entries(self, pos->prev);
 	}
 
 	self->top = pos;
@@ -365,15 +396,17 @@ unsigned int ui_browser__list_head_refresh(struct ui_browser *self)
 	int row = 0;
 
 	if (self->top == NULL || self->top == self->entries)
-                self->top = head->next;
+                self->top = ui_browser__list_head_filter_entries(self, head->next);
 
 	pos = self->top;
 
 	list_for_each_from(pos, head) {
-		ui_browser__gotorc(self, row, 0);
-		self->write(self, pos, row);
-		if (++row == self->height)
-			break;
+		if (!self->filter || !self->filter(self, pos)) {
+			ui_browser__gotorc(self, row, 0);
+			self->write(self, pos, row);
+			if (++row == self->height)
+				break;
+		}
 	}
 
 	return row;
diff --git a/tools/perf/util/ui/browser.h b/tools/perf/util/ui/browser.h
index 7dd9d61..351c006 100644
--- a/tools/perf/util/ui/browser.h
+++ b/tools/perf/util/ui/browser.h
@@ -21,6 +21,7 @@ struct ui_browser {
 	unsigned int  (*refresh)(struct ui_browser *self);
 	void	      (*write)(struct ui_browser *self, void *entry, int row);
 	void	      (*seek)(struct ui_browser *self, off_t offset, int whence);
+	bool	      (*filter)(struct ui_browser *self, void *entry);
 	u32	      nr_entries;
 };
 
-- 
1.6.2.5

[PATCH 4/5] perf annotate browser: Allow toggling the visualization of source code lines

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@redhat.com>

Just press 'S' on any assembly line and the source code will be hidden
while the current line remains selected. Press 'S' again to show them
back.

Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-efmxm5etouebb7es0kkyqqwa@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/ui/browsers/annotate.c |   76 +++++++++++++++++++++++++++++--
 1 files changed, 71 insertions(+), 5 deletions(-)

diff --git a/tools/perf/util/ui/browsers/annotate.c b/tools/perf/util/ui/browsers/annotate.c
index 84315c9..eb2712e 100644
--- a/tools/perf/util/ui/browsers/annotate.c
+++ b/tools/perf/util/ui/browsers/annotate.c
@@ -21,12 +21,16 @@ struct annotate_browser {
 	struct rb_root	  entries;
 	struct rb_node	  *curr_hot;
 	struct objdump_line *selection;
+	int		    nr_asm_entries;
+	int		    nr_entries;
+	bool		    hide_src_code;
 };
 
 struct objdump_line_rb_node {
 	struct rb_node	rb_node;
 	double		percent;
 	u32		idx;
+	int		idx_asm;
 };
 
 static inline
@@ -35,10 +39,22 @@ struct objdump_line_rb_node *objdump_line__rb(struct objdump_line *self)
 	return (struct objdump_line_rb_node *)(self + 1);
 }
 
+static bool objdump_line__filter(struct ui_browser *browser, void *entry)
+{
+	struct annotate_browser *ab = container_of(browser, struct annotate_browser, b);
+
+	if (ab->hide_src_code) {
+		struct objdump_line *ol = list_entry(entry, struct objdump_line, node);
+		return ol->offset == -1;
+	}
+
+	return false;
+}
+
 static void annotate_browser__write(struct ui_browser *self, void *entry, int row)
 {
 	struct annotate_browser *ab = container_of(self, struct annotate_browser, b);
-	struct objdump_line *ol = rb_entry(entry, struct objdump_line, node);
+	struct objdump_line *ol = list_entry(entry, struct objdump_line, node);
 	bool current_entry = ui_browser__is_current_entry(self, row);
 	int width = self->width;
 
@@ -168,6 +184,45 @@ static void annotate_browser__calc_percent(struct annotate_browser *browser,
 	browser->curr_hot = rb_last(&browser->entries);
 }
 
+static bool annotate_browser__toggle_source(struct annotate_browser *browser)
+{
+	struct objdump_line *ol;
+	struct objdump_line_rb_node *olrb;
+	off_t offset = browser->b.index - browser->b.top_idx;
+
+	browser->b.seek(&browser->b, offset, SEEK_CUR);
+	ol = list_entry(browser->b.top, struct objdump_line, node);
+	olrb = objdump_line__rb(ol);
+
+	if (browser->hide_src_code) {
+		if (olrb->idx_asm < offset)
+			offset = olrb->idx;
+
+		browser->b.nr_entries = browser->nr_entries;
+		browser->hide_src_code = false;
+		browser->b.seek(&browser->b, -offset, SEEK_CUR);
+		browser->b.top_idx = olrb->idx - offset;
+		browser->b.index = olrb->idx;
+	} else {
+		if (olrb->idx_asm < 0) {
+			ui_helpline__puts("Only available for assembly lines.");
+			browser->b.seek(&browser->b, -offset, SEEK_CUR);
+			return false;
+		}
+
+		if (olrb->idx_asm < offset)
+			offset = olrb->idx_asm;
+
+		browser->b.nr_entries = browser->nr_asm_entries;
+		browser->hide_src_code = true;
+		browser->b.seek(&browser->b, -offset, SEEK_CUR);
+		browser->b.top_idx = olrb->idx_asm - offset;
+		browser->b.index = olrb->idx_asm;
+	}
+
+	return true;
+}
+
 static int annotate_browser__run(struct annotate_browser *self, int evidx,
 				 int nr_events, void(*timer)(void *arg),
 				 void *arg, int delay_secs)
@@ -175,11 +230,12 @@ static int annotate_browser__run(struct annotate_browser *self, int evidx,
 	struct rb_node *nd = NULL;
 	struct map_symbol *ms = self->b.priv;
 	struct symbol *sym = ms->sym;
+	const char *help = "<-, ESC: exit, TAB/shift+TAB: cycle hottest lines, "
+			   "H: Hottest, -> Line action, S -> Toggle source "
+			   "code view";
 	int key;
 
-	if (ui_browser__show(&self->b, sym->name,
-			     "<- or ESC: exit, TAB/shift+TAB: "
-			     "cycle hottest lines, H: Hottest, -> Line action") < 0)
+	if (ui_browser__show(&self->b, sym->name, help) < 0)
 		return -1;
 
 	annotate_browser__calc_percent(self, evidx);
@@ -234,6 +290,10 @@ static int annotate_browser__run(struct annotate_browser *self, int evidx,
 		case 'H':
 			nd = self->curr_hot;
 			break;
+		case 'S':
+			if (annotate_browser__toggle_source(self))
+				ui_helpline__puts(help);
+			continue;
 		case NEWT_KEY_ENTER:
 		case NEWT_KEY_RIGHT:
 			if (self->selection == NULL) {
@@ -324,6 +384,7 @@ int symbol__tui_annotate(struct symbol *sym, struct map *map, int evidx,
 			.refresh = ui_browser__list_head_refresh,
 			.seek	 = ui_browser__list_head_seek,
 			.write	 = annotate_browser__write,
+			.filter  = objdump_line__filter,
 			.priv	 = &ms,
 		},
 	};
@@ -351,9 +412,14 @@ int symbol__tui_annotate(struct symbol *sym, struct map *map, int evidx,
 		if (browser.b.width < line_len)
 			browser.b.width = line_len;
 		rbpos = objdump_line__rb(pos);
-		rbpos->idx = browser.b.nr_entries++;
+		rbpos->idx = browser.nr_entries++;
+		if (pos->offset != -1)
+			rbpos->idx_asm = browser.nr_asm_entries++;
+		else
+			rbpos->idx_asm = -1;
 	}
 
+	browser.b.nr_entries = browser.nr_entries;
 	browser.b.entries = &notes->src->source,
 	browser.b.width += 18; /* Percentage */
 	ret = annotate_browser__run(&browser, evidx, nr_events,
-- 
1.6.2.5

[PATCH 5/5] perf buildid: Fix possible unterminated readlink() result buffer

[Arnaldo Carvalho de Melo]

From: Thomas Jarosch <thomas.jarosch@intra2net.com>

The readlink function doesn't guarantee that a '\0' will be put at the
end of the provided buffer if there is no space left.

No need to do "buf[len] = '\0';" since the buffer is allocated with
zalloc().

Link: http://lkml.kernel.org/r/4E986ABF.9040706@intra2net.com
Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/header.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
index f2ceb0f..2143a32 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -1289,7 +1289,7 @@ int build_id_cache__remove_s(const char *sbuild_id, const char *debugdir)
 	if (access(linkname, F_OK))
 		goto out_free;
 
-	if (readlink(linkname, filename, size) < 0)
+	if (readlink(linkname, filename, size - 1) < 0)
 		goto out_free;
 
 	if (unlink(linkname))
-- 
1.6.2.5

Re: [GIT PULL 0/5] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> Hi Ingo,
> 
>         Please consider pulling from:
> 
> git://github.com/acmel/linux.git perf/core
> 
> 	These are in addition to the ones you reported being problematic
> with perf top segfaulting sometimes, that problem should be fixed by the
> first patch below.
> 
> Regards,
> 
> - Arnaldo
> 
> Arnaldo Carvalho de Melo (4):
>   perf hists browser: Invalidate ui_browser->top after timer calls
>   perf annotate browser: Exit when pressing ESC or the left arrow
>   perf ui browser: Add filter method
>   perf annotate browser: Allow toggling the visualization of source code lines
> 
> Thomas Jarosch (1):
>   perf buildid: Fix possible unterminated readlink() result buffer
> 
>  tools/perf/util/header.c               |    2 +-
>  tools/perf/util/ui/browser.c           |   52 +++++++++++++++++----
>  tools/perf/util/ui/browser.h           |    1 +
>  tools/perf/util/ui/browsers/annotate.c |   78 +++++++++++++++++++++++++++++--
>  tools/perf/util/ui/browsers/hists.c    |   15 +++++-
>  5 files changed, 131 insertions(+), 17 deletions(-)

Pulled, thanks a lot Arnaldo!

The 'perf top' segfault is indeed fixed for me too.

Btw., i noticed another weirdness - sometimes after startup i get 
this message:

/lib64/libc-2.14.90.so was updated, restart the long running apps that use it!                          

but it was not updated recently:

 earth5:~/tip/tools/perf> ll /lib64/libc-2.14.90.so
 -rwxr-xr-x 1 root root 2062920 Sep 28 15:11 /lib64/libc-2.14.90.so
 earth5:~/tip/tools/perf> date
 Sat Oct 15 16:59:04 CEST 2011
 earth5:~/tip/tools/perf> uptime
  16:59:08 up 19 days, 21:35, 11 users,  load average: 7.77, 7.48, 3.81

Thanks,

	Ingo

Re: [GIT PULL 0/5] perf/core improvements and fixes

[David Ahern]

On 10/15/2011 08:59 AM, Ingo Molnar wrote:
> Btw., i noticed another weirdness - sometimes after startup i get 
> this message:
> 
> /lib64/libc-2.14.90.so was updated, restart the long running apps that use it!                          
> 
> but it was not updated recently:
> 
>  earth5:~/tip/tools/perf> ll /lib64/libc-2.14.90.so
>  -rwxr-xr-x 1 root root 2062920 Sep 28 15:11 /lib64/libc-2.14.90.so
>  earth5:~/tip/tools/perf> date
>  Sat Oct 15 16:59:04 CEST 2011
>  earth5:~/tip/tools/perf> uptime
>   16:59:08 up 19 days, 21:35, 11 users,  load average: 7.77, 7.48, 3.81

I got the impression that comment was relative to when the processes
were started versus prelink touching it. In your case the mod time of
libc is after the uptime of the box.

David

Re: [GIT PULL 0/5] perf/core improvements and fixes

[Ingo Molnar]

* David Ahern <dsahern@gmail.com> wrote:

> On 10/15/2011 08:59 AM, Ingo Molnar wrote:
> > Btw., i noticed another weirdness - sometimes after startup i get 
> > this message:
> > 
> > /lib64/libc-2.14.90.so was updated, restart the long running apps that use it!                          
> > 
> > but it was not updated recently:
> > 
> >  earth5:~/tip/tools/perf> ll /lib64/libc-2.14.90.so
> >  -rwxr-xr-x 1 root root 2062920 Sep 28 15:11 /lib64/libc-2.14.90.so
> >  earth5:~/tip/tools/perf> date
> >  Sat Oct 15 16:59:04 CEST 2011
> >  earth5:~/tip/tools/perf> uptime
> >   16:59:08 up 19 days, 21:35, 11 users,  load average: 7.77, 7.48, 3.81
> 
> I got the impression that comment was relative to when the 
> processes were started versus prelink touching it. In your case the 
> mod time of libc is after the uptime of the box.

Ok, that makes sense. Do we report this in perf report output as 
well?

Thanks,

	Ingo

Re: [GIT PULL 0/5] perf/core improvements and fixes

[David Ahern]

On 10/15/2011 11:04 AM, Ingo Molnar wrote:
> 
> * David Ahern <dsahern@gmail.com> wrote:
> 
>> On 10/15/2011 08:59 AM, Ingo Molnar wrote:
>>> Btw., i noticed another weirdness - sometimes after startup i get 
>>> this message:
>>>
>>> /lib64/libc-2.14.90.so was updated, restart the long running apps that use it!                          
>>>
>>> but it was not updated recently:
>>>
>>>  earth5:~/tip/tools/perf> ll /lib64/libc-2.14.90.so
>>>  -rwxr-xr-x 1 root root 2062920 Sep 28 15:11 /lib64/libc-2.14.90.so
>>>  earth5:~/tip/tools/perf> date
>>>  Sat Oct 15 16:59:04 CEST 2011
>>>  earth5:~/tip/tools/perf> uptime
>>>   16:59:08 up 19 days, 21:35, 11 users,  load average: 7.77, 7.48, 3.81
>>
>> I got the impression that comment was relative to when the 
>> processes were started versus prelink touching it. In your case the 
>> mod time of libc is after the uptime of the box.
> 
> Ok, that makes sense. Do we report this in perf report output as 
> well?

It should. The message comes from map__load() when it detects a deleted
mapping such as:

7f9e8d5c7000-7f9e8d5c8000 rw-p 0000c000 fd:02 1046947
 /lib64/libpam.so.0.82.2.#prelink#.cM3f72 (deleted)

I have removed prelink from most of my systems (managed to find one lone
server with the above).

David

> 
> Thanks,
> 
> 	Ingo

Re: [GIT PULL 0/5] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Em Sat, Oct 15, 2011 at 11:46:14AM -0600, David Ahern escreveu:
> 
> 
> On 10/15/2011 11:04 AM, Ingo Molnar wrote:
> > 
> > * David Ahern <dsahern@gmail.com> wrote:
> > 
> >> On 10/15/2011 08:59 AM, Ingo Molnar wrote:
> >>> Btw., i noticed another weirdness - sometimes after startup i get 
> >>> this message:
> >>>
> >>> /lib64/libc-2.14.90.so was updated, restart the long running apps that use it!                          
> >>>
> >>> but it was not updated recently:
> >>>
> >>>  earth5:~/tip/tools/perf> ll /lib64/libc-2.14.90.so
> >>>  -rwxr-xr-x 1 root root 2062920 Sep 28 15:11 /lib64/libc-2.14.90.so
> >>>  earth5:~/tip/tools/perf> date
> >>>  Sat Oct 15 16:59:04 CEST 2011
> >>>  earth5:~/tip/tools/perf> uptime
> >>>   16:59:08 up 19 days, 21:35, 11 users,  load average: 7.77, 7.48, 3.81
> >>
> >> I got the impression that comment was relative to when the 
> >> processes were started versus prelink touching it. In your case the 
> >> mod time of libc is after the uptime of the box.
> > 
> > Ok, that makes sense. Do we report this in perf report output as 
> > well?
> 
> It should. The message comes from map__load() when it detects a deleted
> mapping such as:
> 
> 7f9e8d5c7000-7f9e8d5c8000 rw-p 0000c000 fd:02 1046947
>  /lib64/libpam.so.0.82.2.#prelink#.cM3f72 (deleted)
> 
> I have removed prelink from most of my systems (managed to find one lone
> server with the above).

David,

	Can you send me a patch that clarifies this situation?

- Arnaldo

Re: [GIT PULL 0/5] perf/core improvements and fixes

[David Ahern]

On 10/15/2011 01:06 PM, Arnaldo Carvalho de Melo wrote:
>>
>> It should. The message comes from map__load() when it detects a deleted
>> mapping such as:
>>
>> 7f9e8d5c7000-7f9e8d5c8000 rw-p 0000c000 fd:02 1046947
>>  /lib64/libpam.so.0.82.2.#prelink#.cM3f72 (deleted)
>>
>> I have removed prelink from most of my systems (managed to find one lone
>> server with the above).
> 
> David,
> 
> 	Can you send me a patch that clarifies this situation?
> 
> - Arnaldo

Clarifies in what way? The code checks for "(deleted)" on the dso and
suggests a restart of the process.

David

Re: [GIT PULL 0/5] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Em Sat, Oct 15, 2011 at 01:09:32PM -0600, David Ahern escreveu:
> On 10/15/2011 01:06 PM, Arnaldo Carvalho de Melo wrote:
> >>
> >> It should. The message comes from map__load() when it detects a deleted
> >> mapping such as:
> >>
> >> 7f9e8d5c7000-7f9e8d5c8000 rw-p 0000c000 fd:02 1046947
> >>  /lib64/libpam.so.0.82.2.#prelink#.cM3f72 (deleted)
> >>
> >> I have removed prelink from most of my systems (managed to find one lone
> >> server with the above).
> > 
> > 	Can you send me a patch that clarifies this situation?
> 
> Clarifies in what way? The code checks for "(deleted)" on the dso and
> suggests a restart of the process.

Perhaps telling that prelinking is the reason, so that users that don't
recall updating anything understands the situation.

- Arnaldo

Re: [GIT PULL 0/5] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote:

> Em Sat, Oct 15, 2011 at 01:09:32PM -0600, David Ahern escreveu:
> > On 10/15/2011 01:06 PM, Arnaldo Carvalho de Melo wrote:
> > >>
> > >> It should. The message comes from map__load() when it detects a deleted
> > >> mapping such as:
> > >>
> > >> 7f9e8d5c7000-7f9e8d5c8000 rw-p 0000c000 fd:02 1046947
> > >>  /lib64/libpam.so.0.82.2.#prelink#.cM3f72 (deleted)
> > >>
> > >> I have removed prelink from most of my systems (managed to find one lone
> > >> server with the above).
> > > 
> > > 	Can you send me a patch that clarifies this situation?
> > 
> > Clarifies in what way? The code checks for "(deleted)" on the dso and
> > suggests a restart of the process.
> 
> Perhaps telling that prelinking is the reason, so that users that 
> don't recall updating anything understands the situation.

Yeah. I am certainly aware of prelinking yet it did not occur to me 
when i saw the message.

Thanks,

	Ingo

[GIT PULL 0/5] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

- Arnaldo

Test results at the end of this message, as usual.

The following changes since commit 11737ca9e3b9d84448fa405a80980aa9957bcee8:

  Merge tag 'perf-core-for-mingo-4.17-20180216' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2018-02-17 11:39:47 +0100)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.17-20180220

for you to fetch changes up to 66dfdff03d196e51322c6a85c0d8db8bb2bdd655:

  perf tools: Add Python 3 support (2018-02-19 12:28:23 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

- Initial support for linking with python3, by explicitely setting
  the PYTHON Makefile variable, python2 remains supported, more work
  needed to test the shipped python scripts used with 'perf script'
  (Jaroslav Škarvada)

- Make twatch.py, an example python script that sets up evlists and
  evsels to then parse events from mmap, to work with both python2 and
  python3 (Arnaldo Carvalho de Melo)

- Fix setting 'perf ftrace' function filter when using a non-existent
  function, which should result in an error instead of simply not setting
  the filter and showing all functions (Changbin Du)

- Fix paranoid check in machine__set_kernel_mmap(), problem introduced
  in previous perf/core batch (Namhyung Kim)

- Fix reading cpuid model information in s/390, ditto, also introduced
  in the previous perf/core batch (Thomas Richter)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
      perf python: Make twatch.py work with both python2 and python3

Changbin Du (1):
      perf ftrace: Append an EOL when write tracing files

Jaroslav Škarvada (1):
      perf tools: Add Python 3 support

Namhyung Kim (1):
      perf machine: Fix paranoid check in machine__set_kernel_mmap()

Thomas Richter (1):
      perf s390: Fix reading cpuid model information

 tools/perf/Makefile.config                         |  23 +---
 tools/perf/Makefile.perf                           |   4 +-
 tools/perf/arch/s390/util/header.c                 |   2 +-
 tools/perf/builtin-ftrace.c                        |  18 ++-
 tools/perf/python/twatch.py                        |   8 +-
 .../perf/scripts/python/Perf-Trace-Util/Context.c  |  34 ++++-
 tools/perf/util/machine.c                          |   2 +-
 tools/perf/util/python.c                           |  95 ++++++++++---
 .../util/scripting-engines/trace-event-python.c    | 147 +++++++++++++++------
 tools/perf/util/setup.py                           |   6 +-
 10 files changed, 243 insertions(+), 96 deletions(-)

Test results:

The first ones are container (docker) based builds of tools/perf with and
without libelf support.  Where clang is available, it is also used to build
perf with/without libelf.

The objtool and samples/bpf/ builds are disabled now that I'm switching from
using the sources in a local volume to fetching them from a http server to
build it inside the container, to make it easier to build in a container cluster.
Those will come back later.

Several are cross builds, the ones with -x-ARCH and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.

The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.

Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.

  Intel(R) Core(TM) i5-7500 CPU @ 3.40GHz
  # dm
   1  49.10 alpine:3.4                    : Ok   gcc (Alpine 5.3.0) 5.3.0
   2  51.30 alpine:3.5                    : Ok   gcc (Alpine 6.2.1) 6.2.1 20160822
   3  53.53 alpine:3.6                    : Ok   gcc (Alpine 6.3.0) 6.3.0
   4  54.74 alpine:edge                   : Ok   gcc (Alpine 6.4.0) 6.4.0
   5  41.38 amazonlinux:1                 : Ok   gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-11)
   6  58.50 amazonlinux:2                 : Ok   gcc (GCC) 7.2.1 20170915 (Red Hat 7.2.1-2)
   7  35.52 android-ndk:r12b-arm          : Ok   arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
   8  34.34 android-ndk:r15c-arm          : Ok   arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
   9  31.16 centos:5                      : Ok   gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55)
  10  40.51 centos:6                      : Ok   gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-18)
  11  50.00 centos:7                      : Ok   gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16)
  12  40.12 debian:7                      : Ok   gcc (Debian 4.7.2-5) 4.7.2
  13  41.64 debian:8                      : Ok   gcc (Debian 4.9.2-10+deb8u1) 4.9.2
  14  69.65 debian:9                      : Ok   gcc (Debian 6.3.0-18) 6.3.0 20170516
  15  91.07 debian:experimental           : Ok   gcc (Debian 7.2.0-18) 7.2.0
  16  48.13 debian:experimental-x-arm64   : Ok   aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
  17  41.69 debian:experimental-x-mips    : Ok   mips-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
  18  36.72 debian:experimental-x-mips64  : Ok   mips64-linux-gnuabi64-gcc (Debian 7.2.0-11) 7.2.0
  19  52.76 debian:experimental-x-mipsel  : Ok   mipsel-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
  20  49.01 fedora:20                     : Ok   gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7)
  21  54.99 fedora:21                     : Ok   gcc (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6)
  22  39.61 fedora:22                     : Ok   gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
  23  42.29 fedora:23                     : Ok   gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
  24  41.84 fedora:24                     : Ok   gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1)
  25  36.88 fedora:24-x-ARC-uClibc        : Ok   arc-linux-gcc (ARCompact ISA Linux uClibc toolchain 2017.09-rc2) 7.1.1 20170710
  26  78.12 fedora:25                     : Ok   gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1)
  27  80.48 fedora:26                     : Ok   gcc (GCC) 7.2.1 20170915 (Red Hat 7.2.1-2)
  28  81.00 fedora:27                     : Ok   gcc (GCC) 7.2.1 20170915 (Red Hat 7.2.1-2)
  29 115.57 fedora:rawhide                : Ok   gcc (GCC) 7.2.1 20170915 (Red Hat 7.2.1-4)
  30  42.70 gentoo-stage3-amd64:latest    : Ok   gcc (Gentoo 6.4.0-r1 p1.3) 6.4.0
  31  45.48 mageia:5                      : Ok   gcc (GCC) 4.9.2
  32  42.61 mageia:6                      : Ok   gcc (Mageia 5.4.0-5.mga6) 5.4.0
  33  42.05 opensuse:42.1                 : Ok   gcc (SUSE Linux) 4.8.5
  34  43.63 opensuse:42.2                 : Ok   gcc (SUSE Linux) 4.8.5
  35  47.48 opensuse:42.3                 : Ok   gcc (SUSE Linux) 4.8.5
  36  90.12 opensuse:tumbleweed           : Ok   gcc (SUSE Linux) 7.3.0
  37  35.32 oraclelinux:6                 : Ok   gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-18)
  38  41.55 oraclelinux:7                 : Ok   gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16)
  39  33.95 ubuntu:12.04.5                : Ok   gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
  40  39.13 ubuntu:14.04.4                : Ok   gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
  41  33.62 ubuntu:14.04.4-x-linaro-arm64 : Ok   aarch64-linux-gnu-gcc (Linaro GCC 5.5-2017.10) 5.5.0
  42  62.84 ubuntu:16.04                  : Ok   gcc (Ubuntu 5.4.0-6ubuntu1~16.04.6) 5.4.0 20160609
  43  38.41 ubuntu:16.04-x-arm            : Ok   arm-linux-gnueabihf-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
  44  41.31 ubuntu:16.04-x-arm64          : Ok   aarch64-linux-gnu-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
  45  40.18 ubuntu:16.04-x-powerpc        : Ok   powerpc-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
  46  35.83 ubuntu:16.04-x-powerpc64      : Ok   powerpc64-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.1) 5.4.0 20160609
  47  35.91 ubuntu:16.04-x-powerpc64el    : Ok   powerpc64le-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
  48  32.80 ubuntu:16.04-x-s390           : Ok   s390x-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
  49  65.42 ubuntu:16.10                  : Ok   gcc (Ubuntu 6.2.0-5ubuntu12) 6.2.0 20161005
  50  67.55 ubuntu:17.04                  : Ok   gcc (Ubuntu 6.3.0-12ubuntu2) 6.3.0 20170406
  51  68.25 ubuntu:17.10                  : Ok   gcc (Ubuntu 7.2.0-8ubuntu3) 7.2.0
  52  72.18 ubuntu:18.04                  : Ok   gcc (Ubuntu 7.3.0-3ubuntu1) 7.3.0
  # 

  # uname -a
  Linux jouet 4.16.0-rc2 #2 SMP Mon Feb 19 14:41:03 -03 2018 x86_64 x86_64 x86_64 GNU/Linux
  # perf test
   1: vmlinux symtab matches kallsyms                       : Ok
   2: Detect openat syscall event                           : Ok
   3: Detect openat syscall event on all cpus               : Ok
   4: Read samples using the mmap interface                 : Ok
   5: Test data source output                               : Ok
   6: Parse event definition strings                        : Ok
   7: Simple expression parser                              : Ok
   8: PERF_RECORD_* events & perf_sample fields             : Ok
   9: Parse perf pmu format                                 : Ok
  10: DSO data read                                         : Ok
  11: DSO data cache                                        : Ok
  12: DSO data reopen                                       : Ok
  13: Roundtrip evsel->name                                 : Ok
  14: Parse sched tracepoints fields                        : Ok
  15: syscalls:sys_enter_openat event fields                : Ok
  16: Setup struct perf_event_attr                          : Ok
  17: Match and link multiple hists                         : Ok
  18: 'import perf' in python                               : Ok
  19: Breakpoint overflow signal handler                    : Ok
  20: Breakpoint overflow sampling                          : Ok
  21: Number of exit events of a simple workload            : Ok
  22: Software clock events period values                   : Ok
  23: Object code reading                                   : Ok
  24: Sample parsing                                        : Ok
  25: Use a dummy software event to keep tracking           : Ok
  26: Parse with no sample_id_all bit set                   : Ok
  27: Filter hist entries                                   : Ok
  28: Lookup mmap thread                                    : Ok
  29: Share thread mg                                       : Ok
  30: Sort output of hist entries                           : Ok
  31: Cumulate child hist entries                           : Ok
  32: Track with sched_switch                               : Ok
  33: Filter fds with revents mask in a fdarray             : Ok
  34: Add fd to a fdarray, making it autogrow               : Ok
  35: kmod_path__parse                                      : Ok
  36: Thread map                                            : Ok
  37: LLVM search and compile                               :
  37.1: Basic BPF llvm compile                              : Ok
  37.2: kbuild searching                                    : Ok
  37.3: Compile source for BPF prologue generation          : Ok
  37.4: Compile source for BPF relocation                   : Ok
  38: Session topology                                      : Ok
  39: BPF filter                                            :
  39.1: Basic BPF filtering                                 : Ok
  39.2: BPF pinning                                         : Ok
  39.3: BPF prologue generation                             : Ok
  39.4: BPF relocation checker                              : Ok
  40: Synthesize thread map                                 : Ok
  41: Remove thread map                                     : Ok
  42: Synthesize cpu map                                    : Ok
  43: Synthesize stat config                                : Ok
  44: Synthesize stat                                       : Ok
  45: Synthesize stat round                                 : Ok
  46: Synthesize attr update                                : Ok
  47: Event times                                           : Ok
  48: Read backward ring buffer                             : Ok
  49: Print cpu map                                         : Ok
  50: Probe SDT events                                      : Ok
  51: is_printable_array                                    : Ok
  52: Print bitmap                                          : Ok
  53: perf hooks                                            : Ok
  54: builtin clang support                                 : Skip (not compiled in)
  55: unit_number__scnprintf                                : Ok
  56: x86 rdpmc                                             : Ok
  57: Convert perf time to TSC                              : Ok
  58: DWARF unwind                                          : Ok
  59: x86 instruction decoder - new instructions            : Ok
  60: Use vfs_getname probe to get syscall args filenames   : Ok
  61: probe libc's inet_pton & backtrace it with ping       : Ok
  62: Check open filename arg using perf trace + vfs_getname: Ok
  63: Add vfs_getname probe to get syscall args filenames   : Ok
  # 

  $ make -C tools/perf build-test
  make: Entering directory '/home/acme/git/perf/tools/perf'
  - tarpkg: ./tests/perf-targz-src-pkg .
   make_install_prefix_slash_O: make install prefix=/tmp/krava/
              make_no_libelf_O: make NO_LIBELF=1
               make_no_slang_O: make NO_SLANG=1
        make_with_babeltrace_O: make LIBBABELTRACE=1
                make_install_O: make install
              make_no_libbpf_O: make NO_LIBBPF=1
                   make_pure_O: make
  make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
           make_no_backtrace_O: make NO_BACKTRACE=1
            make_no_demangle_O: make NO_DEMANGLE=1
                   make_tags_O: make tags
             make_no_libperl_O: make NO_LIBPERL=1
         make_with_clangllvm_O: make LIBCLANGLLVM=1
           make_no_libunwind_O: make NO_LIBUNWIND=1
           make_no_libbionic_O: make NO_LIBBIONIC=1
                make_no_newt_O: make NO_NEWT=1
           make_no_libpython_O: make NO_LIBPYTHON=1
              make_clean_all_O: make clean all
            make_no_libaudit_O: make NO_LIBAUDIT=1
                 make_static_O: make LDFLAGS=-static
                    make_doc_O: make doc
                make_no_gtk2_O: make NO_GTK2=1
         make_install_prefix_O: make install prefix=/tmp/krava
            make_no_auxtrace_O: make NO_AUXTRACE=1
       make_util_pmu_bison_o_O: make util/pmu-bison.o
                   make_help_O: make help
             make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
                  make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
            make_install_bin_O: make install-bin
                make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
             make_util_map_o_O: make util/map.o
                  make_debug_O: make DEBUG=1
             make_no_libnuma_O: make NO_LIBNUMA=1
                 make_perf_o_O: make perf.o
  OK
  make: Leaving directory '/home/acme/git/perf/tools/perf'
  $

Re: [GIT PULL 0/5] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> Test results at the end of this message, as usual.
> 
> The following changes since commit 11737ca9e3b9d84448fa405a80980aa9957bcee8:
> 
>   Merge tag 'perf-core-for-mingo-4.17-20180216' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2018-02-17 11:39:47 +0100)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.17-20180220
> 
> for you to fetch changes up to 66dfdff03d196e51322c6a85c0d8db8bb2bdd655:
> 
>   perf tools: Add Python 3 support (2018-02-19 12:28:23 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> - Initial support for linking with python3, by explicitely setting
>   the PYTHON Makefile variable, python2 remains supported, more work
>   needed to test the shipped python scripts used with 'perf script'
>   (Jaroslav Škarvada)
> 
> - Make twatch.py, an example python script that sets up evlists and
>   evsels to then parse events from mmap, to work with both python2 and
>   python3 (Arnaldo Carvalho de Melo)
> 
> - Fix setting 'perf ftrace' function filter when using a non-existent
>   function, which should result in an error instead of simply not setting
>   the filter and showing all functions (Changbin Du)
> 
> - Fix paranoid check in machine__set_kernel_mmap(), problem introduced
>   in previous perf/core batch (Namhyung Kim)
> 
> - Fix reading cpuid model information in s/390, ditto, also introduced
>   in the previous perf/core batch (Thomas Richter)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
>       perf python: Make twatch.py work with both python2 and python3
> 
> Changbin Du (1):
>       perf ftrace: Append an EOL when write tracing files
> 
> Jaroslav Škarvada (1):
>       perf tools: Add Python 3 support
> 
> Namhyung Kim (1):
>       perf machine: Fix paranoid check in machine__set_kernel_mmap()
> 
> Thomas Richter (1):
>       perf s390: Fix reading cpuid model information
> 
>  tools/perf/Makefile.config                         |  23 +---
>  tools/perf/Makefile.perf                           |   4 +-
>  tools/perf/arch/s390/util/header.c                 |   2 +-
>  tools/perf/builtin-ftrace.c                        |  18 ++-
>  tools/perf/python/twatch.py                        |   8 +-
>  .../perf/scripts/python/Perf-Trace-Util/Context.c  |  34 ++++-
>  tools/perf/util/machine.c                          |   2 +-
>  tools/perf/util/python.c                           |  95 ++++++++++---
>  .../util/scripting-engines/trace-event-python.c    | 147 +++++++++++++++------
>  tools/perf/util/setup.py                           |   6 +-
>  10 files changed, 243 insertions(+), 96 deletions(-)

Pulled, thanks a lot Arnaldo!

	Ingo

[GIT PULL 0/5] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit 43e41adc9e8c36545888d78fed2ef8d102a938dc:

  perf record: Add ability to sample call branches (2015-10-20 10:30:55 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo

for you to fetch changes up to e3d006ce8180a0c025ce66bdc89bbc125f85be57:

  perf annotate: Add debug message for out of bounds sample (2015-10-21 18:12:37 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

User visible:

- Print branch filter state with verbose mode (Andi Kleen)

- Fix core dump caused by per-socket/core system-wide stat (Kan Liang)

- Update libtraceevent KVM plugin (Paolo Bonzini)

Developer stuff:

- Add fixdep to 'tools/build' .gitignore (Yunlong Song)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Andi Kleen (1):
      perf evsel: Print branch filter state with -vv

Arnaldo Carvalho de Melo (1):
      perf annotate: Add debug message for out of bounds sample

Kan Liang (1):
      perf cpu_map: Fix core dump caused by per-socket/core system-wide stat

Paolo Bonzini (1):
      tools lib traceevent: update KVM plugin

Yunlong Song (1):
      perf build: Add fixdep to .gitignore

 tools/build/.gitignore            |  1 +
 tools/lib/traceevent/plugin_kvm.c | 25 +++++++++++++++++--------
 tools/perf/util/annotate.c        |  5 ++++-
 tools/perf/util/cpumap.c          |  2 +-
 tools/perf/util/evsel.c           |  1 +
 5 files changed, 24 insertions(+), 10 deletions(-)
 create mode 100644 tools/build/.gitignore

Re: [GIT PULL 0/5] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> The following changes since commit 43e41adc9e8c36545888d78fed2ef8d102a938dc:
> 
>   perf record: Add ability to sample call branches (2015-10-20 10:30:55 +0200)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
> 
> for you to fetch changes up to e3d006ce8180a0c025ce66bdc89bbc125f85be57:
> 
>   perf annotate: Add debug message for out of bounds sample (2015-10-21 18:12:37 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> User visible:
> 
> - Print branch filter state with verbose mode (Andi Kleen)
> 
> - Fix core dump caused by per-socket/core system-wide stat (Kan Liang)
> 
> - Update libtraceevent KVM plugin (Paolo Bonzini)
> 
> Developer stuff:
> 
> - Add fixdep to 'tools/build' .gitignore (Yunlong Song)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Andi Kleen (1):
>       perf evsel: Print branch filter state with -vv
> 
> Arnaldo Carvalho de Melo (1):
>       perf annotate: Add debug message for out of bounds sample
> 
> Kan Liang (1):
>       perf cpu_map: Fix core dump caused by per-socket/core system-wide stat
> 
> Paolo Bonzini (1):
>       tools lib traceevent: update KVM plugin
> 
> Yunlong Song (1):
>       perf build: Add fixdep to .gitignore
> 
>  tools/build/.gitignore            |  1 +
>  tools/lib/traceevent/plugin_kvm.c | 25 +++++++++++++++++--------
>  tools/perf/util/annotate.c        |  5 ++++-
>  tools/perf/util/cpumap.c          |  2 +-
>  tools/perf/util/evsel.c           |  1 +
>  5 files changed, 24 insertions(+), 10 deletions(-)
>  create mode 100644 tools/build/.gitignore

Pulled, thanks a lot Arnaldo!

	Ingo

[GIT PULL 0/5] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit 712df65ccb63da08a484bf57c40b250dfd4103a7:

  perf/x86/intel/uncore: Fix multi-segment problem of perf_event_intel_uncore (2015-10-06 17:31:51 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo

for you to fetch changes up to ae938802443732e77d01f8d5b52b900b9327ff30:

  perf python: Support the PERF_RECORD_SWITCH event (2015-10-07 19:41:50 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

User visible:

- Adding a field via 'perf report -F' that already is enabled makes
  the tool get stuck in a loop, fix it (Jiri Olsa)

Infrastructure:

- Support PERF_RECORD_SWITCH in the python binding (Arnaldo Carvalho de Melo)

- Fix handling read() result using a signed variable, found with Coccinelle
  (Andrzej Hajda)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Andrzej Hajda (1):
      perf tools: Fix handling read result using a signed variable

Arnaldo Carvalho de Melo (1):
      perf python: Support the PERF_RECORD_SWITCH event

Jiri Olsa (3):
      perf tools: Get rid of superfluos call to reset_dimensions
      perf tools: Introduce hpp_dimension__add_output function
      perf tools: Use hpp_dimension__add_output to register hpp columns

 tools/perf/python/twatch.py | 23 +++++++++++++++---
 tools/perf/ui/hist.c        | 16 ++++++------
 tools/perf/util/event.c     |  3 ++-
 tools/perf/util/python.c    | 59 ++++++++++++++++++++++++++++++++++++++++++---
 tools/perf/util/sort.c      |  8 ++++--
 tools/perf/util/sort.h      |  2 ++
 6 files changed, 93 insertions(+), 18 deletions(-)

[GIT PULL 0/5] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

Best regards,

- Arnaldo

The following changes since commit 066450be419fa48007a9f29e19828f2a86198754:

  perf/x86/intel/pt: Clean up the control flow in pt_pmu_hw_init() (2015-04-12 11:21:15 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo

for you to fetch changes up to be8d5b1c6b468d10bd2928bbd1a5ca3fd2980402:

  perf probe: Fix segfault when probe with lazy_line to file (2015-04-13 17:59:41 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

New features:

- Analyze page allocator events also in 'perf kmem' (Namhyung Kim)

User visible fixes:

- Fix retprobe 'perf probe' handling when failing to find needed debuginfo (He Kuang)

- lazy_line probe fixes in 'perf probe' (He Kuang)

Infrastructure:

- Record pfn instead of pointer to struct page in tracepoints (Namhyung Kim)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
He Kuang (3):
      perf probe: Set retprobe flag when probe in address-based alternative mode
      perf probe: Make --source avaiable when probe with lazy_line
      perf probe: Fix segfault when probe with lazy_line to file

Namhyung Kim (2):
      tracing, mm: Record pfn instead of pointer to struct page
      perf kmem: Analyze page allocator events also

 include/trace/events/filemap.h         |   8 +-
 include/trace/events/kmem.h            |  42 +--
 include/trace/events/vmscan.h          |   8 +-
 tools/perf/Documentation/perf-kmem.txt |   8 +-
 tools/perf/builtin-kmem.c              | 500 +++++++++++++++++++++++++++++++--
 tools/perf/util/probe-event.c          |   3 +-
 tools/perf/util/probe-event.h          |   2 +
 tools/perf/util/probe-finder.c         |  20 +-
 8 files changed, 540 insertions(+), 51 deletions(-)

Re: [GIT PULL 0/5] perf/core improvements and fixes

[Masami Hiramatsu]

Hi, Arnaldo,

>       perf probe: Make --source avaiable when probe with lazy_line

No, could you pull Naohiro's patch?
I'd like to move get_real_path to probe_finder.c

Thank you,

(2015/04/14 7:14), Arnaldo Carvalho de Melo wrote:
> Hi Ingo,
> 
> 	Please consider pulling,
> 
> Best regards,
> 
> - Arnaldo
> 
> The following changes since commit 066450be419fa48007a9f29e19828f2a86198754:
> 
>   perf/x86/intel/pt: Clean up the control flow in pt_pmu_hw_init() (2015-04-12 11:21:15 +0200)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
> 
> for you to fetch changes up to be8d5b1c6b468d10bd2928bbd1a5ca3fd2980402:
> 
>   perf probe: Fix segfault when probe with lazy_line to file (2015-04-13 17:59:41 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> New features:
> 
> - Analyze page allocator events also in 'perf kmem' (Namhyung Kim)
> 
> User visible fixes:
> 
> - Fix retprobe 'perf probe' handling when failing to find needed debuginfo (He Kuang)
> 
> - lazy_line probe fixes in 'perf probe' (He Kuang)
> 
> Infrastructure:
> 
> - Record pfn instead of pointer to struct page in tracepoints (Namhyung Kim)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> He Kuang (3):
>       perf probe: Set retprobe flag when probe in address-based alternative mode
>       perf probe: Make --source avaiable when probe with lazy_line
>       perf probe: Fix segfault when probe with lazy_line to file
> 
> Namhyung Kim (2):
>       tracing, mm: Record pfn instead of pointer to struct page
>       perf kmem: Analyze page allocator events also
> 
>  include/trace/events/filemap.h         |   8 +-
>  include/trace/events/kmem.h            |  42 +--
>  include/trace/events/vmscan.h          |   8 +-
>  tools/perf/Documentation/perf-kmem.txt |   8 +-
>  tools/perf/builtin-kmem.c              | 500 +++++++++++++++++++++++++++++++--
>  tools/perf/util/probe-event.c          |   3 +-
>  tools/perf/util/probe-event.h          |   2 +
>  tools/perf/util/probe-finder.c         |  20 +-
>  8 files changed, 540 insertions(+), 51 deletions(-)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 


-- 
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: masami.hiramatsu.pt@hitachi.com

Re: [GIT PULL 0/5] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Em Tue, Apr 14, 2015 at 07:33:07AM +0900, Masami Hiramatsu escreveu:
> Hi, Arnaldo,
> 
> >       perf probe: Make --source avaiable when probe with lazy_line
> 
> No, could you pull Naohiro's patch?
> I'd like to move get_real_path to probe_finder.c

OOps, yeah, you asked for that... Ingo, please ignore this pull request
for now, thanks,

- Arnaldo
 
> Thank you,
> 
> (2015/04/14 7:14), Arnaldo Carvalho de Melo wrote:
> > Hi Ingo,
> > 
> > 	Please consider pulling,
> > 
> > Best regards,
> > 
> > - Arnaldo
> > 
> > The following changes since commit 066450be419fa48007a9f29e19828f2a86198754:
> > 
> >   perf/x86/intel/pt: Clean up the control flow in pt_pmu_hw_init() (2015-04-12 11:21:15 +0200)
> > 
> > are available in the git repository at:
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
> > 
> > for you to fetch changes up to be8d5b1c6b468d10bd2928bbd1a5ca3fd2980402:
> > 
> >   perf probe: Fix segfault when probe with lazy_line to file (2015-04-13 17:59:41 -0300)
> > 
> > ----------------------------------------------------------------
> > perf/core improvements and fixes:
> > 
> > New features:
> > 
> > - Analyze page allocator events also in 'perf kmem' (Namhyung Kim)
> > 
> > User visible fixes:
> > 
> > - Fix retprobe 'perf probe' handling when failing to find needed debuginfo (He Kuang)
> > 
> > - lazy_line probe fixes in 'perf probe' (He Kuang)
> > 
> > Infrastructure:
> > 
> > - Record pfn instead of pointer to struct page in tracepoints (Namhyung Kim)
> > 
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> > 
> > ----------------------------------------------------------------
> > He Kuang (3):
> >       perf probe: Set retprobe flag when probe in address-based alternative mode
> >       perf probe: Make --source avaiable when probe with lazy_line
> >       perf probe: Fix segfault when probe with lazy_line to file
> > 
> > Namhyung Kim (2):
> >       tracing, mm: Record pfn instead of pointer to struct page
> >       perf kmem: Analyze page allocator events also
> > 
> >  include/trace/events/filemap.h         |   8 +-
> >  include/trace/events/kmem.h            |  42 +--
> >  include/trace/events/vmscan.h          |   8 +-
> >  tools/perf/Documentation/perf-kmem.txt |   8 +-
> >  tools/perf/builtin-kmem.c              | 500 +++++++++++++++++++++++++++++++--
> >  tools/perf/util/probe-event.c          |   3 +-
> >  tools/perf/util/probe-event.h          |   2 +
> >  tools/perf/util/probe-finder.c         |  20 +-
> >  8 files changed, 540 insertions(+), 51 deletions(-)
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> > 
> > 
> 
> 
> -- 
> Masami HIRAMATSU
> Linux Technology Research Center, System Productivity Research Dept.
> Center for Technology Innovation - Systems Engineering
> Hitachi, Ltd., Research & Development Group
> E-mail: masami.hiramatsu.pt@hitachi.com
> 

Re: [GIT PULL 0/5] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Em Mon, Apr 13, 2015 at 08:09:23PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Apr 14, 2015 at 07:33:07AM +0900, Masami Hiramatsu escreveu:
> > Hi, Arnaldo,
> > 
> > >       perf probe: Make --source avaiable when probe with lazy_line
> > 
> > No, could you pull Naohiro's patch?
> > I'd like to move get_real_path to probe_finder.c
> 
> OOps, yeah, you asked for that... Ingo, please ignore this pull request
> for now, thanks,

Ok, I did that and created a perf-core-for-mingo-2, Masami, please check
that all is right, ok?

- Arnaldo

The following changes since commit 066450be419fa48007a9f29e19828f2a86198754:

  perf/x86/intel/pt: Clean up the control flow in pt_pmu_hw_init() (2015-04-12 11:21:15 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-2

for you to fetch changes up to f19e80c640d58ddfd70f2454ee597f81ba966690:

  perf probe: Fix segfault when probe with lazy_line to file (2015-04-13 20:12:21 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

New features:

- Analyze page allocator events also in 'perf kmem' (Namhyung Kim)

User visible fixes:

- Fix retprobe 'perf probe' handling when failing to find needed debuginfo (He Kuang)

- lazy_line probe fixes in 'perf probe' (Naohiro Aota, He Kuang)

Infrastructure:

- Record pfn instead of pointer to struct page in tracepoints (Namhyung Kim)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
He Kuang (2):
      perf probe: Set retprobe flag when probe in address-based alternative mode
      perf probe: Fix segfault when probe with lazy_line to file

Namhyung Kim (2):
      tracing, mm: Record pfn instead of pointer to struct page
      perf kmem: Analyze page allocator events also

Naohiro Aota (1):
      perf probe: Find compilation directory path for lazy matching

 include/trace/events/filemap.h         |   8 +-
 include/trace/events/kmem.h            |  42 +--
 include/trace/events/vmscan.h          |   8 +-
 tools/perf/Documentation/perf-kmem.txt |   8 +-
 tools/perf/builtin-kmem.c              | 500 +++++++++++++++++++++++++++++++--
 tools/perf/util/probe-event.c          |  60 +---
 tools/perf/util/probe-finder.c         |  73 ++++-
 tools/perf/util/probe-finder.h         |   4 +
 8 files changed, 596 insertions(+), 107 deletions(-)

Re: [GIT PULL 0/5] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Em Mon, Apr 13, 2015 at 08:09:23PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Tue, Apr 14, 2015 at 07:33:07AM +0900, Masami Hiramatsu escreveu:
> > > Hi, Arnaldo,
> > > 
> > > >       perf probe: Make --source avaiable when probe with lazy_line
> > > 
> > > No, could you pull Naohiro's patch?
> > > I'd like to move get_real_path to probe_finder.c
> > 
> > OOps, yeah, you asked for that... Ingo, please ignore this pull request
> > for now, thanks,
> 
> Ok, I did that and created a perf-core-for-mingo-2, Masami, please check
> that all is right, ok?
> 
> - Arnaldo
> 
> The following changes since commit 066450be419fa48007a9f29e19828f2a86198754:
> 
>   perf/x86/intel/pt: Clean up the control flow in pt_pmu_hw_init() (2015-04-12 11:21:15 +0200)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-2
> 
> for you to fetch changes up to f19e80c640d58ddfd70f2454ee597f81ba966690:
> 
>   perf probe: Fix segfault when probe with lazy_line to file (2015-04-13 20:12:21 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> New features:
> 
> - Analyze page allocator events also in 'perf kmem' (Namhyung Kim)
> 
> User visible fixes:
> 
> - Fix retprobe 'perf probe' handling when failing to find needed debuginfo (He Kuang)
> 
> - lazy_line probe fixes in 'perf probe' (Naohiro Aota, He Kuang)
> 
> Infrastructure:
> 
> - Record pfn instead of pointer to struct page in tracepoints (Namhyung Kim)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> He Kuang (2):
>       perf probe: Set retprobe flag when probe in address-based alternative mode
>       perf probe: Fix segfault when probe with lazy_line to file
> 
> Namhyung Kim (2):
>       tracing, mm: Record pfn instead of pointer to struct page
>       perf kmem: Analyze page allocator events also
> 
> Naohiro Aota (1):
>       perf probe: Find compilation directory path for lazy matching
> 
>  include/trace/events/filemap.h         |   8 +-
>  include/trace/events/kmem.h            |  42 +--
>  include/trace/events/vmscan.h          |   8 +-
>  tools/perf/Documentation/perf-kmem.txt |   8 +-
>  tools/perf/builtin-kmem.c              | 500 +++++++++++++++++++++++++++++++--
>  tools/perf/util/probe-event.c          |  60 +---
>  tools/perf/util/probe-finder.c         |  73 ++++-
>  tools/perf/util/probe-finder.h         |   4 +
>  8 files changed, 596 insertions(+), 107 deletions(-)

Pulled, thanks a lot Arnaldo!

	Ingo

[GIT PULL 0/5] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit 691286b5561aab2e1b00119bc328598c01250548:

  kprobes/x86: Remove stale ARCH_SUPPORTS_KPROBES_ON_FTRACE define (2014-10-17 07:18:34 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo

for you to fetch changes up to e8564b710c6df2c3aeb56c507c22f4bcfa4c0b2d:

  perf script: Add period as a default output column (2014-10-17 15:22:19 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

User visible:

o Add period data column and make it default in 'perf script' (Jiri Olsa)

Infrastructure:

* Move exit stuff from perf_evsel__delete to perf_evsel__exit, delete
  should be just a front end for exit + free (Arnaldo Carvalho de Melo)

* Add missing 'struct option' forward declaration (Arnaldo Carvalho de Melo)

* No need to drag util/cgroup.h into evsel.h (Arnaldo Carvalho de Melo)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Arnaldo Carvalho de Melo (3):
      perf evsel: Move exit stuff from __delete to __exit
      perf evlist: Add missing 'struct option' forward declaration
      perf evsel: No need to drag util/cgroup.h

Jiri Olsa (2):
      perf script: Add period data column
      perf script: Add period as a default output column

 tools/perf/Documentation/perf-script.txt |  2 +-
 tools/perf/builtin-record.c              |  1 +
 tools/perf/builtin-script.c              | 21 +++++++++++++++++----
 tools/perf/builtin-stat.c                |  1 +
 tools/perf/util/evlist.h                 |  2 ++
 tools/perf/util/evsel.c                  | 11 ++++++-----
 tools/perf/util/evsel.h                  |  3 ++-
 7 files changed, 30 insertions(+), 11 deletions(-)

Re: [GIT PULL 0/5] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> The following changes since commit 691286b5561aab2e1b00119bc328598c01250548:
> 
>   kprobes/x86: Remove stale ARCH_SUPPORTS_KPROBES_ON_FTRACE define (2014-10-17 07:18:34 +0200)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
> 
> for you to fetch changes up to e8564b710c6df2c3aeb56c507c22f4bcfa4c0b2d:
> 
>   perf script: Add period as a default output column (2014-10-17 15:22:19 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> User visible:
> 
> o Add period data column and make it default in 'perf script' (Jiri Olsa)
> 
> Infrastructure:
> 
> * Move exit stuff from perf_evsel__delete to perf_evsel__exit, delete
>   should be just a front end for exit + free (Arnaldo Carvalho de Melo)
> 
> * Add missing 'struct option' forward declaration (Arnaldo Carvalho de Melo)
> 
> * No need to drag util/cgroup.h into evsel.h (Arnaldo Carvalho de Melo)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (3):
>       perf evsel: Move exit stuff from __delete to __exit
>       perf evlist: Add missing 'struct option' forward declaration
>       perf evsel: No need to drag util/cgroup.h
> 
> Jiri Olsa (2):
>       perf script: Add period data column
>       perf script: Add period as a default output column
> 
>  tools/perf/Documentation/perf-script.txt |  2 +-
>  tools/perf/builtin-record.c              |  1 +
>  tools/perf/builtin-script.c              | 21 +++++++++++++++++----
>  tools/perf/builtin-stat.c                |  1 +
>  tools/perf/util/evlist.h                 |  2 ++
>  tools/perf/util/evsel.c                  | 11 ++++++-----
>  tools/perf/util/evsel.h                  |  3 ++-
>  7 files changed, 30 insertions(+), 11 deletions(-)

Pulled, thanks a lot Arnaldo!

	Ingo

[GIT PULL 0/5] perf/core improvements and fixes

[Jiri Olsa]

hi Ingo,
please consider pulling

thanks,
jirka

The following changes since commit 1c92f88542faa3ae4f970c548b4fe8275a45201b:

  Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf into perf/core (2014-06-25 07:44:19 +0200)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-core-for-mingo

for you to fetch changes up to 8ac631cd502d6b31fd29f6d019305305b479fa3e:

  perf script: Handle the num array type in python properly (2014-06-27 11:15:02 +0200)

----------------------------------------------------------------
perf/core improvements and fixes:

. Handle the num array type in python properly (Sebastian Andrzej Siewior)

. Fix wrong condition for allocation failure (Jiri Olsa)

. Adjust callchain based on DWARF debug info on powerpc (Sukadev Bhattiprolu)

. Fix a risk for doing free on uninitialized pointer in traceevent lib (Rickard Strandqvist)

Signed-off-by: Jiri Olsa <jolsa@kernel.org>

----------------------------------------------------------------
Jiri Olsa (1):
      perf tools: Fix wrong condition for allocation failure

Rickard Strandqvist (1):
      tools lib traceevent: Fix a risk for doing free on uninitialized pointer

Sebastian Andrzej Siewior (2):
      perf script: Move the number processing into its own function
      perf script: Handle the num array type in python properly

Sukadev Bhattiprolu (1):
      perf tools powerpc: Adjust callchain based on DWARF debug info

 tools/lib/traceevent/event-parse.c                 |   6 +-
 tools/perf/arch/powerpc/Makefile                   |   1 +
 tools/perf/arch/powerpc/util/skip-callchain-idx.c  | 266 +++++++++++++++++++++
 tools/perf/builtin-stat.c                          |   2 +-
 tools/perf/config/Makefile                         |   4 +
 tools/perf/util/callchain.h                        |  13 +
 tools/perf/util/machine.c                          |  18 +-
 .../util/scripting-engines/trace-event-python.c    |  57 +++--
 8 files changed, 346 insertions(+), 21 deletions(-)
 create mode 100644 tools/perf/arch/powerpc/util/skip-callchain-idx.c

Re: [GIT PULL 0/5] perf/core improvements and fixes

[Ingo Molnar]

* Jiri Olsa <jolsa@kernel.org> wrote:

> hi Ingo,
> please consider pulling
> 
> thanks,
> jirka
> 
> The following changes since commit 1c92f88542faa3ae4f970c548b4fe8275a45201b:
> 
>   Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf into perf/core (2014-06-25 07:44:19 +0200)
> 
> are available in the git repository at:
> 
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-core-for-mingo
> 
> for you to fetch changes up to 8ac631cd502d6b31fd29f6d019305305b479fa3e:
> 
>   perf script: Handle the num array type in python properly (2014-06-27 11:15:02 +0200)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> . Handle the num array type in python properly (Sebastian Andrzej Siewior)
> 
> . Fix wrong condition for allocation failure (Jiri Olsa)
> 
> . Adjust callchain based on DWARF debug info on powerpc (Sukadev Bhattiprolu)
> 
> . Fix a risk for doing free on uninitialized pointer in traceevent lib (Rickard Strandqvist)
> 
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> 
> ----------------------------------------------------------------
> Jiri Olsa (1):
>       perf tools: Fix wrong condition for allocation failure
> 
> Rickard Strandqvist (1):
>       tools lib traceevent: Fix a risk for doing free on uninitialized pointer
> 
> Sebastian Andrzej Siewior (2):
>       perf script: Move the number processing into its own function
>       perf script: Handle the num array type in python properly
> 
> Sukadev Bhattiprolu (1):
>       perf tools powerpc: Adjust callchain based on DWARF debug info
> 
>  tools/lib/traceevent/event-parse.c                 |   6 +-
>  tools/perf/arch/powerpc/Makefile                   |   1 +
>  tools/perf/arch/powerpc/util/skip-callchain-idx.c  | 266 +++++++++++++++++++++
>  tools/perf/builtin-stat.c                          |   2 +-
>  tools/perf/config/Makefile                         |   4 +
>  tools/perf/util/callchain.h                        |  13 +
>  tools/perf/util/machine.c                          |  18 +-
>  .../util/scripting-engines/trace-event-python.c    |  57 +++--
>  8 files changed, 346 insertions(+), 21 deletions(-)
>  create mode 100644 tools/perf/arch/powerpc/util/skip-callchain-idx.c

Pulled, thanks a lot Jiri!

	Ingo

[GIT PULL 0/5] perf/core improvements and fixes

[Jiri Olsa]

hi Ingo,
please consider pulling

thanks,
jirka


The following changes since commit 37b6cb475a6d74bc047c53bc323d6eb3113e27a4:

  Merge branch 'uprobes/core' of git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc into perf/core (2014-04-18 09:49:14 +0200)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-core-for-mingo

for you to fetch changes up to a651d9357f936a19ae811a29d031224cdb8c2f1f:

  perf callchain: Add generic report parse callchain callback function (2014-04-18 11:56:59 +0200)

----------------------------------------------------------------
perf/core improvements and fixes:

Developer stuff:

. Making some code (cpu node map and report parse callchain callback) global
  to be usable by upcomming changes (Don Zickus)

. Fix pmu object compilation error (Jiri Olsa)

----------------------------------------------------------------
Don Zickus (4):
      perf tools: Allow ability to map cpus to nodes easily
      perf tools: Use cpu/possible instead of cpu/kernel_max
      perf kmem: Utilize the new generic cpunode_map
      perf callchain: Add generic report parse callchain callback function

Jiri Olsa (1):
      perf tools: Fix pmu object compilation error

 tools/perf/builtin-kmem.c   |  78 +----------------------
 tools/perf/builtin-report.c |  81 +-----------------------
 tools/perf/util/callchain.c |  82 ++++++++++++++++++++++++
 tools/perf/util/callchain.h |   1 +
 tools/perf/util/cpumap.c    | 147 ++++++++++++++++++++++++++++++++++++++++++++
 tools/perf/util/cpumap.h    |  35 +++++++++++
 tools/perf/util/pmu.c       |   6 +-
 7 files changed, 274 insertions(+), 156 deletions(-)

[GIT PULL 0/5] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

        Please consider pulling from:

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core

Regards,

- Arnaldo

Arnaldo Carvalho de Melo (4):
  perf python: Add cgroup.c to setup.py to get it building again
  perf hists: Print number of samples, not the period sum
  perf record: Delay setting the header writing atexit call
  perf report: Tell the user when a perf.data file has no samples

Stephane Eranian (1):
  perf: make perf stat print user provided full event names

 tools/perf/builtin-record.c    |   10 +++++-----
 tools/perf/builtin-report.c    |    6 ++++++
 tools/perf/util/evsel.c        |    1 +
 tools/perf/util/evsel.h        |    7 +++++++
 tools/perf/util/hist.c         |    7 +++++--
 tools/perf/util/parse-events.c |   10 ++++++++++
 tools/perf/util/setup.py       |    2 +-
 7 files changed, 35 insertions(+), 8 deletions(-)

Re: [GIT PULL 0/5] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> Hi Ingo,
> 
>         Please consider pulling from:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core
> 
> Regards,
> 
> - Arnaldo
> 
> Arnaldo Carvalho de Melo (4):
>   perf python: Add cgroup.c to setup.py to get it building again
>   perf hists: Print number of samples, not the period sum
>   perf record: Delay setting the header writing atexit call
>   perf report: Tell the user when a perf.data file has no samples
> 
> Stephane Eranian (1):
>   perf: make perf stat print user provided full event names
> 
>  tools/perf/builtin-record.c    |   10 +++++-----
>  tools/perf/builtin-report.c    |    6 ++++++
>  tools/perf/util/evsel.c        |    1 +
>  tools/perf/util/evsel.h        |    7 +++++++
>  tools/perf/util/hist.c         |    7 +++++--
>  tools/perf/util/parse-events.c |   10 ++++++++++
>  tools/perf/util/setup.py       |    2 +-
>  7 files changed, 35 insertions(+), 8 deletions(-)

Pulled, thanks a lot Arnaldo!

	Ingo

[GIT PULL 0/5] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

        Please pull from:

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core

	This is in addition to the previous pull request.

Regards,

- Arnaldo

Akihiro Nagai (1):
  perf options: add OPT_CALLBACK_DEFAULT_NOOPT

Chris Samuel (1):
  perf tools: Catch a few uncheck calloc/malloc's

Ian Munsie (1):
  perf hist: Better displaying of unresolved DSOs and symbols

Stephane Eranian (1):
  perf script: Fix compiler warning in builtin_script.c:is_top_script()

Thomas Gleixner (1):
  perf session: Sort all events if ordered_samples=true

 tools/perf/builtin-kmem.c       |    3 +
 tools/perf/builtin-lock.c       |    3 +
 tools/perf/builtin-sched.c      |    3 +
 tools/perf/builtin-script.c     |   10 ++--
 tools/perf/builtin-timechart.c  |    3 +
 tools/perf/util/header.c        |    3 +
 tools/perf/util/parse-options.h |    4 +
 tools/perf/util/session.c       |  125 ++++++++++++++++++++++----------------
 tools/perf/util/sort.c          |    6 +-
 9 files changed, 99 insertions(+), 61 deletions(-)

[GIT PULL 0/5] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>

Hi Ingo,

        Please pull from:

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core

Regards,

- Arnaldo

Arnaldo Carvalho de Melo (2):
  perf record: Add option to disable collecting build-ids
  perf events: Default to using event__process_lost

Davidlohr Bueso (1):
  perf tools: Add GCC optimization to memory allocating functions

Ian Munsie (1):
  perf symbols: Correct final kernel map guesses

Shawn Bohrer (1):
  perf trace: Handle DT_UNKNOWN on filesystems that don't support
    d_type

 tools/perf/builtin-record.c            |   14 ++++++++++--
 tools/perf/builtin-trace.c             |   33 ++++++++++++++++++++++++-------
 tools/perf/util/event.c                |    2 +-
 tools/perf/util/header.c               |   11 ++++++++-
 tools/perf/util/header.h               |    1 +
 tools/perf/util/include/linux/bitops.h |    5 ++++
 tools/perf/util/session.c              |    2 +-
 tools/perf/util/symbol.c               |    2 +-
 tools/perf/util/util.h                 |    5 ++-
 9 files changed, 57 insertions(+), 18 deletions(-)

[GIT PULL 0/5] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

        Please pull from:

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core

Regards,

- Arnaldo

Arnaldo Carvalho de Melo (2):
  perf tools: Remove direct slang.h include
  perf probe: Fix format specified for Dwarf_Off parameter

Ben Hutchings (2):
  perf trace: Use $PERF_EXEC_PATH in canned report scripts
  perf trace: Fix detection of script extension

Sonny Rao (1):
  perf tools: Document event modifiers

 tools/perf/Documentation/perf-list.txt             |   17 +++++++++++++++++
 tools/perf/builtin-trace.c                         |    8 ++++----
 tools/perf/scripts/perl/bin/failed-syscalls-report |    2 +-
 tools/perf/scripts/perl/bin/rw-by-file-report      |    2 +-
 tools/perf/scripts/perl/bin/rw-by-pid-report       |    2 +-
 tools/perf/scripts/perl/bin/rwtop-report           |    2 +-
 tools/perf/scripts/perl/bin/wakeup-latency-report  |    2 +-
 tools/perf/scripts/perl/bin/workqueue-stats-report |    2 +-
 .../python/bin/failed-syscalls-by-pid-report       |    2 +-
 tools/perf/scripts/python/bin/netdev-times-report  |    2 +-
 .../perf/scripts/python/bin/sched-migration-report |    2 +-
 tools/perf/scripts/python/bin/sctop-report         |    2 +-
 .../python/bin/syscall-counts-by-pid-report        |    2 +-
 .../perf/scripts/python/bin/syscall-counts-report  |    2 +-
 tools/perf/util/probe-finder.c                     |    3 ++-
 tools/perf/util/ui/browser.c                       |    1 -
 16 files changed, 35 insertions(+), 18 deletions(-)

Re: [GIT PULL 0/5] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> Hi Ingo,
> 
>         Please pull from:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core
> 
> Regards,
> 
> - Arnaldo
> 
> Arnaldo Carvalho de Melo (2):
>   perf tools: Remove direct slang.h include
>   perf probe: Fix format specified for Dwarf_Off parameter
> 
> Ben Hutchings (2):
>   perf trace: Use $PERF_EXEC_PATH in canned report scripts
>   perf trace: Fix detection of script extension
> 
> Sonny Rao (1):
>   perf tools: Document event modifiers
> 
>  tools/perf/Documentation/perf-list.txt             |   17 +++++++++++++++++
>  tools/perf/builtin-trace.c                         |    8 ++++----
>  tools/perf/scripts/perl/bin/failed-syscalls-report |    2 +-
>  tools/perf/scripts/perl/bin/rw-by-file-report      |    2 +-
>  tools/perf/scripts/perl/bin/rw-by-pid-report       |    2 +-
>  tools/perf/scripts/perl/bin/rwtop-report           |    2 +-
>  tools/perf/scripts/perl/bin/wakeup-latency-report  |    2 +-
>  tools/perf/scripts/perl/bin/workqueue-stats-report |    2 +-
>  .../python/bin/failed-syscalls-by-pid-report       |    2 +-
>  tools/perf/scripts/python/bin/netdev-times-report  |    2 +-
>  .../perf/scripts/python/bin/sched-migration-report |    2 +-
>  tools/perf/scripts/python/bin/sctop-report         |    2 +-
>  .../python/bin/syscall-counts-by-pid-report        |    2 +-
>  .../perf/scripts/python/bin/syscall-counts-report  |    2 +-
>  tools/perf/util/probe-finder.c                     |    3 ++-
>  tools/perf/util/ui/browser.c                       |    1 -
>  16 files changed, 35 insertions(+), 18 deletions(-)

Pulled, thanks Arnaldo!

	Ingo