linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] staging: android: Fixed missing blank line
@ 2014-07-18  4:47 Sanjeev Sharma
  2014-07-18 23:16 ` Greg KH
  0 siblings, 1 reply; 7+ messages in thread
From: Sanjeev Sharma @ 2014-07-18  4:47 UTC (permalink / raw)
  To: gregkh
  Cc: daniel, waydi1, devel, linux-kernel, swetland, Sanjeev Sharma,
	Sanjeev Sharma

This patch will add an blank line after
declaration reported by checkpatch.pl script.

Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@mentor.com>
---
 drivers/staging/android/sw_sync.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c
index a76db3f..863d4b1 100644
--- a/drivers/staging/android/sw_sync.c
+++ b/drivers/staging/android/sw_sync.c
@@ -97,6 +97,7 @@ static void sw_sync_pt_value_str(struct sync_pt *sync_pt,
 				       char *str, int size)
 {
 	struct sw_sync_pt *pt = (struct sw_sync_pt *)sync_pt;
+
 	snprintf(str, size, "%d", pt->value);
 }
 
@@ -156,6 +157,7 @@ static int sw_sync_open(struct inode *inode, struct file *file)
 static int sw_sync_release(struct inode *inode, struct file *file)
 {
 	struct sw_sync_timeline *obj = file->private_data;
+
 	sync_timeline_destroy(&obj->obj);
 	return 0;
 }
-- 
1.7.11.7


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] staging: android: Fixed missing blank line
  2014-07-18  4:47 [PATCH] staging: android: Fixed missing blank line Sanjeev Sharma
@ 2014-07-18 23:16 ` Greg KH
  2014-07-23 10:08   ` Sharma, Sanjeev
  0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2014-07-18 23:16 UTC (permalink / raw)
  To: Sanjeev Sharma; +Cc: devel, waydi1, swetland, linux-kernel, daniel

On Fri, Jul 18, 2014 at 10:17:54AM +0530, Sanjeev Sharma wrote:
> This patch will add an blank line after
> declaration reported by checkpatch.pl script.
> 
> Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@mentor.com>
> ---
>  drivers/staging/android/sw_sync.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c
> index a76db3f..863d4b1 100644
> --- a/drivers/staging/android/sw_sync.c
> +++ b/drivers/staging/android/sw_sync.c
> @@ -97,6 +97,7 @@ static void sw_sync_pt_value_str(struct sync_pt *sync_pt,
>  				       char *str, int size)
>  {
>  	struct sw_sync_pt *pt = (struct sw_sync_pt *)sync_pt;
> +
>  	snprintf(str, size, "%d", pt->value);
>  }
>  
> @@ -156,6 +157,7 @@ static int sw_sync_open(struct inode *inode, struct file *file)
>  static int sw_sync_release(struct inode *inode, struct file *file)
>  {
>  	struct sw_sync_timeline *obj = file->private_data;
> +
>  	sync_timeline_destroy(&obj->obj);
>  	return 0;
>  }

I already applied a previous version of this patch, with your gmail
address :(

^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: [PATCH] staging: android: Fixed missing blank line
  2014-07-18 23:16 ` Greg KH
@ 2014-07-23 10:08   ` Sharma, Sanjeev
  2014-07-23 15:25     ` Greg KH
  0 siblings, 1 reply; 7+ messages in thread
From: Sharma, Sanjeev @ 2014-07-23 10:08 UTC (permalink / raw)
  To: Greg KH; +Cc: devel, waydi1, swetland, linux-kernel, daniel

Thanks, so this is also available in next kernel release version.

Regards
Sanjeev Sharma

-----Original Message-----
From: Greg KH [mailto:gregkh@linuxfoundation.org] 
Sent: Saturday, July 19, 2014 4:46 AM
To: Sharma, Sanjeev
Cc: devel@driverdev.osuosl.org; waydi1@gmail.com; swetland@google.com; linux-kernel@vger.kernel.org; daniel@ffwll.ch
Subject: Re: [PATCH] staging: android: Fixed missing blank line

On Fri, Jul 18, 2014 at 10:17:54AM +0530, Sanjeev Sharma wrote:
> This patch will add an blank line after declaration reported by 
> checkpatch.pl script.
> 
> Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@mentor.com>
> ---
>  drivers/staging/android/sw_sync.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/android/sw_sync.c 
> b/drivers/staging/android/sw_sync.c
> index a76db3f..863d4b1 100644
> --- a/drivers/staging/android/sw_sync.c
> +++ b/drivers/staging/android/sw_sync.c
> @@ -97,6 +97,7 @@ static void sw_sync_pt_value_str(struct sync_pt *sync_pt,
>  				       char *str, int size)
>  {
>  	struct sw_sync_pt *pt = (struct sw_sync_pt *)sync_pt;
> +
>  	snprintf(str, size, "%d", pt->value);  }
>  
> @@ -156,6 +157,7 @@ static int sw_sync_open(struct inode *inode, 
> struct file *file)  static int sw_sync_release(struct inode *inode, 
> struct file *file)  {
>  	struct sw_sync_timeline *obj = file->private_data;
> +
>  	sync_timeline_destroy(&obj->obj);
>  	return 0;
>  }

I already applied a previous version of this patch, with your gmail address :(

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] staging: android: Fixed missing blank line
  2014-07-23 10:08   ` Sharma, Sanjeev
@ 2014-07-23 15:25     ` Greg KH
  2014-07-28  5:14       ` Sharma, Sanjeev
  0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2014-07-23 15:25 UTC (permalink / raw)
  To: Sharma, Sanjeev; +Cc: devel, swetland, waydi1, linux-kernel, daniel

On Wed, Jul 23, 2014 at 10:08:44AM +0000, Sharma, Sanjeev wrote:
> Thanks, so this is also available in next kernel release version.

I don't understand the question.  You should have gotten an automated
email when the patch was applied that explained where the patch was now
located, and when it would be merged into Linus's tree.  Did you not get
that?

greg k-h

^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: [PATCH] staging: android: Fixed missing blank line
  2014-07-23 15:25     ` Greg KH
@ 2014-07-28  5:14       ` Sharma, Sanjeev
  0 siblings, 0 replies; 7+ messages in thread
From: Sharma, Sanjeev @ 2014-07-28  5:14 UTC (permalink / raw)
  To: Greg KH; +Cc: devel, swetland, waydi1, linux-kernel, daniel

Hello Greg,

I didn't received automated email.

Regards
Sanjeev Sharma

-----Original Message-----
From: Greg KH [mailto:gregkh@linuxfoundation.org] 
Sent: Wednesday, July 23, 2014 8:55 PM
To: Sharma, Sanjeev
Cc: devel@driverdev.osuosl.org; swetland@google.com; waydi1@gmail.com; linux-kernel@vger.kernel.org; daniel@ffwll.ch
Subject: Re: [PATCH] staging: android: Fixed missing blank line

On Wed, Jul 23, 2014 at 10:08:44AM +0000, Sharma, Sanjeev wrote:
> Thanks, so this is also available in next kernel release version.

I don't understand the question.  You should have gotten an automated email when the patch was applied that explained where the patch was now located, and when it would be merged into Linus's tree.  Did you not get that?

greg k-h

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] staging: android: Fixed missing blank line
  2014-07-17  7:18 sanjeev sharma
@ 2014-07-17  7:28 ` Dan Carpenter
  0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2014-07-17  7:28 UTC (permalink / raw)
  To: sanjeev sharma
  Cc: gregkh, devel, waydi1, swetland, linux-kernel, root, daniel

On Thu, Jul 17, 2014 at 12:48:44PM +0530, sanjeev sharma wrote:
> From: root <root@inndt291.inn.mentorg.com>

You shouldn't be doing this stuff as root...  Also fix your From header
so that your name is capitalized on your emails.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] staging: android: Fixed missing blank line
@ 2014-07-17  7:18 sanjeev sharma
  2014-07-17  7:28 ` Dan Carpenter
  0 siblings, 1 reply; 7+ messages in thread
From: sanjeev sharma @ 2014-07-17  7:18 UTC (permalink / raw)
  To: gregkh
  Cc: daniel, waydi1, linux-kernel, devel, swetland, root, Sanjeev Sharma

From: root <root@inndt291.inn.mentorg.com>

This patch will add an blank line after
declaration reported by checkpatch.pl script.

Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@mentor.com>
---
 drivers/staging/android/sw_sync.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c
index a76db3f..863d4b1 100644
--- a/drivers/staging/android/sw_sync.c
+++ b/drivers/staging/android/sw_sync.c
@@ -97,6 +97,7 @@ static void sw_sync_pt_value_str(struct sync_pt *sync_pt,
 				       char *str, int size)
 {
 	struct sw_sync_pt *pt = (struct sw_sync_pt *)sync_pt;
+
 	snprintf(str, size, "%d", pt->value);
 }
 
@@ -156,6 +157,7 @@ static int sw_sync_open(struct inode *inode, struct file *file)
 static int sw_sync_release(struct inode *inode, struct file *file)
 {
 	struct sw_sync_timeline *obj = file->private_data;
+
 	sync_timeline_destroy(&obj->obj);
 	return 0;
 }
-- 
1.7.11.7


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2014-07-28  5:14 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-18  4:47 [PATCH] staging: android: Fixed missing blank line Sanjeev Sharma
2014-07-18 23:16 ` Greg KH
2014-07-23 10:08   ` Sharma, Sanjeev
2014-07-23 15:25     ` Greg KH
2014-07-28  5:14       ` Sharma, Sanjeev
  -- strict thread matches above, loose matches on Subject: below --
2014-07-17  7:18 sanjeev sharma
2014-07-17  7:28 ` Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).