From: Jeff Layton <jeff.layton@primarydata.com>
To: Daniel Wagner <daniel.wagner@bmw-carit.de>
Cc: Boaz Harrosh <openosd@gmail.com>,
Jeff Layton <jlayton@primarydata.com>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"J. Bruce Fields" <bfields@fieldses.org>,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [RFC v2 3/4] locks: Split insert/delete block functions into flock/posix parts
Date: Wed, 4 Mar 2015 14:16:49 -0500 [thread overview]
Message-ID: <20150304141649.3d729c54@tlielax.poochiereds.net> (raw)
In-Reply-To: <20150304125923.79c4e993@tlielax.poochiereds.net>
On Wed, 4 Mar 2015 12:59:23 -0500
Jeff Layton <jlayton@poochiereds.net> wrote:
> On Wed, 4 Mar 2015 16:32:57 +0100
> Daniel Wagner <daniel.wagner@bmw-carit.de> wrote:
>
> > On 03/04/2015 04:00 PM, Boaz Harrosh wrote:
> > > On 03/04/2015 04:20 PM, Daniel Wagner wrote:
> > >> On 03/03/2015 01:55 AM, Jeff Layton wrote:
> > >>> On Mon, 2 Mar 2015 15:25:12 +0100
> > >>> Daniel Wagner <daniel.wagner@bmw-carit.de> wrote:
> > >>>
> > > <>
> > >> I have fixed that stuff and now I am testing it. Though it seems
> > >> that there is a memory leak which can be triggered with
> > >>
> > >> while true; rm -rf /tmp/a; ./lease02 /tmp/a; done
> > >>
> > >> and this happens also without any of my patches. Still trying to
> > >> figure out what's happening. Hopefully I just see a ghost.
> > >>
> > >> slabtop tells me that ftrace_event_field is constantly growing:
> > >>
> > >
> > > check out the Kernel's leak detector it is perfect in showing you
> > > what was the exact call stack of the leaked memory.
> >
> > Thanks for the tip. Will use it in future :)
> >
> > I have done a quick bisect limit the search on fs/locks.c.
> > I suspect that the file_lock_context refactoring is the source of the leak.
> > bisect agrees with me
> >
> >
> > 8634b51f6ca298fb8b07aa4847340764903533ab is the first bad commit
> > commit 8634b51f6ca298fb8b07aa4847340764903533ab
> > Author: Jeff Layton <jlayton@primarydata.com>
> > Date: Fri Jan 16 15:05:55 2015 -0500
> >
> > locks: convert lease handling to file_lock_context
> >
> > Signed-off-by: Jeff Layton <jlayton@primarydata.com>
> > Acked-by: Christoph Hellwig <hch@lst.de>
> >
> > :040000 040000 4114db9392dc4dadb30664b71a954321e5e87bab 5b9abbaf1808a7c926c09fa2164044e0cc26fd54 M fs
> > :040000 040000 bd569f527a195edf673c4f7d0e80bf356c7f8d1b 6362646e04dd83efc1a9e92877900797ac879e9a M include
> >
>
> Thanks. I'll take a look.
>
Huh. I'm was a bit surprised by this as I didn't really touch how the
fasync entries get handled. I added a bit of printk debugging
(primitive, I know...) and I see this:
[ 458.715319] lease_modify: calling fasync_helper on ffff880035a942d0
So, the fasync_helper getting called on the fasync entry, but it's
definitely not getting freed. When I look at the object in the
debugger, it looks like call_rcu has been called on it though:
fa_file = 0x0,
fa_rcu = {
next = 0xffff8800ccd6a8a0,
func = 0xffffffff8122b1c0 <fasync_free_rcu>
}
...it's almost like the rcu grace period isn't ending properly? I'll
keep poking at though to see if I can figure out what's going wrong.
--
Jeff Layton <jeff.layton@primarydata.com>
next prev parent reply other threads:[~2015-03-04 19:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 14:25 [RFC v2 0/4] fs/locks: Use plain percpu spinlocks instead of lglock to protect file_lock Daniel Wagner
2015-03-02 14:25 ` [RFC v2 1/4] locks: Remove unnecessary IS_POSIX test Daniel Wagner
2015-03-03 0:55 ` Jeff Layton
2015-03-02 14:25 ` [RFC v2 2/4] locks: Add lockdep assertion for blocked_lock_lock Daniel Wagner
2015-03-03 0:55 ` Jeff Layton
2015-03-02 14:25 ` [RFC v2 3/4] locks: Split insert/delete block functions into flock/posix parts Daniel Wagner
2015-03-03 0:55 ` Jeff Layton
2015-03-04 14:20 ` Daniel Wagner
2015-03-04 15:00 ` Boaz Harrosh
2015-03-04 15:32 ` Daniel Wagner
2015-03-04 17:59 ` Jeff Layton
2015-03-04 19:16 ` Jeff Layton [this message]
2015-03-04 21:01 ` Jeff Layton
2015-03-04 21:12 ` Jeff Layton
2015-03-04 21:13 ` Daniel Wagner
2015-03-02 14:25 ` [RFC v2 4/4] locks: Use blocked_lock_lock only to protect blocked_hash Daniel Wagner
2015-03-03 0:58 ` Jeff Layton
2015-03-02 15:23 ` [RFC v2 0/4] fs/locks: Use plain percpu spinlocks instead of lglock to protect file_lock Jeff Layton
2015-03-02 16:44 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150304141649.3d729c54@tlielax.poochiereds.net \
--to=jeff.layton@primarydata.com \
--cc=bfields@fieldses.org \
--cc=daniel.wagner@bmw-carit.de \
--cc=jlayton@primarydata.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openosd@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).