[PATCH] staging: sm750fb: braces, indents, spaces fix

[PATCH] staging: sm750fb: braces, indents, spaces fix

[Ragavendra BN]

This patch removes the braces for the single line if statement. It fixes
the indent positions correctly. It fixes the spaces appropriately making the code give no
warnings by the checpath.pl script check. Please accept.

Signed-off-by: Ragavendra BN <ragavendra.bn@gmail.com>
---
 drivers/staging/sm750fb/ddk750_chip.c |   22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index b71169e..041a05a 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -20,22 +20,16 @@ logical_chip_type_t getChipType()
 	physicalID = devId750;//either 0x718 or 0x750
 	physicalRev = revId750;
 
-    if (physicalID == 0x718)
-    {
-        chip = SM718;
-    }
-    else if (physicalID == 0x750)
-    {
-        chip = SM750;
+	if (physicalID == 0x718) {
+		chip = SM718;
+	} else if (physicalID == 0x750) {
+		chip = SM750;
 		/* SM750 and SM750LE are different in their revision ID only. */
-		if (physicalRev == SM750LE_REVISION_ID){
+		if (physicalRev == SM750LE_REVISION_ID)
 			chip = SM750LE;
-		}
-    }
-    else
-    {
-        chip = SM_UNKNOWN;
-    }
+	} else {
+		chip = SM_UNKNOWN;
+	}
 
 	return chip;
 }
-- 
1.7.10.4

Re: [PATCH] staging: sm750fb: braces, indents, spaces fix

[Dan Carpenter]

On Thu, Mar 12, 2015 at 11:11:27PM -0700, Ragavendra BN wrote:
> This patch removes the braces for the single line if statement. It fixes
> the indent positions correctly. It fixes the spaces appropriately making the code give no
> warnings by the checpath.pl script check. Please accept.
                                            ^^^^^^^^^^^^^^
Don't put this in the changelog.

> 
> Signed-off-by: Ragavendra BN <ragavendra.bn@gmail.com>

Is your name *really* BN?

regards,
dan carpenter

Re: [PATCH] staging: sm750fb: braces, indents, spaces fix

[Greg KH]

On Fri, Mar 13, 2015 at 09:01:48AM -0700, Ragavendra wrote:
> BN is my initial, should it be expanded?

Yes.

Re: [PATCH] staging: sm750fb: braces, indents, spaces fix

[Sudip Mukherjee]

On Thu, Mar 12, 2015 at 10:14:36PM -0700, Ragavendra BN wrote:
> This patch removes the braces for the single line if statement. It fixes
> the indent positions correctly. It fixes the spaces appropriately making the code give no
> warnings by the checpath.pl script check.

your From: is still having [user] in your email address.
and you are doing too many things in a single patch. one patch should
do only one type of change.

> 
> 
> Signed-off-by: Ragavendra BN <ragavendra.bn@gmail.com>
> 
this extra blank line is not necessary here.

regards
sudip

[PATCH] staging: sm750fb: braces, indents, spaces fix

[Ragavendra BN]

Signed-off-by: Ragavendra BN <ragavendra.bn@gmail.com>

This patch removes the braces for the single line if statement. It fixes
the indent positions correctly. It fixes the spaces appropriately making the code give no
warnings by the checkpath.pl script check.

---
 drivers/staging/sm750fb/ddk750_chip.c |   22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index b71169e..041a05a 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -20,22 +20,16 @@ logical_chip_type_t getChipType()
 	physicalID = devId750;//either 0x718 or 0x750
 	physicalRev = revId750;
 
-    if (physicalID == 0x718)
-    {
-        chip = SM718;
-    }
-    else if (physicalID == 0x750)
-    {
-        chip = SM750;
+	if (physicalID == 0x718) {
+		chip = SM718;
+	} else if (physicalID == 0x750) {
+		chip = SM750;
 		/* SM750 and SM750LE are different in their revision ID only. */
-		if (physicalRev == SM750LE_REVISION_ID){
+		if (physicalRev == SM750LE_REVISION_ID)
 			chip = SM750LE;
-		}
-    }
-    else
-    {
-        chip = SM_UNKNOWN;
-    }
+	} else {
+		chip = SM_UNKNOWN;
+	}
 
 	return chip;
 }
-- 
1.7.10.4

Re: [PATCH] staging: sm750fb: braces, indents, spaces fix

[Sudip Mukherjee]

On Thu, Mar 12, 2015 at 08:43:33PM -0700, Ragavendra BN wrote:
> Signed-off-by: Ragavendra BN <ragavendra.bn@gmail.com>
> 
> This patch removes the braces for the single line if statement. It fixes
> the indent positions correctly. It fixes the spaces appropriately making the code give no
> warnings by the checkpath.pl script check.
> 
Signed-off-by line should come here before the ---

> ---

not at the top like you are giving.
Greg has told you once, I am telling now for the second time.

regards
sudip