linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 11/11] i2c-core: Fix typo in comment
@ 2015-05-18 16:54 Shailendra Verma
  2015-05-19  4:48 ` Sudip Mukherjee
  2015-05-31 23:43 ` Wolfram Sang
  0 siblings, 2 replies; 6+ messages in thread
From: Shailendra Verma @ 2015-05-18 16:54 UTC (permalink / raw)
  To: Wolfram Sang, linux-i2c; +Cc: linux-kernel, Shailendra Verma


Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
---
 drivers/i2c/i2c-core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 987c124..c40141b 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -1673,7 +1673,7 @@ void i2c_del_adapter(struct i2c_adapter *adap)
 	 * FIXME: This is old code and should ideally be replaced by an
 	 * alternative which results in decoupling the lifetime of the struct
 	 * device from the i2c_adapter, like spi or netdev do. Any solution
-	 * should be throughly tested with DEBUG_KOBJECT_RELEASE enabled!
+	 * should be thoroughly tested with DEBUG_KOBJECT_RELEASE enabled!
 	 */
 	init_completion(&adap->dev_released);
 	device_unregister(&adap->dev);
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 11/11] i2c-core: Fix typo in comment
  2015-05-18 16:54 [PATCH 11/11] i2c-core: Fix typo in comment Shailendra Verma
@ 2015-05-19  4:48 ` Sudip Mukherjee
       [not found]   ` <CA+tKcn8exGWjb5Ttr9fMtKhSA_NKf2umZs5JDtC+uTfLKc9fAA@mail.gmail.com>
  2015-05-31 23:43 ` Wolfram Sang
  1 sibling, 1 reply; 6+ messages in thread
From: Sudip Mukherjee @ 2015-05-19  4:48 UTC (permalink / raw)
  To: Shailendra Verma; +Cc: Wolfram Sang, linux-i2c, linux-kernel

On Mon, May 18, 2015 at 10:24:01PM +0530, Shailendra Verma wrote:
> 
this patch is 11/11 , but I can not see your remaining 1/11 to 10/11
patches. have you posted them yet?

regards
sudip
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
> ---

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 11/11] i2c-core: Fix typo in comment
       [not found]   ` <CA+tKcn8exGWjb5Ttr9fMtKhSA_NKf2umZs5JDtC+uTfLKc9fAA@mail.gmail.com>
@ 2015-05-19  5:55     ` Sudip Mukherjee
  2015-05-19  6:20       ` Wolfram Sang
  0 siblings, 1 reply; 6+ messages in thread
From: Sudip Mukherjee @ 2015-05-19  5:55 UTC (permalink / raw)
  To: Shailendra Verma; +Cc: linux-i2c, Wolfram Sang, linux-kernel

On Tue, May 19, 2015 at 10:31:36AM +0530, Shailendra Verma wrote:
> Hello Sudip,
> 
> Those were my older patches in different module and I had posted them
> already.
Hi,
You do not need to mention the count of your older patches here.
When you mentioned 11/11, it meant your current submission is a patchset
of 11 patches. So when the maintainer decides to apply your patch he will
search your remaining 10 patches because he needs to apply them in series.

regards
sudip

> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 11/11] i2c-core: Fix typo in comment
  2015-05-19  5:55     ` Sudip Mukherjee
@ 2015-05-19  6:20       ` Wolfram Sang
  2015-05-19  6:50         ` Sudip Mukherjee
  0 siblings, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2015-05-19  6:20 UTC (permalink / raw)
  To: Sudip Mukherjee; +Cc: Shailendra Verma, linux-i2c, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 560 bytes --]

On Tue, May 19, 2015 at 11:25:08AM +0530, Sudip Mukherjee wrote:

> You do not need to mention the count of your older patches here.

While technically true...

> When you mentioned 11/11, it meant your current submission is a patchset
> of 11 patches. So when the maintainer decides to apply your patch he will
> search your remaining 10 patches because he needs to apply them in series.

... this doesn't matter much for such cleanup series. They obviously
have no dependency and I assume that the other patches are for other
subsystems. This is fine, too.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 11/11] i2c-core: Fix typo in comment
  2015-05-19  6:20       ` Wolfram Sang
@ 2015-05-19  6:50         ` Sudip Mukherjee
  0 siblings, 0 replies; 6+ messages in thread
From: Sudip Mukherjee @ 2015-05-19  6:50 UTC (permalink / raw)
  To: Wolfram Sang; +Cc: Shailendra Verma, linux-i2c, linux-kernel

On Tue, May 19, 2015 at 08:20:47AM +0200, Wolfram Sang wrote:
> On Tue, May 19, 2015 at 11:25:08AM +0530, Sudip Mukherjee wrote:
> 
> > You do not need to mention the count of your older patches here.
> 
> While technically true...
> 
> > When you mentioned 11/11, it meant your current submission is a patchset
> > of 11 patches. So when the maintainer decides to apply your patch he will
> > search your remaining 10 patches because he needs to apply them in series.
> 
> ... this doesn't matter much for such cleanup series. They obviously
> have no dependency and I assume that the other patches are for other
> subsystems. This is fine, too.
yes, I also asssumed the same. But it turned out that he has sent 10/10
on 15th May, and then 11/11 , 12/12 , 13/13 and 14/14 on May 18th.

So I assumed that it is a wrong setting while creating his patch.
isn't it?

regards
sudip

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 11/11] i2c-core: Fix typo in comment
  2015-05-18 16:54 [PATCH 11/11] i2c-core: Fix typo in comment Shailendra Verma
  2015-05-19  4:48 ` Sudip Mukherjee
@ 2015-05-31 23:43 ` Wolfram Sang
  1 sibling, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2015-05-31 23:43 UTC (permalink / raw)
  To: Shailendra Verma; +Cc: linux-i2c, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

On Mon, May 18, 2015 at 10:24:01PM +0530, Shailendra Verma wrote:
> 
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>

Applied to for-next, thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-05-31 23:43 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-18 16:54 [PATCH 11/11] i2c-core: Fix typo in comment Shailendra Verma
2015-05-19  4:48 ` Sudip Mukherjee
     [not found]   ` <CA+tKcn8exGWjb5Ttr9fMtKhSA_NKf2umZs5JDtC+uTfLKc9fAA@mail.gmail.com>
2015-05-19  5:55     ` Sudip Mukherjee
2015-05-19  6:20       ` Wolfram Sang
2015-05-19  6:50         ` Sudip Mukherjee
2015-05-31 23:43 ` Wolfram Sang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).