linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] IB/hfi1: use TASK_COMM_LEN in hfi1_ctxtdata
@ 2015-10-09  5:04 Geliang Tang
  2015-10-09  5:04 ` [PATCH] IB/ipath: use TASK_COMM_LEN in ipath_portdata Geliang Tang
  0 siblings, 1 reply; 7+ messages in thread
From: Geliang Tang @ 2015-10-09  5:04 UTC (permalink / raw)
  To: Mike Marciniszyn, Doug Ledford, Sean Hefty, Hal Rosenstock,
	Greg Kroah-Hartman
  Cc: Geliang Tang, linux-rdma, devel, linux-kernel

Use comm[TASK_COMM_LEN] instead of comm[16].

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
 drivers/staging/rdma/hfi1/hfi.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rdma/hfi1/hfi.h b/drivers/staging/rdma/hfi1/hfi.h
index 8ca171b..a35213e 100644
--- a/drivers/staging/rdma/hfi1/hfi.h
+++ b/drivers/staging/rdma/hfi1/hfi.h
@@ -262,7 +262,7 @@ struct hfi1_ctxtdata {
 	pid_t pid;
 	pid_t subpid[HFI1_MAX_SHARED_CTXTS];
 	/* same size as task_struct .comm[], command that opened context */
-	char comm[16];
+	char comm[TASK_COMM_LEN];
 	/* so file ops can get at unit */
 	struct hfi1_devdata *dd;
 	/* so functions that need physical port can get it easily */
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH] IB/ipath: use TASK_COMM_LEN in ipath_portdata
  2015-10-09  5:04 [PATCH] IB/hfi1: use TASK_COMM_LEN in hfi1_ctxtdata Geliang Tang
@ 2015-10-09  5:04 ` Geliang Tang
  2015-10-18  5:05   ` [PATCH] staging: " Greg Kroah-Hartman
  0 siblings, 1 reply; 7+ messages in thread
From: Geliang Tang @ 2015-10-09  5:04 UTC (permalink / raw)
  To: Mike Marciniszyn, Doug Ledford, Sean Hefty, Hal Rosenstock,
	Greg Kroah-Hartman
  Cc: Geliang Tang, linux-rdma, devel, linux-kernel

Use comm[TASK_COMM_LEN] instead of comm[16]. Add linux/sched.h
header in ipath_kernel.h, and remove linux/sched.h header from
ipath_*.c which have included ipath_kernel.h.

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
 drivers/staging/rdma/ipath/ipath_driver.c      | 1 -
 drivers/staging/rdma/ipath/ipath_intr.c        | 1 -
 drivers/staging/rdma/ipath/ipath_kernel.h      | 3 ++-
 drivers/staging/rdma/ipath/ipath_qp.c          | 1 -
 drivers/staging/rdma/ipath/ipath_ruc.c         | 1 -
 drivers/staging/rdma/ipath/ipath_ud.c          | 1 -
 drivers/staging/rdma/ipath/ipath_user_pages.c  | 1 -
 drivers/staging/rdma/ipath/ipath_user_sdma.c   | 1 -
 drivers/staging/rdma/ipath/ipath_verbs_mcast.c | 1 -
 9 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/rdma/ipath/ipath_driver.c b/drivers/staging/rdma/ipath/ipath_driver.c
index 46d9898..dfcfaa5 100644
--- a/drivers/staging/rdma/ipath/ipath_driver.c
+++ b/drivers/staging/rdma/ipath/ipath_driver.c
@@ -33,7 +33,6 @@
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 
-#include <linux/sched.h>
 #include <linux/spinlock.h>
 #include <linux/idr.h>
 #include <linux/pci.h>
diff --git a/drivers/staging/rdma/ipath/ipath_intr.c b/drivers/staging/rdma/ipath/ipath_intr.c
index e568971..0403fa2 100644
--- a/drivers/staging/rdma/ipath/ipath_intr.c
+++ b/drivers/staging/rdma/ipath/ipath_intr.c
@@ -33,7 +33,6 @@
 
 #include <linux/pci.h>
 #include <linux/delay.h>
-#include <linux/sched.h>
 
 #include "ipath_kernel.h"
 #include "ipath_verbs.h"
diff --git a/drivers/staging/rdma/ipath/ipath_kernel.h b/drivers/staging/rdma/ipath/ipath_kernel.h
index f0f9471..66c934a 100644
--- a/drivers/staging/rdma/ipath/ipath_kernel.h
+++ b/drivers/staging/rdma/ipath/ipath_kernel.h
@@ -44,6 +44,7 @@
 #include <linux/mutex.h>
 #include <linux/list.h>
 #include <linux/scatterlist.h>
+#include <linux/sched.h>
 #include <asm/io.h>
 #include <rdma/ib_verbs.h>
 
@@ -162,7 +163,7 @@ struct ipath_portdata {
 	struct pid *port_pid;
 	struct pid *port_subpid[INFINIPATH_MAX_SUBPORT];
 	/* same size as task_struct .comm[] */
-	char port_comm[16];
+	char port_comm[TASK_COMM_LEN];
 	/* pkeys set by this use of this port */
 	u16 port_pkeys[4];
 	/* so file ops can get at unit */
diff --git a/drivers/staging/rdma/ipath/ipath_qp.c b/drivers/staging/rdma/ipath/ipath_qp.c
index face876..0344327 100644
--- a/drivers/staging/rdma/ipath/ipath_qp.c
+++ b/drivers/staging/rdma/ipath/ipath_qp.c
@@ -32,7 +32,6 @@
  */
 
 #include <linux/err.h>
-#include <linux/sched.h>
 #include <linux/slab.h>
 #include <linux/vmalloc.h>
 
diff --git a/drivers/staging/rdma/ipath/ipath_ruc.c b/drivers/staging/rdma/ipath/ipath_ruc.c
index 1f95bba..2296832 100644
--- a/drivers/staging/rdma/ipath/ipath_ruc.c
+++ b/drivers/staging/rdma/ipath/ipath_ruc.c
@@ -31,7 +31,6 @@
  * SOFTWARE.
  */
 
-#include <linux/sched.h>
 #include <linux/spinlock.h>
 
 #include "ipath_verbs.h"
diff --git a/drivers/staging/rdma/ipath/ipath_ud.c b/drivers/staging/rdma/ipath/ipath_ud.c
index e8a2a91..33fcfe2 100644
--- a/drivers/staging/rdma/ipath/ipath_ud.c
+++ b/drivers/staging/rdma/ipath/ipath_ud.c
@@ -31,7 +31,6 @@
  * SOFTWARE.
  */
 
-#include <linux/sched.h>
 #include <rdma/ib_smi.h>
 
 #include "ipath_verbs.h"
diff --git a/drivers/staging/rdma/ipath/ipath_user_pages.c b/drivers/staging/rdma/ipath/ipath_user_pages.c
index 1da1252..d29b4da 100644
--- a/drivers/staging/rdma/ipath/ipath_user_pages.c
+++ b/drivers/staging/rdma/ipath/ipath_user_pages.c
@@ -34,7 +34,6 @@
 #include <linux/mm.h>
 #include <linux/device.h>
 #include <linux/slab.h>
-#include <linux/sched.h>
 
 #include "ipath_kernel.h"
 
diff --git a/drivers/staging/rdma/ipath/ipath_user_sdma.c b/drivers/staging/rdma/ipath/ipath_user_sdma.c
index e82b3ee..8c12e3c 100644
--- a/drivers/staging/rdma/ipath/ipath_user_sdma.c
+++ b/drivers/staging/rdma/ipath/ipath_user_sdma.c
@@ -33,7 +33,6 @@
 #include <linux/types.h>
 #include <linux/device.h>
 #include <linux/dmapool.h>
-#include <linux/sched.h>
 #include <linux/slab.h>
 #include <linux/list.h>
 #include <linux/highmem.h>
diff --git a/drivers/staging/rdma/ipath/ipath_verbs_mcast.c b/drivers/staging/rdma/ipath/ipath_verbs_mcast.c
index 6216ea9..72d476f 100644
--- a/drivers/staging/rdma/ipath/ipath_verbs_mcast.c
+++ b/drivers/staging/rdma/ipath/ipath_verbs_mcast.c
@@ -32,7 +32,6 @@
  */
 
 #include <linux/rculist.h>
-#include <linux/sched.h>
 #include <linux/slab.h>
 
 #include "ipath_verbs.h"
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] staging: IB/ipath: use TASK_COMM_LEN in ipath_portdata
  2015-10-09  5:04 ` [PATCH] IB/ipath: use TASK_COMM_LEN in ipath_portdata Geliang Tang
@ 2015-10-18  5:05   ` Greg Kroah-Hartman
  2015-10-18 13:57     ` [PATCH v2 1/2] " Geliang Tang
  0 siblings, 1 reply; 7+ messages in thread
From: Greg Kroah-Hartman @ 2015-10-18  5:05 UTC (permalink / raw)
  To: Geliang Tang
  Cc: Mike Marciniszyn, Doug Ledford, Sean Hefty, Hal Rosenstock,
	linux-rdma, devel, linux-kernel

On Thu, Oct 08, 2015 at 10:04:27PM -0700, Geliang Tang wrote:
> Use comm[TASK_COMM_LEN] instead of comm[16]. Add linux/sched.h
> header in ipath_kernel.h, and remove linux/sched.h header from
> ipath_*.c which have included ipath_kernel.h.

That's a lot of different things to be doing all in one patch.  Please
break this up into different patches and resend.

Also please add the "staging:" prefix to your subject lines, like I
changed it to here, that makes it easier for me to notice and handle
your patches properly.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH v2 1/2] staging: IB/ipath: use TASK_COMM_LEN in ipath_portdata
  2015-10-18  5:05   ` [PATCH] staging: " Greg Kroah-Hartman
@ 2015-10-18 13:57     ` Geliang Tang
  2015-10-18 13:57       ` [PATCH v2 2/2] staging: IB/ipath: remove sched.h header Geliang Tang
  0 siblings, 1 reply; 7+ messages in thread
From: Geliang Tang @ 2015-10-18 13:57 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Geliang Tang, Mike Marciniszyn, Doug Ledford, Sean Hefty,
	Hal Rosenstock, linux-rdma, devel, linux-kernel

Use comm[TASK_COMM_LEN] instead of comm[16] in ipath_kernel.h.
And add sched.h header in it.

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
Changes in v2:
 - split it into two patches.
---
 drivers/staging/rdma/ipath/ipath_kernel.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rdma/ipath/ipath_kernel.h b/drivers/staging/rdma/ipath/ipath_kernel.h
index f0f9471..66c934a 100644
--- a/drivers/staging/rdma/ipath/ipath_kernel.h
+++ b/drivers/staging/rdma/ipath/ipath_kernel.h
@@ -44,6 +44,7 @@
 #include <linux/mutex.h>
 #include <linux/list.h>
 #include <linux/scatterlist.h>
+#include <linux/sched.h>
 #include <asm/io.h>
 #include <rdma/ib_verbs.h>
 
@@ -162,7 +163,7 @@ struct ipath_portdata {
 	struct pid *port_pid;
 	struct pid *port_subpid[INFINIPATH_MAX_SUBPORT];
 	/* same size as task_struct .comm[] */
-	char port_comm[16];
+	char port_comm[TASK_COMM_LEN];
 	/* pkeys set by this use of this port */
 	u16 port_pkeys[4];
 	/* so file ops can get at unit */
-- 
2.5.0



^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH v2 2/2] staging: IB/ipath: remove sched.h header
  2015-10-18 13:57     ` [PATCH v2 1/2] " Geliang Tang
@ 2015-10-18 13:57       ` Geliang Tang
  2015-10-25  2:05         ` Greg Kroah-Hartman
  0 siblings, 1 reply; 7+ messages in thread
From: Geliang Tang @ 2015-10-18 13:57 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Geliang Tang, Mike Marciniszyn, Doug Ledford, Sean Hefty,
	Hal Rosenstock, linux-rdma, devel, linux-kernel

sched.h header in ipath_*.c is now unnecessary, since I have added
sched.h in ipath_kernel.h. So remove it.

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
Changes in v2:
 - split it into two patches.
---
 drivers/staging/rdma/ipath/ipath_driver.c      | 1 -
 drivers/staging/rdma/ipath/ipath_intr.c        | 1 -
 drivers/staging/rdma/ipath/ipath_qp.c          | 1 -
 drivers/staging/rdma/ipath/ipath_ruc.c         | 1 -
 drivers/staging/rdma/ipath/ipath_ud.c          | 1 -
 drivers/staging/rdma/ipath/ipath_user_pages.c  | 1 -
 drivers/staging/rdma/ipath/ipath_user_sdma.c   | 1 -
 drivers/staging/rdma/ipath/ipath_verbs_mcast.c | 1 -
 8 files changed, 8 deletions(-)

diff --git a/drivers/staging/rdma/ipath/ipath_driver.c b/drivers/staging/rdma/ipath/ipath_driver.c
index 46d9898..dfcfaa5 100644
--- a/drivers/staging/rdma/ipath/ipath_driver.c
+++ b/drivers/staging/rdma/ipath/ipath_driver.c
@@ -33,7 +33,6 @@
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 
-#include <linux/sched.h>
 #include <linux/spinlock.h>
 #include <linux/idr.h>
 #include <linux/pci.h>
diff --git a/drivers/staging/rdma/ipath/ipath_intr.c b/drivers/staging/rdma/ipath/ipath_intr.c
index e568971..0403fa2 100644
--- a/drivers/staging/rdma/ipath/ipath_intr.c
+++ b/drivers/staging/rdma/ipath/ipath_intr.c
@@ -33,7 +33,6 @@
 
 #include <linux/pci.h>
 #include <linux/delay.h>
-#include <linux/sched.h>
 
 #include "ipath_kernel.h"
 #include "ipath_verbs.h"
diff --git a/drivers/staging/rdma/ipath/ipath_qp.c b/drivers/staging/rdma/ipath/ipath_qp.c
index b2c6766..280cd2d 100644
--- a/drivers/staging/rdma/ipath/ipath_qp.c
+++ b/drivers/staging/rdma/ipath/ipath_qp.c
@@ -32,7 +32,6 @@
  */
 
 #include <linux/err.h>
-#include <linux/sched.h>
 #include <linux/slab.h>
 #include <linux/vmalloc.h>
 
diff --git a/drivers/staging/rdma/ipath/ipath_ruc.c b/drivers/staging/rdma/ipath/ipath_ruc.c
index 1f95bba..2296832 100644
--- a/drivers/staging/rdma/ipath/ipath_ruc.c
+++ b/drivers/staging/rdma/ipath/ipath_ruc.c
@@ -31,7 +31,6 @@
  * SOFTWARE.
  */
 
-#include <linux/sched.h>
 #include <linux/spinlock.h>
 
 #include "ipath_verbs.h"
diff --git a/drivers/staging/rdma/ipath/ipath_ud.c b/drivers/staging/rdma/ipath/ipath_ud.c
index e8a2a91..33fcfe2 100644
--- a/drivers/staging/rdma/ipath/ipath_ud.c
+++ b/drivers/staging/rdma/ipath/ipath_ud.c
@@ -31,7 +31,6 @@
  * SOFTWARE.
  */
 
-#include <linux/sched.h>
 #include <rdma/ib_smi.h>
 
 #include "ipath_verbs.h"
diff --git a/drivers/staging/rdma/ipath/ipath_user_pages.c b/drivers/staging/rdma/ipath/ipath_user_pages.c
index 1da1252..d29b4da 100644
--- a/drivers/staging/rdma/ipath/ipath_user_pages.c
+++ b/drivers/staging/rdma/ipath/ipath_user_pages.c
@@ -34,7 +34,6 @@
 #include <linux/mm.h>
 #include <linux/device.h>
 #include <linux/slab.h>
-#include <linux/sched.h>
 
 #include "ipath_kernel.h"
 
diff --git a/drivers/staging/rdma/ipath/ipath_user_sdma.c b/drivers/staging/rdma/ipath/ipath_user_sdma.c
index e82b3ee..8c12e3c 100644
--- a/drivers/staging/rdma/ipath/ipath_user_sdma.c
+++ b/drivers/staging/rdma/ipath/ipath_user_sdma.c
@@ -33,7 +33,6 @@
 #include <linux/types.h>
 #include <linux/device.h>
 #include <linux/dmapool.h>
-#include <linux/sched.h>
 #include <linux/slab.h>
 #include <linux/list.h>
 #include <linux/highmem.h>
diff --git a/drivers/staging/rdma/ipath/ipath_verbs_mcast.c b/drivers/staging/rdma/ipath/ipath_verbs_mcast.c
index 6216ea9..72d476f 100644
--- a/drivers/staging/rdma/ipath/ipath_verbs_mcast.c
+++ b/drivers/staging/rdma/ipath/ipath_verbs_mcast.c
@@ -32,7 +32,6 @@
  */
 
 #include <linux/rculist.h>
-#include <linux/sched.h>
 #include <linux/slab.h>
 
 #include "ipath_verbs.h"
-- 
2.5.0



^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] staging: IB/ipath: remove sched.h header
  2015-10-18 13:57       ` [PATCH v2 2/2] staging: IB/ipath: remove sched.h header Geliang Tang
@ 2015-10-25  2:05         ` Greg Kroah-Hartman
  2015-10-25  2:06           ` Greg Kroah-Hartman
  0 siblings, 1 reply; 7+ messages in thread
From: Greg Kroah-Hartman @ 2015-10-25  2:05 UTC (permalink / raw)
  To: Geliang Tang
  Cc: devel, Mike Marciniszyn, linux-rdma, linux-kernel, Doug Ledford,
	Sean Hefty, Hal Rosenstock

On Sun, Oct 18, 2015 at 09:57:09PM +0800, Geliang Tang wrote:
> sched.h header in ipath_*.c is now unnecessary, since I have added
> sched.h in ipath_kernel.h. So remove it.

Overall, it's best to split this type of thing out, don't "hide" .h
includes in another .h file, so I'm not going to take this patch, sorry.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] staging: IB/ipath: remove sched.h header
  2015-10-25  2:05         ` Greg Kroah-Hartman
@ 2015-10-25  2:06           ` Greg Kroah-Hartman
  0 siblings, 0 replies; 7+ messages in thread
From: Greg Kroah-Hartman @ 2015-10-25  2:06 UTC (permalink / raw)
  To: Geliang Tang
  Cc: devel, Mike Marciniszyn, linux-rdma, linux-kernel, Doug Ledford,
	Sean Hefty, Hal Rosenstock

On Sat, Oct 24, 2015 at 07:05:32PM -0700, Greg Kroah-Hartman wrote:
> On Sun, Oct 18, 2015 at 09:57:09PM +0800, Geliang Tang wrote:
> > sched.h header in ipath_*.c is now unnecessary, since I have added
> > sched.h in ipath_kernel.h. So remove it.
> 
> Overall, it's best to split this type of thing out, don't "hide" .h
> includes in another .h file, so I'm not going to take this patch, sorry.

Oh nevermind, your 1/2 patch made this make more sense, sorry for the
noise...

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-10-25  8:30 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-09  5:04 [PATCH] IB/hfi1: use TASK_COMM_LEN in hfi1_ctxtdata Geliang Tang
2015-10-09  5:04 ` [PATCH] IB/ipath: use TASK_COMM_LEN in ipath_portdata Geliang Tang
2015-10-18  5:05   ` [PATCH] staging: " Greg Kroah-Hartman
2015-10-18 13:57     ` [PATCH v2 1/2] " Geliang Tang
2015-10-18 13:57       ` [PATCH v2 2/2] staging: IB/ipath: remove sched.h header Geliang Tang
2015-10-25  2:05         ` Greg Kroah-Hartman
2015-10-25  2:06           ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).