Re: [PATCH v4 2/6] clk: sunxi: Add H3 clocks support

From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
	"Jens Kuske" <jenskuske@gmail.com>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Emilio López" <emilio@elopez.com.ar>,
	devicetree@vger.kernel.org,
	"Vishnu Patekar" <vishnupatekar0510@gmail.com>,
	linux-kernel@vger.kernel.org,
	"Hans de Goede" <hdegoede@redhat.com>,
	linux-sunxi@googlegroups.com
Subject: Re: [PATCH v4 2/6] clk: sunxi: Add H3 clocks support
Date: Wed, 4 Nov 2015 08:24:56 -0800	[thread overview]
Message-ID: <20151104162456.GA6114@lukather> (raw)
In-Reply-To: <3751073.AWmm18dvKK@wuerfel>

[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]

Hi Arnd,

On Fri, Oct 30, 2015 at 09:28:55AM +0100, Arnd Bergmann wrote:
> On Tuesday 27 October 2015 17:50:22 Jens Kuske wrote:
> > +               of_property_read_string_index(node, "clock-output-names",
> > +                                             i, &clk_name);
> > +
> > +               if (index == 17 || (index >= 29 && index <= 31))
> > +                       clk_parent = AHB2;
> > +               else if (index <= 63 || index >= 128)
> > +                       clk_parent = AHB1;
> > +               else if (index >= 64 && index <= 95)
> > +                       clk_parent = APB1;
> > +               else if (index >= 96 && index <= 127)
> > +                       clk_parent = APB2;
> > +
> > +               clk_reg = reg + 4 * (index / 32);
> > 
> 
> Same as for the reset driver, this probably means you should have one
> cell to indicate which bus it is for, and another cell for the
> index.

It's not really comparable to the reset driver.

What's happening here is that we have a single set of (contiguous)
registers, controlling gates from different parents.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]