* [PATCH] net: stmmac: remove unneeded phy_iface variable
@ 2015-11-04 20:08 LABBE Corentin
2015-11-05 5:30 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: LABBE Corentin @ 2015-11-04 20:08 UTC (permalink / raw)
To: peppe.cavallaro; +Cc: LABBE Corentin, linux-kernel, netdev
The variable phy_iface is double-initialized and finally is not necessary
at all.
Reported-by: coverity (CID 1271141)
Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
index 11baa4b..26a11b7 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
@@ -354,11 +354,9 @@ static int gmac_clk_init(struct rk_priv_data *bsp_priv)
static int gmac_clk_enable(struct rk_priv_data *bsp_priv, bool enable)
{
- int phy_iface = phy_iface = bsp_priv->phy_iface;
-
if (enable) {
if (!bsp_priv->clk_enabled) {
- if (phy_iface == PHY_INTERFACE_MODE_RMII) {
+ if (bsp_priv->phy_iface == PHY_INTERFACE_MODE_RMII) {
if (!IS_ERR(bsp_priv->mac_clk_rx))
clk_prepare_enable(
bsp_priv->mac_clk_rx);
@@ -390,7 +388,7 @@ static int gmac_clk_enable(struct rk_priv_data *bsp_priv, bool enable)
}
} else {
if (bsp_priv->clk_enabled) {
- if (phy_iface == PHY_INTERFACE_MODE_RMII) {
+ if (bsp_priv->phy_iface == PHY_INTERFACE_MODE_RMII) {
if (!IS_ERR(bsp_priv->mac_clk_rx))
clk_disable_unprepare(
bsp_priv->mac_clk_rx);
--
2.4.10
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: stmmac: remove unneeded phy_iface variable
2015-11-04 20:08 [PATCH] net: stmmac: remove unneeded phy_iface variable LABBE Corentin
@ 2015-11-05 5:30 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-11-05 5:30 UTC (permalink / raw)
To: clabbe.montjoie; +Cc: peppe.cavallaro, linux-kernel, netdev
From: LABBE Corentin <clabbe.montjoie@gmail.com>
Date: Wed, 4 Nov 2015 21:08:12 +0100
> The variable phy_iface is double-initialized and finally is not necessary
> at all.
>
> Reported-by: coverity (CID 1271141)
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
The value is used in two locations, so having it computed once in a
variable is useful.
Please just eliminate the double assignment.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-05 5:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-04 20:08 [PATCH] net: stmmac: remove unneeded phy_iface variable LABBE Corentin
2015-11-05 5:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).