From: Dan Carpenter <dan.carpenter@oracle.com>
To: Shivani Bhardwaj <shivanib134@gmail.com>
Cc: "Drokin, Oleg" <oleg.drokin@intel.com>,
Greg KH <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, "Dilger,
Andreas" <andreas.dilger@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 9/9] Staging: lustre: llite_internal: Remove function prototype
Date: Sat, 7 Nov 2015 23:47:25 +0300 [thread overview]
Message-ID: <20151107204725.GJ18797@mwanda> (raw)
In-Reply-To: <CAKHNQQGP6JbSM_2Kwfvw2fd1gRWJA1r3yySOYLSY=1rB8102WA@mail.gmail.com>
Don't resend, it's fine. I don't like re-reviewing patches and you
don't like sending them. It's not like it introduces a bug or generate
a warning with our current tools.
But it's still important to understand how the one thing per patch rule
works (don't do half a thing per patch) so I wanted you to be aware of
it for future patches as you said.
regards,
dan carpenter
next prev parent reply other threads:[~2015-11-07 20:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-07 7:40 [PATCH 0/9] Remove wrapper function and tidy up the code Shivani Bhardwaj
2015-11-07 7:41 ` [PATCH 1/9] Staging: lustre: dir: Replace function calls Shivani Bhardwaj
2015-11-09 11:07 ` Drokin, Oleg
2015-11-09 12:28 ` Dan Carpenter
2015-11-07 7:42 ` [PATCH 2/9] Staging: lustre: file: Replace function calls with standard function Shivani Bhardwaj
2015-11-07 7:43 ` [PATCH 3/9] Staging: lustre: namei: Replace calls with kfree Shivani Bhardwaj
2015-11-07 7:44 ` [PATCH 4/9] Staging: lustre: xattr_cache: Change function calls Shivani Bhardwaj
2015-11-07 7:44 ` [PATCH 5/9] Staging: lustre: symlink: Substitute standard function Shivani Bhardwaj
2015-11-07 7:45 ` [PATCH 6/9] Staging: lustre: llite_nfs: Replace with " Shivani Bhardwaj
2015-11-07 7:45 ` [PATCH 7/9] Staging: lustre: llite_close: Substitute function calls Shivani Bhardwaj
2015-11-07 7:46 ` [PATCH 8/9] Staging: lustre: llite_lib: Remove wrapper function Shivani Bhardwaj
2015-11-09 13:37 ` Michał Kępień
2015-11-09 16:35 ` Shivani Bhardwaj
2015-11-09 19:18 ` Simmons, James A.
2015-11-10 3:08 ` Shivani Bhardwaj
2015-11-07 7:47 ` [PATCH 9/9] Staging: lustre: llite_internal: Remove function prototype Shivani Bhardwaj
2015-11-07 10:45 ` Dan Carpenter
2015-11-07 15:29 ` Shivani Bhardwaj
2015-11-07 20:47 ` Dan Carpenter [this message]
2015-11-08 8:29 ` Shivani Bhardwaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151107204725.GJ18797@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=shivanib134@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).