linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shivani Bhardwaj <shivanib134@gmail.com>
To: gregkh@linuxfoundation.org
Cc: oleg.drokin@intel.com, andreas.dilger@intel.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 8/9] Staging: lustre: llite_lib: Remove wrapper function
Date: Sat,  7 Nov 2015 13:16:26 +0530	[thread overview]
Message-ID: <2f66e94923a7655495165123a5efe3bd099d77bc.1446881645.git.shivanib134@gmail.com> (raw)
In-Reply-To: <cover.1446881645.git.shivanib134@gmail.com>

Remove the function ll_finish_md_op_data() and replace all its calls
with the standrd function ll_finish_md_op_data().

Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
 drivers/staging/lustre/lustre/llite/llite_lib.c | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c b/drivers/staging/lustre/lustre/llite/llite_lib.c
index 4a8c759..143be87 100644
--- a/drivers/staging/lustre/lustre/llite/llite_lib.c
+++ b/drivers/staging/lustre/lustre/llite/llite_lib.c
@@ -1355,7 +1355,7 @@ out:
 		if (!rc)
 			rc = rc1;
 	}
-	ll_finish_md_op_data(op_data);
+	kfree(op_data);
 
 	if (!S_ISDIR(inode->i_mode)) {
 		mutex_lock(&inode->i_mutex);
@@ -1732,7 +1732,7 @@ int ll_iocontrol(struct inode *inode, struct file *file,
 
 		op_data->op_valid = OBD_MD_FLFLAGS;
 		rc = md_getattr(sbi->ll_md_exp, op_data, &req);
-		ll_finish_md_op_data(op_data);
+		kfree(op_data);
 		if (rc) {
 			CERROR("failure %d inode %lu\n", rc, inode->i_ino);
 			return -abs(rc);
@@ -1763,7 +1763,7 @@ int ll_iocontrol(struct inode *inode, struct file *file,
 		op_data->op_attr.ia_valid |= ATTR_ATTR_FLAG;
 		rc = md_setattr(sbi->ll_md_exp, op_data,
 				NULL, 0, NULL, 0, &req, NULL);
-		ll_finish_md_op_data(op_data);
+		kfree(op_data);
 		ptlrpc_req_finished(req);
 		if (rc)
 			return rc;
@@ -1934,7 +1934,7 @@ void ll_open_cleanup(struct super_block *sb, struct ptlrpc_request *open_req)
 	op_data->op_mod_time = get_seconds();
 	md_close(exp, op_data, NULL, &close_req);
 	ptlrpc_req_finished(close_req);
-	ll_finish_md_op_data(op_data);
+	kfree(op_data);
 }
 
 int ll_prep_inode(struct inode **inode, struct ptlrpc_request *req,
@@ -2170,11 +2170,6 @@ struct md_op_data *ll_prep_md_op_data(struct md_op_data *op_data,
 	return op_data;
 }
 
-void ll_finish_md_op_data(struct md_op_data *op_data)
-{
-	kfree(op_data);
-}
-
 int ll_show_options(struct seq_file *seq, struct dentry *dentry)
 {
 	struct ll_sb_info *sbi;
-- 
2.1.0


  parent reply	other threads:[~2015-11-07  7:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-07  7:40 [PATCH 0/9] Remove wrapper function and tidy up the code Shivani Bhardwaj
2015-11-07  7:41 ` [PATCH 1/9] Staging: lustre: dir: Replace function calls Shivani Bhardwaj
2015-11-09 11:07   ` Drokin, Oleg
2015-11-09 12:28     ` Dan Carpenter
2015-11-07  7:42 ` [PATCH 2/9] Staging: lustre: file: Replace function calls with standard function Shivani Bhardwaj
2015-11-07  7:43 ` [PATCH 3/9] Staging: lustre: namei: Replace calls with kfree Shivani Bhardwaj
2015-11-07  7:44 ` [PATCH 4/9] Staging: lustre: xattr_cache: Change function calls Shivani Bhardwaj
2015-11-07  7:44 ` [PATCH 5/9] Staging: lustre: symlink: Substitute standard function Shivani Bhardwaj
2015-11-07  7:45 ` [PATCH 6/9] Staging: lustre: llite_nfs: Replace with " Shivani Bhardwaj
2015-11-07  7:45 ` [PATCH 7/9] Staging: lustre: llite_close: Substitute function calls Shivani Bhardwaj
2015-11-07  7:46 ` Shivani Bhardwaj [this message]
2015-11-09 13:37   ` [PATCH 8/9] Staging: lustre: llite_lib: Remove wrapper function Michał Kępień
2015-11-09 16:35     ` Shivani Bhardwaj
2015-11-09 19:18       ` Simmons, James A.
2015-11-10  3:08         ` Shivani Bhardwaj
2015-11-07  7:47 ` [PATCH 9/9] Staging: lustre: llite_internal: Remove function prototype Shivani Bhardwaj
2015-11-07 10:45   ` Dan Carpenter
2015-11-07 15:29     ` Shivani Bhardwaj
2015-11-07 20:47       ` Dan Carpenter
2015-11-08  8:29         ` Shivani Bhardwaj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f66e94923a7655495165123a5efe3bd099d77bc.1446881645.git.shivanib134@gmail.com \
    --to=shivanib134@gmail.com \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).