linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Simmons, James A." <simmonsja@ornl.gov>
To: "'Shivani Bhardwaj'" <shivanib134@gmail.com>,
	"Michał Kępień" <kernel@kempniu.pl>
Cc: "Drokin, Oleg" <oleg.drokin@intel.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"Dilger, Andreas" <andreas.dilger@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 8/9] Staging: lustre: llite_lib: Remove wrapper function
Date: Mon, 9 Nov 2015 19:18:16 +0000	[thread overview]
Message-ID: <434305b1308b4da48f38891867e65120@EXCHCS32.ornl.gov> (raw)
In-Reply-To: <CAKHNQQFbNEhv3CP+GibeM-yu_zX4XgJ_f4QJzJ8Nn_JG--c1FQ@mail.gmail.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 728 bytes --]

>On Mon, Nov 9, 2015 at 7:07 PM, Michał Kępień <kernel@kempniu.pl> wrote:
>>> Remove the function ll_finish_md_op_data() and replace all its calls
>>> with the standrd function ll_finish_md_op_data().
>>
>> I believe you meant to write "standard function kfree()".
>>
>
>Yes. I am so sorry. Should I be sending the whole series again?
>Thank you
>Shivani

Yes please redo the series. I saw Oleg's concern and I would recommend that
besides the conversion to kfree that you add comments about what is being deleted.
I.E

/* Free struct md_op_data  data*/
kfree(...)
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

  reply	other threads:[~2015-11-09 19:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-07  7:40 [PATCH 0/9] Remove wrapper function and tidy up the code Shivani Bhardwaj
2015-11-07  7:41 ` [PATCH 1/9] Staging: lustre: dir: Replace function calls Shivani Bhardwaj
2015-11-09 11:07   ` Drokin, Oleg
2015-11-09 12:28     ` Dan Carpenter
2015-11-07  7:42 ` [PATCH 2/9] Staging: lustre: file: Replace function calls with standard function Shivani Bhardwaj
2015-11-07  7:43 ` [PATCH 3/9] Staging: lustre: namei: Replace calls with kfree Shivani Bhardwaj
2015-11-07  7:44 ` [PATCH 4/9] Staging: lustre: xattr_cache: Change function calls Shivani Bhardwaj
2015-11-07  7:44 ` [PATCH 5/9] Staging: lustre: symlink: Substitute standard function Shivani Bhardwaj
2015-11-07  7:45 ` [PATCH 6/9] Staging: lustre: llite_nfs: Replace with " Shivani Bhardwaj
2015-11-07  7:45 ` [PATCH 7/9] Staging: lustre: llite_close: Substitute function calls Shivani Bhardwaj
2015-11-07  7:46 ` [PATCH 8/9] Staging: lustre: llite_lib: Remove wrapper function Shivani Bhardwaj
2015-11-09 13:37   ` Michał Kępień
2015-11-09 16:35     ` Shivani Bhardwaj
2015-11-09 19:18       ` Simmons, James A. [this message]
2015-11-10  3:08         ` Shivani Bhardwaj
2015-11-07  7:47 ` [PATCH 9/9] Staging: lustre: llite_internal: Remove function prototype Shivani Bhardwaj
2015-11-07 10:45   ` Dan Carpenter
2015-11-07 15:29     ` Shivani Bhardwaj
2015-11-07 20:47       ` Dan Carpenter
2015-11-08  8:29         ` Shivani Bhardwaj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=434305b1308b4da48f38891867e65120@EXCHCS32.ornl.gov \
    --to=simmonsja@ornl.gov \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@kempniu.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    --cc=shivanib134@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).