* Re: [RFC/PATCH] pinctrl: qcom: Add generic ssbi and spmi GPIO/MPP bindings
2015-11-18 1:00 [RFC/PATCH] pinctrl: qcom: Add generic ssbi and spmi GPIO/MPP bindings Stephen Boyd
@ 2015-11-18 4:09 ` Andy Gross
2015-11-18 19:33 ` [PATCH] pinctrl: qcom: pmic-gpio/mpp: of_irq_count() == npins Stephen Boyd
` (3 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Andy Gross @ 2015-11-18 4:09 UTC (permalink / raw)
To: Stephen Boyd
Cc: Linus Walleij, linux-kernel, linux-arm-msm, linux-arm-kernel,
linux-gpio, devicetree, Ivan T. Ivanov, Bjorn Andersson
On Tue, Nov 17, 2015 at 05:00:26PM -0800, Stephen Boyd wrote:
> The drivers don't really need to know which PMIC they're for, so
> make a generic binding for them. This alleviates us from updating
> the drivers every time a new PMIC comes out. It's still
> recommended that we update the binding with new PMIC models and
> always specify the specific model for the MPPs and gpios before
> the generic compatible string in devicetree, but this at least
> cuts down on adding more and more compatible strings to the
> drivers until we actually need them.
>
> Cc: <devicetree@vger.kernel.org>
> Cc: "Ivan T. Ivanov" <iivanov@mm-sol.com>
> Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Reviewed-by: Andy Gross <agross@codeaurora.org>
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] pinctrl: qcom: pmic-gpio/mpp: of_irq_count() == npins
2015-11-18 1:00 [RFC/PATCH] pinctrl: qcom: Add generic ssbi and spmi GPIO/MPP bindings Stephen Boyd
2015-11-18 4:09 ` Andy Gross
@ 2015-11-18 19:33 ` Stephen Boyd
2015-11-19 6:04 ` Andy Gross
` (2 more replies)
2015-11-19 14:50 ` [RFC/PATCH] pinctrl: qcom: Add generic ssbi and spmi GPIO/MPP bindings Rob Herring
` (2 subsequent siblings)
4 siblings, 3 replies; 10+ messages in thread
From: Stephen Boyd @ 2015-11-18 19:33 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-kernel, linux-arm-msm, linux-arm-kernel, linux-gpio,
Andy Gross, Ivan T. Ivanov, Bjorn Andersson
The number of interrupts is always equal to the number of pins
provided by the PMIC gpio and MPP hardware blocks. Count the
number of irqs to figure out the number of pins instead of adding
more compatible strings or doing math on the reg property. This
should make the code more generic and ease the number of changes
we have to make to the driver for each new pmic revision.
Cc: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
Stephen Boyd wrote:
> We can also figure out the number of the pins from the number
> of interrupts, so we really don't need to even look at the size of the
> reg property or model number for the spmi and ssbi modules. I'll propose
> that change as well tomorrow.
And here's that change. It can be squashed together if desired.
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 12 ++++++------
drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 11 ++++++-----
drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c | 16 ++++++++++------
drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c | 16 ++++++++++------
4 files changed, 32 insertions(+), 23 deletions(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index 9f9979903fcb..cceda6afe280 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -14,6 +14,7 @@
#include <linux/gpio.h>
#include <linux/module.h>
#include <linux/of.h>
+#include <linux/of_irq.h>
#include <linux/pinctrl/pinconf-generic.h>
#include <linux/pinctrl/pinconf.h>
#include <linux/pinctrl/pinmux.h>
@@ -693,16 +694,15 @@ static int pmic_gpio_probe(struct platform_device *pdev)
struct pmic_gpio_pad *pad, *pads;
struct pmic_gpio_state *state;
int ret, npins, i;
- u32 res[2];
+ u32 reg;
- ret = of_property_read_u32_array(dev->of_node, "reg", res, 2);
+ ret = of_property_read_u32(dev->of_node, "reg", ®);
if (ret < 0) {
- dev_err(dev, "missing base address and/or range");
+ dev_err(dev, "missing base address");
return ret;
}
- npins = res[1] / PMIC_GPIO_ADDRESS_RANGE;
-
+ npins = of_irq_count(dev->of_node);
if (!npins)
return -EINVAL;
@@ -752,7 +752,7 @@ static int pmic_gpio_probe(struct platform_device *pdev)
if (pad->irq < 0)
return pad->irq;
- pad->base = res[0] + i * PMIC_GPIO_ADDRESS_RANGE;
+ pad->base = reg + i * PMIC_GPIO_ADDRESS_RANGE;
ret = pmic_gpio_populate(state, pad);
if (ret < 0)
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
index 5a4373dd9c61..b45123066669 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
@@ -14,6 +14,7 @@
#include <linux/gpio.h>
#include <linux/module.h>
#include <linux/of.h>
+#include <linux/of_irq.h>
#include <linux/pinctrl/pinconf-generic.h>
#include <linux/pinctrl/pinconf.h>
#include <linux/pinctrl/pinmux.h>
@@ -795,15 +796,15 @@ static int pmic_mpp_probe(struct platform_device *pdev)
struct pmic_mpp_pad *pad, *pads;
struct pmic_mpp_state *state;
int ret, npins, i;
- u32 res[2];
+ u32 reg;
- ret = of_property_read_u32_array(dev->of_node, "reg", res, 2);
+ ret = of_property_read_u32(dev->of_node, "reg", ®);
if (ret < 0) {
- dev_err(dev, "missing base address and/or range");
+ dev_err(dev, "missing base address");
return ret;
}
- npins = res[1] / PMIC_MPP_ADDRESS_RANGE;
+ npins = of_irq_count(dev->of_node);
if (!npins)
return -EINVAL;
@@ -854,7 +855,7 @@ static int pmic_mpp_probe(struct platform_device *pdev)
if (pad->irq < 0)
return pad->irq;
- pad->base = res[0] + i * PMIC_MPP_ADDRESS_RANGE;
+ pad->base = reg + i * PMIC_MPP_ADDRESS_RANGE;
ret = pmic_mpp_populate(state, pad);
if (ret < 0)
diff --git a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
index d809c9eaa323..78fa2281116d 100644
--- a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
@@ -23,6 +23,7 @@
#include <linux/gpio.h>
#include <linux/interrupt.h>
#include <linux/of_device.h>
+#include <linux/of_irq.h>
#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
@@ -650,11 +651,12 @@ static int pm8xxx_pin_populate(struct pm8xxx_gpio *pctrl,
}
static const struct of_device_id pm8xxx_gpio_of_match[] = {
- { .compatible = "qcom,pm8018-gpio", .data = (void *)6 },
- { .compatible = "qcom,pm8038-gpio", .data = (void *)12 },
- { .compatible = "qcom,pm8058-gpio", .data = (void *)40 },
- { .compatible = "qcom,pm8917-gpio", .data = (void *)38 },
- { .compatible = "qcom,pm8921-gpio", .data = (void *)44 },
+ { .compatible = "qcom,pm8018-gpio" },
+ { .compatible = "qcom,pm8038-gpio" },
+ { .compatible = "qcom,pm8058-gpio" },
+ { .compatible = "qcom,pm8917-gpio" },
+ { .compatible = "qcom,pm8921-gpio" },
+ { .compatible = "qcom,ssbi-gpio" },
{ },
};
MODULE_DEVICE_TABLE(of, pm8xxx_gpio_of_match);
@@ -672,7 +674,9 @@ static int pm8xxx_gpio_probe(struct platform_device *pdev)
return -ENOMEM;
pctrl->dev = &pdev->dev;
- pctrl->npins = (unsigned)of_device_get_match_data(&pdev->dev);
+ pctrl->npins = of_irq_count(pdev->dev.of_node);
+ if (!pctrl->npins)
+ return -EINVAL;
pctrl->regmap = dev_get_regmap(pdev->dev.parent, NULL);
if (!pctrl->regmap) {
diff --git a/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c b/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c
index 8982027de8e8..0831063da54c 100644
--- a/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c
+++ b/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c
@@ -23,6 +23,7 @@
#include <linux/gpio.h>
#include <linux/interrupt.h>
#include <linux/of_device.h>
+#include <linux/of_irq.h>
#include <dt-bindings/pinctrl/qcom,pmic-mpp.h>
@@ -741,11 +742,12 @@ static int pm8xxx_pin_populate(struct pm8xxx_mpp *pctrl,
}
static const struct of_device_id pm8xxx_mpp_of_match[] = {
- { .compatible = "qcom,pm8018-mpp", .data = (void *)6 },
- { .compatible = "qcom,pm8038-mpp", .data = (void *)6 },
- { .compatible = "qcom,pm8917-mpp", .data = (void *)10 },
- { .compatible = "qcom,pm8821-mpp", .data = (void *)4 },
- { .compatible = "qcom,pm8921-mpp", .data = (void *)12 },
+ { .compatible = "qcom,pm8018-mpp" },
+ { .compatible = "qcom,pm8038-mpp" },
+ { .compatible = "qcom,pm8917-mpp" },
+ { .compatible = "qcom,pm8821-mpp" },
+ { .compatible = "qcom,pm8921-mpp" },
+ { .compatible = "qcom,ssbi-mpp" },
{ },
};
MODULE_DEVICE_TABLE(of, pm8xxx_mpp_of_match);
@@ -763,7 +765,9 @@ static int pm8xxx_mpp_probe(struct platform_device *pdev)
return -ENOMEM;
pctrl->dev = &pdev->dev;
- pctrl->npins = (unsigned)of_device_get_match_data(&pdev->dev);
+ pctrl->npins = of_irq_count(pdev->dev.of_node);
+ if (!pctrl->npins)
+ return -EINVAL;
pctrl->regmap = dev_get_regmap(pdev->dev.parent, NULL);
if (!pctrl->regmap) {
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] pinctrl: qcom: pmic-gpio/mpp: of_irq_count() == npins
2015-11-18 19:33 ` [PATCH] pinctrl: qcom: pmic-gpio/mpp: of_irq_count() == npins Stephen Boyd
@ 2015-11-19 6:04 ` Andy Gross
2015-11-23 18:21 ` Bjorn Andersson
2015-12-01 9:02 ` Linus Walleij
2 siblings, 0 replies; 10+ messages in thread
From: Andy Gross @ 2015-11-19 6:04 UTC (permalink / raw)
To: Stephen Boyd
Cc: Linus Walleij, linux-kernel, linux-arm-msm, linux-arm-kernel,
linux-gpio, Ivan T. Ivanov, Bjorn Andersson
On Wed, Nov 18, 2015 at 11:33:17AM -0800, Stephen Boyd wrote:
> The number of interrupts is always equal to the number of pins
> provided by the PMIC gpio and MPP hardware blocks. Count the
> number of irqs to figure out the number of pins instead of adding
> more compatible strings or doing math on the reg property. This
> should make the code more generic and ease the number of changes
> we have to make to the driver for each new pmic revision.
>
> Cc: "Ivan T. Ivanov" <iivanov@mm-sol.com>
> Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
This is pretty nice.
Reviewed-by: Andy Gross <agross@codeaurora.org>
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] pinctrl: qcom: pmic-gpio/mpp: of_irq_count() == npins
2015-11-18 19:33 ` [PATCH] pinctrl: qcom: pmic-gpio/mpp: of_irq_count() == npins Stephen Boyd
2015-11-19 6:04 ` Andy Gross
@ 2015-11-23 18:21 ` Bjorn Andersson
2015-12-01 9:02 ` Linus Walleij
2 siblings, 0 replies; 10+ messages in thread
From: Bjorn Andersson @ 2015-11-23 18:21 UTC (permalink / raw)
To: Stephen Boyd
Cc: Linus Walleij, linux-kernel, linux-arm-msm, linux-arm-kernel,
linux-gpio, Andy Gross, Ivan T. Ivanov
On Wed 18 Nov 11:33 PST 2015, Stephen Boyd wrote:
> The number of interrupts is always equal to the number of pins
> provided by the PMIC gpio and MPP hardware blocks. Count the
> number of irqs to figure out the number of pins instead of adding
> more compatible strings or doing math on the reg property. This
> should make the code more generic and ease the number of changes
> we have to make to the driver for each new pmic revision.
>
> Cc: "Ivan T. Ivanov" <iivanov@mm-sol.com>
> Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
Reviewed-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Regards,
Bjorn
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] pinctrl: qcom: pmic-gpio/mpp: of_irq_count() == npins
2015-11-18 19:33 ` [PATCH] pinctrl: qcom: pmic-gpio/mpp: of_irq_count() == npins Stephen Boyd
2015-11-19 6:04 ` Andy Gross
2015-11-23 18:21 ` Bjorn Andersson
@ 2015-12-01 9:02 ` Linus Walleij
2 siblings, 0 replies; 10+ messages in thread
From: Linus Walleij @ 2015-12-01 9:02 UTC (permalink / raw)
To: Stephen Boyd
Cc: linux-kernel, linux-arm-msm, linux-arm-kernel, linux-gpio,
Andy Gross, Ivan T. Ivanov, Bjorn Andersson
On Wed, Nov 18, 2015 at 8:33 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> The number of interrupts is always equal to the number of pins
> provided by the PMIC gpio and MPP hardware blocks. Count the
> number of irqs to figure out the number of pins instead of adding
> more compatible strings or doing math on the reg property. This
> should make the code more generic and ease the number of changes
> we have to make to the driver for each new pmic revision.
>
> Cc: "Ivan T. Ivanov" <iivanov@mm-sol.com>
> Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Patch applied with Andy's and Björn's ACKs.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RFC/PATCH] pinctrl: qcom: Add generic ssbi and spmi GPIO/MPP bindings
2015-11-18 1:00 [RFC/PATCH] pinctrl: qcom: Add generic ssbi and spmi GPIO/MPP bindings Stephen Boyd
2015-11-18 4:09 ` Andy Gross
2015-11-18 19:33 ` [PATCH] pinctrl: qcom: pmic-gpio/mpp: of_irq_count() == npins Stephen Boyd
@ 2015-11-19 14:50 ` Rob Herring
2015-11-20 17:53 ` Stephen Boyd
2015-11-23 6:37 ` Ivan T. Ivanov
2015-11-23 18:22 ` Bjorn Andersson
4 siblings, 1 reply; 10+ messages in thread
From: Rob Herring @ 2015-11-19 14:50 UTC (permalink / raw)
To: Stephen Boyd
Cc: Linus Walleij, linux-kernel, linux-arm-msm, linux-arm-kernel,
linux-gpio, devicetree, Ivan T. Ivanov, Bjorn Andersson
On Tue, Nov 17, 2015 at 05:00:26PM -0800, Stephen Boyd wrote:
> The drivers don't really need to know which PMIC they're for, so
> make a generic binding for them. This alleviates us from updating
> the drivers every time a new PMIC comes out. It's still
> recommended that we update the binding with new PMIC models and
> always specify the specific model for the MPPs and gpios before
> the generic compatible string in devicetree, but this at least
> cuts down on adding more and more compatible strings to the
> drivers until we actually need them.
>
> Cc: <devicetree@vger.kernel.org>
> Cc: "Ivan T. Ivanov" <iivanov@mm-sol.com>
> Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
Seems okay to me. I assume you are going to update all the dts files?
Rob
>
> We can also figure out the number of the pins from the number
> of interrupts, so we really don't need to even look at the size of the
> reg property or model number for the spmi and ssbi modules. I'll propose
> that change as well tomorrow.
>
> Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 5 ++++-
> Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt | 5 ++++-
> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
> drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 1 +
> 4 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> index a90c812ad642..f1e4643f4132 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> @@ -17,6 +17,9 @@ PMIC's from Qualcomm.
> "qcom,pm8994-gpio"
> "qcom,pma8084-gpio"
>
> + And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
> + if the device is on an spmi bus or an ssbi bus respectively
> +
> - reg:
> Usage: required
> Value type: <prop-encoded-array>
> @@ -183,7 +186,7 @@ to specify in a pin configuration subnode:
> Example:
>
> pm8921_gpio: gpio@150 {
> - compatible = "qcom,pm8921-gpio";
> + compatible = "qcom,pm8921-gpio", "qcom,ssbi-gpio";
> reg = <0x150 0x160>;
> interrupts = <192 1>, <193 1>, <194 1>,
> <195 1>, <196 1>, <197 1>,
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt
> index d74e631e10da..e28320b18ecb 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt
> @@ -18,6 +18,9 @@ of PMIC's from Qualcomm.
> "qcom,pm8994-mpp",
> "qcom,pma8084-mpp",
>
> + And must contain either "qcom,spmi-mpp" or "qcom,ssbi-mpp"
> + if the device is on an spmi bus or an ssbi bus respectively.
> +
> - reg:
> Usage: required
> Value type: <prop-encoded-array>
> @@ -157,7 +160,7 @@ to specify in a pin configuration subnode:
> Example:
>
> mpps@a000 {
> - compatible = "qcom,pm8841-mpp";
> + compatible = "qcom,pm8841-mpp", "qcom,spmi-mpp";
> reg = <0xa000>;
> gpio-controller;
> #gpio-cells = <2>;
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index df4413023e21..9f9979903fcb 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -806,6 +806,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
> { .compatible = "qcom,pm8941-gpio" }, /* 36 GPIO's */
> { .compatible = "qcom,pm8994-gpio" }, /* 22 GPIO's */
> { .compatible = "qcom,pma8084-gpio" }, /* 22 GPIO's */
> + { .compatible = "qcom,spmi-gpio" }, /* Generic */
> { },
> };
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
> index 7b4136a22c5b..5a4373dd9c61 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
> @@ -909,6 +909,7 @@ static const struct of_device_id pmic_mpp_of_match[] = {
> { .compatible = "qcom,pm8941-mpp" }, /* 8 MPP's */
> { .compatible = "qcom,pm8994-mpp" }, /* 8 MPP's */
> { .compatible = "qcom,pma8084-mpp" }, /* 8 MPP's */
> + { .compatible = "qcom,spmi-mpp" }, /* Generic */
> { },
> };
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [RFC/PATCH] pinctrl: qcom: Add generic ssbi and spmi GPIO/MPP bindings
2015-11-19 14:50 ` [RFC/PATCH] pinctrl: qcom: Add generic ssbi and spmi GPIO/MPP bindings Rob Herring
@ 2015-11-20 17:53 ` Stephen Boyd
0 siblings, 0 replies; 10+ messages in thread
From: Stephen Boyd @ 2015-11-20 17:53 UTC (permalink / raw)
To: Rob Herring
Cc: Linus Walleij, linux-kernel, linux-arm-msm, linux-arm-kernel,
linux-gpio, devicetree, Ivan T. Ivanov, Bjorn Andersson
On 11/19, Rob Herring wrote:
> On Tue, Nov 17, 2015 at 05:00:26PM -0800, Stephen Boyd wrote:
> > The drivers don't really need to know which PMIC they're for, so
> > make a generic binding for them. This alleviates us from updating
> > the drivers every time a new PMIC comes out. It's still
> > recommended that we update the binding with new PMIC models and
> > always specify the specific model for the MPPs and gpios before
> > the generic compatible string in devicetree, but this at least
> > cuts down on adding more and more compatible strings to the
> > drivers until we actually need them.
> >
> > Cc: <devicetree@vger.kernel.org>
> > Cc: "Ivan T. Ivanov" <iivanov@mm-sol.com>
> > Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> > ---
>
> Seems okay to me. I assume you are going to update all the dts files?
Yep, I'll send out patches to do that.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RFC/PATCH] pinctrl: qcom: Add generic ssbi and spmi GPIO/MPP bindings
2015-11-18 1:00 [RFC/PATCH] pinctrl: qcom: Add generic ssbi and spmi GPIO/MPP bindings Stephen Boyd
` (2 preceding siblings ...)
2015-11-19 14:50 ` [RFC/PATCH] pinctrl: qcom: Add generic ssbi and spmi GPIO/MPP bindings Rob Herring
@ 2015-11-23 6:37 ` Ivan T. Ivanov
2015-11-23 18:22 ` Bjorn Andersson
4 siblings, 0 replies; 10+ messages in thread
From: Ivan T. Ivanov @ 2015-11-23 6:37 UTC (permalink / raw)
To: Stephen Boyd
Cc: Linus Walleij, linux-kernel, linux-arm-msm, linux-arm-kernel,
linux-gpio, devicetree, Ivan T. Ivanov, Bjorn Andersson
> On Nov 18, 2015, at 3:00 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>
> The drivers don't really need to know which PMIC they're for, so
> make a generic binding for them. This alleviates us from updating
> the drivers every time a new PMIC comes out. It's still
> recommended that we update the binding with new PMIC models and
> always specify the specific model for the MPPs and gpios before
> the generic compatible string in devicetree, but this at least
> cuts down on adding more and more compatible strings to the
> drivers until we actually need them.
>
> Cc: <devicetree@vger.kernel.org>
> Cc: "Ivan T. Ivanov" <iivanov@mm-sol.com>
> Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Thanks.
Acked-by: Ivan T. Ivanov <iivanov.xz@gmail.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [RFC/PATCH] pinctrl: qcom: Add generic ssbi and spmi GPIO/MPP bindings
2015-11-18 1:00 [RFC/PATCH] pinctrl: qcom: Add generic ssbi and spmi GPIO/MPP bindings Stephen Boyd
` (3 preceding siblings ...)
2015-11-23 6:37 ` Ivan T. Ivanov
@ 2015-11-23 18:22 ` Bjorn Andersson
4 siblings, 0 replies; 10+ messages in thread
From: Bjorn Andersson @ 2015-11-23 18:22 UTC (permalink / raw)
To: Stephen Boyd
Cc: Linus Walleij, linux-kernel, linux-arm-msm, linux-arm-kernel,
linux-gpio, devicetree, Ivan T. Ivanov
On Tue 17 Nov 17:00 PST 2015, Stephen Boyd wrote:
> The drivers don't really need to know which PMIC they're for, so
> make a generic binding for them. This alleviates us from updating
> the drivers every time a new PMIC comes out. It's still
> recommended that we update the binding with new PMIC models and
> always specify the specific model for the MPPs and gpios before
> the generic compatible string in devicetree, but this at least
> cuts down on adding more and more compatible strings to the
> drivers until we actually need them.
>
> Cc: <devicetree@vger.kernel.org>
> Cc: "Ivan T. Ivanov" <iivanov@mm-sol.com>
> Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>
I must say that when it comes to writing dts files I much prefer the msm
way of denoting functions over the pmic one. But because of that
decision this makes perfect sense!
Reviewed-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Regards,
Bjorn
^ permalink raw reply [flat|nested] 10+ messages in thread