From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH 5/7] perf top: Delay UI browser setup after initialization is done
Date: Thu, 10 Dec 2015 14:43:32 -0300 [thread overview]
Message-ID: <20151210174332.GD17996@kernel.org> (raw)
In-Reply-To: <1449716459-23004-6-git-send-email-namhyung@kernel.org>
Em Thu, Dec 10, 2015 at 12:00:57PM +0900, Namhyung Kim escreveu:
> Move setup_browser after all necessary initialization is done. This
> is to remove the browser dependency from usage_with_options() and
> friends.
So, please try:
perf top -C 0 -p 1
So that we get a command line validation error that will cause cmd_top
to trip this:
status = target__validate(target);
if (status) {
target__strerror(target, status, errbuf, BUFSIZ);
ui__warning("%s\n", errbuf);
}
ui__warning() will emit the warning to stdio, and this message will be
seen only after the user exits the tool:
[root@ssdandy ~]# perf top -C 0 -p 1
Warning:
PID/TID switch overriding CPU
Where without this patch the user will be warning with a popup window,
that has to be acknowledged with an enter before proceeding.
Looking at the other patches to check which can be processed now,
leaving this one for later.
- Arnaldo
> Cc: Josh Poimboeuf <jpoimboe@redhat.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/perf/builtin-top.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
> index 7e2e72e6d9d1..75134e106a62 100644
> --- a/tools/perf/builtin-top.c
> +++ b/tools/perf/builtin-top.c
> @@ -1252,13 +1252,6 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused)
> goto out_delete_evlist;
> }
>
> - if (top.use_stdio)
> - use_browser = 0;
> - else if (top.use_tui)
> - use_browser = 1;
> -
> - setup_browser(false);
> -
> status = target__validate(target);
> if (status) {
> target__strerror(target, status, errbuf, BUFSIZ);
> @@ -1326,6 +1319,13 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused)
> sigaction(SIGWINCH, &act, NULL);
> }
>
> + if (top.use_stdio)
> + use_browser = 0;
> + else if (top.use_tui)
> + use_browser = 1;
> +
> + setup_browser(false);
> +
> status = __cmd_top(&top);
>
> out_delete_evlist:
> --
> 2.6.2
next prev parent reply other threads:[~2015-12-10 17:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 3:00 [PATCHSET 0/7] perf tools: Remove browser dependency from usage_with_options() Namhyung Kim
2015-12-10 3:00 ` [PATCH 1/7] perf annotate: Check argument before calling setup_browser() Namhyung Kim
2015-12-14 8:12 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-12-10 3:00 ` [PATCH 2/7] perf annotate: Delay UI browser setup after initialization is done Namhyung Kim
2015-12-14 8:13 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-12-10 3:00 ` [PATCH 3/7] perf kvm: Remove invocation of setup/exit_browser() Namhyung Kim
2015-12-14 8:13 ` [tip:perf/core] perf kvm: Remove invocation of setup/exit_browser () tip-bot for Namhyung Kim
2015-12-10 3:00 ` [PATCH 4/7] perf report: Check argument before calling setup_browser() Namhyung Kim
2015-12-14 8:13 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-12-10 3:00 ` [PATCH 5/7] perf top: Delay UI browser setup after initialization is done Namhyung Kim
2015-12-10 17:43 ` Arnaldo Carvalho de Melo [this message]
2015-12-10 17:52 ` Arnaldo Carvalho de Melo
2015-12-10 18:06 ` Arnaldo Carvalho de Melo
2015-12-10 3:00 ` [PATCH 6/7] perf tools: Free strlist on error path Namhyung Kim
2015-12-14 8:14 ` [tip:perf/core] perf thread_map: Free strlist on constructor " tip-bot for Namhyung Kim
2015-12-10 3:00 ` [PATCH 7/7] perf tools: Get rid of exit_browser() from usage_with_options() Namhyung Kim
2015-12-14 8:14 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-12-10 15:10 ` [PATCHSET 0/7] perf tools: Remove browser dependency " Josh Poimboeuf
2015-12-10 18:53 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210174332.GD17996@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).