From: Andi Kleen <andi@firstfloor.org>
To: Stephane Eranian <eranian@google.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Jiri Olsa <jolsa@kernel.org>, Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: Add top down metrics to perf stat v2
Date: Thu, 17 Dec 2015 15:01:23 +0100 [thread overview]
Message-ID: <20151217140123.GA15533@two.firstfloor.org> (raw)
In-Reply-To: <CABPqkBS5X+cBK0SrmRP6Wn+_H-f0MJh2JZj_X3FRuV26z3adXQ@mail.gmail.com>
On Thu, Dec 17, 2015 at 02:27:58AM -0800, Stephane Eranian wrote:
> > S0-C1 2 4175583320.00 topdown-slots-retired (100.00%)
> > S0-C1 2 1743329246 topdown-recovery-bubbles # 22.22% bad speculation (100.00%)
> > S0-C1 2 6138901193.50 topdown-slots-issued # 46.99% backend bound
> >
> I don't see how this output could be very useful. What matters is the
> percentage in the comments
> and not so much the raw counts because what is the unit? Same remark
> holds for the percentage.
> I think you need to explain or show that this is % of issue slots and
> not cycles.
The events already say slots, not cycles. Except for recovery-bubbles. Could add
-slots there too if you think it's helpful, although it would make the
name very long and may not fit into the column anymore.
>
> > 1.535832673 seconds time elapsed
> >
> > $ perf stat --topdown --topdown --metric-only -I 100 ./BC1s
>
> When I tried from your git tree the --metric-only option was not recognized.
See below.
>
> > 0.100576098 frontend bound retiring bad speculation backend bound
> > 0.100576098 8.83% 48.93% 35.24% 7.00%
> > 0.200800845 8.84% 48.49% 35.53% 7.13%
> > 0.300905983 8.73% 48.64% 35.58% 7.05%
> > ...
> >
> This kind of output is more meaningful and clearer for end-users based
> on my experience
> and you'd like it per-core possibly.
Yes --metric-only is a lot clearer.
per-core is supported and automatically enabled with SMT on.
> > Full tree available in
> > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc perf/top-down-11
>
> That is in the top-down-2 branch instead, I think.
Sorry, typo
The correct branch is perf/top-down-10
I also updated it now with the latest review feedback changes.
top-down-2 is an really old branch that indeed didn't have metric-only.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2015-12-17 14:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 0:54 Add top down metrics to perf stat v2 Andi Kleen
2015-12-16 0:54 ` [PATCH 01/10] perf, tools: Dont stop PMU parsing on alias parse error Andi Kleen
2015-12-21 16:08 ` Jiri Olsa
2015-12-16 0:54 ` [PATCH 02/10] perf, tools, stat: Force --per-core mode for .agg-per-core aliases Andi Kleen
2015-12-16 14:16 ` Stephane Eranian
2015-12-21 16:14 ` Jiri Olsa
2015-12-21 16:16 ` Jiri Olsa
2015-12-16 0:54 ` [PATCH 03/10] perf, tools, stat: Avoid fractional digits for integer scales Andi Kleen
2015-12-16 14:22 ` Stephane Eranian
2015-12-16 0:54 ` [PATCH 04/10] perf, tools, stat: Scale values by unit before metrics Andi Kleen
2015-12-16 0:54 ` [PATCH 05/10] perf, tools, stat: Basic support for TopDown in perf stat Andi Kleen
2015-12-16 14:32 ` Stephane Eranian
2015-12-16 21:21 ` Andi Kleen
2015-12-17 9:26 ` Stephane Eranian
2015-12-17 14:03 ` Andi Kleen
2015-12-16 0:54 ` [PATCH 06/10] perf, tools, stat: Add computation of TopDown formulas Andi Kleen
2015-12-16 0:54 ` [PATCH 07/10] perf, tools, stat: Add extra output of counter values with -v Andi Kleen
2015-12-16 0:54 ` [PATCH 08/10] x86, perf: Support sysfs files depending on SMT status Andi Kleen
2015-12-16 8:53 ` Peter Zijlstra
2015-12-16 12:48 ` Stephane Eranian
2015-12-16 16:26 ` Andi Kleen
2015-12-16 0:54 ` [PATCH 09/10] x86, perf: Add Top Down events to Intel Core Andi Kleen
2015-12-16 0:54 ` [PATCH 10/10] x86, perf: Add Top Down events to Intel Atom Andi Kleen
2015-12-17 10:27 ` Add top down metrics to perf stat v2 Stephane Eranian
2015-12-17 14:01 ` Andi Kleen [this message]
2015-12-17 23:31 ` Stephane Eranian
2015-12-18 1:55 ` Andi Kleen
2015-12-18 9:31 ` Stephane Eranian
2015-12-18 21:38 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151217140123.GA15533@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).