From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, peterz@infradead.org, jolsa@kernel.org,
mingo@kernel.org, linux-kernel@vger.kernel.org,
eranian@google.com, namhyung@kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 01/10] perf, tools: Dont stop PMU parsing on alias parse error
Date: Mon, 21 Dec 2015 17:08:57 +0100 [thread overview]
Message-ID: <20151221160857.GA21700@krava.brq.redhat.com> (raw)
In-Reply-To: <1450227266-2501-2-git-send-email-andi@firstfloor.org>
On Tue, Dec 15, 2015 at 04:54:17PM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> When an error happens during alias parsing currently the complete
> parsing of all attributes of the PMU is stopped. This is breaks
> old perf on a newer kernel that may have not-yet-know
> alias attributes (such as .scale or .per-pkg).
I kind of recall seeing similar patch, but looks like
it never made it in
>
> Continue when some attribute is unparseable.
>
> This is IMHO a stable candidate and should be backported
> to older versions to avoid problems with newer kernels.
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> tools/perf/util/pmu.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index e4b173d..8a520e9 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -283,13 +283,12 @@ static int pmu_aliases_parse(char *dir, struct list_head *head)
> {
> struct dirent *evt_ent;
> DIR *event_dir;
> - int ret = 0;
>
> event_dir = opendir(dir);
> if (!event_dir)
> return -EINVAL;
>
> - while (!ret && (evt_ent = readdir(event_dir))) {
> + while ((evt_ent = readdir(event_dir))) {
> char path[PATH_MAX];
> char *name = evt_ent->d_name;
> FILE *file;
> @@ -305,17 +304,16 @@ static int pmu_aliases_parse(char *dir, struct list_head *head)
>
> snprintf(path, PATH_MAX, "%s/%s", dir, name);
>
> - ret = -EINVAL;
> file = fopen(path, "r");
> if (!file)
> - break;
> + continue;
I think we should emit warning in case of failure to let user know
>
> - ret = perf_pmu__new_alias(head, dir, name, file);
same here
> + perf_pmu__new_alias(head, dir, name, file);
> fclose(file);
> }
>
thanks,
jirka
next prev parent reply other threads:[~2015-12-21 16:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 0:54 Add top down metrics to perf stat v2 Andi Kleen
2015-12-16 0:54 ` [PATCH 01/10] perf, tools: Dont stop PMU parsing on alias parse error Andi Kleen
2015-12-21 16:08 ` Jiri Olsa [this message]
2015-12-16 0:54 ` [PATCH 02/10] perf, tools, stat: Force --per-core mode for .agg-per-core aliases Andi Kleen
2015-12-16 14:16 ` Stephane Eranian
2015-12-21 16:14 ` Jiri Olsa
2015-12-21 16:16 ` Jiri Olsa
2015-12-16 0:54 ` [PATCH 03/10] perf, tools, stat: Avoid fractional digits for integer scales Andi Kleen
2015-12-16 14:22 ` Stephane Eranian
2015-12-16 0:54 ` [PATCH 04/10] perf, tools, stat: Scale values by unit before metrics Andi Kleen
2015-12-16 0:54 ` [PATCH 05/10] perf, tools, stat: Basic support for TopDown in perf stat Andi Kleen
2015-12-16 14:32 ` Stephane Eranian
2015-12-16 21:21 ` Andi Kleen
2015-12-17 9:26 ` Stephane Eranian
2015-12-17 14:03 ` Andi Kleen
2015-12-16 0:54 ` [PATCH 06/10] perf, tools, stat: Add computation of TopDown formulas Andi Kleen
2015-12-16 0:54 ` [PATCH 07/10] perf, tools, stat: Add extra output of counter values with -v Andi Kleen
2015-12-16 0:54 ` [PATCH 08/10] x86, perf: Support sysfs files depending on SMT status Andi Kleen
2015-12-16 8:53 ` Peter Zijlstra
2015-12-16 12:48 ` Stephane Eranian
2015-12-16 16:26 ` Andi Kleen
2015-12-16 0:54 ` [PATCH 09/10] x86, perf: Add Top Down events to Intel Core Andi Kleen
2015-12-16 0:54 ` [PATCH 10/10] x86, perf: Add Top Down events to Intel Atom Andi Kleen
2015-12-17 10:27 ` Add top down metrics to perf stat v2 Stephane Eranian
2015-12-17 14:01 ` Andi Kleen
2015-12-17 23:31 ` Stephane Eranian
2015-12-18 1:55 ` Andi Kleen
2015-12-18 9:31 ` Stephane Eranian
2015-12-18 21:38 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151221160857.GA21700@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).