* [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c
@ 2015-12-17 15:05 Paul Gortmaker
2015-12-17 15:43 ` Nicolas Ferre
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Paul Gortmaker @ 2015-12-17 15:05 UTC (permalink / raw)
To: linux-kernel
Cc: Paul Gortmaker, Nicolas Ferre, Jiri Slaby, linux-serial,
Greg Kroah-Hartman, Sudip Mukherjee
In commit c39dfebc7798956fd2140ae6321786ff35da30c3 ("drivers/tty/serial:
make serial/atmel_serial.c explicitly non-modular") we removed the code
relating to modular support since it currently only supports built in.
However, when redoing my build coverage for mips allmodconfig, which
sets CONFIG_OF, I noticed a remaining line that needs to be removed,
else we will get a build failure for an undefined module macro.
Unfortunately this didn't appear for any of the other arch I tested
more frequently, such as ARM.
Since MODULE_DEVICE_TABLE is a no-op for non-modular code, we can just
remove the offending line.
Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sudip Mukherjee <sudip@vectorindia.org>
Reported-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/tty/serial/atmel_serial.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index 50e785a0ea73..1c0884d8ef32 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -188,8 +188,6 @@ static const struct of_device_id atmel_serial_dt_ids[] = {
{ .compatible = "atmel,at91sam9260-usart" },
{ /* sentinel */ }
};
-
-MODULE_DEVICE_TABLE(of, atmel_serial_dt_ids);
#endif
static inline struct atmel_uart_port *
--
2.6.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c
2015-12-17 15:05 [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c Paul Gortmaker
@ 2015-12-17 15:43 ` Nicolas Ferre
2015-12-17 16:48 ` Sudip Mukherjee
2016-01-02 7:47 ` Sudip Mukherjee
2 siblings, 0 replies; 6+ messages in thread
From: Nicolas Ferre @ 2015-12-17 15:43 UTC (permalink / raw)
To: Paul Gortmaker, linux-kernel, linux-serial, Greg Kroah-Hartman
Cc: Jiri Slaby, Sudip Mukherjee
Le 17/12/2015 16:05, Paul Gortmaker a écrit :
> In commit c39dfebc7798956fd2140ae6321786ff35da30c3 ("drivers/tty/serial:
> make serial/atmel_serial.c explicitly non-modular") we removed the code
> relating to modular support since it currently only supports built in.
>
> However, when redoing my build coverage for mips allmodconfig, which
> sets CONFIG_OF, I noticed a remaining line that needs to be removed,
> else we will get a build failure for an undefined module macro.
>
> Unfortunately this didn't appear for any of the other arch I tested
> more frequently, such as ARM.
>
> Since MODULE_DEVICE_TABLE is a no-op for non-modular code, we can just
> remove the offending line.
>
> Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Absolutely:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thank you Sudip and Paul.
Bye,
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: linux-serial@vger.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Sudip Mukherjee <sudip@vectorindia.org>
> Reported-by: Sudip Mukherjee <sudip@vectorindia.org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
> drivers/tty/serial/atmel_serial.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index 50e785a0ea73..1c0884d8ef32 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -188,8 +188,6 @@ static const struct of_device_id atmel_serial_dt_ids[] = {
> { .compatible = "atmel,at91sam9260-usart" },
> { /* sentinel */ }
> };
> -
> -MODULE_DEVICE_TABLE(of, atmel_serial_dt_ids);
> #endif
>
> static inline struct atmel_uart_port *
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c
2015-12-17 15:05 [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c Paul Gortmaker
2015-12-17 15:43 ` Nicolas Ferre
@ 2015-12-17 16:48 ` Sudip Mukherjee
2016-01-02 7:47 ` Sudip Mukherjee
2 siblings, 0 replies; 6+ messages in thread
From: Sudip Mukherjee @ 2015-12-17 16:48 UTC (permalink / raw)
To: Paul Gortmaker
Cc: linux-kernel, Nicolas Ferre, Jiri Slaby, linux-serial,
Greg Kroah-Hartman, Sudip Mukherjee
On Thu, Dec 17, 2015 at 10:05:46AM -0500, Paul Gortmaker wrote:
> In commit c39dfebc7798956fd2140ae6321786ff35da30c3 ("drivers/tty/serial:
> make serial/atmel_serial.c explicitly non-modular") we removed the code
> relating to modular support since it currently only supports built in.
>
> However, when redoing my build coverage for mips allmodconfig, which
> sets CONFIG_OF, I noticed a remaining line that needs to be removed,
> else we will get a build failure for an undefined module macro.
>
> Unfortunately this didn't appear for any of the other arch I tested
> more frequently, such as ARM.
>
> Since MODULE_DEVICE_TABLE is a no-op for non-modular code, we can just
> remove the offending line.
>
> Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: linux-serial@vger.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Sudip Mukherjee <sudip@vectorindia.org>
> Reported-by: Sudip Mukherjee <sudip@vectorindia.org>
Acked-by: Sudip Mukherjee <sudip@vectorindia.org>
regards
sudip
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c
2015-12-17 15:05 [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c Paul Gortmaker
2015-12-17 15:43 ` Nicolas Ferre
2015-12-17 16:48 ` Sudip Mukherjee
@ 2016-01-02 7:47 ` Sudip Mukherjee
2016-01-04 20:43 ` Paul Gortmaker
2 siblings, 1 reply; 6+ messages in thread
From: Sudip Mukherjee @ 2016-01-02 7:47 UTC (permalink / raw)
To: Paul Gortmaker
Cc: linux-kernel, Nicolas Ferre, Jiri Slaby, linux-serial,
Greg Kroah-Hartman, Sudip Mukherjee
On Thu, Dec 17, 2015 at 10:05:46AM -0500, Paul Gortmaker wrote:
> In commit c39dfebc7798956fd2140ae6321786ff35da30c3 ("drivers/tty/serial:
> make serial/atmel_serial.c explicitly non-modular") we removed the code
> relating to modular support since it currently only supports built in.
>
> However, when redoing my build coverage for mips allmodconfig, which
> sets CONFIG_OF, I noticed a remaining line that needs to be removed,
> else we will get a build failure for an undefined module macro.
>
> Unfortunately this didn't appear for any of the other arch I tested
> more frequently, such as ARM.
>
> Since MODULE_DEVICE_TABLE is a no-op for non-modular code, we can just
> remove the offending line.
>
> Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: linux-serial@vger.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Sudip Mukherjee <sudip@vectorindia.org>
> Reported-by: Sudip Mukherjee <sudip@vectorindia.org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
I think this has not yet landed in linux-next. next-20151231 still
fails.
regards
sudip
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c
2016-01-02 7:47 ` Sudip Mukherjee
@ 2016-01-04 20:43 ` Paul Gortmaker
2016-01-05 7:03 ` Sudip Mukherjee
0 siblings, 1 reply; 6+ messages in thread
From: Paul Gortmaker @ 2016-01-04 20:43 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: linux-kernel, Nicolas Ferre, Jiri Slaby, linux-serial,
Greg Kroah-Hartman, Sudip Mukherjee
[Re: [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c] On 02/01/2016 (Sat 13:17) Sudip Mukherjee wrote:
> On Thu, Dec 17, 2015 at 10:05:46AM -0500, Paul Gortmaker wrote:
> > In commit c39dfebc7798956fd2140ae6321786ff35da30c3 ("drivers/tty/serial:
> > make serial/atmel_serial.c explicitly non-modular") we removed the code
> > relating to modular support since it currently only supports built in.
> >
> > However, when redoing my build coverage for mips allmodconfig, which
> > sets CONFIG_OF, I noticed a remaining line that needs to be removed,
> > else we will get a build failure for an undefined module macro.
> >
> > Unfortunately this didn't appear for any of the other arch I tested
> > more frequently, such as ARM.
> >
> > Since MODULE_DEVICE_TABLE is a no-op for non-modular code, we can just
> > remove the offending line.
> >
> > Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
> > Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
> > Cc: Jiri Slaby <jslaby@suse.com>
> > Cc: linux-serial@vger.kernel.org
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Sudip Mukherjee <sudip@vectorindia.org>
> > Reported-by: Sudip Mukherjee <sudip@vectorindia.org>
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> > ---
>
> I think this has not yet landed in linux-next. next-20151231 still
> fails.
Greg has a lot of irons in the fire, and it is also the season where a
lot of people have unplugged for the last two weeks to be with family,
friends, etc, so lets be patient.
Thanks,
Paul.
--
>
> regards
> sudip
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c
2016-01-04 20:43 ` Paul Gortmaker
@ 2016-01-05 7:03 ` Sudip Mukherjee
0 siblings, 0 replies; 6+ messages in thread
From: Sudip Mukherjee @ 2016-01-05 7:03 UTC (permalink / raw)
To: Paul Gortmaker
Cc: linux-kernel, Nicolas Ferre, Jiri Slaby, linux-serial,
Greg Kroah-Hartman, Sudip Mukherjee
On Mon, Jan 04, 2016 at 03:43:25PM -0500, Paul Gortmaker wrote:
> [Re: [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c] On 02/01/2016 (Sat 13:17) Sudip Mukherjee wrote:
>
> > On Thu, Dec 17, 2015 at 10:05:46AM -0500, Paul Gortmaker wrote:
> > > In commit c39dfebc7798956fd2140ae6321786ff35da30c3 ("drivers/tty/serial:
> > > make serial/atmel_serial.c explicitly non-modular") we removed the code
> > > relating to modular support since it currently only supports built in.
> > >
> > > However, when redoing my build coverage for mips allmodconfig, which
> > > sets CONFIG_OF, I noticed a remaining line that needs to be removed,
> > > else we will get a build failure for an undefined module macro.
> > >
> > > Unfortunately this didn't appear for any of the other arch I tested
> > > more frequently, such as ARM.
> > >
> > > Since MODULE_DEVICE_TABLE is a no-op for non-modular code, we can just
> > > remove the offending line.
> > >
> > > Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
> > > Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
> > > Cc: Jiri Slaby <jslaby@suse.com>
> > > Cc: linux-serial@vger.kernel.org
> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Cc: Sudip Mukherjee <sudip@vectorindia.org>
> > > Reported-by: Sudip Mukherjee <sudip@vectorindia.org>
> > > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> > > ---
> >
> > I think this has not yet landed in linux-next. next-20151231 still
> > fails.
>
> Greg has a lot of irons in the fire, and it is also the season where a
> lot of people have unplugged for the last two weeks to be with family,
> friends, etc, so lets be patient.
Ohhh .. sorry , i didn't notice it will go through Greg.
regards
sudip
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-05 7:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-17 15:05 [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c Paul Gortmaker
2015-12-17 15:43 ` Nicolas Ferre
2015-12-17 16:48 ` Sudip Mukherjee
2016-01-02 7:47 ` Sudip Mukherjee
2016-01-04 20:43 ` Paul Gortmaker
2016-01-05 7:03 ` Sudip Mukherjee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).