From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: g@intel.com, tpmdd-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
"Martin Wilck" <Martin.Wilck@ts.fujitsu.com>,
"Peter Huewe" <peterhuewe@gmx.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v3 3/7] tpm_tis: Do not fall back to a hardcoded address for TPM2
Date: Sun, 20 Dec 2015 14:34:34 +0200 [thread overview]
Message-ID: <20151220123434.GA8232@intel.com> (raw)
In-Reply-To: <20151218165127.GC7354@obsidianresearch.com>
On Fri, Dec 18, 2015 at 09:51:27AM -0700, Jason Gunthorpe wrote:
> On Fri, Dec 18, 2015 at 11:34:32AM +0200, Jarkko Sakkinen wrote:
> > > + st = acpi_get_table(ACPI_SIG_TPM2, 1,
> > > + (struct acpi_table_header **) &tbl);
> > > + if (ACPI_FAILURE(st) || tbl->header.length < sizeof(*tbl)) {
> > > + dev_err(&acpi_dev->dev,
> > > + FW_BUG "failed to get TPM2 ACPI table\n");
> > > + return -EINVAL;
> > > + }
> > > +
> > > + if (tbl->start_method != ACPI_TPM2_MEMORY_MAPPED)
> > > return -ENODEV;
> > >
> > > INIT_LIST_HEAD(&resources);
> > > @@ -996,6 +978,12 @@ static int tpm_tis_acpi_init(struct acpi_device *acpi_dev)
> > >
> > > acpi_dev_free_resource_list(&resources);
> > >
> > > + if (tpm_info.start == 0 && tpm_info.len == 0) {
> > > + dev_err(&acpi_dev->dev,
> > > + FW_BUG "TPM2 ACPI table does not define a memory resource\n");
> > > + return -EINVAL;
> > > + }
> > > +
> >
> > I guess this the only relevant change in this patch? You should propose
> > removal of is_fifo() as a separate patch if that makes sense. This patch
> > is now doing orthogonal things.
>
> No, the return code changes are relevant too, and are why is_fifo was
> best un-inlined.
>
> The patch is fixing all the ACPI data validatation in one go, not just
> the resource range, the description notes this.
Got you. I think I'm good with this patch.
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Jason
/Jarkko
next prev parent reply other threads:[~2015-12-20 12:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 18:23 [PATCH v3 0/7] tpm_tis: Clean up force module parameter Jason Gunthorpe
2015-12-17 18:23 ` [PATCH v3 1/7] tpm_crb: Use the common ACPI definition of struct acpi_tpm2 Jason Gunthorpe
2016-01-03 17:09 ` Jarkko Sakkinen
2016-01-04 18:23 ` Jason Gunthorpe
2016-01-04 18:49 ` Jarkko Sakkinen
2015-12-17 18:23 ` [PATCH v3 2/7] tpm_tis: Disable interrupt auto probing on a per-device basis Jason Gunthorpe
2016-01-03 17:20 ` Jarkko Sakkinen
2016-01-04 18:24 ` Jason Gunthorpe
2016-01-04 18:32 ` Jarkko Sakkinen
2015-12-17 18:23 ` [PATCH v3 3/7] tpm_tis: Do not fall back to a hardcoded address for TPM2 Jason Gunthorpe
2015-12-18 9:34 ` Jarkko Sakkinen
2015-12-18 16:51 ` Jason Gunthorpe
2015-12-20 12:34 ` Jarkko Sakkinen [this message]
2015-12-17 18:23 ` [PATCH v3 4/7] tpm_tis: Use devm_ioremap_resource Jason Gunthorpe
2016-01-03 17:23 ` Jarkko Sakkinen
2015-12-17 18:23 ` [PATCH v3 5/7] tpm_tis: Clean up the force=1 module parameter Jason Gunthorpe
2016-01-03 17:26 ` Jarkko Sakkinen
2016-01-04 18:27 ` Jason Gunthorpe
2015-12-17 18:23 ` [PATCH v3 6/7] tpm_crb: Drop le32_to_cpu(ioread32(..)) Jason Gunthorpe
2016-01-03 17:28 ` Jarkko Sakkinen
2015-12-17 18:23 ` [PATCH v3 7/7] tpm_crb: Use devm_ioremap_resource Jason Gunthorpe
2016-01-03 17:32 ` Jarkko Sakkinen
2016-01-04 18:30 ` Jason Gunthorpe
2016-01-04 19:43 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151220123434.GA8232@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=Martin.Wilck@ts.fujitsu.com \
--cc=g@intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).