From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
"Martin Wilck" <Martin.Wilck@ts.fujitsu.com>,
"Peter Huewe" <peterhuewe@gmx.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v3 2/7] tpm_tis: Disable interrupt auto probing on a per-device basis
Date: Mon, 4 Jan 2016 20:32:42 +0200 [thread overview]
Message-ID: <20160104183242.GA16334@intel.com> (raw)
In-Reply-To: <20160104182442.GC20016@obsidianresearch.com>
On Mon, Jan 04, 2016 at 11:24:42AM -0700, Jason Gunthorpe wrote:
> On Sun, Jan 03, 2016 at 07:20:40PM +0200, Jarkko Sakkinen wrote:
> > On Thu, Dec 17, 2015 at 11:23:15AM -0700, Jason Gunthorpe wrote:
> > > Instead of clearing the global interrupts flag when any device
> > > does not have an interrupt just pass -1 through tpm_info.irq.
> > >
> > > The only thing that asks for autoprobing is the force=1 path.
> >
> > Sorry for my ignorance but what does this patch help? Why interrupts
> > flag is not enough?
>
> It is wrong for a driver's probe function to change global state, and
> very wrong to change a module option.
I disagree about global state in some sense but module options should
stay static. That's much better argument.
> > > Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> > > Tested-by: Wilck, Martin <martin.wilck@ts.fujitsu.com>
> > > Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> >
> > Did I already give Tested-by's for this series (I did for those that
> > went into v4.5 pull request)?
>
> You said you tested the crb stuff, which is this series... Did you
> test something else?
Checked my emails. Right I did run my tests for this (both with FIFO
and CRB driver). It was bit "stormy" before Christmas with all kinds
of small patches so I wasn't sure.
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Jason
/Jarkko
next prev parent reply other threads:[~2016-01-04 18:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 18:23 [PATCH v3 0/7] tpm_tis: Clean up force module parameter Jason Gunthorpe
2015-12-17 18:23 ` [PATCH v3 1/7] tpm_crb: Use the common ACPI definition of struct acpi_tpm2 Jason Gunthorpe
2016-01-03 17:09 ` Jarkko Sakkinen
2016-01-04 18:23 ` Jason Gunthorpe
2016-01-04 18:49 ` Jarkko Sakkinen
2015-12-17 18:23 ` [PATCH v3 2/7] tpm_tis: Disable interrupt auto probing on a per-device basis Jason Gunthorpe
2016-01-03 17:20 ` Jarkko Sakkinen
2016-01-04 18:24 ` Jason Gunthorpe
2016-01-04 18:32 ` Jarkko Sakkinen [this message]
2015-12-17 18:23 ` [PATCH v3 3/7] tpm_tis: Do not fall back to a hardcoded address for TPM2 Jason Gunthorpe
2015-12-18 9:34 ` Jarkko Sakkinen
2015-12-18 16:51 ` Jason Gunthorpe
2015-12-20 12:34 ` Jarkko Sakkinen
2015-12-17 18:23 ` [PATCH v3 4/7] tpm_tis: Use devm_ioremap_resource Jason Gunthorpe
2016-01-03 17:23 ` Jarkko Sakkinen
2015-12-17 18:23 ` [PATCH v3 5/7] tpm_tis: Clean up the force=1 module parameter Jason Gunthorpe
2016-01-03 17:26 ` Jarkko Sakkinen
2016-01-04 18:27 ` Jason Gunthorpe
2015-12-17 18:23 ` [PATCH v3 6/7] tpm_crb: Drop le32_to_cpu(ioread32(..)) Jason Gunthorpe
2016-01-03 17:28 ` Jarkko Sakkinen
2015-12-17 18:23 ` [PATCH v3 7/7] tpm_crb: Use devm_ioremap_resource Jason Gunthorpe
2016-01-03 17:32 ` Jarkko Sakkinen
2016-01-04 18:30 ` Jason Gunthorpe
2016-01-04 19:43 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104183242.GA16334@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=Martin.Wilck@ts.fujitsu.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).