linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org, vince@deater.net,
	eranian@google.com, Arnaldo Carvalho de Melo <acme@infradead.org>,
	jolsa@redhat.com
Subject: Re: [PATCH] perf: Cleanup user's child events
Date: Fri, 15 Jan 2016 14:09:32 +0100	[thread overview]
Message-ID: <20160115130932.GL6357@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <87lh7rvvqa.fsf@ashishki-desk.ger.corp.intel.com>

On Fri, Jan 15, 2016 at 03:05:33PM +0200, Alexander Shishkin wrote:
> Peter Zijlstra <peterz@infradead.org> writes:
> 
> > On Fri, Jan 15, 2016 at 01:22:15PM +0200, Alexander Shishkin wrote:
> >> Events are leaking in the following scenario: user creates an event for
> >> task A, task A forks into B (producing a child event), user closes the
> >> original event. Both original user's event and its child will remain for
> >> as long as task B is around. In other words, we don't clean up children
> >> when we try to release the parent.
> >
> > The orphan stuff should clear those up, no?
> 
> Not if they don't schedule after the parent's gone.

This is true. So when Jiri did this we tried the immediate thing and
that exploded due to lock inversions.

You mention some of that. Let me go dig out that old thread to see if
its the same.

I feel that we should not have both approaches.

  reply	other threads:[~2016-01-15 13:09 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-15 11:22 [PATCH] perf: Cleanup user's child events Alexander Shishkin
2016-01-15 12:54 ` Peter Zijlstra
2016-01-15 13:05   ` Alexander Shishkin
2016-01-15 13:09     ` Peter Zijlstra [this message]
2016-01-15 14:07       ` [PATCH] perf: Synchronously cleanup " Alexander Shishkin
2016-01-15 17:57         ` Peter Zijlstra
2016-01-18 12:07           ` Alexander Shishkin
2016-01-18 12:37           ` Alexander Shishkin
2016-01-18 14:44             ` Peter Zijlstra
2016-01-19 15:12               ` [PATCH v2] " Alexander Shishkin
2016-01-19 20:05                 ` Peter Zijlstra
2016-01-19 21:58                   ` Alexei Starovoitov
2016-01-20  8:32                     ` Peter Zijlstra
2016-01-21  4:55                       ` Alexei Starovoitov
2016-01-20  7:04                   ` Alexander Shishkin
2016-01-20  8:03                     ` Peter Zijlstra
2016-01-22 11:35                   ` Alexander Shishkin
2016-01-22 12:12                     ` Peter Zijlstra
2016-01-22 12:38                     ` Peter Zijlstra
2016-01-22 19:44                       ` Alexei Starovoitov
2016-01-25 11:48                         ` Peter Zijlstra
2016-01-25 14:54                           ` Peter Zijlstra
2016-01-25 21:04                             ` Peter Zijlstra
2016-01-26  4:59                               ` Alexei Starovoitov
2016-01-26 16:16                                 ` Peter Zijlstra
2016-01-26 17:24                                   ` Peter Zijlstra
2016-01-26 23:31                                     ` Alexei Starovoitov
2016-01-27  9:58                                       ` Peter Zijlstra
2016-01-27 17:52                                         ` Alexei Starovoitov
2016-01-29 11:28                                 ` [tip:perf/urgent] perf/bpf: Convert perf_event_array to use struct file tip-bot for Alexei Starovoitov
2016-01-29 20:01                                   ` Alexei Starovoitov
2016-01-19 20:07                 ` [PATCH v2] perf: Synchronously cleanup child events Peter Zijlstra
2016-01-19  7:45         ` [PATCH] " Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160115130932.GL6357@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=acme@infradead.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=vince@deater.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).