From: Ingo Molnar <mingo@kernel.org>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, vince@deater.net,
eranian@google.com, Arnaldo Carvalho de Melo <acme@infradead.org>,
Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH] perf: Synchronously cleanup child events
Date: Tue, 19 Jan 2016 08:45:34 +0100 [thread overview]
Message-ID: <20160119074534.GA18237@gmail.com> (raw)
In-Reply-To: <1452866861-17680-1-git-send-email-alexander.shishkin@linux.intel.com>
* Alexander Shishkin <alexander.shishkin@linux.intel.com> wrote:
> The orphan cleanup workqueue doesn't always catch orphans, for example, if they
> never schedule after they are orphaned. IOW, the event leak is still very real.
> It also wouldn't work for kernel counters.
>
> Also, there seems to be no reason not to carry out this cleanup procedure
> synchronously during parent event's destruction.
Absolutely, synchronous cleanup will probably also be quicker at triggering any
remaining (and new ;-) races.
Thanks,
Ingo
prev parent reply other threads:[~2016-01-19 7:45 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 11:22 [PATCH] perf: Cleanup user's child events Alexander Shishkin
2016-01-15 12:54 ` Peter Zijlstra
2016-01-15 13:05 ` Alexander Shishkin
2016-01-15 13:09 ` Peter Zijlstra
2016-01-15 14:07 ` [PATCH] perf: Synchronously cleanup " Alexander Shishkin
2016-01-15 17:57 ` Peter Zijlstra
2016-01-18 12:07 ` Alexander Shishkin
2016-01-18 12:37 ` Alexander Shishkin
2016-01-18 14:44 ` Peter Zijlstra
2016-01-19 15:12 ` [PATCH v2] " Alexander Shishkin
2016-01-19 20:05 ` Peter Zijlstra
2016-01-19 21:58 ` Alexei Starovoitov
2016-01-20 8:32 ` Peter Zijlstra
2016-01-21 4:55 ` Alexei Starovoitov
2016-01-20 7:04 ` Alexander Shishkin
2016-01-20 8:03 ` Peter Zijlstra
2016-01-22 11:35 ` Alexander Shishkin
2016-01-22 12:12 ` Peter Zijlstra
2016-01-22 12:38 ` Peter Zijlstra
2016-01-22 19:44 ` Alexei Starovoitov
2016-01-25 11:48 ` Peter Zijlstra
2016-01-25 14:54 ` Peter Zijlstra
2016-01-25 21:04 ` Peter Zijlstra
2016-01-26 4:59 ` Alexei Starovoitov
2016-01-26 16:16 ` Peter Zijlstra
2016-01-26 17:24 ` Peter Zijlstra
2016-01-26 23:31 ` Alexei Starovoitov
2016-01-27 9:58 ` Peter Zijlstra
2016-01-27 17:52 ` Alexei Starovoitov
2016-01-29 11:28 ` [tip:perf/urgent] perf/bpf: Convert perf_event_array to use struct file tip-bot for Alexei Starovoitov
2016-01-29 20:01 ` Alexei Starovoitov
2016-01-19 20:07 ` [PATCH v2] perf: Synchronously cleanup child events Peter Zijlstra
2016-01-19 7:45 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160119074534.GA18237@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=vince@deater.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).