* [PATCH][RESEND] asus-nb-wmi: add wapf=4 quirk for ASUS X75VD
@ 2016-02-17 7:45 Oleksandr Natalenko
2016-02-17 10:37 ` Giedrius Statkevičius
2016-02-18 5:25 ` Darren Hart
0 siblings, 2 replies; 4+ messages in thread
From: Oleksandr Natalenko @ 2016-02-17 7:45 UTC (permalink / raw)
To: dvhart; +Cc: corentin.chary, acpi4asus-user, platform-driver-x86, linux-kernel
Wi-Fi on ASUS X75VD laptop does not work unless asus_nb_wmi module
is loaded with wapf=4 option. Add quirk for this.
---
drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/platform/x86/asus-nb-wmi.c
b/drivers/platform/x86/asus-nb-wmi.c
index 131fee2..091ca7a 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -272,6 +272,15 @@ static const struct dmi_system_id asus_quirks[] = {
},
{
.callback = dmi_matched,
+ .ident = "ASUSTeK COMPUTER INC. X75VD",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X75VD"),
+ },
+ .driver_data = &quirk_asus_wapf4,
+ },
+ {
+ .callback = dmi_matched,
.ident = "ASUSTeK COMPUTER INC. 1015E",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
--
2.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH][RESEND] asus-nb-wmi: add wapf=4 quirk for ASUS X75VD
2016-02-17 7:45 [PATCH][RESEND] asus-nb-wmi: add wapf=4 quirk for ASUS X75VD Oleksandr Natalenko
@ 2016-02-17 10:37 ` Giedrius Statkevičius
2016-02-18 5:34 ` Darren Hart
2016-02-18 5:25 ` Darren Hart
1 sibling, 1 reply; 4+ messages in thread
From: Giedrius Statkevičius @ 2016-02-17 10:37 UTC (permalink / raw)
To: Oleksandr Natalenko
Cc: dvhart, corentin.chary, acpi4asus-user, platform-driver-x86,
linux-kernel
On Wed, Feb 17, 2016 at 09:45:05AM +0200, Oleksandr Natalenko wrote:
> Wi-Fi on ASUS X75VD laptop does not work unless asus_nb_wmi module
> is loaded with wapf=4 option. Add quirk for this.
> ---
You forgot Signed-off-by here. Always run your patch through
scripts/checkpatch.pl. Also, I think the format is usually
[PATCH RESEND vX AA/BB] and not [PATCH][RESEND].
--
Giedrius
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][RESEND] asus-nb-wmi: add wapf=4 quirk for ASUS X75VD
2016-02-17 7:45 [PATCH][RESEND] asus-nb-wmi: add wapf=4 quirk for ASUS X75VD Oleksandr Natalenko
2016-02-17 10:37 ` Giedrius Statkevičius
@ 2016-02-18 5:25 ` Darren Hart
1 sibling, 0 replies; 4+ messages in thread
From: Darren Hart @ 2016-02-18 5:25 UTC (permalink / raw)
To: Oleksandr Natalenko
Cc: corentin.chary, acpi4asus-user, platform-driver-x86, linux-kernel
On Wed, Feb 17, 2016 at 09:45:05AM +0200, Oleksandr Natalenko wrote:
> Wi-Fi on ASUS X75VD laptop does not work unless asus_nb_wmi module
> is loaded with wapf=4 option. Add quirk for this.
Point of terminology. It is not a RESEND if you made changes, even whitespace,
it's v2, v3, etc. RESEND means it's identical to the previous one, but it's been
a long time (2 weeks) and nobody responded with a review.
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][RESEND] asus-nb-wmi: add wapf=4 quirk for ASUS X75VD
2016-02-17 10:37 ` Giedrius Statkevičius
@ 2016-02-18 5:34 ` Darren Hart
0 siblings, 0 replies; 4+ messages in thread
From: Darren Hart @ 2016-02-18 5:34 UTC (permalink / raw)
To: Giedrius Statkevičius
Cc: Oleksandr Natalenko, corentin.chary, acpi4asus-user,
platform-driver-x86, linux-kernel
On Wed, Feb 17, 2016 at 12:37:38PM +0200, Giedrius Statkevičius wrote:
> On Wed, Feb 17, 2016 at 09:45:05AM +0200, Oleksandr Natalenko wrote:
> > Wi-Fi on ASUS X75VD laptop does not work unless asus_nb_wmi module
> > is loaded with wapf=4 option. Add quirk for this.
> > ---
>
> You forgot Signed-off-by here. Always run your patch through
> scripts/checkpatch.pl. Also, I think the format is usually
> [PATCH RESEND vX AA/BB] and not [PATCH][RESEND].
RESEND means it's identical. v2 means there was a change. The change should be
noted below the --- line. See Documentation/SubmittingPatches Section 14.
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-18 5:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-17 7:45 [PATCH][RESEND] asus-nb-wmi: add wapf=4 quirk for ASUS X75VD Oleksandr Natalenko
2016-02-17 10:37 ` Giedrius Statkevičius
2016-02-18 5:34 ` Darren Hart
2016-02-18 5:25 ` Darren Hart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).