* [PATCH] spi/rockchip: Add dt-binding for Rockchip rk3399 spi
@ 2016-02-16 9:22 jianqun.xu
2016-02-16 13:22 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: jianqun.xu @ 2016-02-16 9:22 UTC (permalink / raw)
To: heiko, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
jwerner, broonie
Cc: huangtao, linux-rockchip, linux-kernel, linux-arm-kernel,
devicetree, Xu Jianqun
From: Xu Jianqun <jay.xu@rock-chips.com>
Add compatible support for Rockchip rk3399 spi.
Signed-off-by: Xu Jianqun <jay.xu@rock-chips.com>
---
Documentation/devicetree/bindings/spi/spi-rockchip.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.txt b/Documentation/devicetree/bindings/spi/spi-rockchip.txt
index 0c491bd..1b14d69 100644
--- a/Documentation/devicetree/bindings/spi/spi-rockchip.txt
+++ b/Documentation/devicetree/bindings/spi/spi-rockchip.txt
@@ -9,6 +9,7 @@ Required Properties:
"rockchip,rk3066-spi" for rk3066.
"rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188.
"rockchip,rk3288-spi", "rockchip,rk3066-spi" for rk3288.
+ "rockchip,rk3399-spi", "rockchip,rk3066-spi" for rk3399.
- reg: physical base address of the controller and length of memory mapped
region.
- interrupts: The interrupt number to the cpu. The interrupt specifier format
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] spi/rockchip: Add dt-binding for Rockchip rk3399 spi
2016-02-16 9:22 [PATCH] spi/rockchip: Add dt-binding for Rockchip rk3399 spi jianqun.xu
@ 2016-02-16 13:22 ` Mark Brown
2016-02-16 14:37 ` Heiko Stuebner
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2016-02-16 13:22 UTC (permalink / raw)
To: jianqun.xu
Cc: heiko, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
jwerner, huangtao, linux-rockchip, linux-kernel,
linux-arm-kernel, devicetree
[-- Attachment #1: Type: text/plain, Size: 255 bytes --]
On Tue, Feb 16, 2016 at 05:22:18PM +0800, jianqun.xu wrote:
> Documentation/devicetree/bindings/spi/spi-rockchip.txt | 1 +
> 1 file changed, 1 insertion(+)
I'd expect this to be added to both the driver and the binding document
not just the document.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] spi/rockchip: Add dt-binding for Rockchip rk3399 spi
2016-02-16 13:22 ` Mark Brown
@ 2016-02-16 14:37 ` Heiko Stuebner
2016-02-17 0:21 ` Jianqun Xu
0 siblings, 1 reply; 6+ messages in thread
From: Heiko Stuebner @ 2016-02-16 14:37 UTC (permalink / raw)
To: Mark Brown
Cc: jianqun.xu, robh+dt, pawel.moll, mark.rutland, ijc+devicetree,
galak, jwerner, huangtao, linux-rockchip, linux-kernel,
linux-arm-kernel, devicetree
Am Dienstag, 16. Februar 2016, 13:22:23 schrieb Mark Brown:
> On Tue, Feb 16, 2016 at 05:22:18PM +0800, jianqun.xu wrote:
> > Documentation/devicetree/bindings/spi/spi-rockchip.txt | 1 +
> > 1 file changed, 1 insertion(+)
>
> I'd expect this to be added to both the driver and the binding document
> not just the document.
It seems the driver can still use the rk3066-variant - aka nobody has found
specific issues in the rk3399 IP implementation.
Having the more specific IP names already in the dts before actually using
them was suggested by devicetree people to not have to exchange everything
once specific issues were found.
So right now it's using the fallback-mechanism of binding to the rk3066
name, but if some obstacle appears it will only take adding the binding in
the driver to make it work (even with old devicetrees).
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] spi/rockchip: Add dt-binding for Rockchip rk3399 spi
2016-02-16 14:37 ` Heiko Stuebner
@ 2016-02-17 0:21 ` Jianqun Xu
2016-02-17 6:45 ` Heiko Stuebner
0 siblings, 1 reply; 6+ messages in thread
From: Jianqun Xu @ 2016-02-17 0:21 UTC (permalink / raw)
To: Heiko Stuebner, Mark Brown
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
jwerner, huangtao, linux-rockchip, linux-kernel,
linux-arm-kernel, devicetree
Hi Heiko
在 16/02/2016 22:37, Heiko Stuebner 写道:
> Am Dienstag, 16. Februar 2016, 13:22:23 schrieb Mark Brown:
>> On Tue, Feb 16, 2016 at 05:22:18PM +0800, jianqun.xu wrote:
>>> Documentation/devicetree/bindings/spi/spi-rockchip.txt | 1 +
>>> 1 file changed, 1 insertion(+)
>>
>> I'd expect this to be added to both the driver and the binding document
>> not just the document.
>
> It seems the driver can still use the rk3066-variant - aka nobody has found
> specific issues in the rk3399 IP implementation.
>
> Having the more specific IP names already in the dts before actually using
> them was suggested by devicetree people to not have to exchange everything
> once specific issues were found.
>
> So right now it's using the fallback-mechanism of binding to the rk3066
> name, but if some obstacle appears it will only take adding the binding in
> the driver to make it work (even with old devicetrees).
>
>
Thank you, got it, and I will re-send this patch with the driver patch.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] spi/rockchip: Add dt-binding for Rockchip rk3399 spi
2016-02-17 0:21 ` Jianqun Xu
@ 2016-02-17 6:45 ` Heiko Stuebner
2016-02-17 10:53 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Heiko Stuebner @ 2016-02-17 6:45 UTC (permalink / raw)
To: Jianqun Xu
Cc: Mark Brown, robh+dt, pawel.moll, mark.rutland, ijc+devicetree,
galak, jwerner, huangtao, linux-rockchip, linux-kernel,
linux-arm-kernel, devicetree
Hi Jianqun,
Am Mittwoch, 17. Februar 2016, 08:21:58 schrieb Jianqun Xu:
> 在 16/02/2016 22:37, Heiko Stuebner 写道:
> > Am Dienstag, 16. Februar 2016, 13:22:23 schrieb Mark Brown:
> >> On Tue, Feb 16, 2016 at 05:22:18PM +0800, jianqun.xu wrote:
> >>> Documentation/devicetree/bindings/spi/spi-rockchip.txt | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>
> >> I'd expect this to be added to both the driver and the binding document
> >> not just the document.
> >
> > It seems the driver can still use the rk3066-variant - aka nobody has
> > found specific issues in the rk3399 IP implementation.
> >
> > Having the more specific IP names already in the dts before actually
> > using them was suggested by devicetree people to not have to exchange
> > everything once specific issues were found.
> >
> > So right now it's using the fallback-mechanism of binding to the rk3066
> > name, but if some obstacle appears it will only take adding the binding
> > in the driver to make it work (even with old devicetrees).
>
> Thank you, got it, and I will re-send this patch with the driver patch.
you have me confused now :-) .
That was meant as a reply to Mark's comment, explaining why the double
compatible and the driver only binding to the rk3066-one right now.
Heiko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] spi/rockchip: Add dt-binding for Rockchip rk3399 spi
2016-02-17 6:45 ` Heiko Stuebner
@ 2016-02-17 10:53 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2016-02-17 10:53 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Jianqun Xu, robh+dt, pawel.moll, mark.rutland, ijc+devicetree,
galak, jwerner, huangtao, linux-rockchip, linux-kernel,
linux-arm-kernel, devicetree
[-- Attachment #1: Type: text/plain, Size: 480 bytes --]
On Wed, Feb 17, 2016 at 07:45:09AM +0100, Heiko Stuebner wrote:
> That was meant as a reply to Mark's comment, explaining why the double
> compatible and the driver only binding to the rk3066-one right now.
It's still better to have the compatible explicitly listed in the
driver even if it doesn't change the configuration at all at this time.
That way we've at least got a record that the handling is currently
identical to whatever other devices it is the same as.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-17 10:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-16 9:22 [PATCH] spi/rockchip: Add dt-binding for Rockchip rk3399 spi jianqun.xu
2016-02-16 13:22 ` Mark Brown
2016-02-16 14:37 ` Heiko Stuebner
2016-02-17 0:21 ` Jianqun Xu
2016-02-17 6:45 ` Heiko Stuebner
2016-02-17 10:53 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).