* [PATCH] iio: light: gp2ap020a00f: use iio helper function to lock direct mode
@ 2016-06-08 0:19 Alison Schofield
2016-06-08 7:17 ` Jacek Anaszewski
0 siblings, 1 reply; 3+ messages in thread
From: Alison Schofield @ 2016-06-08 0:19 UTC (permalink / raw)
To: jic23; +Cc: j.anaszewski, pmeerw, knaack.h, lars, linux-iio, linux-kernel
Replace the code that guarantees the device stays in direct mode
with iio_device_claim_direct_mode() which does same. Includes a
tiny bit of refactoring (single case -> if) and simplified return
flow.
Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Cc: Daniel Baluta <daniel.baluta@gmail.com>
---
drivers/iio/light/gp2ap020a00f.c | 18 +++++-------------
1 file changed, 5 insertions(+), 13 deletions(-)
diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a00f.c
index 6d41086..af73af3 100644
--- a/drivers/iio/light/gp2ap020a00f.c
+++ b/drivers/iio/light/gp2ap020a00f.c
@@ -1287,22 +1287,14 @@ static int gp2ap020a00f_read_raw(struct iio_dev *indio_dev,
struct gp2ap020a00f_data *data = iio_priv(indio_dev);
int err = -EINVAL;
- mutex_lock(&data->lock);
-
- switch (mask) {
- case IIO_CHAN_INFO_RAW:
- if (iio_buffer_enabled(indio_dev)) {
- err = -EBUSY;
- goto error_unlock;
- }
+ if (mask == IIO_CHAN_INFO_RAW) {
+ err = iio_device_claim_direct_mode(indio_dev);
+ if (err)
+ return err;
err = gp2ap020a00f_read_channel(data, chan, val);
- break;
+ iio_device_release_direct_mode(indio_dev);
}
-
-error_unlock:
- mutex_unlock(&data->lock);
-
return err < 0 ? err : IIO_VAL_INT;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: light: gp2ap020a00f: use iio helper function to lock direct mode
2016-06-08 0:19 [PATCH] iio: light: gp2ap020a00f: use iio helper function to lock direct mode Alison Schofield
@ 2016-06-08 7:17 ` Jacek Anaszewski
2016-06-11 15:54 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Jacek Anaszewski @ 2016-06-08 7:17 UTC (permalink / raw)
To: Alison Schofield; +Cc: jic23, pmeerw, knaack.h, lars, linux-iio, linux-kernel
Hi Alison,
On 06/08/2016 02:19 AM, Alison Schofield wrote:
> Replace the code that guarantees the device stays in direct mode
> with iio_device_claim_direct_mode() which does same. Includes a
> tiny bit of refactoring (single case -> if) and simplified return
> flow.
>
> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@gmail.com>
> ---
> drivers/iio/light/gp2ap020a00f.c | 18 +++++-------------
> 1 file changed, 5 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a00f.c
> index 6d41086..af73af3 100644
> --- a/drivers/iio/light/gp2ap020a00f.c
> +++ b/drivers/iio/light/gp2ap020a00f.c
> @@ -1287,22 +1287,14 @@ static int gp2ap020a00f_read_raw(struct iio_dev *indio_dev,
> struct gp2ap020a00f_data *data = iio_priv(indio_dev);
> int err = -EINVAL;
>
> - mutex_lock(&data->lock);
> -
> - switch (mask) {
> - case IIO_CHAN_INFO_RAW:
> - if (iio_buffer_enabled(indio_dev)) {
> - err = -EBUSY;
> - goto error_unlock;
> - }
> + if (mask == IIO_CHAN_INFO_RAW) {
> + err = iio_device_claim_direct_mode(indio_dev);
> + if (err)
> + return err;
>
> err = gp2ap020a00f_read_channel(data, chan, val);
> - break;
> + iio_device_release_direct_mode(indio_dev);
> }
> -
> -error_unlock:
> - mutex_unlock(&data->lock);
> -
> return err < 0 ? err : IIO_VAL_INT;
> }
>
>
Nice patch.
Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>
--
Best regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: light: gp2ap020a00f: use iio helper function to lock direct mode
2016-06-08 7:17 ` Jacek Anaszewski
@ 2016-06-11 15:54 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2016-06-11 15:54 UTC (permalink / raw)
To: Jacek Anaszewski, Alison Schofield
Cc: pmeerw, knaack.h, lars, linux-iio, linux-kernel
On 08/06/16 08:17, Jacek Anaszewski wrote:
> Hi Alison,
>
> On 06/08/2016 02:19 AM, Alison Schofield wrote:
>> Replace the code that guarantees the device stays in direct mode
>> with iio_device_claim_direct_mode() which does same. Includes a
>> tiny bit of refactoring (single case -> if) and simplified return
>> flow.
>>
>> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
>> Cc: Daniel Baluta <daniel.baluta@gmail.com>
>> ---
>> drivers/iio/light/gp2ap020a00f.c | 18 +++++-------------
>> 1 file changed, 5 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a00f.c
>> index 6d41086..af73af3 100644
>> --- a/drivers/iio/light/gp2ap020a00f.c
>> +++ b/drivers/iio/light/gp2ap020a00f.c
>> @@ -1287,22 +1287,14 @@ static int gp2ap020a00f_read_raw(struct iio_dev *indio_dev,
>> struct gp2ap020a00f_data *data = iio_priv(indio_dev);
>> int err = -EINVAL;
>>
>> - mutex_lock(&data->lock);
>> -
>> - switch (mask) {
>> - case IIO_CHAN_INFO_RAW:
>> - if (iio_buffer_enabled(indio_dev)) {
>> - err = -EBUSY;
>> - goto error_unlock;
>> - }
>> + if (mask == IIO_CHAN_INFO_RAW) {
>> + err = iio_device_claim_direct_mode(indio_dev);
>> + if (err)
>> + return err;
>>
>> err = gp2ap020a00f_read_channel(data, chan, val);
>> - break;
>> + iio_device_release_direct_mode(indio_dev);
>> }
>> -
>> -error_unlock:
>> - mutex_unlock(&data->lock);
>> -
>> return err < 0 ? err : IIO_VAL_INT;
>> }
>>
>>
>
> Nice patch.
>
> Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Applied to the togreg branch of iio.git - initially pushed out as
testing for the autobuilders to play with it.
I would have slightly preferred the patch to not change the
case to an if (as really a slightly separate cleanup from
the main target of the patch).
Good changes though!
Thanks,
Jonathan
Thanks,
Jonathan
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-11 15:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-08 0:19 [PATCH] iio: light: gp2ap020a00f: use iio helper function to lock direct mode Alison Schofield
2016-06-08 7:17 ` Jacek Anaszewski
2016-06-11 15:54 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).