From: Mel Gorman <mgorman@techsingularity.net>
To: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, linux-mm@kvack.org
Subject: Re: [PATCH 04/27] mm, vmscan: Begin reclaiming pages on a per-node basis
Date: Tue, 14 Jun 2016 15:47:16 +0100 [thread overview]
Message-ID: <20160614144716.GC1868@techsingularity.net> (raw)
In-Reply-To: <02f101d1c47c$b4bae0f0$1e30a2d0$@alibaba-inc.com>
On Sun, Jun 12, 2016 at 03:33:25PM +0800, Hillf Danton wrote:
> > @@ -3207,15 +3228,14 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int classzone_idx)
> > sc.may_writepage = 1;
> >
> > /*
> > - * Now scan the zone in the dma->highmem direction, stopping
> > - * at the last zone which needs scanning.
> > - *
> > - * We do this because the page allocator works in the opposite
> > - * direction. This prevents the page allocator from allocating
> > - * pages behind kswapd's direction of progress, which would
> > - * cause too much scanning of the lower zones.
> > + * Continue scanning in the highmem->dma direction stopping at
> > + * the last zone which needs scanning. This may reclaim lowmem
> > + * pages that are not necessary for zone balancing but it
> > + * preserves LRU ordering. It is assumed that the bulk of
> > + * allocation requests can use arbitrary zones with the
> > + * possible exception of big highmem:lowmem configurations.
> > */
> > - for (i = 0; i <= end_zone; i++) {
> > + for (i = end_zone; i >= end_zone; i--) {
>
> s/i >= end_zone;/i >= 0;/ ?
>
Yes although it's eliminated by "mm, vmscan: Make kswapd reclaim in
terms of nodes"
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2016-06-14 14:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <02ed01d1c47a$49fbfbc0$ddf3f340$@alibaba-inc.com>
2016-06-12 7:33 ` [PATCH 04/27] mm, vmscan: Begin reclaiming pages on a per-node basis Hillf Danton
2016-06-14 14:47 ` Mel Gorman [this message]
2016-06-21 14:15 [PATCH 00/27] Move LRU page reclaim from zones to nodes v7 Mel Gorman
2016-06-21 14:15 ` [PATCH 04/27] mm, vmscan: Begin reclaiming pages on a per-node basis Mel Gorman
2016-06-22 14:04 ` Vlastimil Babka
2016-06-22 16:00 ` Vlastimil Babka
2016-06-23 11:07 ` Mel Gorman
2016-06-23 11:13 ` Michal Hocko
2016-06-23 10:58 ` Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2016-06-09 18:04 [PATCH 00/27] Move LRU page reclaim from zones to nodes v6 Mel Gorman
2016-06-09 18:04 ` [PATCH 04/27] mm, vmscan: Begin reclaiming pages on a per-node basis Mel Gorman
2016-06-15 12:52 ` Vlastimil Babka
2016-04-15 9:13 [PATCH 00/27] Move LRU page reclaim from zones to nodes v5 Mel Gorman
2016-04-15 9:13 ` [PATCH 04/27] mm, vmscan: Begin reclaiming pages on a per-node basis Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614144716.GC1868@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).