Re: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions

Re: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions

[Rafael J. Wysocki]

On 6/21/2016 7:50 PM, Adam Thomson wrote:
> This patch set converts the da7219 codec driver to use device/fwnode functions
> to access properties, instead of the DT only of_* functions, allowing ACPI
> to be used as well.
>
> The DT bindings for da7219 have a device node for the main codec properties,
> and a named child node (da7219_aad), which contains all of the accessory
> detection related properties for the device. ACPI also supports this kind of
> FW hierarchy (data only sub-nodes), but some support in the kernel needs to be
> added to take make use of this in driver code.
>
> The first patch adds functions to allow searching for a named child node of a
> device, for both DT and ACPI, and the second patch updates the codec driver to
> use the standard device/fwnode calls, including this new function.
>
> These changes are based on the v4.7-rc4 kernel.
>
> Changes in v4:
>   - Rebase to v4.7-rc4
>   - Use strcmp() in acpi_data_node_match() for matching ACPI data nodes.
>
> Changes in v3:
>   - Use of_node_cmp() in device_get_named_child_node() to match DT node.
>
> Changes in v2:
>   - Rebase to v4.7-rc1
>   - Small updates to codec patch based on previous reviewer comments
>
> Adam Thomson (2):
>    device property: Add function to search for named child of device
>    ASoC: da7219: Convert driver to use generic device/fwnode functions
>
>   drivers/base/property.c       |  28 ++++++++++++
>   include/acpi/acpi_bus.h       |   7 +++
>   include/linux/acpi.h          |   6 +++
>   include/linux/of.h            |  14 +++---
>   include/linux/property.h      |   3 ++
>   sound/soc/codecs/da7219-aad.c | 103 +++++++++++++++++++++---------------------
>   sound/soc/codecs/da7219.c     |  34 +++++++-------
>   7 files changed, 119 insertions(+), 76 deletions(-)
>
> --
> 1.9.3
>
I'm fine with the first patch and the second one carries a couple of 
ACKs already, so do you want me to apply them both?

RE: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions

[Opensource [Adam Thomson]]

On 21 June 2016 23:30, Rafael J. Wysocki wrote:

> > This patch set converts the da7219 codec driver to use device/fwnode functions
> > to access properties, instead of the DT only of_* functions, allowing ACPI
> > to be used as well.
> >
> > The DT bindings for da7219 have a device node for the main codec properties,
> > and a named child node (da7219_aad), which contains all of the accessory
> > detection related properties for the device. ACPI also supports this kind of
> > FW hierarchy (data only sub-nodes), but some support in the kernel needs to be
> > added to take make use of this in driver code.
> >
> > The first patch adds functions to allow searching for a named child node of a
> > device, for both DT and ACPI, and the second patch updates the codec driver to
> > use the standard device/fwnode calls, including this new function.
> >
> > These changes are based on the v4.7-rc4 kernel.
> >
> > Changes in v4:
> >   - Rebase to v4.7-rc4
> >   - Use strcmp() in acpi_data_node_match() for matching ACPI data nodes.
> >
> > Changes in v3:
> >   - Use of_node_cmp() in device_get_named_child_node() to match DT node.
> >
> > Changes in v2:
> >   - Rebase to v4.7-rc1
> >   - Small updates to codec patch based on previous reviewer comments
> >
> > Adam Thomson (2):
> >    device property: Add function to search for named child of device
> >    ASoC: da7219: Convert driver to use generic device/fwnode functions
> >
> >   drivers/base/property.c       |  28 ++++++++++++
> >   include/acpi/acpi_bus.h       |   7 +++
> >   include/linux/acpi.h          |   6 +++
> >   include/linux/of.h            |  14 +++---
> >   include/linux/property.h      |   3 ++
> >   sound/soc/codecs/da7219-aad.c | 103 +++++++++++++++++++++--------------------
> -
> >   sound/soc/codecs/da7219.c     |  34 +++++++-------
> >   7 files changed, 119 insertions(+), 76 deletions(-)
> >
> > --
> > 1.9.3
> >
> I'm fine with the first patch and the second one carries a couple of
> ACKs already, so do you want me to apply them both?

Thanks Rafael. I think we still need Mark's Ack for the ASoC codec changes
though before we can proceed.

Re: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

On Tue, Jun 21, 2016 at 10:54:39PM +0000, Opensource [Adam Thomson] wrote:
> On 21 June 2016 23:30, Rafael J. Wysocki wrote:

> > I'm fine with the first patch and the second one carries a couple of
> > ACKs already, so do you want me to apply them both?

None of whom are from anyone who works on the subsystem at all!  I've
not looked at the patch yet.

> Thanks Rafael. I think we still need Mark's Ack for the ASoC codec changes
> though before we can proceed.

Probably the easiest thing would be a tag for the core change that I can
pull.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions

[Rafael J. Wysocki]

On Wed, Jun 22, 2016 at 1:21 AM, Mark Brown <broonie@kernel.org> wrote:
> On Tue, Jun 21, 2016 at 10:54:39PM +0000, Opensource [Adam Thomson] wrote:
>> On 21 June 2016 23:30, Rafael J. Wysocki wrote:
>
>> > I'm fine with the first patch and the second one carries a couple of
>> > ACKs already, so do you want me to apply them both?
>
> None of whom are from anyone who works on the subsystem at all!  I've
> not looked at the patch yet.
>
>> Thanks Rafael. I think we still need Mark's Ack for the ASoC codec changes
>> though before we can proceed.
>
> Probably the easiest thing would be a tag for the core change that I can
> pull.

Or you can apply them both if that helps (please consider the first
one as ACKed in that case).

Re: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

On Wed, Jun 22, 2016 at 03:05:26AM +0200, Rafael J. Wysocki wrote:
> On Wed, Jun 22, 2016 at 1:21 AM, Mark Brown <broonie@kernel.org> wrote:

> > Probably the easiest thing would be a tag for the core change that I can
> > pull.

> Or you can apply them both if that helps (please consider the first
> one as ACKed in that case).

That works too, if I do that I'll make a tag in case it needs to get
pulled elsewhere.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions

[Rafael J. Wysocki]

On Thu, Jun 23, 2016 at 12:01 PM, Mark Brown <broonie@kernel.org> wrote:
> On Wed, Jun 22, 2016 at 03:05:26AM +0200, Rafael J. Wysocki wrote:
>> On Wed, Jun 22, 2016 at 1:21 AM, Mark Brown <broonie@kernel.org> wrote:
>
>> > Probably the easiest thing would be a tag for the core change that I can
>> > pull.
>
>> Or you can apply them both if that helps (please consider the first
>> one as ACKed in that case).
>
> That works too, if I do that I'll make a tag in case it needs to get
> pulled elsewhere.

Sounds good, thanks!

Re: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1349 bytes --]

On Thu, Jun 23, 2016 at 02:57:35PM +0200, Rafael J. Wysocki wrote:
> On Thu, Jun 23, 2016 at 12:01 PM, Mark Brown <broonie@kernel.org> wrote:

> > That works too, if I do that I'll make a tag in case it needs to get
> > pulled elsewhere.

> Sounds good, thanks!

The following changes since commit 1a695a905c18548062509178b98bc91e67510864:

  Linux 4.7-rc1 (2016-05-29 09:29:24 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/dev-prop-named-child

for you to fetch changes up to 613e97218ccbd7f33895cad4525d861810a9d5d5:

  device property: Add function to search for named child of device (2016-06-26 12:39:03 +0100)

----------------------------------------------------------------
device property: Add function to search for named child of device

This adds a function to the device property API allowing us to look up
the named child of a device.

----------------------------------------------------------------
Adam Thomson (1):
      device property: Add function to search for named child of device

 drivers/base/property.c  | 28 ++++++++++++++++++++++++++++
 include/acpi/acpi_bus.h  |  7 +++++++
 include/linux/acpi.h     |  6 ++++++
 include/linux/of.h       | 14 +++++++-------
 include/linux/property.h |  3 +++
 5 files changed, 51 insertions(+), 7 deletions(-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]