* [PATCH] iommu: arm-smmu: use devm_request_irq and devm_free_irq
@ 2016-07-04 9:38 Peng Fan
2016-07-11 10:32 ` Robin Murphy
0 siblings, 1 reply; 4+ messages in thread
From: Peng Fan @ 2016-07-04 9:38 UTC (permalink / raw)
To: will.deacon
Cc: robin.murphy, linux-arm-kernel, iommu, linux-kernel, van.freenix
Use devm_request_irq to simplify error handling path,
when probe smmu device.
Also devm_{request|free}_irq when init or destroy domain context.
Signed-off-by: Peng Fan <van.freenix@gmail.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Robin Murphy <robin.murphy@arm.com>
---
drivers/iommu/arm-smmu.c | 24 ++++++++++--------------
1 file changed, 10 insertions(+), 14 deletions(-)
diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
index 9345a3f..860652e 100644
--- a/drivers/iommu/arm-smmu.c
+++ b/drivers/iommu/arm-smmu.c
@@ -987,8 +987,8 @@ static int arm_smmu_init_domain_context(struct iommu_domain *domain,
* handler seeing a half-initialised domain state.
*/
irq = smmu->irqs[smmu->num_global_irqs + cfg->irptndx];
- ret = request_irq(irq, arm_smmu_context_fault, IRQF_SHARED,
- "arm-smmu-context-fault", domain);
+ ret = devm_request_irq(smmu->dev, irq, arm_smmu_context_fault,
+ IRQF_SHARED, "arm-smmu-context-fault", domain);
if (ret < 0) {
dev_err(smmu->dev, "failed to request context IRQ %d (%u)\n",
cfg->irptndx, irq);
@@ -1028,7 +1028,7 @@ static void arm_smmu_destroy_domain_context(struct iommu_domain *domain)
if (cfg->irptndx != INVALID_IRPTNDX) {
irq = smmu->irqs[smmu->num_global_irqs + cfg->irptndx];
- free_irq(irq, domain);
+ devm_free_irq(smmu->dev, irq, domain);
}
free_io_pgtable_ops(smmu_domain->pgtbl_ops);
@@ -1986,15 +1986,15 @@ static int arm_smmu_device_dt_probe(struct platform_device *pdev)
}
for (i = 0; i < smmu->num_global_irqs; ++i) {
- err = request_irq(smmu->irqs[i],
- arm_smmu_global_fault,
- IRQF_SHARED,
- "arm-smmu global fault",
- smmu);
+ err = devm_request_irq(smmu->dev, smmu->irqs[i],
+ arm_smmu_global_fault,
+ IRQF_SHARED,
+ "arm-smmu global fault",
+ smmu);
if (err) {
dev_err(dev, "failed to request global IRQ %d (%u)\n",
i, smmu->irqs[i]);
- goto out_free_irqs;
+ goto out_put_masters;
}
}
@@ -2006,10 +2006,6 @@ static int arm_smmu_device_dt_probe(struct platform_device *pdev)
arm_smmu_device_reset(smmu);
return 0;
-out_free_irqs:
- while (i--)
- free_irq(smmu->irqs[i], smmu);
-
out_put_masters:
for (node = rb_first(&smmu->masters); node; node = rb_next(node)) {
struct arm_smmu_master *master
@@ -2050,7 +2046,7 @@ static int arm_smmu_device_remove(struct platform_device *pdev)
dev_err(dev, "removing device with active domains!\n");
for (i = 0; i < smmu->num_global_irqs; ++i)
- free_irq(smmu->irqs[i], smmu);
+ devm_free_irq(smmu->dev, smmu->irqs[i], smmu);
/* Turn the thing off */
writel(sCR0_CLIENTPD, ARM_SMMU_GR0_NS(smmu) + ARM_SMMU_GR0_sCR0);
--
2.6.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iommu: arm-smmu: use devm_request_irq and devm_free_irq
2016-07-04 9:38 [PATCH] iommu: arm-smmu: use devm_request_irq and devm_free_irq Peng Fan
@ 2016-07-11 10:32 ` Robin Murphy
2016-07-11 10:38 ` Will Deacon
2016-07-12 1:24 ` Peng Fan
0 siblings, 2 replies; 4+ messages in thread
From: Robin Murphy @ 2016-07-11 10:32 UTC (permalink / raw)
To: Peng Fan, will.deacon; +Cc: linux-arm-kernel, iommu, linux-kernel
On 04/07/16 10:38, Peng Fan wrote:
> Use devm_request_irq to simplify error handling path,
> when probe smmu device.
>
> Also devm_{request|free}_irq when init or destroy domain context.
>
> Signed-off-by: Peng Fan <van.freenix@gmail.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
> ---
[...]
> @@ -2050,7 +2046,7 @@ static int arm_smmu_device_remove(struct platform_device *pdev)
> dev_err(dev, "removing device with active domains!\n");
>
> for (i = 0; i < smmu->num_global_irqs; ++i)
> - free_irq(smmu->irqs[i], smmu);
> + devm_free_irq(smmu->dev, smmu->irqs[i], smmu);
There shouldn't be any need for this at all, since the very next thing
called after drv->remove() is devres_release_all().
Robin.
>
> /* Turn the thing off */
> writel(sCR0_CLIENTPD, ARM_SMMU_GR0_NS(smmu) + ARM_SMMU_GR0_sCR0);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iommu: arm-smmu: use devm_request_irq and devm_free_irq
2016-07-11 10:32 ` Robin Murphy
@ 2016-07-11 10:38 ` Will Deacon
2016-07-12 1:24 ` Peng Fan
1 sibling, 0 replies; 4+ messages in thread
From: Will Deacon @ 2016-07-11 10:38 UTC (permalink / raw)
To: Robin Murphy; +Cc: Peng Fan, linux-arm-kernel, iommu, linux-kernel
On Mon, Jul 11, 2016 at 11:32:55AM +0100, Robin Murphy wrote:
> On 04/07/16 10:38, Peng Fan wrote:
> > Use devm_request_irq to simplify error handling path,
> > when probe smmu device.
> >
> > Also devm_{request|free}_irq when init or destroy domain context.
> >
> > Signed-off-by: Peng Fan <van.freenix@gmail.com>
> > Cc: Will Deacon <will.deacon@arm.com>
> > Cc: Robin Murphy <robin.murphy@arm.com>
> > ---
> [...]
> > @@ -2050,7 +2046,7 @@ static int arm_smmu_device_remove(struct platform_device *pdev)
> > dev_err(dev, "removing device with active domains!\n");
> >
> > for (i = 0; i < smmu->num_global_irqs; ++i)
> > - free_irq(smmu->irqs[i], smmu);
> > + devm_free_irq(smmu->dev, smmu->irqs[i], smmu);
>
> There shouldn't be any need for this at all, since the very next thing
> called after drv->remove() is devres_release_all().
I already sent a pull request for this, so any further changes will need
to be sent as incremental patches.
Will
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iommu: arm-smmu: use devm_request_irq and devm_free_irq
2016-07-11 10:32 ` Robin Murphy
2016-07-11 10:38 ` Will Deacon
@ 2016-07-12 1:24 ` Peng Fan
1 sibling, 0 replies; 4+ messages in thread
From: Peng Fan @ 2016-07-12 1:24 UTC (permalink / raw)
To: Robin Murphy; +Cc: will.deacon, linux-arm-kernel, iommu, linux-kernel
Hi Robin,
On Mon, Jul 11, 2016 at 11:32:55AM +0100, Robin Murphy wrote:
>On 04/07/16 10:38, Peng Fan wrote:
>> Use devm_request_irq to simplify error handling path,
>> when probe smmu device.
>>
>> Also devm_{request|free}_irq when init or destroy domain context.
>>
>> Signed-off-by: Peng Fan <van.freenix@gmail.com>
>> Cc: Will Deacon <will.deacon@arm.com>
>> Cc: Robin Murphy <robin.murphy@arm.com>
>> ---
>[...]
>> @@ -2050,7 +2046,7 @@ static int arm_smmu_device_remove(struct platform_device *pdev)
>> dev_err(dev, "removing device with active domains!\n");
>>
>> for (i = 0; i < smmu->num_global_irqs; ++i)
>> - free_irq(smmu->irqs[i], smmu);
>> + devm_free_irq(smmu->dev, smmu->irqs[i], smmu);
>
>There shouldn't be any need for this at all, since the very next thing
>called after drv->remove() is devres_release_all().
Thanks for comments. I'll fix this with a new patch.
Thanks,
Peng.
>
>Robin.
>
>>
>> /* Turn the thing off */
>> writel(sCR0_CLIENTPD, ARM_SMMU_GR0_NS(smmu) + ARM_SMMU_GR0_sCR0);
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-12 1:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-04 9:38 [PATCH] iommu: arm-smmu: use devm_request_irq and devm_free_irq Peng Fan
2016-07-11 10:32 ` Robin Murphy
2016-07-11 10:38 ` Will Deacon
2016-07-12 1:24 ` Peng Fan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).