From: Matt Wilson <msw@amzn.com>
To: Netanel Belgazal <netanel@annapurnalabs.com>,
Benjamin Poirier <benjamin.poirier@gmail.com>,
David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-kernel@vger.kernel.org, zorik@annapurnalabs.com,
saeed@annapurnalabs.com, alex@annapurnalabs.com,
aliguori@amazon.com, ben@decadent.org.uk, romieu@fr.zoreil.com,
rami.rosen@intel.com, antoine.tenart@free-electrons.com
Subject: Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)
Date: Thu, 14 Jul 2016 08:22:15 -0700 [thread overview]
Message-ID: <20160714152215.GA24590@u54ee753d2d1854bda401.ant.amazon.com> (raw)
In-Reply-To: <1468478774-19942-1-git-send-email-netanel@annapurnalabs.com>
On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote:
> This is a driver for the ENA family of networking devices.
>
> Signed-off-by: Netanel Belgazal <netanel@annapurnalabs.com>
> ---
>
> Notes:
> Changes in v3:
> - Fix compilation warning for 32bit systems. [kbuild test rebot]
> - Replace netdev->num_tx_queues with adapter->num_queues in ethtool. [ben@decadent.org.uk]
> - Use get_link_ksettings instread of get_settings (deprecated ethtool API). [ben@decadent.org.uk]
> - Remove rna_nway_reset (ethtool). [ben@decadent.org.uk]
> - Add missing break in switch condition. [ben@decadent.org.uk]
> - Increase driver version to 1.0.2
>
> Changes in v2:
> - Increment driver version to 1.0.1
> - Reorder the initialization of the workqueus and the timer service
> - Initialize last_keep_alive_jiffies in probe
> - Remove ena_trc_* functions in favor of pr_* [davem@davemloft.net]
> - Fix Tx interrupt control register value [romieu@fr.zoreil.com]
> - Edit ena.txt to focus on technical details [romieu@fr.zoreil.com]
> - Rename small_copy_len tunable to rx_copybreak [benjamin.poirier@gmail.com]
> - Change uint32_t to u32 [romieu@fr.zoreil.com]
> - Return error in ena_com_set_hash_ctrl [rami.rosen@intel.com]
> - Fix API documentation [rami.rosen@intel.com]
> - Remove redundant check in ena_com_mem_addr_set [romieu@fr.zoreil.com]
> - Add local variables for allocation methods to improve readability [romieu@fr.zoreil.com]
> - Replace dma_alloc_coherent and __GFP_ZERO flag with dma_zalloc_coherent [romieu@fr.zoreil.com]
> - Fix style when using dma_alloc_coherent [romieu@fr.zoreil.com]
> - Tx xmit - In case of an error drop the packet and return NETDEV_TX_OK [romieu@fr.zoreil.com]
> - Reduce the number of parameters in ena_get_dev_stats [romieu@fr.zoreil.com]
> - Return ret and not 0 in ena_com_set_hash_ctrl [rami.rosen@intel.com]
> - Do not initialize variables if the function doesn't read them before the second write [romieu@fr.zoreil.com]
> - Enums - Replace space with tabs to line the assign value [romieu@fr.zoreil.com]
> - Remove redundant comments [romieu@fr.zoreil.com]
>
> TODO:
> - Add bytes variable to set_coalesce ethtool callback and use this callback
> instead of dedicated sysfs files.
Dave and Benjamin,
Do you want to see the interrupt moderation extensions to ethtool and
the sysfs nodes removed before this lands in net-next? Or should
Netanel remove the sysfs bits until we can extend the ethtool
interfaces to cover the parameters that ena uses?
--msw
next prev parent reply other threads:[~2016-07-14 15:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 6:46 [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Netanel Belgazal
2016-07-14 15:22 ` Matt Wilson [this message]
2016-07-14 16:08 ` Benjamin Poirier
2016-07-14 16:15 ` Matt Wilson
2016-07-15 18:29 ` David Miller
2016-07-15 5:00 ` Leon Romanovsky
2016-07-15 15:17 ` Benjamin Poirier
2016-07-15 15:47 ` Leon Romanovsky
2016-07-19 11:09 ` Netanel Belgazal
2016-07-19 17:26 ` Leon Romanovsky
2016-07-19 17:49 ` Joe Perches
2016-07-25 5:06 ` Leon Romanovsky
2016-07-19 18:39 ` Netanel Belgazal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714152215.GA24590@u54ee753d2d1854bda401.ant.amazon.com \
--to=msw@amzn.com \
--cc=alex@annapurnalabs.com \
--cc=aliguori@amazon.com \
--cc=antoine.tenart@free-electrons.com \
--cc=ben@decadent.org.uk \
--cc=benjamin.poirier@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netanel@annapurnalabs.com \
--cc=netdev@vger.kernel.org \
--cc=rami.rosen@intel.com \
--cc=romieu@fr.zoreil.com \
--cc=saeed@annapurnalabs.com \
--cc=zorik@annapurnalabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).