From: Leon Romanovsky <leon@kernel.org>
To: Netanel Belgazal <netanel@annapurnalabs.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-kernel@vger.kernel.org, zorik@annapurnalabs.com,
saeed@annapurnalabs.com, alex@annapurnalabs.com, msw@amazon.com,
aliguori@amazon.com, benjamin.poirier@gmail.com,
ben@decadent.org.uk, romieu@fr.zoreil.com, rami.rosen@intel.com,
antoine.tenart@free-electrons.com
Subject: Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)
Date: Fri, 15 Jul 2016 08:00:05 +0300 [thread overview]
Message-ID: <20160715050005.GD30603@leon.nu> (raw)
In-Reply-To: <1468478774-19942-1-git-send-email-netanel@annapurnalabs.com>
[-- Attachment #1: Type: text/plain, Size: 3281 bytes --]
On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote:
> This is a driver for the ENA family of networking devices.
>
> Signed-off-by: Netanel Belgazal <netanel@annapurnalabs.com>
> ---
>
> Notes:
...
> - Increase driver version to 1.0.2
...
> +static void ena_get_drvinfo(struct net_device *dev,
> + struct ethtool_drvinfo *info)
> +{
> + struct ena_adapter *adapter = netdev_priv(dev);
> +
> + strlcpy(info->driver, DRV_MODULE_NAME, sizeof(info->driver));
> + strlcpy(info->version, DRV_MODULE_VERSION, sizeof(info->version));
Does module version give anything valuable in real life usage?
Do you plan to bump version after every patch?
Hint, NO.
> + strlcpy(info->bus_info, pci_name(adapter->pdev),
> + sizeof(info->bus_info));
> +}
> +
> +
...
> +
> +static char version[] =
> + DEVICE_NAME " v"
> + DRV_MODULE_VERSION " (" DRV_MODULE_RELDATE ")\n";
> +
> +MODULE_AUTHOR("Amazon.com, Inc. or its affiliates");
> +MODULE_DESCRIPTION(DEVICE_NAME);
> +MODULE_LICENSE("GPL");
> +MODULE_VERSION(DRV_MODULE_VERSION);
> +
> +/* Time in jiffies before concluding the transmitter is hung. */
> +#define TX_TIMEOUT (5 * HZ)
> +
> +#define ENA_NAPI_BUDGET 64
> +
> +#define DEFAULT_MSG_ENABLE (NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_IFUP | \
> + NETIF_MSG_TX_DONE | NETIF_MSG_TX_ERR | NETIF_MSG_RX_ERR)
> +static int debug = -1;
> +module_param(debug, int, 0);
> +MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)");
What is it?
> +
> +static int push_mode;
> +module_param(push_mode, int, 0);
> +MODULE_PARM_DESC(push_mode, "Descriptor / header push mode (0=automatic,1=disable,3=enable)\n"
> + "\t\t\t 0 - Automatically choose according to device capability (default)\n"
> + "\t\t\t 1 - Don't push anything to device memory\n"
> + "\t\t\t 3 - Push descriptors and header buffer to device memory");
> +
> +static int enable_wd = 1;
> +module_param(enable_wd, int, 0);
> +MODULE_PARM_DESC(enable_wd, "Enable keepalive watchdog (0=disable,1=enable,default=1)");
> +
> +static int enable_missing_tx_detection = 1;
> +module_param(enable_missing_tx_detection, int, 0);
> +MODULE_PARM_DESC(enable_missing_tx_detection, "Enable missing Tx completions. (default=1)");
> +
> +static int numa_node_override_array[NR_CPUS] = {[0 ... (NR_CPUS - 1)] = NUMA_NO_NODE };
> +module_param_array(numa_node_override_array, int, NULL, 0);
> +MODULE_PARM_DESC(numa_node_override_array, "Numa node override map\n");
> +
> +static int numa_node_override;
> +module_param(numa_node_override, int, 0);
> +MODULE_PARM_DESC(numa_node_override, "Enable/Disable numa node override (0=disable)\n");
As fas as I remember, new drivers are not supposed to add module
parameters.
...
> +
> +#define DRV_MODULE_VER_MAJOR 1
> +#define DRV_MODULE_VER_MINOR 0
> +#define DRV_MODULE_VER_SUBMINOR 1
> +
> +#define DRV_MODULE_NAME "ena"
> +#ifndef DRV_MODULE_VERSION
> +#define DRV_MODULE_VERSION \
> + __stringify(DRV_MODULE_VER_MAJOR) "." \
> + __stringify(DRV_MODULE_VER_MINOR) "." \
> + __stringify(DRV_MODULE_VER_SUBMINOR)
> +#endif
> +#define DRV_MODULE_RELDATE "22-JUNE-2016"
Please remove it, driver version is useless in real life kernel usage.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-07-15 5:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 6:46 [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Netanel Belgazal
2016-07-14 15:22 ` Matt Wilson
2016-07-14 16:08 ` Benjamin Poirier
2016-07-14 16:15 ` Matt Wilson
2016-07-15 18:29 ` David Miller
2016-07-15 5:00 ` Leon Romanovsky [this message]
2016-07-15 15:17 ` Benjamin Poirier
2016-07-15 15:47 ` Leon Romanovsky
2016-07-19 11:09 ` Netanel Belgazal
2016-07-19 17:26 ` Leon Romanovsky
2016-07-19 17:49 ` Joe Perches
2016-07-25 5:06 ` Leon Romanovsky
2016-07-19 18:39 ` Netanel Belgazal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715050005.GD30603@leon.nu \
--to=leon@kernel.org \
--cc=alex@annapurnalabs.com \
--cc=aliguori@amazon.com \
--cc=antoine.tenart@free-electrons.com \
--cc=ben@decadent.org.uk \
--cc=benjamin.poirier@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=msw@amazon.com \
--cc=netanel@annapurnalabs.com \
--cc=netdev@vger.kernel.org \
--cc=rami.rosen@intel.com \
--cc=romieu@fr.zoreil.com \
--cc=saeed@annapurnalabs.com \
--cc=zorik@annapurnalabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).