From: Leon Romanovsky <leon@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: Netanel Belgazal <netanel@annapurnalabs.com>,
netdev@vger.kernel.org, davem@davemloft.net,
linux-kernel@vger.kernel.org, zorik@annapurnalabs.com,
saeed@annapurnalabs.com, alex@annapurnalabs.com, msw@amazon.com,
aliguori@amazon.com, benjamin.poirier@gmail.com,
ben@decadent.org.uk, romieu@fr.zoreil.com, rami.rosen@intel.com,
antoine.tenart@free-electrons.com
Subject: Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)
Date: Mon, 25 Jul 2016 08:06:49 +0300 [thread overview]
Message-ID: <20160725050649.GX20674@leon.nu> (raw)
In-Reply-To: <1468950597.1900.56.camel@perches.com>
[-- Attachment #1: Type: text/plain, Size: 841 bytes --]
On Tue, Jul 19, 2016 at 10:49:57AM -0700, Joe Perches wrote:
> On Tue, 2016-07-19 at 20:26 +0300, Leon Romanovsky wrote:
> > On Tue, Jul 19, 2016 at 02:09:25PM +0300, Netanel Belgazal wrote:
> > > This is the debugging message interface.
> > > https://www.kernel.org/doc/Documentation/networking/netif-msg.txt
> > This document was updated last time in 2006 and I doubt that it is
> > relevant in 2016. You have dynamic debug prints infrastructure for it,
> > use it.
>
> I think this is uninformed.
>
> netif_<level> works well, is compatible with dynamic debug,
> and is commonly used with new networking drivers.
>
I have a very strong feeling that it is not "used in new drivers" by was
influenced (copied) from "old drivers". The same goes for real life usage of
module version which was introduced in this patch.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-07-25 5:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 6:46 [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Netanel Belgazal
2016-07-14 15:22 ` Matt Wilson
2016-07-14 16:08 ` Benjamin Poirier
2016-07-14 16:15 ` Matt Wilson
2016-07-15 18:29 ` David Miller
2016-07-15 5:00 ` Leon Romanovsky
2016-07-15 15:17 ` Benjamin Poirier
2016-07-15 15:47 ` Leon Romanovsky
2016-07-19 11:09 ` Netanel Belgazal
2016-07-19 17:26 ` Leon Romanovsky
2016-07-19 17:49 ` Joe Perches
2016-07-25 5:06 ` Leon Romanovsky [this message]
2016-07-19 18:39 ` Netanel Belgazal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725050649.GX20674@leon.nu \
--to=leon@kernel.org \
--cc=alex@annapurnalabs.com \
--cc=aliguori@amazon.com \
--cc=antoine.tenart@free-electrons.com \
--cc=ben@decadent.org.uk \
--cc=benjamin.poirier@gmail.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=msw@amazon.com \
--cc=netanel@annapurnalabs.com \
--cc=netdev@vger.kernel.org \
--cc=rami.rosen@intel.com \
--cc=romieu@fr.zoreil.com \
--cc=saeed@annapurnalabs.com \
--cc=zorik@annapurnalabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).